From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D1CEC5478A for ; Wed, 21 Feb 2024 19:31:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDE3E6B0072; Wed, 21 Feb 2024 14:31:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C8EF16B007B; Wed, 21 Feb 2024 14:31:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B08396B0082; Wed, 21 Feb 2024 14:31:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9CCC46B0072 for ; Wed, 21 Feb 2024 14:31:01 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 47283C0A3B for ; Wed, 21 Feb 2024 19:31:01 +0000 (UTC) X-FDA: 81816803922.13.8945537 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id C87C140011 for ; Wed, 21 Feb 2024 19:30:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PQYH7P0o; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708543858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e92swIaUqEXhIB7gf6Yq/Avzv/ncoPBOXFnJskwAgWg=; b=dNn/IvXE9FBleyOZ6HsGXcmg4A7EMPSJA7HkzNIGcoTO6ogCslRecv/7436m25AkAZNt7P B0Dqh1kku4YxaWX+dTFTBXUyfYHg6ch437NRM7TfBremBlk04CHOiKlTQwRV6eu/K06DVY Y8/ZBUzBqSsGD9MqpVaFFS3gxiLnxKw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708543858; a=rsa-sha256; cv=none; b=4OEZYtPGEGEKkimR5B3KNoWmGh5lGPWqSc/pgOagHdqkeGQlXh7sjkMSa4qkUsKXirpeUv 8fmw9OYn17q/ylYpNmG+NCbhgfEuJLpTfndG9QZBb8x/ZnIex0qErAMDqkgMAejUuUqxJW T6lznKMj5gSplqVFwI4kgrtpMEOm8pQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PQYH7P0o; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708543858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e92swIaUqEXhIB7gf6Yq/Avzv/ncoPBOXFnJskwAgWg=; b=PQYH7P0or7DfG4bx7ZAL1f9mem5oDZ6CS7e0vtIAjUbJ2SeI+mMuS3EsvBLI9c3/jXGxin hKDsw9eu5YqNTyX77dJRTRiDtIU6kf2iLZlnpQhQyx8x2gNkm8AKr9LcJ+hWJyzzV0G7pg wcV+ektqRD8M6vzdSb0lAwHhyP85c90= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-bBXLCiReOqOyIkZgh_FjVg-1; Wed, 21 Feb 2024 14:30:56 -0500 X-MC-Unique: bBXLCiReOqOyIkZgh_FjVg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4127eafcdc8so92565e9.3 for ; Wed, 21 Feb 2024 11:30:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708543855; x=1709148655; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e92swIaUqEXhIB7gf6Yq/Avzv/ncoPBOXFnJskwAgWg=; b=mtvyWImcpcSZtxRBkTfO7BAcM1R7dPvUM9ZEdDPME6y5n0MLACG8lQ9axRQfyWVc1X gOYmbnjCKwohFC/dg6JcdQbdDaFEWTBystPclqHxDQOUbyXon0f8gF6tmwVoibQjgb1z OYDerDHAMr8b9girYYJetYQRYSkreSj8IcUntJ2sxZP+qlpdj4Avl+lt6rHDSk+1xQ+0 ZczITmhlXXhIkpZnKlK/cXRK/BKRq25hyrt6Xy87/2MMXSaWtNZk++06GPGpiA4ITVZ1 rx1Ilr+sHSn5wMvVICTCowCzFnimegHPldU1sVmqbxT2/ROptgrAdmQp49Tv2cIFnBV/ wRew== X-Forwarded-Encrypted: i=1; AJvYcCW/4+i666LtGkEwZoqVbZjw/DnWXRZSZ32XlBaGEu2ISzSkUgmq9f+AwLNgTOwKOpApnOSwpdM83k0HF9ozDTVO7ww= X-Gm-Message-State: AOJu0YybmRv0ctILqt7VsYZX7z48LUq8g2SHBNhBZ2KstAhvT7Bzikzg Rx4teMK45+IEyjdSkMYPnkYTF2aIHIjovlxSABVLyQt2V34ADNS+lDcm1ambaOOSv2Ri/jp0nWm WGPN6Az98CIGa6bNOhXc5Aba2u/wwS8qlC90jEdcxZIPV5Ct8 X-Received: by 2002:a05:600c:3b9d:b0:412:6ea6:8206 with SMTP id n29-20020a05600c3b9d00b004126ea68206mr3882419wms.3.1708543855660; Wed, 21 Feb 2024 11:30:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IG6JyNCqtS4prmjexnVFCpGuUHYuxVCVVfbgiUensLVbTQNTKifSwoaAOzgWz/I+um13e3+jA== X-Received: by 2002:a05:600c:3b9d:b0:412:6ea6:8206 with SMTP id n29-20020a05600c3b9d00b004126ea68206mr3882402wms.3.1708543855277; Wed, 21 Feb 2024 11:30:55 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:4200:ef82:84d2:3d2d:f069? (p200300cbc70b4200ef8284d23d2df069.dip0.t-ipconnect.de. [2003:cb:c70b:4200:ef82:84d2:3d2d:f069]) by smtp.gmail.com with ESMTPSA id p6-20020adfe606000000b0033cdbe335bcsm17888920wrm.71.2024.02.21.11.30.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 11:30:54 -0800 (PST) Message-ID: Date: Wed, 21 Feb 2024 20:30:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/mmu_gather: change __tlb_remove_tlb_entry() to an inline function To: Arnd Bergmann , Andrew Morton Cc: Arnd Bergmann , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Ryan Roberts , "Vishal Moola (Oracle)" , Alistair Popple , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20240221154549.2026073-1-arnd@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240221154549.2026073-1-arnd@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 9nhcmm7x3asedw7o6r7j7skt7gxf3mky X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C87C140011 X-Rspam-User: X-HE-Tag: 1708543858-809842 X-HE-Meta: U2FsdGVkX1/Aoh1WMU+x0oGWfiIRMVDrItusBoInJeunGe/YdrYZkpPb5oWBsu4Sl/wnSAsXXX/9SPvMnh00DEE7lY8qKycS3+7OCgBrukML5jYMwtbgAKYx/0W3JnGP5ro7Tk/Qmutl3N/RGG/iHNRIztAAEw+/AEP+rLM7CrwRk3FTd5YMMVxyc98p/J04+HvDL/Ft+7r1P2ynJrf1YLbpd5jpSA/tWvMHC0g7Ngh779ueXJB+G1/MYgu3meZeP1A357bFegvVZmRdbr5+8ov8Cx9ev2j3ovCcrwOuOZ4Pe1ZOxqhrODpO39av5enB1tj64vbFQZH86sYu6fBAZCHE9WSkwu7jN72YYyF86hBKelyyZUATRZSxYnnVfCbZct3C1XI3nNLX6lQrfR/hs6fPOP4ah+3ylFAfjFrHVWMLlM0UhIWmsgNWAh7vrxjH4Tb4/yW8l/bHPChEyPZc8la36x+S37oCciW2aUhVm8oLSFD9MT9PNFbHVt23zqdNT0uwutAT5GR671M7SpZMLdkS3w6Z83YvIbzdfAlWPfAtnAvMxQexDfLa0brTsgpTs6yHE//E3U4Jxe0p/4b8PQ/Vb+h9bDMLAs58FVdNvMeUakrNQHsT3q84G8rrhqDGtDZmz45Nz7Oqo0tSNAXUS1029PfRnKxvTi0OdUaHjzoYK42dsPEZVGYmuCTi9QRlQvUhIP8LKc/+bL9KUXviPGa520UWLMG2Cln9Jg41IPpBFP4b4x2tdjwHPF3vPVASnMslWwvBYDYX/DcyYxlDuyU/JhNEh9KpG+wCfEcauO4N1OYSKe3qQMO0h8Kq/X1mVq+LZnmJW5GFnaNzVf6PwE83GA2fvESVtpI38CkneyzToM8CJRtR00+5w9ZtBadX33VqtvezAHWEP8Qi7rlUuKr0Dyf5vmTbIa50Wa5td7bx9VLRaDWKPk6/olFk9EHc7fJwyb9J/hE8oT2lSsz pmSEoVtz agK3dZCQ3YszQgy4tz3vwOsBZ2nkaerOxcfEHBYcXniCkERvGel/3a8ScdNhyqpbBO0vm5QLvovaw6pKgWt1FgUMrwTowd+lxf9SePynWygrulrftTJtOGrZq/s8N5+Cw9XFnSyGRmY7hSWViOe/BuXxy7NXXeBt9D0tkbALGpWOeDh49xLVQ7jV20PmsZuiuFbq2FqNZ4ouYuhzHY4JJFlRcUVZDTHwNvmapCN1WJh0MHD7jdX6GvJLqIEBAG2tNX4SJyO8R0GyVZMpfMFbHTwDx9o0Aofm61csQHYgGEZMH8zeAkwTC6IdyjvVpIYdooij4nV+7fWGeEe/B5GWPMtccNkGS0/Xt0gnzJ9AIXOt8XucYIZfoU60Uk1QlG3jRu7DzsQBzEyDS4Q/ZOQ5I9eATzRo/gIS2cVmu1Nf44VQBsy4sK28muf7IeSxZCyBl2+lozQA+roeKeKy2Rpe2SAG8K+DRCxhMrvx88RdWzXRqWmJagDdRo9A9r2WSq/RIDA4R5Kh8P2ojmmOIMlq2YM0EHNfTXblAtDes X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.02.24 16:45, Arnd Bergmann wrote: > From: Arnd Bergmann > Hi Arnd, > clang complains about tlb_remove_tlb_entries() not using the 'ptep' variable > when __tlb_remove_tlb_entry() is an empty macro: > > include/asm-generic/tlb.h:627:10: error: parameter 'ptep' set but not used [-Werror,-Wunused-but-set-parameter] > > Change it to an equivalent inline function that avoids the warning since > the compiler can see how the variable gets passed into it. > Ugh, quite an annoying clang behavior in this particular case. I wonder why no build bot complained so far. Thanks! > Fixes: 66958b447695 ("mm/mmu_gather: add tlb_remove_tlb_entries()") That commit id is not stable yet. So Andrew might want to fold it into that commit before moving it to mm-stable. -- Cheers, David / dhildenb