From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDEF6ECE579 for ; Mon, 9 Sep 2024 17:12:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A7286B01A5; Mon, 9 Sep 2024 13:12:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 555F86B01A6; Mon, 9 Sep 2024 13:12:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D0416B01A7; Mon, 9 Sep 2024 13:12:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 19EED6B01A5 for ; Mon, 9 Sep 2024 13:12:38 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 94D15A0CCB for ; Mon, 9 Sep 2024 17:12:37 +0000 (UTC) X-FDA: 82545843954.05.D620E11 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf30.hostedemail.com (Postfix) with ESMTP id 2332380002 for ; Mon, 9 Sep 2024 17:12:34 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Hs+SOynR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TxTYXfrH; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pS0riaUn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Rn9sN7HI; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725901904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GujdpzXwQLob4MAahamAEEmRJyiFm/Q7cuWc1AY/HRo=; b=CtNq3GrlDgBKpwZ9Vksc5a4dStbOZbfq/wOjEsO/XhK9A+IlW0wvomytWuxf0qUhWUXMgA FlqTL6QcOR6hXw+Oh5JefynuFOM1kpvnmSmAMwfQAsK99A9kMD6gA9kSKLki9GaJUegEqD IzaXhDNJ4y4aeZUOoVXbABT/W8AOR1E= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Hs+SOynR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TxTYXfrH; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pS0riaUn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Rn9sN7HI; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725901904; a=rsa-sha256; cv=none; b=zQsIw8rk3B4dN8a/dFXbKrED8mdzWWJqHRREntYS+KDkhAvps3+Hbfw1i1mGadBHk4KCMC Q+UnGEOLY2gsXArVvws4HOA2tSmtr83FEqxt5qz01zNezMzP9baCbfEro8sgPq2y5UvgQz cBvjkF3LdYNAsPNoPbVZ2mVhySCBK4Y= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 123E01F7CB; Mon, 9 Sep 2024 17:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725901953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GujdpzXwQLob4MAahamAEEmRJyiFm/Q7cuWc1AY/HRo=; b=Hs+SOynR3yqEuOdl1NTlQUdkDl3aJ7d4spzd41FnJAhmVROfKBIOnWIK1HAfn9Lo40Qqwc fyQAItWaqPY4UrHGrrJGw46UbptdYm8acJsYqBrzexzHsH4MM/m7NbXj4cAqv3FuqemYN3 40ScaVQ9SIx1hP6uG8YB7oCbdGYjOuE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725901953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GujdpzXwQLob4MAahamAEEmRJyiFm/Q7cuWc1AY/HRo=; b=TxTYXfrHp6YtSCLXz2CKh/XVKZelQseSAvF/3UWznlcQukWhDvFfc0LP7RvQxWEw4vofH2 nDRGun25eGk+X6Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725901952; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GujdpzXwQLob4MAahamAEEmRJyiFm/Q7cuWc1AY/HRo=; b=pS0riaUnDEYnU8s9B0kMA3f78svbkplWLEoCf2RYdBLjhkdcnJGNOkiXYvgNHVfiCz4Q/v bZearu6nZIUkxjQ5xZcqty8oYf4L49XOyd+/C1Xpr7Ym1q7Y2TzquMLl7BZcbxt7XZT3RK q6Sh/EuR1DZEAmPEAFuVleCu1RxfclA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725901952; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GujdpzXwQLob4MAahamAEEmRJyiFm/Q7cuWc1AY/HRo=; b=Rn9sN7HIfOnoilr+WmsvO9ENCmbS3ClybmQXDdZ14bltlOAfueVoWW8knQTIjzVzFHXdby cws2XmHQFPATBjAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E450013A3A; Mon, 9 Sep 2024 17:12:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id H8w2N38s32YfRAAAD6G6ig (envelope-from ); Mon, 09 Sep 2024 17:12:31 +0000 Message-ID: Date: Mon, 9 Sep 2024 19:12:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] mm/slub: Improve data handling of krealloc() when orig_size is enabled Content-Language: en-US To: Feng Tang , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov , Marco Elver , Shuah Khan , David Gow , Danilo Krummrich Cc: linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org References: <20240909012958.913438-1-feng.tang@intel.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240909012958.913438-1-feng.tang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 2332380002 X-Stat-Signature: cnr59f4z67km6xbajp7jo74cd8ehqt4m X-HE-Tag: 1725901954-915545 X-HE-Meta: U2FsdGVkX19LyMhrDgT7ONZlkuufBOs70c/rXSm0NhWz4lWhMmEd+ggjd4fiqroxS98M/IqBvJOEcpBkaJo7+YC4V/HogLZiDwkEP6tb6f+pdAvxsDx0wFb6tOdYFyhRxHrbq8hKzkCKY6exksC4NhkJtiX1byOqXkPfs+byCkbKlE3rtrSSZko+1+5nVUs2ntOVe65beir2wII3srFeZ/pr32kciH4Dw1lSaM6gcu2tM8zPec+7Ljf/tC/IAFsww7ZUCOszVFIKfOVNKogiBA5w04ctFQpw4vhd4xkNBw+QI9KScoSV3aRH42aCtODSs04mlUpY6XhCA83yLuet8UqyhkiVzvLozre7uQ9UyQZtsE05F0A1LmHX3T0+Gob5JFN/B78EbcGOGG72i9Er0GC3tl2qC8u736gD0j4PimnJIFUlY5f+hFzjlJi5v4k16GJHuw/3uLYh2FOy7D8x2kjO8pZFOHSVWDUSN39AVxGTXxu+EB0RQ+BNR2ptrX+NEpIC4Aj9oEg5xD7sPhqjO1M6IZCajuJTlpM95eWblfgPMW+QEP/i7TRtmxHS3LvURBA1B+PTj2KBgx1pPT/WhJ6xpj7Qw2vig5v7sc+yC27DnyBBSbhd7qNbUQ40RJ7MTyEspePMlJV5RgG9DyUMKwn2Tc1AeeyUzTdC5r7+lsLauFKGAIOjGRkSfweCE8sFkTXbGplf5nvl0v3e7/RR1u7Y99EQdOg7xULxPFA64nBvlYrBTGXbystg9h84oKPt2ibJH3iuBgH/MHOmv1AMCPoLzAi0fSWEFrSBUgRkFPxTJiclhGjt5+3ljXTjcpTeaKp7sfu21913ZfyQTT5oCiR9pD/bCXSUES3iTlOrKeIs1szg5JqxOv8kgovZ36i0f4jeuC5d1Yl3BMtAHvBzSSRZQDHo/ugkoo2Bft8iPGQnu4S76j1DLdyTJX7YI3afEM7vnDqpyCgrrPeHqw4 n2lt0SgY xCyK7jeqmy8LEVOGg5JAc326dDlntUVmKXVa+zqEclE3OS7uXBO3utQpzLrm1zoApKP/ZUaritU2nqS69Cs2mBuLpJVuZ/JZNmWrQcXBaGZ2Hrstd3sjskpy+dAh9v1PMAOVKiVWRPSNd9/NuvCWbhuwH37b5XzVCOEy0pSlZKtx827vtUaWF+hWWkQyYwDERuJJOqbSt3Ihl08Gle0ux8WMj5kLzQOSbnzHEjisP0QRNInxC1E97sU6wdDnoXFxJjvC2k4sgWF8s07vYXc16dAZ+FAGhdPruuC884EmHHIJj1xNaidUAHtb1htIuYYIFAE3FAb15Ap3KPPU3eN5CnM4WgVV+bk2/ILyiHQrVhWabdbbidA4lAH7Z8HSbPA0/L0uyzDL9zWAWgdeH1WHVtgIBRAR0wR0v6TFCdtSYN3BvNM8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/9/24 03:29, Feng Tang wrote: > Danilo Krummrich's patch [1] raised one problem about krealloc() that > its caller doesn't know what's the actual request size, say the object > is 64 bytes kmalloc one, but the original caller may only requested 48 > bytes. And when krealloc() shrinks or grows in the same object, or > allocate a new bigger object, it lacks this 'original size' information > to do accurate data preserving or zeroing (when __GFP_ZERO is set). > > And when some slub debug option is enabled, kmalloc caches do have this > 'orig_size' feature. As suggested by Vlastimil, utilize it to do more > accurate data handling, as well as enforce the kmalloc-redzone sanity check. > > To make the 'orig_size' accurate, we adjust some kasan/slub meta data > handling. Also add a slub kunit test case for krealloc(). > > This patchset has dependency over patches in both -mm tree and -slab > trees, so it is written based on linux-next tree '20240905' version. Thanks, given the timing with merge window opening soon, I would take this into the slab tree after the merge window, when the current -next becomes 6.12-rc1. > > [1]. https://lore.kernel.org/lkml/20240812223707.32049-1-dakr@kernel.org/ > > Thanks, > Feng > > Feng Tang (5): > mm/kasan: Don't store metadata inside kmalloc object when > slub_debug_orig_size is on > mm/slub: Consider kfence case for get_orig_size() > mm/slub: Improve redzone check and zeroing for krealloc() > kunit: kfence: Make KFENCE_TEST_REQUIRES macro available for all kunit > case > mm/slub, kunit: Add testcase for krealloc redzone and zeroing > > include/kunit/test.h | 6 ++ > lib/slub_kunit.c | 46 +++++++++++++++ > mm/kasan/generic.c | 5 +- > mm/kfence/kfence_test.c | 9 +-- > mm/slab.h | 6 ++ > mm/slab_common.c | 84 --------------------------- > mm/slub.c | 125 ++++++++++++++++++++++++++++++++++------ > 7 files changed, 171 insertions(+), 110 deletions(-) >