From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6558DC35FFB for ; Wed, 19 Mar 2025 19:29:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B58B5280002; Wed, 19 Mar 2025 15:29:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE06D280001; Wed, 19 Mar 2025 15:29:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98293280002; Wed, 19 Mar 2025 15:29:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 73F14280001 for ; Wed, 19 Mar 2025 15:29:20 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 32A8456354 for ; Wed, 19 Mar 2025 19:29:21 +0000 (UTC) X-FDA: 83239289322.27.977CA17 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) by imf19.hostedemail.com (Postfix) with ESMTP id DBB451A000A for ; Wed, 19 Mar 2025 19:29:17 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="T4/G/4HE"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742412558; a=rsa-sha256; cv=none; b=qJejfdq6HlTLmXl5S4atJkfhj/BZhwG8vCrF4/FYoCbjUMNTwVXQ3i4o4Z6LHTrKSv7Xoj odjAoPOG2zTUt/hU9sdOJ0CwIgB0FKbArXoXqdPwapXwVNvOBvjZZeBe84E1f0pE3xONx+ JfF267YCsLpQTaxwD5nib7ipGTGgabE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="T4/G/4HE"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742412558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lgoOXi1p75eg5oXGkctS0LJrHBVQGqCMdSovDcPhhkg=; b=sWH+p7osFM5HhQEOyMYZiz+VfvVCrNZOXFN5+x5crGp0QJiKHojtiB9PlyW79DmIpDzVQs 1ZRqwk17IBJcxepNrrb9+Q7UZS1K+jNbe2OQIOtX+CcdJAMs5jhevTP3jadgalxYulgykw aaIOLMRDD8drNevPBouTvCSrLqgy0d4= Date: Wed, 19 Mar 2025 12:29:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742412555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lgoOXi1p75eg5oXGkctS0LJrHBVQGqCMdSovDcPhhkg=; b=T4/G/4HERbRFM9YBFd+s6xthzabUPztVYkfs1fm3qMfpaE7HLiGtc8TVu+XsRDN1Df1/J2 hR7WtWNYHg8twv7tLerOZ52CRMBN9rbr80pEW6kuhwSf7Nmjzu3QCZrLrDm82QATRLgYg1 DVmXDRPpVWDHuA6piZbfcWa0yKTjFV4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Jingxiang Zeng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, kasong@tencent.com Subject: Re: [RFC 1/5] Kconfig: add SWAP_CHARGE_V1_MODE config Message-ID: References: <20250319064148.774406-1-jingxiangzeng.cas@gmail.com> <20250319064148.774406-2-jingxiangzeng.cas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250319064148.774406-2-jingxiangzeng.cas@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: DBB451A000A X-Rspamd-Server: rspam05 X-Stat-Signature: bapxtbpcs5ac7ktgpert3qsjg4o45c19 X-HE-Tag: 1742412557-87840 X-HE-Meta: U2FsdGVkX19/b4zfN42Yun2W3T2wYL1aPa3bPtbAagd7yFUllPWNCOi/VFylkllPVlK5CDGibvPbPkeWv2d+12c/An/37KUkYlZ6ucVi0LubzY5NhkySabiSNfwaIqjfbjuzRGWSKsHWAgev02I9gECv82CRq4qh1LYGvkFWcnBW29u/NnE0u7GFOXMxtu6hhw7NII1OkVDUPDceT6sBtKn4S2r8xAyANpZuMTPpZt+5pFWepzQ9q6DkI0FBRTnc8cLwd7YTDdm4JstyskPxPiJmTzYxjFzTybJrIS4TBP9VnEYFh/mjKFaeIsQSt0fxWPB99FSAyAGgKHY5PvLqMitJLEY9pUAvngnF3o59pbEmBNeXWAxDfNzbKVk9rfLcvFISansb9wR/HXleUIgmEdtgneHPD2pvYVJTuJrX/+KvUt4VHkwNLg5z7CYwdIF2FReusMwJXa6094dSc8n4rQRKvsIrgr2y3EPzbutmhk0dyj5u1wCjBmGMVZmIfcqR2JzUVwoJnpHU+jTgb9RTsDscqhU+H4CD+LmcRWMqi7l7B2HmopfZuWa32cJc8GYBgKlnULfa8B4f/3+f0KuEG0t7OqoY0WDpTRu5H3PrZQVF2DT0WvB6apEmH1/3TOPM7fAz7TLhE5pzBR94FBJwgoMHzF1oRVUXEKFNSpL5vhKQaCj+ccbz6ZV7fyD7KIgfbeBHbhTL8IJILPg28cWWNofUqljuSOZjMi5Sk/sVNczGMl0HKqSnS0PfyivAviU4V5ViNkMsMRkzLXl7pdugiHOJ5DalL8r6TvE8QmXVgShTuXuHX8/CzApOe/W7nK8N/svWZ858oA4yqYDP6xnPi2OjC6ighVe3IGDXB+NHLXJs0e471y4v67pH0Szbp3v4eERg9sR1UqkwjZueoErALyEnsji6MjkndTUUL51g+ZHSPvcmLIUOQADMq1x+QoKoX32NMyCUXinls8E2z86 OfHOsaqt beH582ef7U+/qoE/CN1uRiyWEBYOpBaInKdJIM6cCe9NkQZJkmPY3LTvy9NnnjZmEhpIzKmgx7+RSnu8Qh+67YIVYEbT4I9UdL+N4w7mL6KKElSa72xpBH9kLpRaBo/i2itwLCNjuSxveqLFI8sd3JCkAqCoVxspb6ouS4begAissYLFY9nHgUZmXXsd26Mv4dXvI2iQZAheQUWGruqEsoGk4B9GRN7Mfjuve7WqI8sOLisDPPR5BpJITsnnXHLqY3sAc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 19, 2025 at 02:41:44PM +0800, Jingxiang Zeng wrote: > From: Zeng Jingxiang > > Added SWAP_CHARGE_V1_MODE config, which is disabled by default. > When enabled in cgroupv2 mode, the memory accounting method of > swap will be restored to cgroupv1 mode. > > Signed-off-by: Zeng Jingxiang > --- > include/linux/memcontrol.h | 6 ++++++ > init/Kconfig | 16 ++++++++++++++++ > 2 files changed, 22 insertions(+) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 53364526d877..dcb087ee6e8d 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -62,6 +62,12 @@ struct mem_cgroup_reclaim_cookie { > > #ifdef CONFIG_MEMCG > > +/* Whether enable memory+swap account in cgroupv2 */ > +static inline bool do_memsw_account_on_dfl(void) > +{ > + return IS_ENABLED(CONFIG_MEMSW_ACCOUNT_ON_DFL); > +} > + Please move the above to memcontrol-v1.h file. > #define MEM_CGROUP_ID_SHIFT 16 > > struct mem_cgroup_id { > diff --git a/init/Kconfig b/init/Kconfig > index 7f67d8942a09..669e39214244 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -1012,6 +1012,22 @@ config MEMCG_V1 > > Say N if unsure. > > +config MEMSW_ACCOUNT_ON_DFL > + bool "Whether enable memory+swap account in cgroup v2" > + depends on MEMCG && MEMCG_V1 > + default n > + help > + Say Y here to enable memory+swap account in cgroup v2. Enabling this > + option means that the semantics of memory.swap.max will align with > + memory.memsw.limit_in_bytes, and memory.swap.current will align with > + memory.memsw.usage_in_bytes. > + This is particularly useful for workloads that require strict memory > + and swap limits. > + > + If you are unsure whether to enable this option, it is recommended > + to leave it disabled (N) unless you specifically need memory and swap > + accounting features in your cgroup v2 setup. > + > config BLK_CGROUP > bool "IO controller" > depends on BLOCK > -- > 2.41.1 >