From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08475C25B77 for ; Wed, 22 May 2024 11:49:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F89C6B0088; Wed, 22 May 2024 07:49:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A7B26B0089; Wed, 22 May 2024 07:49:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 621846B008C; Wed, 22 May 2024 07:49:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4412E6B0088 for ; Wed, 22 May 2024 07:49:20 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BFCE680A07 for ; Wed, 22 May 2024 11:49:19 +0000 (UTC) X-FDA: 82145861238.29.F93407F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 6E3D78000A for ; Wed, 22 May 2024 11:49:17 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JJYacRVu; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716378557; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iQhB0iztFPknInaPPJkVPXM2/PL7yjnBkt/B3GMg3iA=; b=rFcHMuL95kBxdcwNbx9TOdqyPW2MqdvTYsBHMqO4sYdzbhe1UWWsPxLG/NkzvbW/06o8cW 28ADuibNjz2enH2DbGLX3YPWrIATARffPiczXRCmjNoqxYuE6UOprzvZOIlQeNZmYSLLos WVsY+7P0DVO/4YCYP95X3MTtfd+ahJU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JJYacRVu; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716378557; a=rsa-sha256; cv=none; b=oFGRJjd22z7/WyYKEas7OlvYuvMdquPBUVfnjSKLJ5txK4oCifepLwR1Jxdxd9tPI8xmER z28sU/UBPtnmtpPbj+AB/TuMt1rnUl/SdzgTKJ+t3mDLFohI2RmmD/9RTM0BIrfh8Duh1x hmk20+e5+NOf+eKZApgIt2U7FpczeNI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716378556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iQhB0iztFPknInaPPJkVPXM2/PL7yjnBkt/B3GMg3iA=; b=JJYacRVuuFxLkEBNCV8+3gJHywk15tMI5E6KC+qT90MVlNEM99OTX7X5nhK4e5bvaPoJbm VUbpMk0kNNT3E2Kg+Fl7ByVk8kJ9Q6cUfVxaZXiprTlzIAHthrh4sDTpuzYVREVoDfkhvP eHPOjJYhIw05nyBwtnfh5wPYHOBqkMc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-260-FBT74GG_NcCGV5Y2oWfMpw-1; Wed, 22 May 2024 07:49:13 -0400 X-MC-Unique: FBT74GG_NcCGV5Y2oWfMpw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-354e233a2b3so244220f8f.1 for ; Wed, 22 May 2024 04:49:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716378552; x=1716983352; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iQhB0iztFPknInaPPJkVPXM2/PL7yjnBkt/B3GMg3iA=; b=uDrvIt+yydi46diK+WT33jNnEvVizJPGUwooYpVJxbuh6GfTmB8mwYH/Vlu0bKK7D9 7CFbKoNfmIpIa3LOo0MFNRPqZZQ8EPO48Bic61WovoEBkGXHfEQCHOwZaAG5LRbImPA6 NQIoS6HNNRLgFGtrm3NDgY+QIFcctPxalmXImhgGjl253NPpiZeVT+qbsaxf/93gWnMl Tk3Hcxo+Cdp8oaXpHVegX7luyBiHM/iR97wHkVOrXyFIvtRAHiSHYiKiPdbYgK1HDnF4 Xhw36uOpioEjGMqTHcHG6ry6svf3ERqEE0kZ4KRcuQ3z21239s5atMZyLm9Mlbgz/n+T 2JKA== X-Forwarded-Encrypted: i=1; AJvYcCWjuTbIwvvaTw4zKrOyx8m6G/N5IAE9ci53fjd0PUWFjFZeJ3JHNtkXQr4XEOZjUTlSknoVbCfMf9VYjTIp81gsT08= X-Gm-Message-State: AOJu0YzZrUG3+Aiov8723npobF8+2CxN5irbidd4lAq6hi34APEhfNTu RSFI2HGVZRs1H2ebSq4J8b5lKjkS39oHvBgmYcHvemxERpyDwTuY21XcEB5bHIynQDq5aMZfUWD 1TBeqeS71Ba81z3wFOOPRJclz+Bb0NfD+FD7RaM67q1aVzsYR X-Received: by 2002:a05:6000:89:b0:34d:b549:9465 with SMTP id ffacd0b85a97d-354d8cdd80amr1325091f8f.32.1716378552031; Wed, 22 May 2024 04:49:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPYshRhMBqprIwRI44n20QSlHrRd/6hhTxsXawr1u16AgvgZxzQ/HYSdCueimfhK32bSDORA== X-Received: by 2002:a05:6000:89:b0:34d:b549:9465 with SMTP id ffacd0b85a97d-354d8cdd80amr1325072f8f.32.1716378551552; Wed, 22 May 2024 04:49:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:d500:4044:6d4c:f060:f677? (p200300cbc709d50040446d4cf060f677.dip0.t-ipconnect.de. [2003:cb:c709:d500:4044:6d4c:f060:f677]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-354db76acafsm1480470f8f.49.2024.05.22.04.49.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 04:49:11 -0700 (PDT) Message-ID: Date: Wed, 22 May 2024 13:49:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] mm/ksm: rename mm_slot_cache to ksm_slot_cache To: Alex Shi , alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org, izik.eidus@ravellosystems.com References: <20240428100619.3332036-1-alexs@kernel.org> <20240428100619.3332036-3-alexs@kernel.org> <2e074a0b-7ab6-4381-9216-31f68a738a07@redhat.com> <4c255baa-99e3-4f48-9303-13edb99adc89@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4c255baa-99e3-4f48-9303-13edb99adc89@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: ai7xqw76xedwqd4dus1e4u4fq4eacqb5 X-Rspamd-Queue-Id: 6E3D78000A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1716378557-34585 X-HE-Meta: U2FsdGVkX18m5kgIfo61RNx+jObvdl4m9J44CahTHyEP4V7xIP7ErcIsIi44P8wU9q1mA8CcDKjuDvNLJzRC6VsOMmrOplIj0aC8sNOK93829GfMUdjD/Cm/VX00/WjEx1UYfRj3v5UkFajeE+nlrfNcV/0Q07bIFlzepF4bA9bgBP45c3lznyfAlIfL2V8zW/fSXU9lA+hRGRR2smXl2XQI1oWnpSy6wE/Di+GlIkoREj35oR4W3pBrpQEtYQc0CSXq3abzGNxTgHHsX115rekr1Sq7O93EQJXA9OH1tsOr8t9pI0PP4aGy1fmXccuM6W1Ay/Y+kHqq4/SP0GZ8RAggMhQq5VpaXJ6YAKTot7kn5W9dQ3mn8uyz47hKa8p9CQRArq8HMUvgaoPmQhEJCqVVMAf8ajnmYv+rl/coPyHtxKO24C0qDK028Ny1ycz8zel0IiOlB0qkk4oa1b1j48sk2+ZHXXTus2aCbmpjN3BHI4HL8NsZv8At1bc5W4l/d8cFyyI6XFUx5KNjIIf1mDvGkve6RNfbZtEdGyDralLXF0sHuQhgP/Vv1Yx8JrUvVf/zU5JMiCKRnGVmQ74f23kigO3Tzx4PpiTCOvlpgR6PkMmJg6GhVgWrZQZKQXvImddi8N4AIlGjQGuWq39blQRJzUQwydmRC5sOQTPIjwvI4UzYpn5zWiXk6wYaGWdscBcY5hCvWlblo2cxSC6dTpgx+M0Nc1fw/Yyn70/BMSFSr7tANGJnu7HETTC7DfrS/d3rEgwiLu38fYkVMmH9J+3kwpu3K5KojfwuTxX7RlTqLqpFTMp9qlfi67BP8R0lR1coM/GaT/JzNiRcLOYZ6HdfzYW68jyP4rB6WYIy6I45StxEwYmQK42CF8CdbcOkpDahljJJT/Q8pqBFsy/0WW09hIEk2OmErKoyXEiCPwaavJoqIakABQMUi8q15Cq+oCqu4NP9MCg/dJEOKUq Ygm7S2Y/ 6Lb1h0XhVUya7Xvq5Nk9KuRXhjBKZB+OGTeGPoReInyp2Helzzah1qcZ+EbWkdrns/dm6xr4aZRls7mFAiLUvqNC9z345u97yXO4F9vntN+YP17PCScJZUIhsk5/A9f85k6keyalgOqpgnGL44TPMA5kI1MYnE5Km2oZev2qPjP8LMFaIA4sOnTjaXMAVDfWudVb4cf7UKRaDdGO87bYrNWrCc7Pv9HqGYK4QgmauG22j6nddOENV28f2teuE3H8Hduk+rw64H8aJQVIJGDwYhKRXGFy7BiN2lFJsxRQrpP00hojZErVGsCzdqy4qEbWhQOCv6+ZFdAjmq+qZczKNQNE64rb+x0c4J18D3EDw1FwRl5pqYrTbuV6G0/b4Cdu5FPS9h9pfAE1XqEjEcTi9omnQia5EoKYIYdLwtdbqM5tjadwpm1GcXTtKU9h7abVX5NCHmIqwM9lSVsTGbzbslfhkkT6Pg3wnhSgZWock2GkjqwP4/exMpYXauvU4wE9Go/FpJM8aeNxkwuMUPIyQCm7C/PPJw5KyHEkK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.05.24 14:15, Alex Shi wrote: > > > On 4/30/24 8:57 PM, David Hildenbrand wrote: >>> >>> @@ -2972,7 +2972,7 @@ int __ksm_enter(struct mm_struct *mm) >>>       struct mm_slot *slot; >>>       int needs_wakeup; >>>   -    ksm_slot = mm_slot_alloc(mm_slot_cache); >>> +    ksm_slot = mm_slot_alloc(ksm_slot_cache); >> >> Similarly, this makes the code more confusion. The pattern in khugepaged is similarly: >> >> mm_slot = mm_slot_alloc(mm_slot_cache); > > Could we rename it to khg_mm_slot_cache in khugepaged? I don't see any sense in such renaming, sorry. This code resides in ksm.c/khugepaged.c respectively and at least for me is, therefore, quite clear. -- Cheers, David / dhildenb