From: David Hildenbrand <david@redhat.com>
To: Alex Shi <seakeel@gmail.com>,
alexs@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
willy@infradead.org, izik.eidus@ravellosystems.com
Subject: Re: [PATCH 3/4] mm/ksm: rename mm_slot_cache to ksm_slot_cache
Date: Wed, 22 May 2024 13:49:10 +0200 [thread overview]
Message-ID: <edb23777-fd94-4395-893f-ac9697e915e1@redhat.com> (raw)
In-Reply-To: <4c255baa-99e3-4f48-9303-13edb99adc89@gmail.com>
On 16.05.24 14:15, Alex Shi wrote:
>
>
> On 4/30/24 8:57 PM, David Hildenbrand wrote:
>>>
>>> @@ -2972,7 +2972,7 @@ int __ksm_enter(struct mm_struct *mm)
>>> struct mm_slot *slot;
>>> int needs_wakeup;
>>> - ksm_slot = mm_slot_alloc(mm_slot_cache);
>>> + ksm_slot = mm_slot_alloc(ksm_slot_cache);
>>
>> Similarly, this makes the code more confusion. The pattern in khugepaged is similarly:
>>
>> mm_slot = mm_slot_alloc(mm_slot_cache);
>
> Could we rename it to khg_mm_slot_cache in khugepaged?
I don't see any sense in such renaming, sorry. This code resides in
ksm.c/khugepaged.c respectively and at least for me is, therefore, quite
clear.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-05-22 11:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 10:06 [PATCH 1/4] mm/ksm: rename mm_slot members to ksm_slot for better readability alexs
2024-04-28 10:06 ` [PATCH 2/4] mm/ksm: rename variable mm_slot to ksm_slot in unmerge_and_remove_all_rmap_items alexs
2024-04-28 10:06 ` [PATCH 3/4] mm/ksm: rename mm_slot_cache to ksm_slot_cache alexs
2024-04-30 12:57 ` David Hildenbrand
2024-05-16 12:15 ` Alex Shi
2024-05-22 11:49 ` David Hildenbrand [this message]
2024-04-28 10:06 ` [PATCH 4/4] mm/ksm: rename mm_slot for get_next_rmap_item alexs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edb23777-fd94-4395-893f-ac9697e915e1@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=izik.eidus@ravellosystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=seakeel@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox