From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 103F0C35FF3 for ; Fri, 21 Mar 2025 04:39:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C9F5280002; Fri, 21 Mar 2025 00:39:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 275B3280001; Fri, 21 Mar 2025 00:39:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 165F8280002; Fri, 21 Mar 2025 00:39:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EB46B280001 for ; Fri, 21 Mar 2025 00:39:23 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0377E81D53 for ; Fri, 21 Mar 2025 04:39:24 +0000 (UTC) X-FDA: 83244304290.06.32D7351 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 129D518000D for ; Fri, 21 Mar 2025 04:39:22 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf06.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742531963; a=rsa-sha256; cv=none; b=GYRpXRTnkt1Lk12ivlqqa+2997dzLexi9cw9CIMkCIOyAg5SiNxp80xUjZJ4wDYfTMJJ6m e+Mhc3qLMcqBijwWElMS7DUJr79MkaWnxGeZTZvvjLnx1ve7avWL8lNtp8iUqxrkSZwfwE Q0/utlDDJM3eTbgetLRf98vdULJAUmU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf06.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742531963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ciAN09sJCz1EXJ/RqUozLXq0ga90Gf8fmuUUeg1Uqk=; b=nIQBCi0An1Iuh6783VFpfuZZoBgIKbzLIb16Gguj9Rwh+RtD67DBljyJUzxstLVK7/Yw4o buQXo0OHM1KdPXywlczwS75w5aE5Wc49mCU7rKKiCye62WUqyFIZluoTnBb2yXbLcCq1k7 DsH0RR5RpoSO5G641eUKghso2IJU/GA= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C9508106F; Thu, 20 Mar 2025 21:39:29 -0700 (PDT) Received: from [10.162.16.153] (a077893.blr.arm.com [10.162.16.153]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A4E263F673; Thu, 20 Mar 2025 21:39:20 -0700 (PDT) Message-ID: Date: Fri, 21 Mar 2025 10:09:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page_alloc: Simplify free_page_is_bad by removing free_page_is_bad_report To: Ye Liu , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ye Liu References: <20250321010710.548105-1-ye.liu@linux.dev> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250321010710.548105-1-ye.liu@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 129D518000D X-Stat-Signature: xnno6bdcywzgtdgb83ht37dhip699z91 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1742531962-162109 X-HE-Meta: U2FsdGVkX1/aps4/rc80OlXGmifT2WVGqXT3PXIsQZtQvYdy+xYQYvJQEl6v0083mHA2cUIX8dT2N6xfBFYR1Az7PlGD9ohp1nXdWX1IaqpiRcfGUHNOpQJmcsE5S0skE8ZmLXkJoGIQMTrxp4YDVKqoJyOOUmc/o/DDJPnBTVVTLbAOo1cYnHn90rAZcRPX10Wd3hWfcYfraF0+//eRFRb5pRgp586g22VCQ9Pl0Gd3CHwnoFQbQpis0X+lnIj90Q+C17ANOopb0UQFs0hjxGBLw9C5O3aQzpAEYHmPp7P2wMQxrG/aLIMiloxlwTLydhKDM3k7hDXrG13+VtivIGjz9s477uTsyO4corklDoGyHW4eNR8noQBlVSgMm3U61+/Cgd2VR0RzKTzCHonaTISFtEnqgKDNxAAAlju3XfSGKh1bYy8TEc2b1c5YmdivK9+WHPdBhpbrp1+8aTvjSrxRC+2YY9V08NzbFIRpXSxRE9mVRxc4IquADLYBnfi8Z0SwHH2VExZL2pDN6JcKnj7OeSZChtjMo4LYbyS78ZycFiSbOw+ppL1HDxpxb5cC83WJ6kVKnLfA2+ass1+j+RZToCQpnqVnJNQkS85tz//nbb0fgwa9nVRRymPbk8Ec/i8nK2blC6eRTAjmnCjIOM1wcaQU0fcYAiv1ufYgrYEaKYQdhfROF69UI3xgpmnicLKfKONxotILzQpuTQOHCRBk6qrBqfiKLaJgWQHkHH8GlTfxSiFTrP4ce96dquj3ObsjHrieH+3Y5aEKj9/USzAQ3YiYWsWkfy6aDCxd8mHgQCcMBd57fGKTvFZkX4EhCt7zoVzkMch5TJidDcrEzu3nxKs43JltWHHAvP1RnUIm8xcedUVTZiza0DOZZG2IcliipX2q/tMUkPy5/XVylxrqaF+JUvuT1Dww6vRXjhFtHZwmc0GoftXO7s9pLAH/7fsNtedqihhNDPgvp4g 2EZb9508 E+7vu4GmOuu3DrEpWfh95dhAGLrnzcMx9vOB1pQtyBwjrrHajiG2+Dd5yHeGvlDm6iOIBNUQgz6KPVnHoz6nslBxtR9mAsp6T2ZWc0koL8I5lykJxPq50Qp5PKeC3ZoWQ0JMuF01GSNTIg13lasWpcn/e9NifiYgddyGF4DHuYRhz35hIlBAJ2kXx95YCLrLj8+js/T9YPpLHrcJgXbRX/JE6dvO66GSFqI3HxVcCoENvO5pzcTvkoTdmOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/21/25 06:37, Ye Liu wrote: > From: Ye Liu > > This patch refactors the free_page_is_bad function by directly calling > bad_page() instead of using the intermediary function > free_page_is_bad_report(). The removal of free_page_is_bad_report() > reduces unnecessary indirection, making the code cleaner and easier to > read. > > The functionality remains the same, as free_page_is_bad_report() was > merely a wrapper for the bad_page() call. The patch also improves > maintainability by reducing the function call depth. Seems to be a sensible clean up indeed. > > Signed-off-by: Ye Liu > --- > mm/page_alloc.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 61d6a3b1b286..2842da893eea 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -933,19 +933,14 @@ static const char *page_bad_reason(struct page *page, unsigned long flags) > return bad_reason; > } > > -static void free_page_is_bad_report(struct page *page) > -{ > - bad_page(page, > - page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE)); > -} > - > static inline bool free_page_is_bad(struct page *page) > { > if (likely(page_expected_state(page, PAGE_FLAGS_CHECK_AT_FREE))) > return false; > > /* Something has gone sideways, find it */ > - free_page_is_bad_report(page); > + bad_page(page, > + page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE)); Please fold these above two lines into a single line instead. bad_page(page, page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE)); > return true; > } > With the above suggested change in place. Reviewed-by: Anshuman Khandual