From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 828A0C47258 for ; Wed, 31 Jan 2024 03:27:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C129C6B006E; Tue, 30 Jan 2024 22:27:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC2536B009E; Tue, 30 Jan 2024 22:27:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8AAD6B009F; Tue, 30 Jan 2024 22:27:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 95F826B009E for ; Tue, 30 Jan 2024 22:27:38 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 51C5D140393 for ; Wed, 31 Jan 2024 03:27:38 +0000 (UTC) X-FDA: 81738171396.05.13E21E9 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf15.hostedemail.com (Postfix) with ESMTP id 3FFFCA000F for ; Wed, 31 Jan 2024 03:27:35 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf15.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706671655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0SCsed3MdfFJhbvnBYx+Rqrpq6zRtEKDXdYacEkucC4=; b=mHiA3GILkQotf3BmAp7GQKUhqGGBChpcYNQ7VxKW749U6/vFSNEUDcP5Wo7xiPleb8s0Rz OnuHYIfDsVtHP42wNCs54SFfZHmAMaVB7uKu5yhxJ/YVDnLH9XOWxbfRgjs/tb2V9ydn6k Bef1+o7O5UZBi4Z2+2O6REDosKm4f0E= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf15.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706671655; a=rsa-sha256; cv=none; b=4MuR1xqvr9LQ7fHI7ZSKpQXv1V857lgHQ14vzeCjTTsXREQ+dJXDOJb2QIeJnx7s780LKX XZ4XnMxnHzmpRs0JXQPKjXgQah8GSWjqP96wgX+eWZHdUnwcBhH029qnOwEDpUA8nFPdrb JMF+xRwg+cdumJ8yFlDuTzqDo1s1kmk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D55EDA7; Tue, 30 Jan 2024 19:28:17 -0800 (PST) Received: from [10.163.41.195] (unknown [10.163.41.195]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9FBBE3F5A1; Tue, 30 Jan 2024 19:27:21 -0800 (PST) Message-ID: Date: Wed, 31 Jan 2024 08:57:19 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 04/35] mm: page_alloc: Partially revert "mm: page_alloc: remove stale CMA guard code" Content-Language: en-US To: Alexandru Elisei Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-5-alexandru.elisei@arm.com> <966a1a84-76dc-40da-bde2-251d2a81ee31@arm.com> <3983416f-b613-42c7-bb42-d3ab268ea1be@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: i9if833qzun6dr5qz79jokqt65r85ix6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3FFFCA000F X-HE-Tag: 1706671655-193965 X-HE-Meta: U2FsdGVkX18/wZInLt1UVb2Ncr0ri6MMJwzHqFO+mz+ckhQGOXTffGRrK1oi9QGYQiH57wIm/p/YX0dDEdN1eK3J/yW+QNqwA6vAP6yFpzXoCG6SgTCqdOLQPUaqjs4lCWPHjGxBVp2Upvl3Zwy6GPIdx4U2y7TRW+oWUG5yPwJ4RVONRewDfhbkSvEwE3KYIO3zjuT9Cssn8GP+lPwatRykO4J+9V336XiuY/1L0ALL2ktTnSiLZz9i2csau62Z5afXbtOGQ34LJniGAmeL5bKuw4F3nZ1TLFhrzOc1mEoc3dXDDev4IvMFudHTewkl4oRM6HFf+NYjQuywcohNMvsIhxLTMQ4a6BOtnD2WAyr0pHvGp/1tV6ROhWqxU3HDZW5vgrY35krkMcuf0cY68ftZhw6DJAOlpRYu/1tl/LsSXq9l5JEoihwIQA/U1Z1xOoPeUnPqLlhdQvdKFJXgei22xQXpdwblOg4i7UeTyfpaAoHNNrc8MuybHf6zZ3L8Z4+5JH5YmpDK1EPTUWdnkWI0GBTNqV1CRVAjSxWkv0n1J5p4+/F8OPWsMmklFN1A0k37Xjo5NnJ/GOQnbKzjEammMzNyfabGd4xGEQF7Myoiee17tlnKnIF1F42CI3Ql7unPm5JNSARk0WDx9vT2UWSjmmE0sQ5d50rK3tsxQctpc1UXHcdsHKwPFW+017Mh9WVN+LMmbQoClFsy4NX8nIfzWJKifxiJJNqQ1Z6XlTVdSKlXDEPm+Dts9fKnSvQdWpECh+ib0KdICtBD/ZN/SgL+ttyyJTXlYD+BvI9/HcSCIC6dGp6Qb4toiVGBA4G8/b8W4T9T/94BGBDneiGDobXn3LJGzEc/DQ6cTo6xPg4janiaK9xqQgVteHs4OqdMRvsKjxPyepDdJa+Mic0v8N0eZWV1366ZVExtOwpRjISQM+8+WuqSgDISeym46hIWnfBi4CB/O990kqtYuVC kaKhhY3R 51stG9cY/HVMvkBzK8yk2ZkFm/J20Jij3i9L1uEvgrsAkS1c+3+PoNMNtLxaCJEXMwwh4S6JW2Bp1Nw1RGVB/oOkKRzIC5f0Hs/rXcZxlsFzxncrTjujqvI5gzcqpM7aabTZlN/wLLCsZFW7JLWh+VUWdHG7PxMz9HZsb/0WlCFZVVZInsqm9IpzU5D6L5xggiIgy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/30/24 17:27, Alexandru Elisei wrote: > Hi, > > On Tue, Jan 30, 2024 at 10:04:02AM +0530, Anshuman Khandual wrote: >> >> >> On 1/29/24 17:16, Alexandru Elisei wrote: >>> Hi, >>> >>> On Mon, Jan 29, 2024 at 02:31:23PM +0530, Anshuman Khandual wrote: >>>> >>>> >>>> On 1/25/24 22:12, Alexandru Elisei wrote: >>>>> The patch f945116e4e19 ("mm: page_alloc: remove stale CMA guard code") >>>>> removed the CMA filter when allocating from the MIGRATE_MOVABLE pcp list >>>>> because CMA is always allowed when __GFP_MOVABLE is set. >>>>> >>>>> With the introduction of the arch_alloc_cma() function, the above is not >>>>> true anymore, so bring back the filter. >>>> >>>> This makes sense as arch_alloc_cma() now might prevent ALLOC_CMA being >>>> assigned to alloc_flags in gfp_to_alloc_flags_cma(). >>> >>> Can I add your Reviewed-by tag then? >> >> I think all these changes need to be reviewed in their entirety >> even though some patches do look good on their own. For example >> this patch depends on whether [PATCH 03/35] is acceptable or not. >> >> I would suggest separating out CMA patches which could be debated >> and merged regardless of this series. > > Ah, I see, makes sense. Since basically all the core mm changes are there > to enable dynamic tag storage for arm64, I'll hold on until the series > stabilises before separating the core mm from the arm64 patches. Fair enough but at least could you please separate out this particular patch right away and send across. mm: cma: Don't append newline when generating CMA area name