From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AAC0C19F32 for ; Wed, 5 Mar 2025 18:34:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACC0328000A; Wed, 5 Mar 2025 13:32:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CA5D280008; Wed, 5 Mar 2025 13:32:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B8C328000A; Wed, 5 Mar 2025 13:32:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 505E6280009 for ; Wed, 5 Mar 2025 13:32:28 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 136831A092E for ; Wed, 5 Mar 2025 18:26:03 +0000 (UTC) X-FDA: 83188326606.23.3A019AE Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) by imf16.hostedemail.com (Postfix) with ESMTP id F1A52180012 for ; Wed, 5 Mar 2025 18:26:00 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=rIVNU23p; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="5 sixJxi"; spf=pass (imf16.hostedemail.com: domain of arnd@arndb.de designates 202.12.124.150 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741199161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q1dco+A1ZQ134eZ1BhjcbdIuYCO4f0Xtrgj8AjId3H0=; b=pFcRj5VAeAZ3gc2JAwSoI0KQrp6soT9nfZ70P72LZdR51s46eNsmL6SDeNnLIxjB2hYmIw floMdW/Q4ljJV3mlkNFX+eM0LGGYjM5NP602LemAaK27epUeJryZjz1svPR2xl1msJfiWC DjfB0DCHnNcslvgKYwVKO0GHsZMt3+8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741199161; a=rsa-sha256; cv=none; b=z0wQOj9c7F/aqqqNNWxz7TIjW/3YqNpvsNQ/LYnLIvdr9uYBT5S1qPiQ/S3uilW46SZ6y3 MhH9VO7nO36ZJM30iuuE+yUlST30TpoehfX+1KtRDyWrJ1PSNFLgaTmq04PrnlX7mqlpv0 yko07wkbgpKeCPDzx7/ro19yg1fn58E= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=rIVNU23p; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="5 sixJxi"; spf=pass (imf16.hostedemail.com: domain of arnd@arndb.de designates 202.12.124.150 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id BAC141140199; Wed, 5 Mar 2025 13:25:59 -0500 (EST) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-09.internal (MEProxy); Wed, 05 Mar 2025 13:26:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1741199159; x=1741285559; bh=q1dco+A1ZQ134eZ1BhjcbdIuYCO4f0Xtrgj8AjId3H0=; b= rIVNU23pV2mRSjKjsxplZRcfLak3xJn+HgNi52nfZKD0hkxLhz81qR0zds8sc6O/ 80DK6rfwnPw7bC7b3aV2ocpN6OzavwlWunwR6YOCtp0hsqy1R2HSTXYAu/nWpEXQ NDq265NtpP7uiPYENnhaIDXKCEta55HZ8gslnbn3CEHyauWTB2mXLuHBUUKkDK2K soSmV89GGqb3AZBT+b3wrH+iKWIgKEpECg0AK7RwC2kDuFCBvOwn9oNZuJA+/LKQ rB6rdcbZY8U1LPhssEsvxMn/2xWzAgKmrtWIu2S7fIM8vIeRadKOUYU/arrmoh4z 1f3I/dGjmR0zCgiLvSyk0A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1741199159; x= 1741285559; bh=q1dco+A1ZQ134eZ1BhjcbdIuYCO4f0Xtrgj8AjId3H0=; b=5 sixJxiH2hJ5LQPpsk8DGqxPZdxBE9mzc6oZqYom7PI7wCZLSewmTfa8PaeOLmQuR /82LWLLL3vieFsafOb91od1lcZoUA2ZHR115GK5Amq3mgTwaTpX9vSa0SMI63dCF TOIQ+fsa6mMOVGdmat8qRnU40W6S5oUaCFPqIFDDi1+y2kaneUwlQR2x9Vd7ql1q B5NTvB++t70PxcKCy94I3QSM317iykHrEClT5OOkT1KxlfD4YktCbAcWHHrg+ffK y2tNdFg53cNGgywiizyninT0UVaZoVzF3xUamjWO0/TuZWA0Lw1CLIpXoZMl/O94 8RRo6r9QH5XB3Gj0DIbtg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddutdehheehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertder tddtnecuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnug gsrdguvgeqnecuggftrfgrthhtvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeet fefggfevudegudevledvkefhvdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohep uddvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjvghffhiguhestghhrhhomh hiuhhmrdhorhhgpdhrtghpthhtohepphgvughrohdrfhgrlhgtrghtohesghhmrghilhdr tghomhdprhgtphhtthhopehjrghnnhhhsehgohhoghhlvgdrtghomhdprhgtphhtthhope ifrghnghhkvghfvghnghdrfigrnhhgsehhuhgrfigvihdrtghomhdprhgtphhtthhopegr rhhnugeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqmhhmsehkvhgrtg hkrdhorhhgpdhrtghpthhtoheprghkphhmsehlihhnuhigqdhfohhunhgurghtihhonhdr ohhrghdprhgtphhtthhopehlihgrmhdrhhhofihlvghtthesohhrrggtlhgvrdgtohhmpd hrtghpthhtoheplhhorhgvnhiiohdrshhtohgrkhgvshesohhrrggtlhgvrdgtohhm X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 970AD2220072; Wed, 5 Mar 2025 13:25:58 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Wed, 05 Mar 2025 19:25:38 +0100 From: "Arnd Bergmann" To: "Lorenzo Stoakes" , "Arnd Bergmann" Cc: "Andrew Morton" , "Liam R. Howlett" , "Vlastimil Babka" , "Jann Horn" , "Pedro Falcato" , "David Hildenbrand" , "Kefeng Wang" , "Jeff Xu" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: References: <20250305172800.3465120-1-arnd@kernel.org> Subject: Re: [PATCH] mm/mremap: fix uninitialized return code Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Stat-Signature: uf1sf9ran5sp4sgtjraao31iqjar6mhj X-Rspamd-Queue-Id: F1A52180012 X-Rspam-User: X-HE-Tag: 1741199160-431518 X-HE-Meta: U2FsdGVkX19+MK9wWd5BWXFxWFB0KRkd5K0rC9jrwksSb1GlcNV0x3e1BHk/B15wYTwX+aRp5UpLakNYnYFdZ+7vYCZGbO1HxpxbKOAmD9fcWxwQZE0QCodEFztzpYuEZ5O5y7bCAdyOamDKaVS23bIPtlBnhvub3H/7L8z+8ju6QL3+Pa1ri2+hj0BR3rNmwaIwzm5PENg3rsFrfjEHaogHqMCBgFUBZhntgP/HwmcJyKtNwtqiSIa1cvRfiTgbiLLSciCyCExXriwM7GLRGXEg8+Jy9wqBhh4zedJUFcqOFlr3CZ/3TDQFR+3jxO/ebUUf76MrsrxrACj6gJsR7j3rqXSwr1t0NRz5zu/2+rMG4XXbfE8fbt62pEpkBOU+Tb9S/y00LUivcYYUR3X3jBRXZvplg5ElAfo3H6m6xX5EzBSTYFLc3XRuzrsip3EgXSi2jKFx13NoSCB3CxUKq3UPr1/ROQfeYysGmAIUga9EJm0WgrOs9P5bcDryB07gfLv3q4qpL+OtSP4DvvyjcvZxV5LfM4G8wVgyFCU2tPz4dynCRcmEyg/ydCChIb6L9Q97xKwgibS4Zlgsai2KMO7HbdVyqp3UMZB7Sg5yWV5+2ThDfEbe/gX4KVnvZdWxw2q3DTdcZd/7cF1tQCiNxMg5AXiuBC1FscOE9ABVu/uiz91bIH52IhR0FcqvvR+/iWVvS7S/0UqPYcMc4gFdlxLyjfJpsVdRDBaXyYr9N9PtofKSkdqFSooJhGcROaVCnGaVdbBpVwj2k/bcaByspFnZq9ptJ/bgbF45xHp/6ZFH89+Ln0WO3nbpI95o1VV6R25xx79vu7jY00OVV4Tucozw21xayyqUGuT89vWtc5j3t5xCHk+5gWQH5IGp0lX1ge+8lgkORVtnwWQ4V9gHdArTSGpW561gkX1/xcPSwWAG4XSgKj2Wk7MX4ny3DjBOLgOJNJMFP3/xzVSds3l RdNm6vP2 2rgFg4aQ6XFhDcaEB5l2gOyAp0aGV8BCa8KY5yVWpuVT5xafHk5SjNu3VK6MgnVvP9hHf028kMn2eenc835XsbbxBn+5bUZZxy+B51FP+Xlc8sNQu2ctxyyj4QN93PHeLqpx2YvjL/XBilB+JFdJgqp4uZLNjbYxKHjQqrPjZFoZqKsQMRxQUKk6Jh4HJX4gQ72JrqDQQkBGVSOkRIul8M2vcZpggVVPysLARGuTL4e6ssQ1v4Uamrtt4JcNm36AljYX+PupPoqG0ku5Xypy4P/ZFMb7MdbC/+98BfIjbZ29GquY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 5, 2025, at 18:29, Lorenzo Stoakes wrote: > On Wed, Mar 05, 2025 at 06:27:56PM +0100, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> The 'err' variable is set in a conditinal branch and is not >> set otherwise: >> >> mm/mremap.c:1017:7: error: variable 'err' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] >> 1017 | if (vma->vm_start != old_addr) >> >> Set it to zero before the initial value is set. >> >> Fixes: 3129f7896afb ("mm/mremap: initial refactor of move_vma()") >> Signed-off-by: Arnd Bergmann > > Thanks for this, however this has already been fixed via Andrew doing a > fix-patch which should land in mm-unstable,-next soon (possibly tmr?). > > This is entirely my bad btw, for some reason my compiler locally didn't > catch this even with CONFIG_WERROR on which _really_ surprises me... Unfortunately gcc never shows warnings about conditionally uninitialized variables. There is a -Wmaybe-uninitialized, but that has so many false positives that it is completely useless and it is turned off globally. Arnd