From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72592C3DA7A for ; Thu, 5 Jan 2023 09:03:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04DF68E0002; Thu, 5 Jan 2023 04:03:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F413A8E0001; Thu, 5 Jan 2023 04:03:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E07FD8E0002; Thu, 5 Jan 2023 04:03:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D1E338E0001 for ; Thu, 5 Jan 2023 04:03:26 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8407980D23 for ; Thu, 5 Jan 2023 09:03:26 +0000 (UTC) X-FDA: 80320156812.06.39D09D1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 89C2814000B for ; Thu, 5 Jan 2023 09:03:24 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cilPLck7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672909404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yJxUMJ4cc0bXFjxOxYH/8plJN+Z8JHXgOnN6m3GItqw=; b=ugCke+bPPMJsW3oPzwyG5fIdZfe9ZzHAhJIaJ+o4FuOhSLehrSIysX9I/P0ZVC55Xi6nd+ AtcZDw/0VRSVPtjsXu3De481dZIEEvUyF39pNFAwrRpCqoumvP3NZoyuBvo+gYoBKwPekf 4HdbB+MCMM/6/iFwqVVSrC2n+uI+bao= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cilPLck7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672909404; a=rsa-sha256; cv=none; b=0Yn0b+Coqztsovto3cjM/wUjIeyZqPBieh3rmQPZkzZ7ICdcbnWNKSsn/fpLPbkLwD5AON NW0MfxxhWuZezA4HUgUfKqUJPxYyhDwLK6d23szI2lFWyluekrWgEQYIJEos6TyCpl1OY4 VQrz/pirUouH16DHxBx9cxxuw5vDtAg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672909403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yJxUMJ4cc0bXFjxOxYH/8plJN+Z8JHXgOnN6m3GItqw=; b=cilPLck7tdvS85xWvWOYw602K8T6/I7IgsZfa/elYi2CNSDqPP3fqNtLu/7CI62HCQM+Qj lAA7vU+E5+0QWZWuFH4bUiEUH4+Y7F9vGuG1qDxUxWyAcYvMLEcFVa5L4LHShQzqIsOHQo 4OwUkeIqVWI7+d1jY1UOoge8iqThYVI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-617-pef4pRQfNkym8Hqm76Niyg-1; Thu, 05 Jan 2023 04:03:23 -0500 X-MC-Unique: pef4pRQfNkym8Hqm76Niyg-1 Received: by mail-wr1-f69.google.com with SMTP id u15-20020adfa18f000000b002b129dc55bfso167203wru.11 for ; Thu, 05 Jan 2023 01:03:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yJxUMJ4cc0bXFjxOxYH/8plJN+Z8JHXgOnN6m3GItqw=; b=VKfYdyoujws2l7xQkVZ5n9D+KaYbyPxE/XdqLREbaNum2nnNgHoJ7HMA20UZaqG2S9 IB4rIFKqdDQKTu0n38PIBdQy4I6K3Z9J588zn8F+EkPyaUO9tkBOgBOGbFgYnz69M5yL +g+OFIafCc2iBjwpcqwWIhREOQgJJ5eY/Db+j24l2sdXhYuDN8Qt+B4dLJRiZ3L0bpYj d+sfFlHtqE70J7aYIIYBHsbfpEck4y/p3ZfXhLBxpclgp7QpCuX8dJMdWO6Tz4L8jkX1 7/VPBglvmbL/ozvvQwgO48no5ERXoc7TaG9zOzDUXIWV3V6+lM8grSdykRh9Yv+QUtar lBTg== X-Gm-Message-State: AFqh2krF5a1jPpH6Oh5461RwG38FoX/mJ4AiosOtpPu6T8x/oyJg1inC +MfRfy3YfRvp4pYLnEvbnS0oqasaAWJSQ/pAH1LOzUiy+QZYi5vyQQClvsBos6O4AQ4uKqun3qj 5PzUaQLG+Exg= X-Received: by 2002:a7b:ce8e:0:b0:3d7:1b84:e377 with SMTP id q14-20020a7bce8e000000b003d71b84e377mr37831290wmj.27.1672909401815; Thu, 05 Jan 2023 01:03:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXv0Y5fQcX763RAIzRQ8PNO4w/Q2VzlNrFEMudJbNju7Ud3QGHFnC6dt54wDBWwyaGolHjuW8Q== X-Received: by 2002:a7b:ce8e:0:b0:3d7:1b84:e377 with SMTP id q14-20020a7bce8e000000b003d71b84e377mr37831254wmj.27.1672909401521; Thu, 05 Jan 2023 01:03:21 -0800 (PST) Received: from ?IPV6:2003:cb:c707:6e00:ff02:ec7a:ded5:ec1e? (p200300cbc7076e00ff02ec7aded5ec1e.dip0.t-ipconnect.de. [2003:cb:c707:6e00:ff02:ec7a:ded5:ec1e]) by smtp.gmail.com with ESMTPSA id hg9-20020a05600c538900b003cf71b1f66csm1752231wmb.0.2023.01.05.01.03.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jan 2023 01:03:21 -0800 (PST) Message-ID: Date: Thu, 5 Jan 2023 10:03:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs To: Suren Baghdasaryan , Andrew Morton Cc: hughd@google.com, hannes@cmpxchg.org, vincent.whitchurch@axis.com, seanjc@google.com, rppt@kernel.org, shy828301@gmail.com, pasha.tatashin@soleen.com, paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz, Liam.Howlett@oracle.com, ccross@google.com, willy@infradead.org, arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com, bagasdotme@gmail.com, suleiman@google.com, steven@liquorix.net, heftig@archlinux.org, cuigaosheng1@huawei.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com References: <20230105000241.1450843-1-surenb@google.com> <20230104173855.48e8734a25c08d7d7587d508@linux-foundation.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 89C2814000B X-Stat-Signature: wp557k6pqf4rarsdun16mkrgkctjdy7m X-HE-Tag: 1672909404-26459 X-HE-Meta: U2FsdGVkX19xcl748f84dPAsWHqFTvwYaI3MeydKQMqpCmqWecceCuwhRhuoHsh+VsRGWynPbQdIt4hgT2blTr9Jumbuq67TquFLiJRUn0Te+E1qmMmZED5kFumREsyBNsnolXRQI/nhjNA2/BZ2ZaWNy8TGUuCBsx+FEhfefr36QjOrNUNFq9ysG7a7GEYXGZQDI4UVJZDJvYu1npdOZplksD3hYFD62+5BHAGGD3n+n9+jVBQP0atnaDiFfrwYPxuH+j2j+/R4XOqNKM6moAuH6mrPDF3MNCseU+UWXbKICdlLrStl1yN3dC232hZZTKRyo7PzcCQW3m85QkFTOelSEH0f/07VqtSCyBT2baW2uTqYzAcaJKlfyr51m1BlXFC39xCZaBa7DBTGXw9iXCTe+d8fFIo01+mQH2Bn01JJPgRpj1QqftlcuggxCb5U/8maXcghzD9xAROzcNDTS9maM8F9nw9nBCEdVPxzCm30BZSITJwY9ZbLXGHkZhu+nDssQn9NJFK6ZAwkkNMS5S1TYERawqrABTGCS7wWlTLz+B80WcJhfYUBCGcUSQHsv6M6URgGFQaxJy4fJvfRrvef8rDzJdXS6RTvDedphM79tdubomekcemkHLWLdUKzUOIkV2kLhiy+vxmgLfHCwwQVn3MwoR6cfMk3nf7VFz9XaM5WwHwNGd/U5ZBLpiNXn1McQsJffeXLB8JABJjLA/6zZxRLDi/VnzI8DF0ogu7lD+UJ0pjdYX/HlkISttgZrHqWyJRN8xwbrAtpK/yMkJ8NQOCN5ulTqefcXgZHiwvnJHXR3nRcnlV/MIlWuGIllJcXvgH+8ccpkpErUxB6vdGyKYief/WHKonH3shyrodjfuxLz4NmGutNbcWsaxbbzwtcotgWO2HfIx8epD+p7OilpQTSxo3I0FGutxyYTeMJmUBtTtI0M/r0pF42C470CMT2t3BxRZ+rc7k/3iN NvQTnT0Q cfJLo75mNNs5XV1e375loi/LN2s9gjOm1ThgAeNxmU1RQesc1eXhn4Ap9K4wmQqcEzvpUGgWUuBwOfAgDDeMnVpYX1CvcT26IMkZvf2gjAKyNVO1RfpPghJ4DCNDPtwB0CeY39KJsc/qY1GZkYMc/Nz2whbCtEGwOX4TxuF+1xLDfIF7JATT87od4ncBeISZcltrIkFQDkVzZvw5rcsBP1YBZoMdR5sNiEiXcwcx5jQNwi0PEGKaSZkh8ZcfTDN9WvVgYI/Rv+SiXwpeQiaYoSpLZyFhxYdCrNsmi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.01.23 03:39, Suren Baghdasaryan wrote: > On Wed, Jan 4, 2023 at 5:38 PM Andrew Morton wrote: >> >> On Wed, 4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan wrote: >> >>> free_anon_vma_name() is missing a check for anonymous shmem VMA which >>> leads to a memory leak due to refcount not being dropped. Fix this by >>> calling anon_vma_name_put() unconditionally. It will free vma->anon_name >>> whenever it's non-NULL. >>> >>> Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming") >> >> A cc:stable is appropriate here, yes? > > Hmm. The patch we are fixing here was merged in 6.2-rc1. Should I CC > stable to fix the previous -rc branch? > No need for stable if it's not in a release kernel yet. -- Thanks, David / dhildenb