From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A1AC433ED for ; Tue, 20 Apr 2021 13:56:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4F130613AF for ; Tue, 20 Apr 2021 13:56:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F130613AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B50B46B006C; Tue, 20 Apr 2021 09:56:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B01506B006E; Tue, 20 Apr 2021 09:56:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 961C26B0070; Tue, 20 Apr 2021 09:56:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 7A1756B006C for ; Tue, 20 Apr 2021 09:56:34 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 205581DFA for ; Tue, 20 Apr 2021 13:56:34 +0000 (UTC) X-FDA: 78052895508.34.E1B8674 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 73B79200027F for ; Tue, 20 Apr 2021 13:56:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618926992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2swGFScfNKtndGubsPyzcMB/R/9UWctxaEjz506YT0I=; b=WhVHr/cXV0RHftIvwt8W2BEhqq+DPBVHEt0vfMV1erWbJnZMvtBAbNeRdVc5A9xbo8PAj6 4bij2LyNrv7kOZgOGtCJC4FZix+uks/SgNsn5fjJVlB4KfpHIF01s8qYO/ac9VUiNiYMlT w/HSkN0my7SIFezsHSWjfj7yEqBra0w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-604-k1PJdZVZOZ-HG3Gv-U5lQw-1; Tue, 20 Apr 2021 09:56:30 -0400 X-MC-Unique: k1PJdZVZOZ-HG3Gv-U5lQw-1 Received: by mail-wm1-f69.google.com with SMTP id v5-20020a05600c2145b029012bdd9ddcb7so3870774wml.1 for ; Tue, 20 Apr 2021 06:56:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=2swGFScfNKtndGubsPyzcMB/R/9UWctxaEjz506YT0I=; b=UfDwCSnDTCQI5Hm+QRhnOUfkyWxvH1H7XHaeKimurP9FGJLnrA5rovq9wuR0inVS96 JezAODszMCll9tI/TTdhxS5cE/R4BxzFUB/8KD4QroIRpT7Rlu99NzpW643zfw4Z3P3J Nzsa4fZezIfDVBx44D2R9UlUFv5Uqaz27cK2fNd8V8+0ts6tPIEqO2RL95QxFZ7Hs9lU ck3WbOgcjWwku4TbJ5ieDUmn6OlLL+sDsW5itZkT7inbcKQYyq2c9X4XL30H/JjZP0Vt Kn7WkiUvF3Z81/wf1nvoJ+jGjMG2SiYo2KTbhnuAp4CVm45Js3womOSvJTJlzChWS4Mm nU1A== X-Gm-Message-State: AOAM531+ZO+KjuaKwDhuS9IgaYRzjETemtxO3ALGdzSYRQnrmjcnCElm 8MUZCU5ZgoqWnRf1NicB86hXrpekCjndYKYd9hQJ85Qpd7Br0uh2UEu7sk9xvi1ffZK9Thzcq8b 9jH2999LQH9e1Z3bD7yYRW/5xomJ/G4RQLYhv+jeV6PU0VQKbKfFOT8ifDTk= X-Received: by 2002:a1c:7714:: with SMTP id t20mr4773903wmi.24.1618926989447; Tue, 20 Apr 2021 06:56:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXffdbVbO4EhLxZXboPYwUyY34Zz8JQIixcWjehp7ikNXXuUMfZAGOffqPbzkJhVg2Dv9JJQ== X-Received: by 2002:a1c:7714:: with SMTP id t20mr4773877wmi.24.1618926989194; Tue, 20 Apr 2021 06:56:29 -0700 (PDT) Received: from [192.168.3.132] (p4ff2390a.dip0.t-ipconnect.de. [79.242.57.10]) by smtp.gmail.com with ESMTPSA id c18sm27378176wrn.92.2021.04.20.06.56.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Apr 2021 06:56:28 -0700 (PDT) To: Mike Rapoport , linux-arm-kernel@lists.infradead.org Cc: Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210420090925.7457-1-rppt@kernel.org> <20210420090925.7457-3-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v1 2/4] memblock: update initialization of reserved pages Message-ID: Date: Tue, 20 Apr 2021 15:56:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210420090925.7457-3-rppt@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 73B79200027F X-Stat-Signature: o8ru5z5yjuc4zsfiuu4zsirugbxgu664 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618926980-626541 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.04.21 11:09, Mike Rapoport wrote: > From: Mike Rapoport >=20 > The struct pages representing a reserved memory region are initialized > using reserve_bootmem_range() function. This function is called for eac= h > reserved region just before the memory is freed from memblock to the bu= ddy > page allocator. >=20 > The struct pages for MEMBLOCK_NOMAP regions are kept with the default > values set by the memory map initialization which makes it necessary to > have a special treatment for such pages in pfn_valid() and > pfn_valid_within(). Just a general question while thinking about it: Would we right now initialize the memmap of these pages already via=20 memmap_init_zone()->memmap_init_range()? (IOW, not marking the=20 PageReserved?) --=20 Thanks, David / dhildenb