From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C58ADC19F2E for ; Thu, 27 Feb 2025 08:44:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F6C56B0088; Thu, 27 Feb 2025 03:44:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 17FF56B0089; Thu, 27 Feb 2025 03:44:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F15216B008A; Thu, 27 Feb 2025 03:44:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D01FD6B0088 for ; Thu, 27 Feb 2025 03:44:11 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 35E93120A27 for ; Thu, 27 Feb 2025 08:44:11 +0000 (UTC) X-FDA: 83165087502.13.12E83FF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf19.hostedemail.com (Postfix) with ESMTP id B7B9D1A0008 for ; Thu, 27 Feb 2025 08:44:08 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hEfFXhJw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XdlO5DSJ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hEfFXhJw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XdlO5DSJ; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740645849; a=rsa-sha256; cv=none; b=35zgMAAZ5sVbLk1bLpVdStg4Ok3SqXvTPdPtOEZlvRMkbY2KTDufB8xbcEOEt5yp0M7Kx+ zEV1mbDdQ3Pp3WpJ+692ab7veDuooZK+s7nbV5KfdzfGs3wW91sxteDz6hBJEY1d903pEL FtEufXZkIAXN91CKMTcv9VWrhNhq7QY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740645849; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LMnKh/z5fQSVEn3XFGBuLrLYrNnKT8zMWuHixToX0KQ=; b=z9v3pg2mef4ZknDRw9Ly8Q7FfYtEMv32fgVyNWfIMIb2wX6+CRnBi6qDQ/3zQre0jHW+uA asDuJFwr4VLxikngQ1C9MUj1VES0rxSw2arg751vTMrOJmToJMp483MIXGOzoB3neyNhn4 t2Uv4HcFaHulkMwFbq4WmGiwukF/d2Q= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hEfFXhJw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XdlO5DSJ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hEfFXhJw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XdlO5DSJ; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2AAF721189; Thu, 27 Feb 2025 08:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740645847; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LMnKh/z5fQSVEn3XFGBuLrLYrNnKT8zMWuHixToX0KQ=; b=hEfFXhJw0h/kVsbtY4abQeu1Fr/LrxwXeJ+lOipadzmuMaqPQt2RbNVo2zUJwd1oUSukoW fqmCnFTQWheMKN36hMWBUhiqav6DTENI9IOZWcHiIXvaTkuivbAgq9TzB0OOD6bCtXFuhN JJZ4V0fs/r7i8HPmYpLtQAyfsUW8Zqk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740645847; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LMnKh/z5fQSVEn3XFGBuLrLYrNnKT8zMWuHixToX0KQ=; b=XdlO5DSJHC8sugjJ19TwxDNxRf46dUAFulFTr8t/z/lpKXHhxei0WeTLHxU58Gn+gFcJDm U5GwPzVLCIG/AcDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740645847; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LMnKh/z5fQSVEn3XFGBuLrLYrNnKT8zMWuHixToX0KQ=; b=hEfFXhJw0h/kVsbtY4abQeu1Fr/LrxwXeJ+lOipadzmuMaqPQt2RbNVo2zUJwd1oUSukoW fqmCnFTQWheMKN36hMWBUhiqav6DTENI9IOZWcHiIXvaTkuivbAgq9TzB0OOD6bCtXFuhN JJZ4V0fs/r7i8HPmYpLtQAyfsUW8Zqk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740645847; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LMnKh/z5fQSVEn3XFGBuLrLYrNnKT8zMWuHixToX0KQ=; b=XdlO5DSJHC8sugjJ19TwxDNxRf46dUAFulFTr8t/z/lpKXHhxei0WeTLHxU58Gn+gFcJDm U5GwPzVLCIG/AcDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 19B3713888; Thu, 27 Feb 2025 08:44:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ao3xBdclwGeLBAAAD6G6ig (envelope-from ); Thu, 27 Feb 2025 08:44:07 +0000 Message-ID: Date: Thu, 27 Feb 2025 09:44:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/page_alloc: Fix uninitialized variable To: 76824143@qq.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, Hao Zhang , syzbot+0cfd5e38e96a5596f2b6@syzkaller.appspotmail.com References: Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: B7B9D1A0008 X-Rspamd-Server: rspam08 X-Rspam-User: X-Stat-Signature: 1iz5m7m4kjdigwo3omgwaqn6ahs31rqf X-HE-Tag: 1740645848-23553 X-HE-Meta: U2FsdGVkX19JPIS3C+s/gi2cHtbaHfFJP2HcTFz2yjX6v3/sZEWIAv93auwtS7CR1gdOqH0Fvs6m7abNRYdU2Agzbs/gErQew6yZy7h6ZCVNGKZuI2Otc8PkCk2R2gNvfmoUonDssXCZ6GurMet911hcpPXekLzNwBPiIMPA21NNhhD/CMY/isJtnumaEsYJ/vR3IW7hs4X3SYq3re7AwfX3sN/x34XsnSG2ye4suOrArNtXDH+WpKLHkDbHh5b+M8y8JenkADBtjGuVpmn8DFKj0HZr6+SNvWbyh5+dNjqDL9BsMZB0SzeUhXcrkk8Tn9RowzQ/cSA3cHObrAlGk7L1ozNXyHFhyWT8rSUQ0MiePYuYtMI/iWsILzENnYZQwQeido4V2gtE+YuxP1csdok3eIna6SqDvF5nzgz0x4NNwXViBRckF+l+ARP160/FLhdeGi0OpGfaHURURRFTRalF4i+u6zqXbzv9iIJogYKGozjaMRwctJP3IjhYaaim4tTpTv8po1rF2gNRuHQlDImG0GefctO108vYoDLBMsUKtU6HQW7+6PXg5sG3EnT/+PgK8Fa4vGfl7VqOYGpWfxb098bUQPAXWkRkes/QigD04o1ZZJqmZm0qI8Md2BZbheA+YR4oeAA0wHlgUC/16X/nNM0ilu1NcEvDmkqVM9pbNRbrmI13kaQWOhb/fD0FGEwI1NobhhW/cSVhUifbdn2jE7qmkmfFLHJ0Gle4MY1vuj2ja9hSMS5SB9+ugqpiAa/nB0w06+fWgL9U6d4/3sPnBAXKDeo9cjSDY6417lUbcsvuULsgEvnaXnPXgLcAmThZCWoul3FWLOh5JvNoUBOBZNq+bL0pJ3W6IyVtW0E9CWXo8ShI4LXFnd92lMTYDkRfR8QHXP6AwJ39HpUmvYUlR12maIp1bbZliCAh9KB6pDKPd/JEceTpZqPT49axsM8A9mpHYAZumczhzYw SZfU7mdQ 1Zz+18pRP9arLMtJUMYZsY/dchSKukoqfN5a2ZgXjPz/g1cAZOx/TuyeCyd0edu7uxSOi22Q4irH85pJnaq8HpibFSQasf4PUgfOqLUrui0mVD/VnrrxGbdVN9TJ50zafZhqJQ/6TXu+91ZmPaiJ5DBX4h27QfLceXvkHcYjWaB6eQ06TIT/3+2q2UjTSo4hhly12eggpaTZS+zrryRR2qDRjCIiiCBbKLdkuUU3XK+fIsSphtLnL0fWBZkoDsJKYMmmka+ibLL48VlMZulQDo4qkzHfYnfbWfmKhp2Sz+YIcmMphr3v8eP82/ke9pB6I7rIjQwFK2gLflFVe3kUG9QtL7q4I1ImBuAMrJa57ytyFScBfbTFCBDTHl3/wcCl51TWkycHOZS8E9dXewDD45Ks/qhhGPiFEVZiaFXUa6abWLv22qc4StNL9Ijnwv1n5Rn7x2PgVaaK/v3R63UDp7lAFtxDg/D25GaHNRwKPd3XT8fffCw4F6wai+zZIG+B57DfqOzOLgXmMc9LRgVEIMsrrFI6GXdABW4GCx5sC/q99GL2Fks1KPDJt3WFaG+UGzObX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/27/25 04:41, 76824143@qq.com wrote: > From: Hao Zhang > > The variable "compact_result" is not initialized in function > __alloc_pages_slowpath(). It causes should_compact_retry() > to use an uninitialized value. > > Initialize variable "compact_result" with the value COMPACT_SKIPPED. > > BUG: KMSAN: uninit-value in __alloc_pages_slowpath+0xee8/0x16c0 mm/page_alloc.c:4416 > __alloc_pages_slowpath+0xee8/0x16c0 mm/page_alloc.c:4416 > __alloc_frozen_pages_noprof+0xa4c/0xe00 mm/page_alloc.c:4752 > alloc_pages_mpol+0x4cd/0x890 mm/mempolicy.c:2270 > alloc_frozen_pages_noprof mm/mempolicy.c:2341 [inline] > alloc_pages_noprof mm/mempolicy.c:2361 [inline] > folio_alloc_noprof+0x1dc/0x350 mm/mempolicy.c:2371 > filemap_alloc_folio_noprof+0xa6/0x440 mm/filemap.c:1019 > __filemap_get_folio+0xb9a/0x1840 mm/filemap.c:1970 > grow_dev_folio fs/buffer.c:1039 [inline] > grow_buffers fs/buffer.c:1105 [inline] > __getblk_slow fs/buffer.c:1131 [inline] > bdev_getblk+0x2c9/0xab0 fs/buffer.c:1431 > getblk_unmovable include/linux/buffer_head.h:369 [inline] > ext4_getblk+0x3b7/0xe50 fs/ext4/inode.c:864 > ext4_bread_batch+0x9f/0x7d0 fs/ext4/inode.c:933 > __ext4_find_entry+0x1ebb/0x36c0 fs/ext4/namei.c:1627 > ext4_lookup_entry fs/ext4/namei.c:1729 [inline] > ext4_lookup+0x189/0xb40 fs/ext4/namei.c:1797 > __lookup_slow+0x538/0x710 fs/namei.c:1793 > lookup_slow+0x6a/0xd0 fs/namei.c:1810 > walk_component fs/namei.c:2114 [inline] > link_path_walk+0xf29/0x1420 fs/namei.c:2479 > path_openat+0x30f/0x6250 fs/namei.c:3985 > do_filp_open+0x268/0x600 fs/namei.c:4016 > do_sys_openat2+0x1bf/0x2f0 fs/open.c:1428 > do_sys_open fs/open.c:1443 [inline] > __do_sys_openat fs/open.c:1459 [inline] > __se_sys_openat fs/open.c:1454 [inline] > __x64_sys_openat+0x2a1/0x310 fs/open.c:1454 > x64_sys_call+0x36f5/0x3c30 arch/x86/include/generated/asm/syscalls_64.h:258 > do_syscall_x64 arch/x86/entry/common.c:52 [inline] > do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > > Local variable compact_result created at: > __alloc_pages_slowpath+0x66/0x16c0 mm/page_alloc.c:4218 > __alloc_frozen_pages_noprof+0xa4c/0xe00 mm/page_alloc.c:4752 > > Reported-by: syzbot+0cfd5e38e96a5596f2b6@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=0cfd5e38e96a5596f2b6 > Signed-off-by: Hao Zhang Reviewed-by: Vlastimil Babka > --- > v2: Init variable "compact_result" in __alloc_pages_slowpath() > > mm/page_alloc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 579789600a3c..424731333276 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4243,6 +4243,7 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > restart: > compaction_retries = 0; > no_progress_loops = 0; > + compact_result = COMPACT_SKIPPED; > compact_priority = DEF_COMPACT_PRIORITY; > cpuset_mems_cookie = read_mems_allowed_begin(); > zonelist_iter_cookie = zonelist_iter_begin(); > > base-commit: d082ecbc71e9e0bf49883ee4afd435a77a5101b6