From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08717C5B549 for ; Fri, 30 May 2025 10:22:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 968376B00C8; Fri, 30 May 2025 06:22:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 918626B00D0; Fri, 30 May 2025 06:22:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B8EC6B00D8; Fri, 30 May 2025 06:22:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 551686B00C8 for ; Fri, 30 May 2025 06:22:10 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C6DB857B53 for ; Fri, 30 May 2025 10:22:09 +0000 (UTC) X-FDA: 83499183978.20.A1528BA Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf24.hostedemail.com (Postfix) with ESMTP id 6A368180002 for ; Fri, 30 May 2025 10:22:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b="nUmhD/bW"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=gF1A2Ba4; spf=pass (imf24.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748600526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GhJ3NZfAR+hL2gDBjLoeKSjE8nDhfKkL7k2fu4ZzkGY=; b=8WfgpxylyaFUXtwhkIwCPumcpNoqc7/1MwNvBbd+nZmxbpnc4aCZqhp4QKwJMFS6PKkjSN tsTK7giyZO0UbTttUKUwVmAaw+sWIZsqUtzP+v3OfpVNieA8cANHjbZAYdwJcw79nkl3+S cry0zHH4XWXgs+e1x1iIM2eUoJ7f1C8= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b="nUmhD/bW"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=gF1A2Ba4; spf=pass (imf24.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1748600526; a=rsa-sha256; cv=pass; b=53srIQ5I3DRO79mz2LOZyTRNMBjZLo4Z9hIwUCAB2jAZFjyke2tCUdbaOwUBhSqyNFJpqH P+C+FSSmUz7dRUL9U8CTUvkg1HXrzGJnWQYxkZCtJbJ2XQZVO+ZhsEWTayrNF2ngdVSFNj y01GGVBks/mCzpb5z8Q/ADccDSCUNxM= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54U6ttc2000677; Fri, 30 May 2025 10:21:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=GhJ3NZfAR+hL2gDBjL oeKSjE8nDhfKkL7k2fu4ZzkGY=; b=nUmhD/bWQh0/yb2Uj506yezAzLFcdOKe6Q sSkN+frg7WUPP8bmCkV0Ac3Zu/1CkZOwr53hbBScWcEo29utxWnkUosjYghM0gu8 yBM2clx1e/mB0H2qIBAzWCigog/wg7ILGTfBN8p8Lp3v/Icp292wKmMpWBBqGKMG /o8B0egyPKazr6g4JZvSichh/8XL0YW5qg8zgVFBaEOROwqmIbzTP1V4vWzu76eC h55YEoyXUzZ10wBvKvd0RP9+IkmLpL//PPinCZPC96opbpKV3cA7a2ZWKoroVOr2 CZ6CKTQMXX7wYhuALG2DhqOiFcO+xAyMG3/xT8BUSoUyqQWOGtnA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46v21s9u9f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 May 2025 10:21:46 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 54U8aZQs019465; Fri, 30 May 2025 10:21:45 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12on2073.outbound.protection.outlook.com [40.107.244.73]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 46u4jd43h2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 May 2025 10:21:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K+SphPmL0SA1wOjh81vPK33geQvUON8TgKuL1nmGuyINVRylscx4S4H0lC8DGfs/Jd6rZU4gqipcW/l0qXznry3ixjwb2uvJJ/9ZW9Wou3lOOPLu9iFpI1b3f8t9kw9i+ERvqYzXU3P7N03/ujNQXY0socPEb/ru/U8IJaUId+w4mRde3GSwpCkT5oS/Eqi04SmJgzd5h4RMM2YLwh1e4UQeaVZLzpgkophuHEpKqB3EiKUaJOFsDyxjPgiD9KUM3386UgE8MvbeT08HhuLTw/RTFDEgic9Hx2HRq9h8BfLsKY0Ok64Jqs4F+ge6JRIPoZPrl7vL2AH7/HO0uIXSxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GhJ3NZfAR+hL2gDBjLoeKSjE8nDhfKkL7k2fu4ZzkGY=; b=GzIj/UXlOqEQi6J80QgGI2Ua4qrWJeMN4hHTs+UDH9ADrOfNn2BfTuA1GSNCzsV6fbw7bAFzvBrmrD+wY9nvQwuSgI9qiM9jra6+9VUcUUvgBYOXhed1gOjSl7s/Y9hBIyRgY6knuRxIlcyK+KlOooc1wxJB2+isKifH93JlIXNQ8qe613wGIXtePpL/lywN6qM4PMkNkN1//sdnEJfyU7KHLhXllj760o5sYr5saYQiJvYsRgMVV5OxlpHRcH0P15NEqBeFLB44VFABlUNByTLj+k+qsqUfa1e14RzdR8XldE+LDez66gpG2vn9IBfkHbOqxHRsboZpGkjadsD/3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GhJ3NZfAR+hL2gDBjLoeKSjE8nDhfKkL7k2fu4ZzkGY=; b=gF1A2Ba4W/rJvIbgGeIvDpvZZ24Fe2IBtm9kvBcJID1hC5kRp+sfCSETSxa24ftcg3ZEI3iWGkfnQYh99IREI3rAo2+RZhbk8saB2yu7MyVq4cV5+iaMbZ4Ge5S9oIpwoYE7CRbpKu/jnVDKu5q9vtU68/kSjUjPky9s9FEQziU= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by DS4PPF717557185.namprd10.prod.outlook.com (2603:10b6:f:fc00::d29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.40; Fri, 30 May 2025 10:21:41 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.8746.030; Fri, 30 May 2025 10:21:41 +0000 Date: Fri, 30 May 2025 11:21:33 +0100 From: Lorenzo Stoakes To: Pu Lehui Cc: mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, pulehui@huawei.com Subject: Re: [PATCH v1 2/4] mm: Expose abnormal new_pte during move_ptes Message-ID: References: <20250529155650.4017699-1-pulehui@huaweicloud.com> <20250529155650.4017699-3-pulehui@huaweicloud.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250529155650.4017699-3-pulehui@huaweicloud.com> X-ClientProxiedBy: JN3P275CA0037.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:ca::19) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|DS4PPF717557185:EE_ X-MS-Office365-Filtering-Correlation-Id: fac91eec-4278-44ac-e7e5-08dd9f63c4e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?JPxbKSpVAJRGGoxfk68sj853Z7if24Zuc+lLy70bG1fkLL5ecPCpYcLm0Ov8?= =?us-ascii?Q?VA/dY0xp5WxQ1HAUERdgcNXEevCr1uEjZSmeBYIrXbtqAIgLRWiYZxJ1csT0?= =?us-ascii?Q?fgfDubwXV4SYVb2i2SOETBhpHjj3aiGHX82BOJGnCIyQNX7enkm9JbJCJg0W?= =?us-ascii?Q?BTyM4s+EMoTBcJZ8E8k1q6Dv/IblnrM+7hqfKuRHsxAhMLsEVbogGHXTFnHu?= =?us-ascii?Q?M03FxTxIFjR/VWTZS5/B7p+0Wdc/+UzHOFBdvOxX0FkYuHzOoLZl9T5RhTTG?= =?us-ascii?Q?gwzsYdy9BIdTIPGKER3iV5IHjXkFzFJU+7N6lTX8rdCXrvbpgtdZOSe17VJb?= =?us-ascii?Q?YMBlLQbMxwv/cvWFeJjIR7IDQE1st9P7Ys/YdC4lrVOHOb82lRe1cUfASYN0?= =?us-ascii?Q?c6FSBFrIVCXRDGhOzCt7O5mqo7e7Mza/V6Cz0KZjmoPgB1A8PwKAf3eAcLhp?= =?us-ascii?Q?mnNbcFDo22PsepnusKe4RnehscPbCHzJewdhmc4bYRsnTHkiEWc9ieCciHsj?= =?us-ascii?Q?4WDPU/PXFc3fv70X7gAi3woL6qYjXz7WhCOGRDFWEei83TWwvedVe9JIi8sK?= =?us-ascii?Q?BO0wLmgo0rgMDCK2L1OFeZBr7Fy9eN0XL4Ol4dFeOqSCdtHv+qZ5/1sGxZLO?= =?us-ascii?Q?BseWIaBJ8uifLzqQsDk3Jj9w7St10ZVYYLYjR3bXL8JPVf97EYl9iKRl8xLp?= =?us-ascii?Q?ANbXhmR0wboXOPczmOtZXPmXXcMYuq5Te6KBzanw1UCIoUCKsQ8qDgIWPxRj?= =?us-ascii?Q?+8AOYQSDuXy1AchhgCoXLFXzu+XsTOigvjxwSlZwabLRt19YdjcflA3Uui1P?= =?us-ascii?Q?4OQytsRmgPWrWseAsqY8R7N1V/kZ2BoNnJm9tORPMhvo1GxSm2vBujzrddzy?= =?us-ascii?Q?buFtDqz5fwYPk59R5bQ1kN+bXI4FFWnwopijTXIMVQlv86L2KGlJFEIcVYos?= =?us-ascii?Q?9UG4HoJNv9l53PqRGzugqIZ4X7zzcuLVkM/XTPkgxHGnaGmG9We7qd6waHId?= =?us-ascii?Q?MXJ5/u/JhjqN0Fo6Q7tdSSvggA1Ys8BHDvkQCrrsXVB9/lUH0M1y+JaE8nFL?= =?us-ascii?Q?tef9rQ7GBc2KfYb/MzeLfapJA1yoNBAou37UtJ2N9066xEKObfuKdeozW+J2?= =?us-ascii?Q?Aea36Xtt+ymjv4cI7AOKR43KFw+Vb1+AnpTaPxjZfmaUpXUrfLs8HVSmaKFD?= =?us-ascii?Q?q377ZuTKQPUIcdmefSP7FWTQKYgDitAMiD+mOfhUPKOBnWI7I25/Ugk248Ai?= =?us-ascii?Q?UueMLIg1duq8TtMzSvQEpinRuF9xwMa4mTPn0I1uui50H6TigXphECkPPp1S?= =?us-ascii?Q?HkLN2pQGfjI4Tn1NSw907c+WZt8rMVxGfGhLHUgCaUW/Zop7dXkcyLefNqbq?= =?us-ascii?Q?3sWMS8Yyv+8qNmeqIrtDdPh+TBnc0LUaKbV6TBiLyHV1nqHwPQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u+QbFUJRwXmY7ioyCxFK55FlOGWy8qeTMPPBhworrZQwYdVVZqXaQbjx8XSL?= =?us-ascii?Q?8N2RrrPQmJ8x6HP1TJGdNIxpjf/Mbst3q34AOKiCNVPpCZpRDgMkG3byFp4z?= =?us-ascii?Q?gLUMSQx2OOfk92IfS4KBPXAtEhCI6UIm7dW/3mBI/OvYKrFp/JrS5W3351FF?= =?us-ascii?Q?EJq07Lt2oWbqIigHz2icx4bqbl5vVsYiVmM3ZKiH1shiqpCbupIwlBoIEQ2t?= =?us-ascii?Q?xdgMYhiMdNYxx26pTqkDpq2TnxoE/UcZLzo4gqIQZKh1N/RJw8ILr3zdirgO?= =?us-ascii?Q?ziUtRi6UN6h9P+GS+sYMcr3uNKs8ffx0v2QyTwbwT0Imh757CvipAj+gLwVZ?= =?us-ascii?Q?5DQxkLI9veBgRDtb+J2QHnjTHqFYqrdRQSFsDJCQQeG/sFHs5PqGI4Wo+C4m?= =?us-ascii?Q?02sIiduk7eHN6mSrgNsNIQgXmoCL/3cuH2iaXDJXOfoYdGkZMzlOSFCh7grp?= =?us-ascii?Q?ybSUK+iKm51Wr5GX0q8O9bK5PDvwJCm6BXNrIb/7iCAuF/xiYoLYxzaZLNzs?= =?us-ascii?Q?c+A78ic3p9FIvwcH481i1rWh5olMT+QGHCyXjvzQwTgcRYWglOwDJyjTfdNL?= =?us-ascii?Q?cPdMsQw8M5iK/3SKWvXf9vNkJv4bSHigP9gtqVZi4XquFVTPXTiPoO2Blv6o?= =?us-ascii?Q?YH8Zu1AIsu8HD3GCYyyiRzsHn4q95sZpDBaxja3TMVfxZ3hVV2E/YshU2nop?= =?us-ascii?Q?JsmdS6rGDPzkAa1oDqlAVbWIlSVoHVFlD8cIOVW7RbAvu0iGs6S6NX0ELvar?= =?us-ascii?Q?sGP7fhFf6wQbdnmCADcyeby/UpySZFlwMD3qFVgoEUNwcEDKWWI1u7MzSvE1?= =?us-ascii?Q?4298NlTioTYuQ4dbgfBpdGWhicyXmai4ApN+vh+ZQdeYKwBxyU3AGDPNGjBT?= =?us-ascii?Q?qQFAjUrkJJBiVuEVMbcVI6Gr2zfZ4d74BwV+65B3mATup458FBMFAaJ07/H3?= =?us-ascii?Q?hMDFGjJ/VC89y+TsbzreBbp287V9cY0W8MYxZ6aRPbYcjKikEr2BM8rSnjU2?= =?us-ascii?Q?ezmcyWFmMtrN1MDKQWmTbKgHIE8NebDQsJlMNUTYp+Zg7Oi2g18feUedh0Sd?= =?us-ascii?Q?ZPYK23rmtA3hflvgBbKaWYOLmh6DDMJ1FjRo8DzkRzLSZJ/SWs3erUvfKEVH?= =?us-ascii?Q?g0ZZc+4hM2sFGv1lxyMcGKFZYP1AZmlRmU7D96lcb+6o7GR6/RWjoHUWGyYx?= =?us-ascii?Q?Vpvb0gMfROTOmGs3GAAV30FYpNNKcPx9cqUlvJqFqswDO0IpTlEcadtUcuV7?= =?us-ascii?Q?SwFLsKTiDe+8S3RS28UcUFuiX7mw0LSd2VdOWG4eRjVKsqZdxkZqGAoHglxd?= =?us-ascii?Q?d4tohUh7o8ksYHxSG62j44sjQVQTKYUhpvT7mu80HPevjUf/DQlKQcAc4DLy?= =?us-ascii?Q?e6C/28ENtaePTMsq9eAog2npZ5z+xUs5Bu1T5MiVThWMVHIsHbAFOBpqJQy/?= =?us-ascii?Q?O93PrLitDFMwcec3Hgfm1rU3WwaMnVH8JiqjXII9/+UGPi8eHrKBemEI4Et9?= =?us-ascii?Q?SPwKC7XhQ/3sDjiyNgJqyT9ls9BPaK1wS2kQrO92lHR4Cxbg0AhIBFZDkcUG?= =?us-ascii?Q?zXQ9s+Qyyt7Utw4rhbcTp6/hfIiDMHegg0rBPHwEWbSoU9sKnDCvfdlz6VBP?= =?us-ascii?Q?UQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5Vn0KGF7OMumTAdVzmHbXZ6rxCqUi/R9CAEpBZ1iBpEagOjTqtUbdKRz1D25KOMpg9fBZGxMvodCqt/SmnwBt2GKXoEL/PnYMcyAFwlSrY2DossyyWSuCyu0lxrSFR/h6j6rO/QefP85ZjWjCjF7B/70QL9jMti7Xd14BD3AR7zocLUsooK4jzXypMyaB3w9Xdw0lDFtFB6W9ypey2RscWuLHnFJ9wQsg+/bHtNFxiqDdPqoc1SePHH3YqDEboWZa2c8KzDz3iRSMiOubLA5DN3K8OB6OsVfbNjQSgYBCkd9dzZMARF68B9dl6EV52Y2cNuxeM/pqxweJ1evFamd68ZwL5av1+Dq4LwtBzBlCy6JqlHIgxT48OFmeMtlZYfnvbHalRXhe16Tph7NwtBrZDY6KmACKUEpnZRHjdr4IAE8jIAwAV5rEiZenJzHIh4WTO1hjVAp9uhG0JOGJkeck6Rgtyu72idDHl1tVXUX5AJufcZeyHnmpPNngSP8do3qtWkrO9R0lbjsDaPffnhNJi6AEl3vCqpXOy94481WqePNLSksv/Sw3eHcBbIyFvlW54uqSUsVDnX+Jzdck8vf5/KaEgPL/OP4kGawMHovfeA= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: fac91eec-4278-44ac-e7e5-08dd9f63c4e3 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2025 10:21:41.1155 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HmicIsgwpCnQ8/oie/OEVyH/rA2OsYe3L7YdOg3m81NBHJCt2o8OuZOzu8hlMxOn4iB6jQyLLol5wDbUohTruuIGOB8DjI80e3iJq0QSorY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPF717557185 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-30_04,2025-05-29_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2505300089 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTMwMDA4OSBTYWx0ZWRfX6u080+2JoTke w4R8eLsUpdb21B5WC9g8Zub7XQT9qF8OFevlJsmPe0nYjATOAQa7z51UXwvUm8ie92Y7rpjksV3 mPQwC/SYvhSFSwieeERNhCJs9Z50o4U2H/O49+qxnzfOft8QZ3EfSCSjhCyGjvzEZ8xLf6Wp5BV vml0XBzT0Q5/3ymzK8aR+aDHDsAR7j9hcZBt1ZICC0IFnTJoTx3ZUfR7cIDd1xGcAlu3ETEqLl6 sR3431/p9J77HnN2li9AWUTXJhRGKA9KgqarXKAurqnFVhswsO6JfB36G0RBQDOTt4YdluyXwVP +pDlX14i01nO8utNB8iW3H42/NGwihFvtdPMLzJcORd8ORHuJjOKqyMKHFsRNmUK1Jvy1jV0n54 D+RJz3WkeSZ+zofCD8BZBF2y02EeI/6YygkB3PIuZAz0ett0klzKm/weNXNp+McolrvE9WsC X-Proofpoint-GUID: cah4SK2yg8xjoEQn2tvOVK_Ppz8u2JJx X-Authority-Analysis: v=2.4 cv=UvhjN/wB c=1 sm=1 tr=0 ts=683986ba b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=i0EeH86SAAAA:8 a=20KFwNOVAAAA:8 a=yPCof4ZbAAAA:8 a=pdG_qfMyCWuCLcrjtW4A:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:13206 X-Proofpoint-ORIG-GUID: cah4SK2yg8xjoEQn2tvOVK_Ppz8u2JJx X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6A368180002 X-Stat-Signature: oq7xifnsn4m6hsy3rysu8enazwtp484h X-Rspam-User: X-HE-Tag: 1748600526-982871 X-HE-Meta: U2FsdGVkX19wcYlF6b4woMVMb5DiTWWdN790KoOs1vu7AuO5ht3n1O7q3TYKZ4KFtX2UFDoXrJYuzVL9321wrqLWQ2bpJ6LckKpfdbxiNUDK8TW3KIOx+X5q8jefaDmfOzGpCvqdEAcoLWTiNG/TgmrJspd0com1hoyG7M1yiIT2ARO/YQHC1bzbyYt3dJuHZFWkCBCiYPJNISZQIGKyJ6g/lgf+8ctI/Osf+WAItEjN1aGAi0E6M20bdbj/Lioebnh3H3z51okVcmOf1fv2WMmqSzxuubGOxhFDa4s5HYREAnoZ9igS4Q7DHt4eWyLGCo0lRkHO4jHXWCmA+/+HrPVqIqr/KQJhjD3LNZg1U2IYZAJ+z1/0F7x7aWIdUP+Nt7OhhiUJjIFFTZxv27OIBKpse6oTgLru03ZiJHNxLoz2oX3e8US4YNdxvIaIr/VTdpkkPBBu9gC6d4dNFCRJ8OMZOCQDqXzMofD16fnVLRWNYFwE8+JoDZ5Rg+Hh1T31iYFZ+rSBw0lIpNJKvEplx5yPhekB1UnjIVEFLMeu5KSWjLYJ3VEXNjKXYv4CA0qNNFO3ucvUfMboVMiCsMbtAx2b2XqCfTl7XkmSmnEWUiKYESJwt1j2iwuHByXTCJJrYvN8kF5448EpSjdJJqBP00wFYGOGlVATo9PlZVPp6AT2CG3j6Che3pulIz/lB21HjZfMZBGZCSU4Ij7khK/eEukG5+dWHzXGdq1Q+uAowTYm4FcObrCtBEiUVnLmU550YifJ2DKI4ARwD/acvDC+SkUCU/eXtIthTN7FXfXAy0CujbKUCE0oc3TogtV57D07RpQCCFb/b1Fd27SyA1TH0rwK4e8c0t4DCWGCK5jqb6QDaDVMAg/OqLjQAxEq4z/+pIkx72q6Cd1UdrGy04zwVOHB5lT/iaXcOgF8M3b8Z77+vZGIaok4pFxVnTMuqpm9ZBvhyzpG7DBOrmPcqh3 REX8p3WP hVzX4qSOaZD1R55ZwwwbD+zkGeJvxdkh7rITnai8O6J7bNmUPQ4Gj7WUlda43ibmDAdY+Sk8UoF2kyRoNCf5vfsppGWKsH/4TGIiLs1HuRtXmzhXYPS7IvBOtz0umOo1h616i8ObPPAX17upfHbFCemZO7WxjVhbh5jtltxt2LqaM4GbdFxa4kXJ5XptF8LRds4Ehz6ABNe4X7QS9ZC2rJrdME0JmS8DAdIs1qX7YyEC9C7rclp1LCyoJlIFVwJxWkfh6m36v50/16gVuig0GwAOExm1O15HGjUmyXDl9dYFqVxnVLf4kPXwa9YJs+Vw8fAw1DSMPaH63BOxGJMDFXwFu156YGSp4uoH2IZHC2XH7w2NhC6sU/4hRbwIlC7fHE16wDyTryEjdXNXCS2FlpxD+fuSmWB1/lO2BtmXZRKLyRk66bmD2zWO5PQ4GidrqlhW27oTKL8kgDeKHOwaKL6W96sKtFjvaqjHB6bb71PnwQW0cPTpZE3k4PSFab2qxYwOzqF6pHMa4+ENyyc0yirPd5SDqFUkQD05XCyMj22J+VsF0U291Sr24j1e4hIs45XpHjpz/aAtMmugIFAVOLAHwBd+lISeokB/OpXWsH/17eWZSFiNp4uCyxEPBMYsL1YRYlgUCNVYaj4EJELfQru2UAstl/8UfZpQYcGE57ttCq5jmaLhbKAi+1WGGEfuUyCI7kFKKWgDTnlJmSP7pG3lxLRcfmoxL75P5D4C8egHrteEs4C7oYz5bgvXygm5sOticFehPSAnVRvDKtKd8KRP/aqJmAVWYy1pKxDJ1rmKRh1Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 29, 2025 at 03:56:48PM +0000, Pu Lehui wrote: > From: Pu Lehui > > When executing move_ptes, the new_pte must be NULL, otherwise it will be > overwritten by the old_pte, and cause the abnormal new_pte to be leaked. > In order to make this problem to be more explicit, let's add > WARN_ON_ONCE when new_pte is not NULL. > > Suggested-by: Oleg Nesterov > Signed-off-by: Pu Lehui Reviewed-by: Lorenzo Stoakes (both this and the amended version :) > --- > mm/mremap.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/mremap.c b/mm/mremap.c > index 83e359754961..4e2491f8c2ce 100644 > --- a/mm/mremap.c > +++ b/mm/mremap.c > @@ -237,6 +237,8 @@ static int move_ptes(struct pagetable_move_control *pmc, > > for (; old_addr < old_end; old_pte++, old_addr += PAGE_SIZE, > new_pte++, new_addr += PAGE_SIZE) { > + WARN_ON_ONCE(!pte_none(*new_pte)); > + I mean, we really really should not ever be seeing a mapped PTE here, so I think a WARN_ON_ONCE() is fine. We unmap anything ahead of time, and only I think this uprobe breakpoint installation would ever cause this to be the case. We can make this a VM_WARN_ON_ONCE() too I suppose, just in case there's something we're not thinking of, but I'd say at some point we'd want to change it to a WARN_ON_ONCE(). > if (pte_none(ptep_get(old_pte))) > continue; > > -- > 2.34.1 >