From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB9CFE77188 for ; Fri, 20 Dec 2024 08:50:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 230E06B007B; Fri, 20 Dec 2024 03:50:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E19F6B0083; Fri, 20 Dec 2024 03:50:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05B026B0085; Fri, 20 Dec 2024 03:50:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DB30C6B007B for ; Fri, 20 Dec 2024 03:50:32 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8F0E2440DA for ; Fri, 20 Dec 2024 08:50:32 +0000 (UTC) X-FDA: 82914714708.19.E725A4A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 7208E40002 for ; Fri, 20 Dec 2024 08:49:52 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qe02ZHGo; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734684607; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JKhUHWqUNHLRx+cJMKcF6KM/pZO48THXr0FUtSNdE0Q=; b=XXjf1F1Zr9rJMxN+5Dun0AMKl+Cc/vN+tgcPSvlHfImTsaCJALZL9UmWOjRdd/8RQHHRZp CofsubZzrvYs3WcOU3KVCNmxztsB38Jrz0iYnT+H1dm2Kjf4l8zP9ATIRyfM50qfQHio9m Nqn+07ZOdJJyLRdDtt7arN08N8FX6rQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734684607; a=rsa-sha256; cv=none; b=kPbl2NFi5qrqtGF7Z1U2d8uxLMGgMrHBp8d4m6VIpekIpCs+QbWG9ZsZm+1KgPw3PVEMhE 0tcAJnkQrNQc4Ihf6LtTGB5GLL8vMdCrV9INd4F6H+uYW8J+ubVWF3BQA83FTGhYjWaBa8 0k3oSGMCUx0iSm1vb1GpXGTp19KfYYM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qe02ZHGo; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734684629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JKhUHWqUNHLRx+cJMKcF6KM/pZO48THXr0FUtSNdE0Q=; b=Qe02ZHGoGtvKlfanvHW7Y2PJYwADCNvpdM/Bo7hC3l+tc6a+rFLBacG9n8LfVsgrKqcagH +PAm7ypyRBKQ72NK1xdUhutZ9cI9kaWqPA7D27o+lVXBuxPCgfUsOBAoMffTWPvMTjctNi EJdCD62KggH10u6FY5uQUCk/uCdhzKI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-6-8J55G6cYOESlGhez5lJUVA-1; Fri, 20 Dec 2024 03:50:27 -0500 X-MC-Unique: 8J55G6cYOESlGhez5lJUVA-1 X-Mimecast-MFC-AGG-ID: 8J55G6cYOESlGhez5lJUVA Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43625ceae52so9623305e9.0 for ; Fri, 20 Dec 2024 00:50:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734684626; x=1735289426; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JKhUHWqUNHLRx+cJMKcF6KM/pZO48THXr0FUtSNdE0Q=; b=OkNfpS3snDAGKlO4QrQgzmjsCik3bJ1M29cgLDGDLieVPYPvzFpjbNDWEckCn0Kv0p Z8RuFGlrbUWA33HpLlx1GrUlLsKCMnji5Az8EGIaHVmRmRCH4YLMi4+dOHBzjEzREjGM NaE2RFEaRAYZ3ln9Hn/UFJ+6CTVgO+fSd5UeggsqcNPv6PQidpUiibU0KwqzdupFMpxi oFLV1E9vX43LZGbsAt4oMR3eiHBioQGx8Q22jUysJxAAFh/3LkD1vIrgBIclz8LwXK2Q PlpY7By8eP0jIH5OEHaW9PtxRQH+caQotz4K/gXDGJGnHsZrGlJ6tR0UuucH4Wdb0+Wr oTmQ== X-Forwarded-Encrypted: i=1; AJvYcCWu54BYRLDdML+Qlmrru7EOzmQrss3xpBwLvlty5wjUYbPFz8DN5h0n9G361y0+qCYfmwgcNWQE7g==@kvack.org X-Gm-Message-State: AOJu0Yz8WjTIZdS8PibmmA0770qGGhxsY19SjhVKv9iHIfNZ7JS5KXaw c5yTXmIGy06W9N1x6HRQVy94UF0U881T2S67RA6+cTn6Xe1UXGVVC5Y8Ep5CYLhto3lRmfe+qbo qUBd1tzIFxEIyTK/WwFbxGYrKkdmYYJJwcU1El6Ud7Dd/nUXn X-Gm-Gg: ASbGncvg5a0K02NVGLJO9uvFrLnRYe3cp7GyKRnEYt5sDyqkAZGdFsZa6m11KdlroM2 0tyJqe05tS33baCGvayJS1fYadDgEFWav4vl9YIlzfB2KLSJH5DxyVhOVylL7+9lhVf3w9kPFky Tup+hDlKXOiVPkURsm7I3SIqLIlEEasLtibNQIOieDTrUznnUbAXep+u2u51Uhx74sAWjbWMhDY +spGLIdSYxPL4dgBPhqRXA4Rf04o8GoW7JGX4tXqslDpQI+US99Jfte2KriT25P7zk2dzedniUW c7/iV9E3w75Xrl68JrMBdsLnrpqzZpxOGoQsykH4lWgTesldchBdVF9y75FHPzGrrFY+ujSaYhM VNhVN2U4J X-Received: by 2002:a05:6000:480b:b0:385:fb34:d585 with SMTP id ffacd0b85a97d-38a221fa418mr1838291f8f.34.1734684626534; Fri, 20 Dec 2024 00:50:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IF7PUfQoiNIKilZ6i70jdvtdAohbjLrGVCGD4c+X1ywG/20Ncw/oq6m3ah2C6vTHYKt/YoZ6w== X-Received: by 2002:a05:6000:480b:b0:385:fb34:d585 with SMTP id ffacd0b85a97d-38a221fa418mr1838259f8f.34.1734684626110; Fri, 20 Dec 2024 00:50:26 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c847d7fsm3499780f8f.60.2024.12.20.00.50.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 00:50:25 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 09:50:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/memory-failure: fix VM_BUG_ON_PAGE(PagePoisoned(page)) when unpoison memory To: Miaohe Lin , akpm@linux-foundation.org, Dan Williams Cc: nao.horiguchi@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241219115209.574065-1-linmiaohe@huawei.com> <06a45f8a-0981-40a2-a12a-5964fcdace13@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WYhetMIIvLpArc0wKZnH4O981JlFOftxtURAVIJ2iCw_1734684627 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7208E40002 X-Stat-Signature: 9q9zokudsntetr39qo854u895a1qjr6f X-Rspam-User: X-HE-Tag: 1734684592-287085 X-HE-Meta: U2FsdGVkX18vLwn4PwhJMRBt2qsPXN+YE/7HEMXEnxlwFZusr8E9xFpTInjRomSyjS7GhtDcKiPRSFXgPs0hgp6bovwofyXOJfgkGiN5KrLZUQJXNTKp+femsDXJ+IhkYULmsJkcyL32/6cjf9Uq0N4Mxj4w/uMYX569dbkSekDmQSOM0AsS8rnOBRYz27kGtNXu5YUaBknOKTENtxUKNEg9V9L5odn6C6HQ5lNef7lwk81ijOO75UAWK+y9aJnmkz1nq/y+6atpNvoBVyRqxDOpEgW3NKIbcPKWpJ2B4qxpL3pBKrbNp5hN3p2fmFDjWbGrkAUKttJzkLB+VMs2rt9pAheCqCDlgZ41KOkT+ciHz6CJ9NflGmlIWQsktHfCYQW7n2gYCFEZMi3T0hMTKmEgQLgOfuoWiT8f7kRPObeGp0dgKrUTV+EGa8HqboT/wbCX/e4j6SvR2NBfikDZlLSSqt/XwN7AFlmrRUhZL/gvqAsfEbykup506czc3/XGtcv8ha2v7TSJEanCZXMbnzIpteDkMGc5LYq+GIbQBXuM4jsIHuqJay5cESDqAKvybF+YotTNHmVa8J5m3uHhxp+7Ob5fWHjQwUK31oQd/f34aUQJakD8U4N9ANdq/1fQJumS92kgvTm5ByPKuTLqZVgPlAh4zT9hZA4zg1ovbw/LOpLbJu2aprprYLmiQiPjVOmksmxNIAyfSuQLWmmo7PM9hOZ/PcsQ1riBq3iLHKMXXfzsEpEspsbyjcBlN+yE3hFqP/2bROqW3KY3aqHryjXdui2Kt107Ko5hvSqclWeqT+yoVQZlQOvnqWpWgP6jN7T2KXkzmlft7f9bQ3q4OYkZ4wb0PYh36PL00AwKKnl+MAv1ivLIpnBG/MzRzOJK2k5aeyxY3NFFbJd/YjHI7VQ8iwS5Q6t9w9Z4CmFVmOSRadEvuJ//SI4dZFyG1tUjj3703O9j/CTS5WNv+Gf +uO4eSe6 aRKvDzZwt46nr5p1FMtHn8x09fEeQRRQpWBvW0lgcJVRQ5+nRsEKfHzgQOHk+d1G8x7ALZeDRD3Qleac7Am+SDV2DYiAsQNQLnKPlVq8JNcfrRY4KKwfnytj9N959l6k/hHygjurW+ijzG147SQvet1QuulX6NHwGE7FX8+tLrn7uF+RZ/08w2r36tMbOvf1u15ynpskMV3bg6AfNQZg7hB1IHzLp3EKWTCBDwIPPfkySVo613Grp82scTCZKLpcdT2cKEzDUiVdtaPTLa1YMWccvTBEhsdtfdUGyg4AqhyKxDGiSJnRBF3WXW+AfLb/aWGHOR/rYtM87xPlzW8D4UXIUveTQN5zsbcqfQqLnGC6zpawMOufTuZV8Mlr1c6cRfPpJU0BWYaVJ9LPHvyvxkflbF4kxLX2CF0KK/XgVUnmtL0C8HcF5zL//4HVt1M3Px0wxNhLSZUQg61Q5XIbG7WdlG0DGrdehp8pGXcBfhwjmG8goGVsDGQpypffw63dLyO2PcHmFpV0l495Jl3UOP7ebCnrXoGnW6XtRfZwEu4CBOlBRFJjnbU0qAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.12.24 03:35, Miaohe Lin wrote: > On 2024/12/19 20:18, David Hildenbrand wrote: >> On 19.12.24 12:52, Miaohe Lin wrote: >>> When I did memory failure tests recently, below panic occurs: >>> >>> page dumped because: VM_BUG_ON_PAGE(PagePoisoned(page)) >>> kernel BUG at include/linux/page-flags.h:616! >>> Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI >>> CPU: 3 PID: 720 Comm: bash Not tainted 6.10.0-rc1-00195-g148743902568 #40 >>> RIP: 0010:unpoison_memory+0x2f3/0x590 >>> RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 >>> RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 >>> RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 >>> RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb >>> R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 >>> R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe >>> FS:  00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 >>> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>> CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 >>> Call Trace: >>>   >>>   unpoison_memory+0x2f3/0x590 >>>   simple_attr_write_xsigned.constprop.0.isra.0+0xb3/0x110 >>>   debugfs_attr_write+0x42/0x60 >>>   full_proxy_write+0x5b/0x80 >>>   vfs_write+0xd5/0x540 >>>   ksys_write+0x64/0xe0 >>>   do_syscall_64+0xb9/0x1d0 >>>   entry_SYSCALL_64_after_hwframe+0x77/0x7f >>> RIP: 0033:0x7f08f0314887 >>> RSP: 002b:00007ffece710078 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 >>> RAX: ffffffffffffffda RBX: 0000000000000009 RCX: 00007f08f0314887 >>> RDX: 0000000000000009 RSI: 0000564787a30410 RDI: 0000000000000001 >>> RBP: 0000564787a30410 R08: 000000000000fefe R09: 000000007fffffff >>> R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000009 >>> R13: 00007f08f041b780 R14: 00007f08f0417600 R15: 00007f08f0416a00 >>>   >>> Modules linked in: hwpoison_inject >>> ---[ end trace 0000000000000000 ]--- >>> RIP: 0010:unpoison_memory+0x2f3/0x590 >>> RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 >>> RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 >>> RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 >>> RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb >>> R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 >>> R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe >>> FS:  00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 >>> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>> CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 >>> Kernel panic - not syncing: Fatal exception >>> Kernel Offset: 0x31c00000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) >>> ---[ end Kernel panic - not syncing: Fatal exception ]--- >>> >>> The root cause is that unpoison_memory() tries to check the PG_HWPoison >>> flags of an uninitialized page. So VM_BUG_ON_PAGE(PagePoisoned(page)) is >>> triggered. This can be reproduced by below steps: >>> 1.Offline memory block: >>>   echo offline > /sys/devices/system/memory/memory12/state >>> 2.Get offlined memory pfn: >>>   page-types -b n -rlN >>> 3.Write pfn to unpoison-pfn >>>   echo > /sys/kernel/debug/hwpoison/unpoison-pfn >>> >>> Signed-off-by: Miaohe Lin >>> --- >>> v2: Use pfn_to_online_page per David. Thanks. >>> --- >>>   mm/memory-failure.c | 14 +++++++++++--- >>>   1 file changed, 11 insertions(+), 3 deletions(-) >>> >>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >>> index a7b8ccd29b6f..02be0596ce67 100644 >>> --- a/mm/memory-failure.c >>> +++ b/mm/memory-failure.c >>> @@ -2556,10 +2556,18 @@ int unpoison_memory(unsigned long pfn) >>>       static DEFINE_RATELIMIT_STATE(unpoison_rs, DEFAULT_RATELIMIT_INTERVAL, >>>                       DEFAULT_RATELIMIT_BURST); >>>   -    if (!pfn_valid(pfn)) >>> -        return -ENXIO; >>> +    p = pfn_to_online_page(pfn); >>> +    if (!p) { >>> +        struct dev_pagemap *pgmap; >>>   -    p = pfn_to_page(pfn); >>> +        if (!pfn_valid(pfn)) >>> +            return -ENXIO; >>> +        pgmap = get_dev_pagemap(pfn, NULL); >>> +        if (!pgmap) >>> +            return -ENXIO; >>> +        put_dev_pagemap(pgmap); >>> +        p = pfn_to_page(pfn); >>> +    } >> >> Hm, I wonder if we can do anything reasonable with ZONE_DEVICE pages here? > > All I can see in unpoison_memory() is folio_test_clear_hwpoison() for ZONE_DEVICE pages. IIRC, it can only be triggered via debugfs in special kernel configs. So chances are this was never ever actually run against a ZONE_DEVICE page. > >> >> CCing Dan, maybe he knows if this interface used to do something reasonable with ZONE_DEVICE pages. >> >> Also, I'm not sure about using the page after doing the put_dev_pagemap(). Likely we would have to do that at the before exiting from this function. > > IMHO, the page can be used after doing put_dev_pagemap(). The page should still be > available while it has HWPoison set. 1) Why do you think it can be used afterwards? :) 2) At that point in time you don't even know yet if the page is HWPoisoned! That check is performed later 3) From GUP code, I recall that we must keep the pagemap referenced until we grabbed a page/folio reference. Or are you worrying about memory offline? That > might not be the scope of this problem. But I might be miss something. I suspect unpoison_memory() doesn't do with ZONE_DEVICE pages what it should be doing. Maybe I'm wrong, it would be great to get feedback from Dan. -- Cheers, David / dhildenb