From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FDFBC3404D for ; Tue, 18 Feb 2020 21:33:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E2442173E for ; Tue, 18 Feb 2020 21:33:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="f5Iuo6bl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E2442173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC6D86B0005; Tue, 18 Feb 2020 16:33:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D77186B0006; Tue, 18 Feb 2020 16:33:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB38F6B0007; Tue, 18 Feb 2020 16:33:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id B2C876B0005 for ; Tue, 18 Feb 2020 16:33:22 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 838B42DFD for ; Tue, 18 Feb 2020 21:33:22 +0000 (UTC) X-FDA: 76504549044.02.chair35_579359923d00e X-HE-Tag: chair35_579359923d00e X-Filterd-Recvd-Size: 4383 Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Feb 2020 21:33:21 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 18 Feb 2020 13:32:09 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 18 Feb 2020 13:33:20 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 18 Feb 2020 13:33:20 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 18 Feb 2020 21:33:19 +0000 Subject: Re: [PATCH v6 02/19] mm: Ignore return value of ->readpages To: Matthew Wilcox , CC: , , , , , , , , , Christoph Hellwig References: <20200217184613.19668-1-willy@infradead.org> <20200217184613.19668-3-willy@infradead.org> From: John Hubbard X-Nvconfidentiality: public Message-ID: Date: Tue, 18 Feb 2020 13:33:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200217184613.19668-3-willy@infradead.org> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1582061529; bh=RXve5/fUA3oBILhUm8o+y+17c7pBmRijpBQPJAnmP80=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=f5Iuo6blIXbcDZrM05UIgCY8ANT5xW9HB6FXMMGQCfaHMfBnR1DfaWLTMAYIE7XBP B9QOW8wSO4ij5j+4bCfhLlUR2LpeSTGJV0y8tnLGhP+d4at2LBMPXmcd1007q6GV+V F6nXmc1d8pgAlmrCaaR8bklkj+n7DiCZH8Mj9XZsOl6SUYvt06XEAlqdCtbjrJAqsO JEKRbCwBCkx6iNbCJyyfXN8/DDeOTx/qKgkY7yedkT+Pn0V+QFJNvk6ybzosDhS50D pgn5lvAGlEV280+lBsRM1YfSDahNeoARNWUSdQ6PSTGWm5OdOjiCPRr9K7h5I26KXq jvW6k1ji+T2MA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/17/20 10:45 AM, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > We used to assign the return value to a variable, which we then ignored. > Remove the pretence of caring. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > --- > mm/readahead.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) Looks good, Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA > > diff --git a/mm/readahead.c b/mm/readahead.c > index 8ce46d69e6ae..12d13b7792da 100644 > --- a/mm/readahead.c > +++ b/mm/readahead.c > @@ -113,17 +113,16 @@ int read_cache_pages(struct address_space *mapping, struct list_head *pages, > > EXPORT_SYMBOL(read_cache_pages); > > -static int read_pages(struct address_space *mapping, struct file *filp, > +static void read_pages(struct address_space *mapping, struct file *filp, > struct list_head *pages, unsigned int nr_pages, gfp_t gfp) > { > struct blk_plug plug; > unsigned page_idx; > - int ret; > > blk_start_plug(&plug); > > if (mapping->a_ops->readpages) { > - ret = mapping->a_ops->readpages(filp, mapping, pages, nr_pages); > + mapping->a_ops->readpages(filp, mapping, pages, nr_pages); > /* Clean up the remaining pages */ > put_pages_list(pages); > goto out; > @@ -136,12 +135,9 @@ static int read_pages(struct address_space *mapping, struct file *filp, > mapping->a_ops->readpage(filp, page); > put_page(page); > } > - ret = 0; > > out: > blk_finish_plug(&plug); > - > - return ret; > } > > /* >