From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE5B3C47DD9 for ; Sun, 25 Feb 2024 04:51:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E7D86B00EA; Sat, 24 Feb 2024 23:51:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 198976B00EB; Sat, 24 Feb 2024 23:51:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05F636B00EC; Sat, 24 Feb 2024 23:51:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E64D86B00EA for ; Sat, 24 Feb 2024 23:51:00 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 918541C03CE for ; Sun, 25 Feb 2024 04:51:00 +0000 (UTC) X-FDA: 81829101480.12.0B811E6 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) by imf05.hostedemail.com (Postfix) with ESMTP id 979D8100002 for ; Sun, 25 Feb 2024 04:50:57 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tZdU18OU; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708836658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C06gSC6P/Rwm/k9Z3WJ2+aHSbmkMvV5GJOz0ep+CZ0U=; b=YI1QMdr5Varhtda4P74Zbf2OzXFI0blY2oaF5gWe0pbERgtTU+qcsZPGAQ5mtDwGeUED86 fOw/+hpCDHvkCQpQuDdYYhdlPQCTDAZWMZf9zw5d2UZ34SucCgmzfXLaCAhzXtN0vDuF9x teBbEAfzJgg4USG7UNZ4km6vBylU6S0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tZdU18OU; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708836658; a=rsa-sha256; cv=none; b=Or0kHgcgm/FDRCu0wtFi+TajbTR4W/P36tn45Od4QI4midTohZ0B8a6yBVp9tnB8j3Y/pb tOjgs/yvUUXSHV9QLp4d6NhdDxCtJfCM+HD9WqRiF+6RA53+0pqhsjVexCUUjFTvxpsEoC Ql96UUrBXIEQrDOtzSghW8keBFCunkM= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708836655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C06gSC6P/Rwm/k9Z3WJ2+aHSbmkMvV5GJOz0ep+CZ0U=; b=tZdU18OUvJpqWrrtwP23W9ROblmTtoli30JqKc7d/W86K18fgROGZg2F2W33mUe9hhWho7 e1yqQSFVeRa1AWuo3e+nhc+HMnx4rqZa8H2gp39PsVngGVmEwcnBSsN+KupC3NrokvH+Vu wPif1tGqwZcQ7k6rOrMZNAv3myN+y4Q= Date: Sun, 25 Feb 2024 12:50:18 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] xfs: remove SLAB_MEM_SPREAD flag usage To: "Darrick J. Wong" Cc: chandan.babu@oracle.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com, Chengming Zhou References: <20240224135323.830509-1-chengming.zhou@linux.dev> <20240224170306.GI616564@frogsfrogsfrogs> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240224170306.GI616564@frogsfrogsfrogs> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 979D8100002 X-Stat-Signature: 7ftrbhaz8phesg3a6d1g14s1kzow47fk X-Rspam-User: X-HE-Tag: 1708836657-591911 X-HE-Meta: U2FsdGVkX184zGCNQN283KhgjSDNjKFYD5lpuVJwm72u7NTv/YYfAb5DWtQskn0XcAhlFRRpIpILRLa1ENavaeC+y9nPxB0dQdGquJW3VU+gpRzPtLPFsZvqycK0i3d97jeGQQW988tCmQCLzagfP613QWe/5Pu88YLGPl0CUzmDKrkIo0KZj4Fuz/fiBl5p76hIF0p91whsQXNNJnNd28EoBRl+3LvBiukz0/ItYruX/Yw6wKfJ9Z2Ws2dyBp7MlFR1jY3XPOfgK35aUgsi7awLNiqtUMp/0pWf2rDgwP02BsGmmxxYcqH9hM3inxS6aje5RqdXA4Hjn8KQa+xCVcYv+jhypfWtSn0wDmJS9PzgoSRzp31KqlmziurUEoIOoJJF0MlvNGCqmx7XSBwTlqHgdF4QP5Ht7R+e66PtLe2MC0cyJMul1dMx/haIKfyfQiPmP/aYgnDIuaIuBFoYrfh+P7b46a+dxhSSrTjFufdT5AC5uatLMrbxiAKFJ3uyrFgsgizMBVPQu907OMerpEDfpPbp4ok9aAw92QdnEALEJlPIwsb4r4nDNT2ZDd8qatobn7GCnBm7qjAojBCVlYsWY7TGmyN76X3e7PO9mmfmWwloYimTtQ2g8fOS7HK5vSIQQlKqkS7uNltjF2Ykqee7QZjtI2CTVf4uzEBRna6UBGMQmUUjKwXlJgF8570LYQT2mxF2KxJKtOkBvs3lppQ3COkL/rwBq1JmdIMRck4WI799QDyaJg8YDc9yq826ipw/826Q6W95CXShHisw8YbRcAgza9NovDvsxGZtnlr4EHoSeA46iBFoMLPMulWcTNjc02fgLNhkvs4sARhSDp0qnJoapT7i9Bv58WEIMNDm5N9ajvA9hPLbjKAXAg12EWUeu816VZU+LkOheT81RnVSWGl1v98A5iTFqSkKpEBJKllx+FU/z0BZo0/VBPtg3mshj4I5cV5QZMpixGL iNA9R2X0 ZSU5BrblkJhRq3SwflzoCW+w8G+dx3djM/z92PXBMBHSVguQNDyVU0sbns2dyxidmYrAiQoAE38PjOXVqkKjiLp1z0Kl2LPBoDowRNov7f6BCx/PsdP4yvGDioQr2Fo3e7Gyl48Jb1gMG919EEPAWotZWBLRBST+wY0rxlnmgw8e2M1d7Gd9uF9sQgLIt2ZZnKau08vQaS14rjV0GvjMEwq6Mt4S7ROrS0ZFn4iS83Lbxb0aL2kPUVpfTUqNvo9dCHoBI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/25 01:03, Darrick J. Wong wrote: > On Sat, Feb 24, 2024 at 01:53:23PM +0000, chengming.zhou@linux.dev wrote: >> From: Chengming Zhou >> >> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove >> its usage so we can delete it from slab. No functional change. >> >> Signed-off-by: Chengming Zhou > > Acked-by: Darrick J. Wong > > (acked, as in "this looks right, i don't know why it wasn't removed when > slab went away, and from the -mm list traffic this seems to be in line > with [1] but i still had to dig for details) Right, I think it was just forgotten when slab went away. Then Steven reported this when he found it obsolete. As discussed in [1], we submit these patches independently to remove its usages. [1] https://lore.kernel.org/all/20240220-slab-cleanup-flags-v1-0-e657e373944a@suse.cz/ Thanks! > > [1] https://lore.kernel.org/linux-mm/20240131172027.10f64405@gandalf.local.home/T/#u > > --D > >> --- >> fs/xfs/xfs_super.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c >> index 56006b877a5d..171a1287b296 100644 >> --- a/fs/xfs/xfs_super.c >> +++ b/fs/xfs/xfs_super.c >> @@ -2042,8 +2042,7 @@ xfs_init_caches(void) >> >> xfs_buf_cache = kmem_cache_create("xfs_buf", sizeof(struct xfs_buf), 0, >> SLAB_HWCACHE_ALIGN | >> - SLAB_RECLAIM_ACCOUNT | >> - SLAB_MEM_SPREAD, >> + SLAB_RECLAIM_ACCOUNT, >> NULL); >> if (!xfs_buf_cache) >> goto out; >> @@ -2108,14 +2107,14 @@ xfs_init_caches(void) >> sizeof(struct xfs_inode), 0, >> (SLAB_HWCACHE_ALIGN | >> SLAB_RECLAIM_ACCOUNT | >> - SLAB_MEM_SPREAD | SLAB_ACCOUNT), >> + SLAB_ACCOUNT), >> xfs_fs_inode_init_once); >> if (!xfs_inode_cache) >> goto out_destroy_efi_cache; >> >> xfs_ili_cache = kmem_cache_create("xfs_ili", >> sizeof(struct xfs_inode_log_item), 0, >> - SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD, >> + SLAB_RECLAIM_ACCOUNT, >> NULL); >> if (!xfs_ili_cache) >> goto out_destroy_inode_cache; >> -- >> 2.40.1 >> >>