From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 519B4C25B7C for ; Mon, 27 May 2024 07:46:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA6886B0089; Mon, 27 May 2024 03:46:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2E966B008A; Mon, 27 May 2024 03:46:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8B2A6B008C; Mon, 27 May 2024 03:46:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8612E6B0089 for ; Mon, 27 May 2024 03:46:14 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F0967141448 for ; Mon, 27 May 2024 07:46:13 +0000 (UTC) X-FDA: 82163392626.29.FDE026B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id F11A340002 for ; Mon, 27 May 2024 07:46:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D4th8tOY; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716795972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bJZhvxGXUT9T0zhT9Bm8NpxZXQt5bsEOd5lUm7XYqDs=; b=rz6rgDzvCF4whOBg5wMvjDIP8hEraPxuvbtt6TrbW281XMhINCdv1iu4BzETf2GQGZW74j UF9sWwcB8sWtFAcyg1olxGxdtETzclwzFE8PtBJ+u3oDsYWqkfWxOrxkyn9ZtcAs3vJntO s7Jiy9FiDxJtkdC38XeboDV7OXbNvI8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716795972; a=rsa-sha256; cv=none; b=AwqqAgxaNeoIaBKF3YkArPub/xh0Q0c8LShUxa1pD9Oroxhc6TkufiHg36lYc6YpdU93YZ liRgXNk/+zJlNiiMCqkmfgTolxyMHs+9AD3KXozx06Meqa/Zy8eH0BGJvFBdogXRyk3u4n E6CBPwkaG56XGTVc9BlIiBgsx1CQgVk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D4th8tOY; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716795971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bJZhvxGXUT9T0zhT9Bm8NpxZXQt5bsEOd5lUm7XYqDs=; b=D4th8tOYxca4POK44wJzovxBFg0+1PjtrAIYUoL2cS1mlBbQ9AGcrTAec8J5XOxq3Xn4Yu Ry7ktMlZSKXRe0Yf76FevJir0XLGuyx2AlD0laWbPUEBFjtsoJG4KXXcCwQjGFUtCHibtw 7UXjc9vl5lsQ683aTNy4D7o/qKp2MPg= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-546-js69-xy4O3ay3UVXlO46-w-1; Mon, 27 May 2024 03:46:09 -0400 X-MC-Unique: js69-xy4O3ay3UVXlO46-w-1 Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-3d1badeb4c8so1158910b6e.0 for ; Mon, 27 May 2024 00:46:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716795969; x=1717400769; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bJZhvxGXUT9T0zhT9Bm8NpxZXQt5bsEOd5lUm7XYqDs=; b=YU1NnTQ2rHiZbD5T2iW6YZ57EBzHDd3lZe7EQWaFPACG8VSbrC8BNSOMJiugCmKgZC Y5QTfk5tzWZ9vBZPb3mINpaowN42NxnZYpfTKx6C7EXcNTw7qFnuieFLXcqjGTrJa8da E8W+m+QvzQAoSv+JKMFcLbqRZjGsWT/gRG2YKQ0TTUHMNvolq7tOmMAWrWXC/od+8Sdu 5OZyDstmusOaJ11Kel99cnkrYLheENtSIqGUER1DAGciypziCwriLf0pdgnhD/A6L1Fa ER2LvrJjUAFcdcpEA7R1mekhlWVlQkw8AF6UIlv3SPOqkhaidAJRF/xZcYV7S3ve4Ue8 FYfA== X-Forwarded-Encrypted: i=1; AJvYcCVFdJVd+Cxnd/vMeWMmKH2cpbrHnrn6Eoq8D3AQn9izuQy15apixwsjER1TIIZOoklNN2ye4mOv/MQHyOTjt86tq8g= X-Gm-Message-State: AOJu0YyGY1+NTJ31JAFicDpZd+pyPPc8cKfcpYK04ABtOjYGq7OnRBmd TI7Z1Z6ciclP0QGouXLdmF5MbTp16R9mfceS4lwhUuuQOOVFCLZGI5vcg2IH1nli2WFAslgxXJ1 Fx1jCHeqfQG0jMbRgEO5nD/vhZ/nLOW1+gsfSFCz/UFOY9IIN X-Received: by 2002:a54:4406:0:b0:3c9:92e9:4d4a with SMTP id 5614622812f47-3d1a5670ecdmr9892242b6e.20.1716795969054; Mon, 27 May 2024 00:46:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAbbXjX6ChuOgo2M0rqauoFiJgYUcJvR4iwaf+zhT1Fnpb371QdsrqEKkfGi471XXPew2QNw== X-Received: by 2002:a54:4406:0:b0:3c9:92e9:4d4a with SMTP id 5614622812f47-3d1a5670ecdmr9892221b6e.20.1716795968327; Mon, 27 May 2024 00:46:08 -0700 (PDT) Received: from ?IPV6:2003:d8:2f28:4600:d3a7:6c26:54cf:e01e? (p200300d82f284600d3a76c2654cfe01e.dip0.t-ipconnect.de. [2003:d8:2f28:4600:d3a7:6c26:54cf:e01e]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-43fb5db77f7sm27019831cf.78.2024.05.27.00.46.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 May 2024 00:46:07 -0700 (PDT) Message-ID: Date: Mon, 27 May 2024 09:46:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arch/x86: Do not explicitly clear Reserved flag in free_pagetable To: Oscar Salvador , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dave Hansen References: <20240527044523.29207-1-osalvador@suse.de> From: David Hildenbrand In-Reply-To: <20240527044523.29207-1-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: z685it78d59ftzbgyi7gsgpk4gegjm9w X-Rspamd-Queue-Id: F11A340002 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1716795971-753253 X-HE-Meta: U2FsdGVkX1/tyHRNuDxR68x52u+f5NTeu5gjHV5ZgHDsUi8Gyx3/mkX4zbYuMOSx0WGtcjGyv4vmpJ5OJn+Pb4gdwUMtuJW/LU995HOpssWSXo1hxKNjGL10z+vPK8uaG0VRbob03QbXLxSFRZ/Gepxueq9pxEGdh/FHab3/0qELNTUOcBJTr6n5ZnCLCbXJ6P7SYhDm4sT6fax7PJcTw+lvlYMMFbr3s7m2gS3u3B2byACarm3S+NN9zelu+iuXz9I3OLa0m7hK/4VpkS0PZj/fJ0vcih3Ajvt14SqWRf6+TcCfhvDclzCROYAppsJyfa58Ui6R/gT88nQ6r8U2NpbaqLxGdjVgJtlTdYfRpL5MWPnPb0QCwo1Cus531ufL3ODsit3qcM8wHBvyp/DFuQC/gE4eTvNxnzmHAiQ9H9a5cd7n6ZF8U/WRLTgCPkR+EaGSQvwJgZNtBP4jkk2OQC/voZseIgHwL61Jzwoo6CCTJCg46USgFJdPndN+khUPLNVsj+RuY5HZvZyw6emK4ZXhpCco8rpchmiZVlYpsATeBxk2DKEH3tTwQehXH/uMWNzdaGFUztB6FT7ue9YBnyJEsorkS/tFuYdhjgEIfn6xZtFI8BvrGIxnppnyWyTXiDQ5FskOxsMYoBBHT4N/yvNLhPKANWXAQ93hYibC8PaJfVMOtsbfgLEzL0dyziWlywCJIzd5b7CzPt9/+h+adv068dc4bdgS9Vz0g1sCqOeMHnegbxE7KrSTvwjYXLaW4/msp0PJZ6K9LEKbUQcWh0PsBCDL3aUJ2tecSay0ziAncb1SFWAXxSGZAmnSJOgXCcVNqVBiGOq5BTbnExDq5y8RSjLXDXMR5eb5AfSwpeFP7Peq+r18XxK3UN9xLgOGhfLxdXAmFKOOLUo4HdDr30euW+SscHLXxjUunH3SkCNuvAVyDrU8oA/z2RS9gH2d78fAK/2byD9RFXKnMR6 bGYza7Im lAUJMo05iYSaWbWpP7OFndqUtKux1ry4FNaU5G1ZrP0K+G15Kmo8XhGX5hQdcWNdaHjziUCzlIPkWqRJEJGM9doGNPvcT8iSqdgXcHbH4w5P1rRrHRD0E5Ga05HSqLZpLyASr0gMUVQWu6CMp17bpLR+BqMe3kxYGrURhyCJ50VMcgd4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.044545, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Am 27.05.24 um 06:45 schrieb Oscar Salvador: > In free_pagetable() we use the non-atomic version for clearing the > PageReserved bit from the page. > free_pagetable() will either call free_reserved_page() or > put_page_bootmem(), which will eventually end up calling > free_serverd_page(), and in there we already clear the PageReserved flag. > > Signed-off-by: Oscar Salvador > --- > This has been like this since commit ae9aae9eda2d ("memory-hotplug: common APIs to > support page tables hot-remove"), so I might be missing something obvious, but > I cannot explain why we would need that __ClearPageReserved upfront, when > free_reserved_pages() already does that for us. Especially, we only call it on the first page (in case we'd have order>0). Acked-by: David Hildenbrand -- Thanks, David / dhildenb