From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0091FC3DA4A for ; Wed, 14 Aug 2024 23:47:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89D076B0089; Wed, 14 Aug 2024 19:47:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84BEB6B008A; Wed, 14 Aug 2024 19:47:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 739DF6B008C; Wed, 14 Aug 2024 19:47:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 538E66B0089 for ; Wed, 14 Aug 2024 19:47:24 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C30311C4CF6 for ; Wed, 14 Aug 2024 23:47:23 +0000 (UTC) X-FDA: 82452489966.17.13E56E3 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) by imf03.hostedemail.com (Postfix) with ESMTP id 0410B20004 for ; Wed, 14 Aug 2024 23:47:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vYvHjkeI; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723679169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jg+s4mYzcdav/XM5wUxFRJ/VTK1SLADq2GMhI8NVFig=; b=NKGp8215CF4G4IXj3zCQopMzmFH5ia6KBXSN3wGx7clLxHni8Rcf7IwnQ9H5pL/yQusDb+ IQYhEGQeg8X+QWWwKWwp36/GHk/ta6F8NoR3cxmaRH34RVrpXAq+WhAT1635xBQMLYlwhA gOmbl+WKLL+A1Oy5pwcv/jT02fSekQw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723679169; a=rsa-sha256; cv=none; b=F0WBbxzaikajfe4UgKplD6or49aSQnKwcKWz0SAMm8KaNwwvuy/uzW1izUftmQCl8VID5x kQfZPnAtd5LJst9MFBKecRZ9ivwiXsc7KJBk9dzfY3FAeLATPTcH3VonC2CDwWrcU91wi7 YtJmAoLSgs/Ff/srK3SLHqxlUU8ryfw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vYvHjkeI; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 14 Aug 2024 16:47:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723679234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jg+s4mYzcdav/XM5wUxFRJ/VTK1SLADq2GMhI8NVFig=; b=vYvHjkeIzOd9u2FtJot7z+v8W/8RcvA86Zm0RxrNUdZvYUMV6N+0cBiqXzQLKb7mncY91h LvDOX7VhoIWN+CMT+8V5xpxeW1J37rZ8PLOcBOtZd1YQ/HJGgrQ12Tcjj9rd2MYBjBiry7 LLYDXxaRXlqSm/28keYycwFmST7uLC8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: "T.J. Mercier" Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org Subject: Re: [PATCH v2 3/4] memcg: initiate deprecation of oom_control Message-ID: References: <20240814220021.3208384-1-shakeel.butt@linux.dev> <20240814220021.3208384-4-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: oqcyj6zmujb6wm6zgpkmtbmiyjgjqbzk X-Rspamd-Queue-Id: 0410B20004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723679241-346026 X-HE-Meta: U2FsdGVkX1+VhVZBz3DpKybCUMbgXahMigwrzPpz/+w7GJPEjCBroWd1twWUiuiqvV9ZkWaEVOwkvkky8LkAEIv/KSdgi+6yLu5KIwwa+qZM/86lbL3+Ph0s1TtPiHwyt0ICyXm1M834f6knDxox1PE4zsVXh7BFMV18K6UAHpcEezlrQUGCTMCz3B97/I5CkURwrsFMBwn39YQE9faC6zXsjEhnAmy1ONbqS6jmSZlTaz/XQ3uMWf5QjB8/D6VlEtiDsB70P6IlQzKAwb7VAO5lY5apr3Unqo8qIJTjR9Yze4rjKwIrX9MGT6ysyKcIoymKFuUVUmHNkAzppk8WMRgwUuZR4HXk59gmPEUTOiBgrBsMnU8i/gNlg7Qaogbd3iHsqGQw/Ugcco14azwZFGZ1TZLwiaMDksneBczfHCBDPqZjfnPbLWHL5Ob51MAm6RtS9pUeMeqKezTKDP5nAYyUvXipKr+II0ACOlaObTZxChaYG59opcuuTMsEWn9GwjL66S4L2Hxu9cFzErTAz/FQjF+OfLgu1xoRkGZb++O0nG1LShIAq7VOe9t89T43CJLDlxms/gfIzaLKONRSVi90Jg7KpPr+rGqOOkHXzH5NQErPWmm/uR5eXrYNE7242gKsZxlQW1eF/Q07hq+9ZYz8sH9WfVbA9tGM8WuAnGZUUpX35K6NMzjqs1C5p5peR2B3W/Lj0QTR67zlU7tPiT8XwgNbrH7EcSOkDcqV472AEDodzQ0gRNCjWhUJIJhQsoc1LkVw+gywYrq60APgmIbJCjKst+xOBc+8BmuYOtLvkZXZVVV9sqpJd9bkFOZlF1Wbq22Vd/xcYERZMjX0FRdExp66H5h4x8fMe/wtsG/ZJmbUAjbNQk/yc9L5Y/ric1/++15BjZcDiVEMMlfJxzZLTC0EgtcbeDLhOp28D+ccKz98UO3cAC1mvM3zBv9FFTeciCDSdUjrj74jZ10 r0kOoGC/ 2ncBmIuRbwokbdUKneMh9NG3rqU3yZoeErOGHARGHAW/PMfdTmvj9avZ7U3caQ6PR1GUjQ65rkUs6Wu0OsynPJUX56A5H6OaeN6co6pRzu+sOL+XQ5z2QOGqdqjr1soinVzxY6Ivt9QNMZa8iDfcRFU7J+YfoPBWzdJ3WxFYpGsAZPqN7gvKZzArd5GUzMIB9Bn9H6avSLi+W3pAAwFNlo0dxgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 03:58:03PM GMT, T.J. Mercier wrote: > On Wed, Aug 14, 2024 at 3:00 PM Shakeel Butt wrote: > > > > The oom_control provides functionality to disable memcg oom-killer, > > notifications on oom-kill and reading the stats regarding oom-kills. > > This interface was mainly introduced to provide functionality for > > userspace oom-killers. However it is not robust enough and only supports > > OOM handling in the page fault path. > > > > For v2, the users can use the combination of memory.events notifications > > and memory.high interface to provide userspace OOM-killing functionality. > > Might be worth it to mention PSI here too for userspace OOM-killing? > (It's what LMKD does for Android.) I think Andrew will fix the commit messages for others, let me request to replace the first sentence of this paragraph with the following text. "For v2, the users can use the combination of memory.events notifications, memory.high and PSI to provide userspace OOM-killing functionality. Actually LMKD in Android and OOMd in systemd and Meta infrastructure already uses PSI with combination of other stats to implement userspace OOM-killing." > > > Let's start the deprecation process for v1 and gather the info on how > > the current users are using this interface and work on providing a more > > robust functionality in v2. > > > > Signed-off-by: Shakeel Butt > > Reviewed-by: T.J. Mercier Thanks