Re: [PATCH v2 3/4] memcg: initiate deprecation of oom_control

[Shakeel Butt <shakeel.butt@linux.dev>]

On Wed, Aug 14, 2024 at 03:58:03PM GMT, T.J. Mercier wrote:
> On Wed, Aug 14, 2024 at 3:00 PM Shakeel Butt <shakeel.butt@linux.dev> wrote:
> >
> > The oom_control provides functionality to disable memcg oom-killer,
> > notifications on oom-kill and reading the stats regarding oom-kills.
> > This interface was mainly introduced to provide functionality for
> > userspace oom-killers. However it is not robust enough and only supports
> > OOM handling in the page fault path.
> >
> > For v2, the users can use the combination of memory.events notifications
> > and memory.high interface to provide userspace OOM-killing functionality.
> 
> Might be worth it to mention PSI here too for userspace OOM-killing?
> (It's what LMKD does for Android.)

I think Andrew will fix the commit messages for others, let me request
to replace the first sentence of this paragraph with the following text.

"For v2, the users can use the combination of memory.events
notifications, memory.high and PSI to provide userspace OOM-killing
functionality. Actually LMKD in Android and OOMd in systemd and Meta
infrastructure already uses PSI with combination of other stats to
implement userspace OOM-killing."

> 
> > Let's start the deprecation process for v1 and gather the info on how
> > the current users are using this interface and work on providing a more
> > robust functionality in v2.
> >
> > Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev>
> 
> Reviewed-by: T.J. Mercier <tjmercier@google.com>

Thanks