From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02D5C433FE for ; Mon, 27 Sep 2021 23:23:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 88493611C2 for ; Mon, 27 Sep 2021 23:23:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 88493611C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=quicinc.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0D070900003; Mon, 27 Sep 2021 19:23:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08082900002; Mon, 27 Sep 2021 19:23:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED764900003; Mon, 27 Sep 2021 19:23:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id DCF8B900002 for ; Mon, 27 Sep 2021 19:23:06 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A10CC31EC1 for ; Mon, 27 Sep 2021 23:23:06 +0000 (UTC) X-FDA: 78634931172.12.4CF3046 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by imf29.hostedemail.com (Postfix) with ESMTP id 1E653900013E for ; Mon, 27 Sep 2021 23:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1632784986; x=1664320986; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=S3JwOABhR/3dTwDn7YJ9Upq8D+qXiJRw20o/fQbTFn4=; b=OjN7m39Mlmfot9oI14zbip1NUZVKskbHmR9lMfMwyTK/i7V+ajXPfmcY ahaD2ucW5huLKRC54R/mlfrb57qozoHsMCs0qM8BF0sPdXw+dB+uFNLfh EbtiqG3kBY44O4dDaTVIX0QLh3g2wFgRN1R8rb3Spdc5rSZfVEuLYS4hI s=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-01.qualcomm.com with ESMTP; 27 Sep 2021 16:23:05 -0700 X-QCInternal: smtphost Received: from unknown (HELO nasanex01a.na.qualcomm.com) ([10.52.223.231]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 16:23:04 -0700 Received: from [10.251.44.228] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.7; Mon, 27 Sep 2021 16:23:02 -0700 Message-ID: Date: Tue, 28 Sep 2021 02:22:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [RFC] arm64: mm: update max_pfn after memory hotplug Content-Language: en-US To: David Hildenbrand , Chris Goldsworthy , Catalin Marinas , "Will Deacon" , Andrew Morton CC: , , , Sudarshan Rajagopalan References: <595d09279824faf1f54961cef52b745609b05d97.1632437225.git.quic_cgoldswo@quicinc.com> <833493d2-d585-47ee-c258-79eae5deff36@redhat.com> From: Georgi Djakov In-Reply-To: <833493d2-d585-47ee-c258-79eae5deff36@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1E653900013E X-Stat-Signature: dz11odxstxuec6pkzc4oghprydwu8j5d Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=OjN7m39M; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf29.hostedemail.com: domain of quic_c_gdjako@quicinc.com designates 199.106.114.38 as permitted sender) smtp.mailfrom=quic_c_gdjako@quicinc.com X-HE-Tag: 1632784985-413530 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/27/2021 6:51 PM, David Hildenbrand wrote: > On 24.09.21 00:54, Chris Goldsworthy wrote: >> From: Sudarshan Rajagopalan >> >> After new memory blocks have been hotplugged, max_pfn and max_low_pfn >> needs updating to reflect on new PFNs being hot added to system. >> >> Signed-off-by: Sudarshan Rajagopalan >> Signed-off-by: Chris Goldsworthy >> --- >> =C2=A0 arch/arm64/mm/mmu.c | 5 +++++ >> =C2=A0 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >> index cfd9deb..fd85b51 100644 >> --- a/arch/arm64/mm/mmu.c >> +++ b/arch/arm64/mm/mmu.c >> @@ -1499,6 +1499,11 @@ int arch_add_memory(int nid, u64 start, u64 siz= e, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (ret) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 __remove_pgd_ma= pping(swapper_pg_dir, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 __phys_to_vi= rt(start), size); >> +=C2=A0=C2=A0=C2=A0 else { >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 max_pfn =3D PFN_UP(start += size); >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 max_low_pfn =3D max_pfn; >> +=C2=A0=C2=A0=C2=A0 } >> + >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return ret; >=20 > Note: didn't verify if updating max_low_pfn is correct here. My understanding is that max_low_pfn defines the low/high memory boundary and it should be also updated. Thanks, Georgi