From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: SeongJae Park <sj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
damon@lists.linux.dev, linux-mm@kvack.org
Subject: [PATCH 20/30] mm/damon: Use kstrtobool() instead of strtobool()
Date: Tue, 1 Nov 2022 22:14:08 +0100 [thread overview]
Message-ID: <ed2b46489a513988688decb53850339cc228940c.1667336095.git.christophe.jaillet@wanadoo.fr> (raw)
In-Reply-To: <cover.1667336095.git.christophe.jaillet@wanadoo.fr>
strtobool() is the same as kstrtobool().
However, the latter is more used within the kernel.
In order to remove strtobool() and slightly simplify kstrtox.h, switch to
the other function name.
While at it, include the corresponding header file (<linux/kstrtox.h>)
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
This patch is part of a serie that axes all usages of strtobool().
Each patch can be applied independently from the other ones.
The last patch of the serie removes the definition of strtobool().
You may not be in copy of the cover letter. So, if needed, it is available
at [1].
[1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/
---
mm/damon/lru_sort.c | 3 ++-
mm/damon/reclaim.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
index 2a532e3983df..7b8fce2f67a8 100644
--- a/mm/damon/lru_sort.c
+++ b/mm/damon/lru_sort.c
@@ -8,6 +8,7 @@
#define pr_fmt(fmt) "damon-lru-sort: " fmt
#include <linux/damon.h>
+#include <linux/kstrtox.h>
#include <linux/module.h>
#include "modules-common.h"
@@ -241,7 +242,7 @@ static int damon_lru_sort_enabled_store(const char *val,
bool enable;
int err;
- err = strtobool(val, &enable);
+ err = kstrtobool(val, &enable);
if (err)
return err;
diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
index e57604bec06d..e82631f39481 100644
--- a/mm/damon/reclaim.c
+++ b/mm/damon/reclaim.c
@@ -8,6 +8,7 @@
#define pr_fmt(fmt) "damon-reclaim: " fmt
#include <linux/damon.h>
+#include <linux/kstrtox.h>
#include <linux/module.h>
#include "modules-common.h"
@@ -187,7 +188,7 @@ static int damon_reclaim_enabled_store(const char *val,
bool enable;
int err;
- err = strtobool(val, &enable);
+ err = kstrtobool(val, &enable);
if (err)
return err;
--
2.34.1
next parent reply other threads:[~2022-11-01 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1667336095.git.christophe.jaillet@wanadoo.fr>
2022-11-01 21:14 ` Christophe JAILLET [this message]
2022-11-01 22:00 ` SeongJae Park
2022-11-01 21:14 ` [PATCH 21/30] mm: " Christophe JAILLET
2022-11-01 22:47 ` Kees Cook
2022-11-02 11:29 ` Andy Shevchenko
2022-11-05 2:58 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed2b46489a513988688decb53850339cc228940c.1667336095.git.christophe.jaillet@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox