From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by kanga.kvack.org (Postfix) with ESMTP id 19FAB6B1A0A for ; Mon, 19 Nov 2018 04:52:24 -0500 (EST) Received: by mail-ed1-f70.google.com with SMTP id c3so11578959eda.3 for ; Mon, 19 Nov 2018 01:52:24 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id b51sor2659446edd.5.2018.11.19.01.52.22 for (Google Transport Security); Mon, 19 Nov 2018 01:52:22 -0800 (PST) Subject: Re: [Xen-devel] [PATCH 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_insert_range References: <20181115154912.GA27969@jordon-HP-15-Notebook-PC> From: Oleksandr Andrushchenko Message-ID: Date: Mon, 19 Nov 2018 11:52:20 +0200 MIME-Version: 1.0 In-Reply-To: <20181115154912.GA27969@jordon-HP-15-Notebook-PC> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: owner-linux-mm@kvack.org List-ID: To: Souptick Joarder , akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com, oleksandr_andrushchenko@epam.com, airlied@linux.ie Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xen.org On 11/15/18 5:49 PM, Souptick Joarder wrote: > Convert to use vm_insert_range() to map range of kernel > memory to user vma. > > Signed-off-by: Souptick Joarder > Reviewed-by: Matthew Wilcox > --- > drivers/gpu/drm/xen/xen_drm_front_gem.c | 20 ++++++-------------- > 1 file changed, 6 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c > index 47ff019..a3eade6 100644 > --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c > +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c > @@ -225,8 +225,7 @@ struct drm_gem_object * > static int gem_mmap_obj(struct xen_gem_object *xen_obj, > struct vm_area_struct *vma) > { > - unsigned long addr = vma->vm_start; > - int i; > + int err; I would love to keep ret, not err > > /* > * clear the VM_PFNMAP flag that was set by drm_gem_mmap(), and set the > @@ -247,18 +246,11 @@ static int gem_mmap_obj(struct xen_gem_object *xen_obj, > * FIXME: as we insert all the pages now then no .fault handler must > * be called, so don't provide one > */ > - for (i = 0; i < xen_obj->num_pages; i++) { > - int ret; > - > - ret = vm_insert_page(vma, addr, xen_obj->pages[i]); > - if (ret < 0) { > - DRM_ERROR("Failed to insert pages into vma: %d\n", ret); > - return ret; > - } > - > - addr += PAGE_SIZE; > - } > - return 0; > + err = vm_insert_range(vma, vma->vm_start, xen_obj->pages, > + xen_obj->num_pages); > + if (err < 0) > + DRM_ERROR("Failed to insert pages into vma: %d\n", err); > + return err; > } > > int xen_drm_front_gem_mmap(struct file *filp, struct vm_area_struct *vma) With the above fixed, Reviewed-by: Oleksandr Andrushchenko