From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B1A6C282EC for ; Fri, 14 Mar 2025 10:01:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4790A280005; Fri, 14 Mar 2025 06:01:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FF18280001; Fri, 14 Mar 2025 06:01:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 278E8280005; Fri, 14 Mar 2025 06:01:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 05960280001 for ; Fri, 14 Mar 2025 06:01:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9542DC0E01 for ; Fri, 14 Mar 2025 10:01:08 +0000 (UTC) X-FDA: 83219713416.26.6C7FC36 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf12.hostedemail.com (Postfix) with ESMTP id 467F34001E for ; Fri, 14 Mar 2025 10:01:05 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nfiXhSs8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Y0ImvUuo; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nfiXhSs8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Y0ImvUuo; dmarc=none; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741946466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jCQu6sjM1S582yyCJbxTmiOkhuaJtxfPp1egfeJdg7A=; b=w7MSY3x3Ltn9H7rBN7cOSHxi4Z1Xx1QI2yCluB9AjXTXMUUJZc0HK1LP6RvkZl/PhxvYUF mJtK21wPhHD+ozKuEn1RfKzNGc0RxVKadec5x/I9Be8f8yYPuDWo7YIxgBKL7DkJKCVfnL YndFN8gh3AbKSK3e7vkpkItXFG523h4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741946466; a=rsa-sha256; cv=none; b=lghtCDRtDAXqWUfHEkX1JurewUssHGNtZe5UWHxRPmBUJnsek2tfAhyhLcPDA1S6EaP5Pg S0IqC/cFYWR3GlktgPRV3fhyovyrd1RGkcxsfLFg94LftVhQHiAZ1ktc3gd+nZ1+iFMPSN IeF1ZEfKkH5p9xEL9eKigdnpFfVmqT8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nfiXhSs8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Y0ImvUuo; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nfiXhSs8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Y0ImvUuo; dmarc=none; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 79BF61F452; Fri, 14 Mar 2025 10:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741946464; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jCQu6sjM1S582yyCJbxTmiOkhuaJtxfPp1egfeJdg7A=; b=nfiXhSs8QqcWFtFhJf7D+wykhDCezXIq/i9l01vGIF5eQUW18Zu2KtzurwbjiiGKl/IO7u 4UoQCGTARxnvBoapnocaH/isiVkKNafBFDvdj5sTzvisex773CKrCKdqO6EwoVIIknMvZn Nqpy+byaqHa/gyY3DbXzQ7hYE7UTTiE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741946464; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jCQu6sjM1S582yyCJbxTmiOkhuaJtxfPp1egfeJdg7A=; b=Y0ImvUuo/tydYTfoKChvKup2I492jKIOwiS049+NRqtQM5+HKPzhaBeZyV9eaDxEpZT3hr t81opyqNTMHP1xCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741946464; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jCQu6sjM1S582yyCJbxTmiOkhuaJtxfPp1egfeJdg7A=; b=nfiXhSs8QqcWFtFhJf7D+wykhDCezXIq/i9l01vGIF5eQUW18Zu2KtzurwbjiiGKl/IO7u 4UoQCGTARxnvBoapnocaH/isiVkKNafBFDvdj5sTzvisex773CKrCKdqO6EwoVIIknMvZn Nqpy+byaqHa/gyY3DbXzQ7hYE7UTTiE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741946464; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jCQu6sjM1S582yyCJbxTmiOkhuaJtxfPp1egfeJdg7A=; b=Y0ImvUuo/tydYTfoKChvKup2I492jKIOwiS049+NRqtQM5+HKPzhaBeZyV9eaDxEpZT3hr t81opyqNTMHP1xCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5ECAF13A31; Fri, 14 Mar 2025 10:01:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id tl3AFmD+02cUXQAAD6G6ig (envelope-from ); Fri, 14 Mar 2025 10:01:04 +0000 Message-ID: Date: Fri, 14 Mar 2025 11:01:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 03/10] memcg: introduce memcg_uncharge Content-Language: en-US To: Shakeel Butt , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Sebastian Andrzej Siewior , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team References: <20250314061511.1308152-1-shakeel.butt@linux.dev> <20250314061511.1308152-4-shakeel.butt@linux.dev> From: Vlastimil Babka In-Reply-To: <20250314061511.1308152-4-shakeel.butt@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 467F34001E X-Stat-Signature: qsn7pitkgd9h81r668jk9kqmfusme4ke X-HE-Tag: 1741946465-693896 X-HE-Meta: U2FsdGVkX18V0/3FBUfEO3xuVzqFJuRsfM1Ec4rp+CJg4woPG6GnQF9yZZzACSXWZAGaM219QWRaydbeVq21Z4D3g96zpe7mLxW3TYP+ObGCpVvoXSmW3D7lSP+POCA2Ub7MjbIEaqF8CDFX66J7It+QJHUyzh9wFtaRM2Lp/LYC4WkdULXMEeaqvpS7xrLftl9LjgoyzmhHy3+Cep8SK2DBXd8eN3lmoUAz8BU5Tzde/Xa9QZcMjJtLoB4WoTYe3zn5CH4M6ZdWke9dT22lOQro1djdgFVTQM5dlhNYVigm5KH3hAIhKZg2twXR8aN9njgfw31P91lP+lOSWixi+GY/FooeimkmRiot9W+FOWUFrj9PypXOArdzl5rOcoDBQxKN3D9YzPPoid4L7NUHQYF6REc0zcIYJviwMAEhlQKe1elX704Jj6ddPqCRSteH6f/06UoJVFahE5UghUzyMk+KHj5YTMKLYaYL+6zPDAu+hjyppWvOH4wit4pY1IQZ0a8IkFkkZNS8zLy3Wjx9hxCUjJ5Xb3w5ZwdViw2gqQP0GsbdxHYSZbUaqyOCGVc31Y3U+WIG9MawqmjD6Kjo4V6BV+H2Fh8v+AVgogSSHsd4VQ6Ncj1CsvFWy2CTIJlWDmjxlFPxTPPM+Fkzu4kUPaEVz8CsrG5YvfJCgM7Jarew74ZbfcThB+4QaEF0eB+Zzfa63zbplVYVFDdLa3jwIA+VY9nlOJzkZcqm04G2tmsQBLR/LnlVW2tGVj1wTD24lR7dfAfXp40y03nzslCvZKIXsNDgQQ2GQwX3V97rHaL5XgoffbXokwv6ghfy6yRCCyXX+yaWup4z/1AeZYQT9DyJxZI081ObFyodtt2b1UImFMCpwAn5S9ShZ80ZaoiSgopqxbzNSDrtTBxJeDdlqp3d2mEk79x38ieP8tLNjVhQY2RxNF/lLyVMuICXBL5UUUMNEH3eZajDA3Kb/Cy 8PLkuLA7 6wH6GX6u95l0pJAg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/14/25 07:15, Shakeel Butt wrote: > At multiple places in memcontrol.c, the memory and memsw page counters > are being uncharged. This is error-prone. Let's move the functionality > to a newly introduced memcg_uncharge and call it from all those places. > > Signed-off-by: Shakeel Butt Acked-by: Vlastimil Babka