From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1FA3C77B7A for ; Thu, 8 Jun 2023 02:46:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17D4F900002; Wed, 7 Jun 2023 22:46:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 106306B0078; Wed, 7 Jun 2023 22:46:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC27D900002; Wed, 7 Jun 2023 22:46:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D873A6B0075 for ; Wed, 7 Jun 2023 22:46:39 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A54C640342 for ; Thu, 8 Jun 2023 02:46:39 +0000 (UTC) X-FDA: 80878042518.23.479DFB3 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf04.hostedemail.com (Postfix) with ESMTP id D228140002 for ; Thu, 8 Jun 2023 02:46:37 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=da3ktJDt; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of hughd@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686192397; a=rsa-sha256; cv=none; b=fvL7PtsbReirD9PbgUpI5WutHhyGiYoO8kOC5EeHUO7tO7TEs5qqjSR1vTNVhb/VD9zK0u h5V9Nz+0gYuX+WsyjrOhnQyBerf4202ZI+nEQfUizl4Xng9yRM7bcJTxgS0NVC6aA3j+bZ MEWrXWnVha3e4zp54M+/rBKhrr1C690= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=da3ktJDt; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of hughd@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686192397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3ASVf02IlD8C2FBeHhgGmTxXuzubkx9rvqSR5YGjpQE=; b=HipvDs0/VYlQAbwoBiz9UC5rym1/WjPQSTYl2fHlbCbih7w/WskaCQ0FuMgCnQdZuQQkIN UUtuug8UZvTMt1dAorC28a3lpzvDZo9qUBBj8zRDTfv9B2R3l4O3AEb8V11mf4SPZfHVRf BF45fSgjsG42ALEQ6BZVg/9QlIREQcs= Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-565de553de1so2902937b3.0 for ; Wed, 07 Jun 2023 19:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686192397; x=1688784397; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=3ASVf02IlD8C2FBeHhgGmTxXuzubkx9rvqSR5YGjpQE=; b=da3ktJDtrHlXFJY7fBZV9rF65uZZhghhOV9dnWa/Fsa39j+kMpSSL6DALstHpQz61g K4YVYJos6+GGP6Xf9ot3Uk/1ZbuoyK1eEfBQh/bTNe/mDYJxX8S+fb9se2eckLKEuTOP UD7/4cfGR2T85Ke8Bc4ObLfx9a9FXmomkcXEFQInN+aLXpDDyqofJ4uF60Ko9gzt3x2L MGX9ZxFfnKfNnjs1tFSzEKj5NE78sfc+UDhIQev+RhydadRJR8BTDVk3Lch9IO5KK2Az N/YtKtrcGMeEnF2xteGjLRnISuA5d7eV63yxWyEhWp6zKk6kXjpoiTGJgfB7a9sG5sLf 6M9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686192397; x=1688784397; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3ASVf02IlD8C2FBeHhgGmTxXuzubkx9rvqSR5YGjpQE=; b=T9srzK7D6lvEj0lY2hIyhfQD1CTV/3blqoujWjJPFLCCgBM+TJrtucVUjlrYCiDnmD L6SjvJJVC+aCzjF4vXK2GghaBYb9JvBrDDPXDNTgaT8ip40sYyj7vSdQHq/oXZ3S2RyT lWuJmdXUMGm0kKWwLsBz1IWTJxT10d5AqM0tzbC1BxI03QWdLEAM5DjwneQFrSlF8L1a vIMimd3EFvnMC0ko0nCzgCoxgvv73t4e2W+EfbzA0AqLt456WygYQCGeawjsTLOkPL8S V/7G4ic1XsXM99RlWa53EtrNHM2o9DT974SJ+BkwvmcU64/Rct3DMr0H2oV2B057tdPA ztjg== X-Gm-Message-State: AC+VfDyCAp9Lkh6wgG7EVUmMh007Zb6aVEqzfKcHn/ig9L4qk2UBH3so D1sEJ/VhXoq2Fb0vr0bm3Wv+vA== X-Google-Smtp-Source: ACHHUZ4dFnfQCU4EFBdNXwNcj7Ir8z8QRqL+UH/A47UqaCSLxCcPaFmZ7Dypt65uEduAukIhZYJfeQ== X-Received: by 2002:a81:5f06:0:b0:561:bbb8:2dc3 with SMTP id t6-20020a815f06000000b00561bbb82dc3mr981921ywb.21.1686192396777; Wed, 07 Jun 2023 19:46:36 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id j7-20020a816e07000000b00568e7e21db7sm103768ywc.96.2023.06.07.19.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 19:46:36 -0700 (PDT) Date: Wed, 7 Jun 2023 19:46:26 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Jason Gunthorpe cc: Hugh Dickins , Gerald Schaefer , Vasily Gorbik , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Russell King , "David S. Miller" , Michael Ellerman , "Aneesh Kumar K.V" , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , Alexander Gordeev , Jann Horn , linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 07/12] s390: add pte_free_defer(), with use of mmdrop_async() In-Reply-To: Message-ID: References: <35e983f5-7ed3-b310-d949-9ae8b130cdab@google.com> <6dd63b39-e71f-2e8b-7e0-83e02f3bcb39@google.com> <175ebec8-761-c3f-2d98-6c3bd87161c8@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D228140002 X-Stat-Signature: amnw4iywiqb8tae874ueg1zpdfaftpq4 X-HE-Tag: 1686192397-153354 X-HE-Meta: U2FsdGVkX19l6B02Wg6HJpuX40b7EPQPSJ3xms0qzkAhnC18A4ZlMhvK3v02skAkKmPNZjN0iVQfroOnaaVL3FA75vayigBf59N/+8pWtsjhbp1w9W947rcjwx+g8ReJH07SkxJDUUMd287KNamAEfMS6FrM29hvQjwScGZHnhIbdEoN45XxbHKu2Gyh4QkxuYwSlt1DnOq2Uhwdn75gYWh1fexH+gL1OUebqI7PhYL/yK9ZuoXJk+Zmc8jaQAwmJhG96bt4UFKpYJACS0DdctXuO7v2RkSeu35JJ4aGf9O3qJ27LNUz5QkTEFa42wyS37ocKFPTUdhu4h4hne3Zu5psCFcNYwq9yviXxVCK5qekac11vn6qkMokO15Ke2LitvWsftv8NjPYaqM0r8oKjLqNriHvAb85ZCScSgU/W4t8/Ojic/Q2A1tinRD2nZLQQDOLtiX3CZmjR457ag5aE8u4s2jze7V5WqZuqQKwMU6cRqNA94oPDQZ7hHJaFrKIZcLtSH4JXy0S7joAjGw86GxJe3GBeZAm1E3Nohe0ZwFObciHZpus0SHek6WoGMbptfiszt0culWB3jdv3vUPK7eoNs5MPs9iRj/S+e7z3JwjaHQZHVMtLfk/FWF/5TQfdA1HcKbbIiJscJePHzK03vegsvhTRubzd1ST7vq6ADdEsocJ9U8y1An70AU4FYfZFzl+KsZRjCtpqJiHWIaO1vZQM87xAVCkDR1AKFAavs1XdJgierUiLLLQcmni0MaPhTlpOaqcdcPLh40+tV2j7D+GZjEK64p99yGhJEXKYQVs1Vk6Qr5DOxbn++Z8qzgDajbnmF2c5Uz08wB35HFGygqfiLE3GQF5VFvCSqA8ouZevIe2Jbz99IuoReLCSoapkjCNef2WDrgMrxHJg/xm6S+gQ4bdDogt07OCPDe2KrRpJTFYaef/4xkGZ5Zfi2YWZkZGA6RaM2QGARs9O2y Dyiphsaq sR6gCOxI/Z548qpuqnFgH+T4LtpkB87+L4V52jlbmdVZr0lXPF7UNaMjW0YCNYW6BXJ8aPrdW5KIfoZ8m+8JXQ+oGkAvndxcK9YJfCQxlo+/dOrJgq8aU2tXDfVaz/Jzcl7m8QRSVYyx+5qpT5NWb6Bf5q5hkeva+8cBybWYNOrM7g3LIVDVHsLQ2BTwL93EhBHk+h0e11sdeQyvspzyMsFP7swLoRoT/1xXKq4HWb92AINJ2r5rJWqCzlRe0rtoIzuginWMOdHWQIeoRrLQcOUqiCQxchLeEBzpwJWUbsGjcIkTuMDI9c+SbydQjCniWNaSF3oPGpPh5Xixd4alox//vF03z8XnkD+9MuNJ4F2hHZ/6BSjkxOqK67smdz5R+Fnb63F1T3Ua6X2JVVQzzb5xowkw2YkSrKCJOVkBqQFtdkUvYI+4cMFKfTA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 6 Jun 2023, Jason Gunthorpe wrote: > On Mon, Jun 05, 2023 at 10:11:52PM -0700, Hugh Dickins wrote: > > > "deposited" pagetable fragments, over in arch/s390/mm/pgtable.c: use > > the first two longs of the page table itself for threading the list. > > It is not RCU anymore if it writes to the page table itself before the > grace period, so this change seems to break the RCU behavior of > page_table_free_rcu().. The rcu sync is inside tlb_remove_table() > called after the stores. Yes indeed, thanks for pointing that out. > > Maybe something like an xarray on the mm to hold the frags? I think we can manage without that: I'll say slightly more in reply to Gerald. Hugh