From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B39A9C3271E for ; Fri, 5 Jul 2024 16:48:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3494E6B0095; Fri, 5 Jul 2024 12:48:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F9816B0096; Fri, 5 Jul 2024 12:48:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19A0C6B0098; Fri, 5 Jul 2024 12:48:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EF2406B0095 for ; Fri, 5 Jul 2024 12:48:36 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9F76DA149D for ; Fri, 5 Jul 2024 16:48:36 +0000 (UTC) X-FDA: 82306282632.05.769EB4E Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf29.hostedemail.com (Postfix) with ESMTP id 355AE12000D for ; Fri, 5 Jul 2024 16:48:33 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=XrzlpYRI; spf=pass (imf29.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720198087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aIdtEz/ceNHX6TjIUu0L4V6JPzYwy3OzJfwnmxjuk0o=; b=deXKSRmamCnTj0F1L7eCypAQn7LGZTMu+7GEvKAiwFs8LGaCcaEbopFb7lfkyQy9Wo0O9B oXCgOB3ZVMhqWome2l5gZanNtJQockao0b5VQOIrjnIKvElKRvXa32R9kXIre2QOBgisw2 sHoKv+4Y6yUP+2o1US6Z8Z7NgAip9Ik= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720198087; a=rsa-sha256; cv=none; b=5Huy13mIXyIU9ONvAikOYKSI+/eTamQkb7a5127OgegrH9I34hCqsNZJmvTtDnuUy6lZou 528qHbF95Y1UN530fD5pyT/yxEw4jgR0jDQ6D6uI0iu87PqlFT94NYeHB0OcBLM3scPuiQ 3tWfppz+9F3l3J5xIiBJlLVdg7deUUc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=XrzlpYRI; spf=pass (imf29.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 465GRR9t007184; Fri, 5 Jul 2024 16:48:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=a IdtEz/ceNHX6TjIUu0L4V6JPzYwy3OzJfwnmxjuk0o=; b=XrzlpYRI4fC2mqV/+ Hkb8AcHue/X4i2kwMa/+2r5dwVdVI/8iH6aBT+ZbI94P1LCALGM19s/hU3U1vbdd bfIAidjDunLgbhlSRj8buSLNbTrXAndkQal83vjHWBlPW5N6tEOg7kY5ecEcthn8 vLt3rykROTJUarmMZDC7xhgxujjYVx0Z9qjR+FO5c8lBfc+Kcc23HJeG9nVHquFv JWlx62Yc3FhcuBsq0Cbs3Y7tgaNeolgWPRFTRCulK3AmQGv2DZtETFNOO97L853C ddJDcIYYnYw7b4oAqgC/x5zNmMyUe/eUYHucuvvqROLQ//1ZCf37VJDoz8gvNRhV cc+8Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 406j6a0by8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 05 Jul 2024 16:48:19 +0000 (GMT) Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 465GmIcH006669; Fri, 5 Jul 2024 16:48:18 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 406j6a0by6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 05 Jul 2024 16:48:18 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 465E8Mss026393; Fri, 5 Jul 2024 16:48:17 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 402wkqees2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 05 Jul 2024 16:48:17 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 465GmED411993614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 5 Jul 2024 16:48:16 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 361FC58062; Fri, 5 Jul 2024 16:48:14 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CFDCC58068; Fri, 5 Jul 2024 16:48:08 +0000 (GMT) Received: from [9.179.4.203] (unknown [9.179.4.203]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 5 Jul 2024 16:48:08 +0000 (GMT) Message-ID: Date: Fri, 5 Jul 2024 22:18:01 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fs/hugetlbfs/inode.c: Ensure generic_hugetlb_get_unmapped_area() returns higher address than mmap_min_addr To: "Kirill A . Shutemov" Cc: Andrew Morton , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ritesh Harjani , Mike Rapoport , David Hildenbrand , Matthew Wilcox , Tony Battersby , "Aneesh Kumar K . V" , Nicholas Piggin , Alexei Starovoitov , Andy Lutomirski , jj@black.fi.intel.com References: <20240705071150.84972-1-donettom@linux.ibm.com> Content-Language: en-US From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: B5HTZE9k8iN5lvA3x2_wO1SGwrYIw4QR X-Proofpoint-ORIG-GUID: BaRYynCNqe_F5ZTnlMl55fvDEov7zx1V X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-05_12,2024-07-05_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 phishscore=0 priorityscore=1501 clxscore=1011 spamscore=0 malwarescore=0 impostorscore=0 suspectscore=0 mlxlogscore=771 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2407050118 X-Stat-Signature: 8so5dxiegfpg9hbm37uuzbswkqiq9sbn X-Rspamd-Queue-Id: 355AE12000D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720198113-890322 X-HE-Meta: U2FsdGVkX18xamhb92Q2SLXzXGMznvEASz2rNDzXwUiatQYauLAwMHHFec7Ag70K6rl1frGPvuhNAVQTH8s2OfdqhyMMsYStW6Y3fZY7tejNJDO/SxQo3VvNliOW3om1k9ACbW7VS6rPjgqBB4txqcklPJO6+sWUs3VSQnDK+xKjc30UHAqVKaxP9J09G204iKXyKyUEdnUh3W/1nPVky8hwQa7+BDZqjlSq1AbCRX+opXQHOxlrATvR1JfXtcZQfaUA+kdExDUTjzRbkX0jHnNObABDPs5oLUipH+QUOBdAeXmbPkhvbzvdzCcYXt2zY8cOGyETHLldSf5hlhoMj8ZkE9nMk3wdQuS9/LCWRN9h4z3f2q+k9gY1PIBCF01YWTAbBB0lP6SRQTuWnH9wJanSbuwS7K6swcC+1lr9gSaBLSVDdYKmkICy8gMcvux/essDZArgKlUN7RKAZF06E63ka3gR+HxESILAXTPaZIaRkcaS7OGAKBI3t6mL4WIWMB77VCy6HWja8kHCFMc5AlUlky1eORASeVEsC/kgcwkImuQl4s6JSV7QxukO6cLELLENQJwCLsU9WsmSmedKQjRQDHj38tk09woTHD/5Tpd9Ug4rZnaGb8jesffc65e+/XQQnuIaqnTVbmy2Ju2EAYwuX3V4ZdDq6mo6DCPo4P7OLmYHFOBnh8QwNH01h893NPP3y+XntfpH8MHrxXDJd5oqRYp3kmp2Ra92631O5VOW8f5XvhdcEWd6VeTw3kKg9kITWhdG8krzHI7OoVgoz/Hks85/EAVGgXicPXEvDiLaPyqApRfbls8QyFoUlfzl2orUWRRjLopX8oYJdt8IBi2zotAV0DW/wX5hO0y3UFNPowhgak8oSgjXNmvaLjsnsc+sa32gkQ5w/bDkz5lA3d2/WrMvroLqCooJ7FKGnoRLSMas2JV0assknnA0S/JXV3OYmbrJhhcF9HisDz4 kfgoGG1I WAGsTISDKdqswi1J78l1akkZk5qT0fxcu+6kaq7rGQPI9/yHbxnPKa1oRSWGnR7kTwXc4JaepvJ6k9tCZK0OaehoFOaSrb+VCGoNckObNX0sld3WO77XsSzEH4j/IRNAB2sQd6tsHYAueTNC3MPI0NdhP8YsBk1z/t8oKSnhJKngXP9Yw6t9xPeQ8bHTm7lZi1mCoIjYLQjOwnrVBGCf1TEyu6oURmDevZU6bD+A0cQ06KG39hjH/1dmcCklefrK0h+mYA3HW9QB5I5vg7hXtMEr8HA0wUAVzxj0A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/5/24 17:53, Kirill A . Shutemov wrote: > On Fri, Jul 05, 2024 at 02:11:50AM -0500, Donet Tom wrote: >> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c >> index 412f295acebe..428fd2f0e4c4 100644 >> --- a/fs/hugetlbfs/inode.c >> +++ b/fs/hugetlbfs/inode.c >> @@ -228,7 +228,7 @@ generic_hugetlb_get_unmapped_area(struct file *file, unsigned long addr, >> >> if (len & ~huge_page_mask(h)) >> return -EINVAL; >> - if (len > TASK_SIZE) >> + if (len > mmap_end - mmap_min_addr) >> return -ENOMEM; >> >> if (flags & MAP_FIXED) { >> @@ -240,7 +240,7 @@ generic_hugetlb_get_unmapped_area(struct file *file, unsigned long addr, >> if (addr) { >> addr = ALIGN(addr, huge_page_size(h)); >> vma = find_vma(mm, addr); >> - if (mmap_end - len >= addr && >> + if (mmap_end - len >= addr && addr >= mmap_min_addr && >> (!vma || addr + len <= vm_start_gap(vma))) >> return addr; >> } > There's more difference with generic_get_unmapped_area() than what you are > fixing. I think we also need vm_end_gap() here. Thank you for your comment. I will add this change and send V2. -Donet > > Hugetlb code duplication is annoying. >