From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FBB0C282EC for ; Tue, 18 Mar 2025 11:02:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76ED2280002; Tue, 18 Mar 2025 07:02:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71E2E280001; Tue, 18 Mar 2025 07:02:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E625280002; Tue, 18 Mar 2025 07:02:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4485F280001 for ; Tue, 18 Mar 2025 07:02:51 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3AA0B14105F for ; Tue, 18 Mar 2025 11:02:52 +0000 (UTC) X-FDA: 83234384184.26.47AFEF1 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf08.hostedemail.com (Postfix) with ESMTP id 7DC2E160039 for ; Tue, 18 Mar 2025 11:02:49 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742295770; a=rsa-sha256; cv=none; b=5URMUu8GL+ukHbVvi8EVFk0mcnhN30uVy70PoY9xIMjqcb1vr6xYAbjGqjCvhkTCvTo2Rl ITy5GHdJity8FuBdknU1ZEnQh7fRKmAYiEzOn952ETIuKZAWY4X+qKzJ7YsUgzJtAurEKf x8dyQ3LPeSxUkeqCfwb8AnK2L6zoJGM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742295770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mS+4oSX6sA2wanawqw869T2s8SMMzRHR1GaF/+PQg58=; b=EtH4wt8siUGcOTWQRGZRNVBUOBOZkzOE+qoJk5trJBMwZjXGEwr40mNQHLRrRmEQWZi3II OzG9RY4ByQDkEGYfLwBNqHfuT0YNfamStZErdCuFvU/asDCf+uloo9MzM0osyYuij81ohu tpBv5h3f70oKtIi+0zpDSmirbNbL0b8= X-AuditID: a67dfc5b-669ff7000002311f-e1-67d952d63e8c Message-ID: Date: Tue, 18 Mar 2025 20:02:46 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: kernel_team@skhynix.com, Joshua Hahn , harry.yoo@oracle.com, ying.huang@linux.alibaba.com, gregkh@linuxfoundation.org, rakie.kim@sk.com, akpm@linux-foundation.org, rafael@kernel.org, lenb@kernel.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: Re: [PATCH 2/2 v6] mm/mempolicy: Don't create weight sysfs for memoryless nodes Content-Language: ko To: Yunjeong Mun , Gregory Price References: <20250318080246.1058-1-yunjeong.mun@sk.com> From: Honggyu Kim In-Reply-To: <20250318080246.1058-1-yunjeong.mun@sk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsXC9ZZnke71oJvpBgueM1rMWb+GzWL61AuM FiduNrJZ/Lx7nN2iefF6NovVm3wt7i97xmJxu/8cq8WqhdfYLI5vncduse8iUMPOh2/ZLJbv 62e0uLxrDpvFvTX/WS3mfpnKbLF6TYaDoMfhN++ZPXbOusvu0d12md2j5chbVo/Fe14yeWxa 1cnmsenTJHaPEzN+s3jsfGjpsbBhKrPH/rlr2D3OXazw+Pj0FovH501yAXxRXDYpqTmZZalF +nYJXBkTX79iKVggXrFpzhT2BsYvgl2MnBwSAiYS/e+b2WDsy3t7GUFsXgFLiQ+n17CC2CwC qhL/H65nhYgLSpyc+YQFxBYVkJe4f2sGexcjFwezwBlmid2tX8CahQWiJHa++ssEYjMLiEjM 7mxjBrFFBDwlDh/8C9YsJGAucfF5AzuIzSagJnHl5SSwek4BC4klR++zQvSaSXRt7WKEsOUl mrfOZgZZJiFwjV2i5d92qKslJQ6uuMEygVFwFpIDZyHZPQvJrFlIZi1gZFnFKJSZV5abmJlj opdRmZdZoZecn7uJERjHy2r/RO9g/HQh+BCjAAejEg+vATC+hVgTy4orcw8xSnAwK4nwuj+5 ni7Em5JYWZValB9fVJqTWnyIUZqDRUmc1+hbeYqQQHpiSWp2ampBahFMlomDU6qBUe96f0z5 jBNrL5U03f8263Tpjvj7Rn9Xur6c97DfN3Cv+6Rtz3b+Ttrf9MXDwzSI6ZWzc/3uTQc4wjZa nghWLfX/suRa3/XGkGdnzhl/EL2/4OhbkdrI8zzhf92KN1dE75gzoUZo9g6H9sgXMnvm1Iva bd3y/kfVrRPiGfbWsp3y8odiwr9blimxFGckGmoxFxUnAgBFxw0b3wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsXCNUNLT/da0M10g+WnjC3mrF/DZjF96gVG ixM3G9ksft49zm7RvHg9m8XqTb4W95c9Y7G43X+O1WLVwmtsFse3zmO32HcRqOHw3JOsFjsf vmWzWL6vn9Hi8q45bBb31vxntZj7ZSqzxaFrz1ktVq/JsPi9bQWbg4jH4TfvmT12zrrL7tHd dpndo+XIW1aPxXteMnlsWtXJ5rHp0yR2jxMzfrN47Hxo6bGwYSqzx/65a9g9zl2s8Pj49BaL x7fbHh6LX3xg8vi8SS5AIIrLJiU1J7MstUjfLoErY+LrVywFC8QrNs2Zwt7A+EWwi5GTQ0LA ROLy3l5GEJtXwFLiw+k1rCA2i4CqxP+H61kh4oISJ2c+YQGxRQXkJe7fmsHexcjFwSxwhlli d+sXsGZhgSiJna/+MoHYzAIiErM725hBbBEBT4nDB/+CNQsJmEtcfN7ADmKzCahJXHk5Caye U8BCYsnR+6wQvWYSXVu7GCFseYnmrbOZJzDyzUJyxywkK2YhaZmFpGUBI8sqRpHMvLLcxMwc U73i7IzKvMwKveT83E2MwIhdVvtn4g7GL5fdDzEKcDAq8fAaACNZiDWxrLgy9xCjBAezkgiv +5Pr6UK8KYmVValF+fFFpTmpxYcYpTlYlMR5vcJTE4QE0hNLUrNTUwtSi2CyTBycUg2Mfquv Jskb12hlVDY/OszEN8dVcvq0f20cczJCl509cWH7x7iu2DfzQzY5zt/x143p7qJ1d40nF899 cYvv1LwjVhmZDltt7c59uOJ381aB6I55KZXS1g/vrHs8Of30G+Xgus6wp4EtzwTzv3GEqFsW rCxL6DgkdbR7gsEboUKv4GUO0RPE/dZpKLEUZyQaajEXFScCAHLK5+nUAgAA X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 7DC2E160039 X-Rspamd-Server: rspam05 X-Stat-Signature: 5d88bnzq4ty7rx9niz4retfboji5fdno X-HE-Tag: 1742295769-790433 X-HE-Meta: U2FsdGVkX1++7/zCM9LVTgvwv2L920FeeNU6MidvvRjXJlLKwACxs6zLxtpWZ8OC8eQAVbtDvn51tNJh/lQGR1krnNJvtftK47T7mn5SbOttHAnojKHN96G4AsshKsjnpRS5dMNW0jBf824pPimO26lyaAW84T1D4fxhVxthDD7kjfNEOowKJ/GrnQx+YlaQvWujPWlLCql7olpEX2Y2OR3ok4SeCQWKpeJhjnXOwIbQmrRwS5/F8WtgtJvr0Q1sFV79PPeiYHtkOON+cp/R6LQooU7Yttv2y0ONMMX28/U6CrfQf3ipJEY27qD93s3Ajnr8pD6t2o1nf/LfyvKJcW/u8GRWL1LqyagN5uRTCbwCGsRbiQLMQi+2pNM6N0aWsVg7LTLmKmXUfJkBm1R1O7Kf79a69GEuLf5U4jXP2tZREV+N5vFomzY9GVA0OIlfzqHEHuVjlIFj1QYvD2sQIsC7nQBoveEGlmHyiys4tkcXHYD9upb/9J7Oc9jZ5/ekZFsDnUSeqpJbqeH1jzcowYsR2mlB7SW2L1S8yDKSHVxsN/7H4Dpj464GppYA4DpPrvjgRKVRrLwqR74gLed6sVJXcTWWYY14sr2VUpIpfMfitfbDQyKr9/SEHjtPp3nVEmRuzuLRXAfJGUfntK3ulEdHZ/j32cI9njUdzVDVsHG9qBOIEmmNR8lIW/0X+XQR75SeFDGUR3dVvJXVcwcC3315+zXAfs7EdT3ExsSLoQAOVpqUcLz7DV7eN+PdG6M2aJTF44C9AVlV903ixkLcvsawyRKZqmHfEBMM87aIbGfxT8yVIRVMr1uwQv9nrYMZ7xshuQzDxIHN93mRA8NQAi6Vkynd4zC3lPj5tEbtTaBQOIpLFn8YKcjjeMA46CM+41OYjUcy6l+RqTQWMZr3/hHSlJUpHR8prWyssFVdihe7fp4n1u7S3OuTg9xTZdqEJ++TwFFUevIQUDht5HE +2BvtNEc QxQGgcKyd6W+JeO6C7LJB1T9E0C8ki7H+rDznDjU6lascwc4UHOevNv4AidLQv9prvuZEdxG6euasZFXCT9aIW/kCMuT55KVHrpX0VXdsV6Y22wg28LUre15hmki8DQq23ll1U+lGXW/20U5yirQ5Mty4afook5hW+VhqLIjbA1K7T88= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/18/2025 5:02 PM, Yunjeong Mun wrote: > Hi Gregory, I have one more question below. > > On Tue, 11 Mar 2025 00:42:49 -0400 Gregory Price wrote: >> On Tue, Mar 11, 2025 at 01:02:07PM +0900, Yunjeong Mun wrote: >> >> forenote - Hi Andrew, please hold off on the auto-configuration patch >> for now, the sk group has identified a hotplug issue we need to work out >> and we'll likely need to merge these two patch set together. I really >> appreciate your patience with this feature. >> >>> Hi Gregory, >>> >>> In my understanding, the reason we are seeing 12 NUMA node is because >>> it loops through node_states[N_POSSIBLE] and its value is 4095 (twelves ones) >>> in the code [1] below: >>> >> ... snip ... >> >> Appreciated, so yes this confirms what i thought was going on. There's >> 4 host bridges, 2 devices on each host bridge, and an extra CFMWS per >> socket that is intended to interleave across the host bridges. >> > > Thanks for confirm. Honggyu represented it as a tree sturcture: > rootport/ > ├── socket0 > │   ├── cross-host-bridge0 -> SRAT && CEDT (interleave on) --> NODE 2 > │   │   ├── host-bridge0 -> CEDT > │   │   │   ├── cxl0 -> CEDT > │   │   │   └── cxl1-> CEDT > │   │   └── host-bridge1 -> CEDT > │   │   ├── cxl2 -> CEDT > │   │   └── cxl3 -> CEDT > │   └── dram0 -> SRAT ---------------------------------------> NODE 0 > └── socket1 > ├── cross-host-bridge1 -> SRAT && CEDT (interleave on)---> NODE 3 > │   ├── host-bridge2 -> CEDT > │   │   ├── cxl4 -> CEDT > │   │   └── cxl5 -> CEDT > │   └── host-bridge3 -> CEDT > │   ├── cxl6 -> CEDT > │   └── cxl7 -> CEDT > └── dram1 -> SRAT ---------------------------------------> NODE 1 Some simple corrections here. host-bridge{0-3} above aren't detected from CEDT. The corrected structure is as follows. rootport/ ├── socket0 │ ├── cross-host-bridge0 -> SRAT && CEDT (interleave on) --> NODE 2 │ │ ├── host-bridge0 │ │ │ ├── cxl0 -> CEDT │ │ │ └── cxl1-> CEDT │ │ └── host-bridge1 │ │ ├── cxl2 -> CEDT │ │ └── cxl3 -> CEDT │ └── dram0 -> SRAT ---------------------------------------> NODE 0 └── socket1 ├── cross-host-bridge1 -> SRAT && CEDT (interleave on)---> NODE 3 │ ├── host-bridge2 │ │ ├── cxl4 -> CEDT │ │ └── cxl5 -> CEDT │ └── host-bridge3 │ ├── cxl6 -> CEDT │ └── cxl7 -> CEDT └── dram1 -> SRAT ---------------------------------------> NODE 1 Thanks, Honggyu