From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B922C021B5 for ; Fri, 21 Feb 2025 18:15:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD2E628000F; Fri, 21 Feb 2025 13:14:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C830328000B; Fri, 21 Feb 2025 13:14:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B49F628000F; Fri, 21 Feb 2025 13:14:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 97AAC28000B for ; Fri, 21 Feb 2025 13:14:59 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 11B1681D82 for ; Fri, 21 Feb 2025 18:14:59 +0000 (UTC) X-FDA: 83144753118.27.2E37B7B Received: from out-185.mta1.migadu.com (out-185.mta1.migadu.com [95.215.58.185]) by imf08.hostedemail.com (Postfix) with ESMTP id 0A698160008 for ; Fri, 21 Feb 2025 18:14:56 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BlR9uFS0; spf=pass (imf08.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740161697; a=rsa-sha256; cv=none; b=AiC/fUjNab+8Q0LHFMocSxxP3DcbEt+5uiQw5soPg+eQyi4j/wEw+v4L93bYH1nXCffXA6 0raGQYaIZ8BZSVXaUAND9wAaTQVc7wbd0yCVQhmgE4DEgsLc955plV1sR481mkjebPE7M0 9oq/B08qmOyhS9Whnne/wS8jhVOv3/8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BlR9uFS0; spf=pass (imf08.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740161697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NWj3nEIXIzXvDvRcJsnu7wuSwT8d2VWs1fuwJH3BtHE=; b=y/ZZszvZHRYrCdq5pPsVR6wtpJDyg71Y6djnKrz8P2X3p2gVQ4HMAjgSOulPD1fShkCy6d JQtmGx7c53qkRltiZ8FHssGVzvCh6U+AjdN4oMUu0SX7Wq+gBcp8VLBHOeltDNxaOodn4x hciA2ELaZP0bS/ikiTI2YYOZdc0cfQg= Date: Fri, 21 Feb 2025 10:14:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740161695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NWj3nEIXIzXvDvRcJsnu7wuSwT8d2VWs1fuwJH3BtHE=; b=BlR9uFS0GeOlZTJ8/hGj7f0ehH1tSBEtAMedhUbljeHOgoglPaBjpsiOhF/R4/Oo7EcrL9 LoBgcKIgBsWi+cpgdhNekiStLN671hblyti0dn8hKJGDsC/TxpNSpCEVRdEvKZlrTNKSMn 5UW3RKzDdJO60sBWVh435uJ5vd39kZQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: JP Kobryn Cc: tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 05/11] cgroup: separate rstat for bpf cgroups Message-ID: References: <20250218031448.46951-1-inwardvessel@gmail.com> <20250218031448.46951-6-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218031448.46951-6-inwardvessel@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 0A698160008 X-Stat-Signature: w16e98y3p9ngtkimtoc316o7tfiff4j4 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740161696-33628 X-HE-Meta: U2FsdGVkX1+WiH4/iOskcfppUm4b+GS8mM/3OnkRMcUzvkELyZ/spkJlZp6V9gtn8cc+VNQv+2o8N0MU3fTgwcqqpKf24xedGaL3CvzRc3whfMM+yofhzoIRdYdFSGdFa3usWpV6CtDYo0GfYq9/n0cSKiNpCI8/5F2YdMpPevt+5/rvU7dqTBdE2liBTOp+FVJHt4tyw/lx5Gke8hOMOKxdCOpiDjvQlCSEC9iV5LHzEevM/xWR8UkaE0KvFy2bpxQyVql4852CgkEZTikFZ2D6e1hIIH/IGq2SaLnE2PcjuvfHawnizxRg+7nn+GGOA1A0cGkHn/5nlEB1z9QyR1sdUJKCi2m57yEf3ZNb8AE3Btx8fs5A0jSzF60b5VAH65IMxAHH4JFF/vEixfJNyyuILnWyIpXfUCAtJIUM4yHyxfzrXfZg9V1Q1XcpkG1F/HKRcK9tJc9i/9ZCGvLSyvaOl8/jxtgeBu6wsq93M9+UmWH08veOS6epF5QeyVS1uQFPrAeQf4TghrjM+MfAfxX8+0zPrk33daepDtdaos07MsNGB94Fu+lSRKkgx3YvzOHgPpEe1esVolyJTJXds0o3o5zyL2O4qT5KAytthq6124owzVjQWEyYIkaAV8KA/7vZoUC/KDEQH9P1imZR1zMkUyP84bXcICJtklygRcYjyk5GP7k4+jmML7HUX/wDCZQ/Cr4qTFU9iUllYpjS6Lvz0JowBI/X9gOeKH4UzmUkLuVqwPmQWk1e1r5/H7QZ5rInWgRj4e/62J63/ooHefi9Ipu3Hn8iPp1o8tOf+z7YtFQle7C5CHjS0nuvL/bJXu+K/b0XKqg3zkHH4LvNto6hF2Lj+7wRperhyCJp31ISIbObrEBfpKowz9hVQGWScGGStnw3RUVcdqq9E2LaghunojHcjE+XWSJMpY5sWPvAff7Z5igA2rwFmNxw2sVA2osGZUmTHBTIxWVd/mK CaFho3yS rmKM9TmtdvlBOfSgXOAQdxwxk26XrYsWP6t4mrhWlIrW4MWmIeduLF0eikcvtNPiBLpsBmLee3KEXd+GQNvkdHIp4C7vvK2Q0nOz5CjGk4PXC5YbAaSf6eC1slJbTmax+negITBEjFKFQT5tM2GNu/I0PdShnskvCvzj1OeCgFyBjN0dEGBUiVf3HQWUj3QqXY3EuZIeX98bk8hs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 07:14:42PM -0800, JP Kobryn wrote: > The processing of bpf cgroup stats is tied to the rstat actions of other > subsystems. Make changes to have them updated/flushed independently. > Give the cgroup_bpf struct its own cgroup_rstat instance and define a > new cgroup_rstat_ops instance specifically for the cgroup_bpf. Then > replace the kfunc status of the existing updated/flush api calls with > non-kfunc status. As an alternative, create new updated/flush kfuncs > specifically for bpf cgroups. In these new kfuncs, make use of the > bpf-specific rstat ops to plumb back in to the existing rstat routines. > Where applicable, use pre-processor conditionals to define bpf rstat > related stuff. > > Signed-off-by: JP Kobryn Since we deicided to keep bpf with the base stats, this patch will go away.