Re: [PATCH 1/2] mm: always call rmap_walk() on locked folios

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

On Thu, Sep 18, 2025 at 10:45:21PM -0700, Lokesh Gidra wrote:
> On Thu, Sep 18, 2025 at 4:57 AM Lorenzo Stoakes
> <lorenzo.stoakes@oracle.com> wrote:
> >
> > On Wed, Sep 17, 2025 at 10:51:34PM -0700, Lokesh Gidra wrote:
> > > Guarantee that rmap_walk() is called on locked folios so that threads
> > > changing folio->mapping and folio->index for non-KSM anon folios can
> > > serialize on fine-grained folio lock rather than anon_vma lock. Other
> > > folio types are already always locked before rmap_walk().
> >
> > Be good to explain why you're doing certain things, like adding the folio
> > lock to kill_procs_now().
>
> Agreed! I'll add in the next version.

Hi Lokesh,

I realise this was trivial, but it triggered me to hold off on further review on
the basis you'd send another version.

Are you actually planning to do so? As it seems set to merge without me having
completed my review.

I'll try to get to reviewing the rest of this, I just happened to have a look
and wondered why my tags weren't there...

You may as well hold off until I finish review anyway.

Thanks, Lorenzo