From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3636C47DB3 for ; Tue, 30 Jan 2024 03:13:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 532E76B00A7; Mon, 29 Jan 2024 22:13:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E3136B00A8; Mon, 29 Jan 2024 22:13:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D1B46B00C1; Mon, 29 Jan 2024 22:13:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2DF686B00A7 for ; Mon, 29 Jan 2024 22:13:26 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F09F81606DD for ; Tue, 30 Jan 2024 03:13:25 +0000 (UTC) X-FDA: 81734506770.01.830A30E Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by imf02.hostedemail.com (Postfix) with ESMTP id 63EF380011 for ; Tue, 30 Jan 2024 03:13:23 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="lLZWlv/P"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf02.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706584404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gz/0DrxSnC6UsvfwPyk9OxqtFLi7qctjiAyBJL30GqU=; b=4+fxwFGZUtTgZ4lYS14t0r9pyddfjZmyFM9W2GyfKnVQorDz/FEz2NiTCIafa6yW7a6/5z Tr3199LGkDOe205+0tM6+Lth/vbJXLd6onK4acsKHriPd/dGVJ8hcb7bhKbkFVa2QhKEC7 sx3YLZUBT0CkrePTI0yHjoNI/HtbSC4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="lLZWlv/P"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf02.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706584404; a=rsa-sha256; cv=none; b=IrCutAq/I8XFJnCeYvWeAfIIbsjOX+3rAQO2BQt4rIwVM+uBFUU9NWgAJ4k2MNBEGHIoyM 8weCWwOdYVKPPcVdmQqclLnuz/w2U1fpLs9ztcUvSEQzIa2vgSHk4V5RtY6vis9cRj5D5e ykavTVTyLshRV5wl5nPMxuWahvTlG7E= Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-21432e87455so2271103fac.1 for ; Mon, 29 Jan 2024 19:13:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1706584402; x=1707189202; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gz/0DrxSnC6UsvfwPyk9OxqtFLi7qctjiAyBJL30GqU=; b=lLZWlv/PawzBkYsCi5W8xgPb9bLMlX5Q+0u1lpJGIh8k0TLt3UXctrFMZOWgx41s7e B/K1x97BQImPFQBxQAjWbvDzoXLKM28gzgbOS94q1uyd37BBc9RTCW4yMRbTNg2WOFGX sMuUvpQlxs1DsAIHRW2jSDPn7GQ/cS1mJiwpg9yMRgakGINgUt5d1tg2f8+2+WJxHpU+ dABc17BOALfdyIwQV7T/zrm3MKVvYL6vVlKKX5QRpeJo2Nl5kOiMRGNc/Ely9siVxu1H EczUo9RYPh/8OYpnHwJSeuCb8vdgeTEl3CjYTi2tWl6cf3YHQB35i4i6EltoeltvuTBa 8McQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706584402; x=1707189202; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gz/0DrxSnC6UsvfwPyk9OxqtFLi7qctjiAyBJL30GqU=; b=W6IeueVJLWPY9pfoCedLdz0/DOtOkqYVVLroqzaxDiQcVsItt/JEiPfkWn+MUuxhj/ wEkbV6dCjAz5MTIZSWcEr5WEhwaV0WPDNoeeyMSD+gSxMD6fbWcsrwKJDOY3cAXsmzM0 IWZuPj2hYtvzgrWL+Bq99I9mWi/O0DXgnEtLUegxz3PBEZ8umN3ramPsS/i6HEzSipMU rEEBP0gsZCUDEhgaiQM2/M44MUvVIZ28y4368zUF2LCTvC7uxCNFBQ9KQZ3OJyTIpCgw WrBPmzeYaiFRS2Este8YsSLsMpFGP0Q6LtMphjljLPPCfAYKkibf2r2zvoDnDo0UVUdS 5oSQ== X-Gm-Message-State: AOJu0YyIfncHfn7sBx2UGpPBdl3qpZnXT11UhefUsvsZC4LFGgLSPRGX o0i88i1bB7polSJ9eajmrNd9RBxcisomwYwAPr4RhDptboaBonVnu3BxwAjsC5U= X-Google-Smtp-Source: AGHT+IHePOoINh/isj1RRshS5OzhsNd/kKBlxk9k2lL8yiMZokgQzFyLIJdUArbanQO+uNV1UInNpA== X-Received: by 2002:a05:6358:ed05:b0:178:7a67:addd with SMTP id hy5-20020a056358ed0500b001787a67adddmr2111816rwb.58.1706584402359; Mon, 29 Jan 2024 19:13:22 -0800 (PST) Received: from [10.4.207.234] ([139.177.225.234]) by smtp.gmail.com with ESMTPSA id d10-20020a63fd0a000000b005cf450e91d2sm7036824pgh.52.2024.01.29.19.13.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 19:13:21 -0800 (PST) Message-ID: Date: Tue, 30 Jan 2024 11:13:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/20] mm: zswap: rename zswap_free_entry to zswap_entry_free Content-Language: en-US To: Johannes Weiner , Andrew Morton Cc: Nhat Pham , Yosry Ahmed , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-2-hannes@cmpxchg.org> From: Chengming Zhou In-Reply-To: <20240130014208.565554-2-hannes@cmpxchg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 63EF380011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: k9kbiu6otmfnduc1mciskdcthwyqw1f7 X-HE-Tag: 1706584403-410434 X-HE-Meta: U2FsdGVkX1+j4vuXxg91unQNdOTKUZ9mhkq5AfWStO/H5sMUTJ78BHvHEOUBpcSc0gx8kfBzNV+eX8HxHVw7FMDcvAEMoccM31e/aKzRSfJa23jpIjHOCyPvtjkgqRu8L408TWrf2aLqsqidn4fxeAqWfxTJDZbTWE71o4yRYQtPRIQR60gzHAQQvyza5W2QlJI7mCreuiRxIOIT4ttdIKoNB+l51Khj9dAphxUu8iVGwwfiM2+D2eVbwqqH79VUCoCZhuxQd37DxCPzGqoemjrTwgN6TTLnrjmX8JME2ZAqhuANdcAVSDQ3K4ZLBeKCKfwKs3nlTONAu5g49wI//TIjRt8b+mf5oekCkgcJr/wP+qyjR7DrhGbrucpiKTug6PJ0aEir7skaQI50MU2vfJzW8QoBaWtOFmszqI2CgHgt9QSwgQo90o8/JGhF7ZMm+no7UDMuYTfxVSrVVhtqU0CGR4PgB3UWe7f86iNML7bTEUA3FM3JljBhzlALj7o9xefybk1/NWzt9RoMI473sGINK4hFcLlEljHUxveQK+kWVhhnuIqUBONbW6Ec+0R/u0BUQVZ8+1etlFuzkSiGwzYJdcvbXsqYcxHlRBJl86KJukP2imYn2c4CDwHGYThyewgoCz5w5ZIecox2n/cgZvTq9OgSp5ICX0wlAmXkaT/QcMhQHnnAfLpHP5Hc+3bTm+IJXjC2NJzND1Wn8mPzj8HXN36t46o2IHL9EAmQx/f4j/WUMd9QfpNwgMqtiLDTG0qX7ERHzWNO4r3cTrIKfGSivlA0l+IfBb664VTW/07amydAc/DIoLYE7gPsUvsp0ULA8/lML/L8Fjz4hl3RR0vMLVCFF8n2CE8NSbx87ggX4hUH1LN7XFCuZInS+dqNjyhPYJuVRV1viiqE/Lnr5qCzm8VlCTeMv3snUnOZRxyG89c0D+StyEj8snzvyg1nJEQ1oEbi/CZdu1I0oud FVU3isG0 OCT10Msghv5c48rlH2F92eS9wJyZ0hZaTMilbsY8S3B454ShImUFLdkNPUIpy5zT8ugpTqQIemNaJjKE5iuAL8LAA1wEUSE9HO9GeIsPFOPLCmZf7mb3Tn396Z7GtFrh0CvtK7frIvjJb018KIJ2ykC2BBzftVNapP/CUvVGb36x+ytM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/30 09:36, Johannes Weiner wrote: > There is a zswap_entry_ namespace with multiple functions already. Another is zswap_invalidate_entry(), maybe zswap_entry_invalidate is better. > > Signed-off-by: Johannes Weiner > --- > mm/zswap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 7f88b3a77e4a..173f2e6657de 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -520,7 +520,7 @@ static struct zpool *zswap_find_zpool(struct zswap_entry *entry) > * Carries out the common pattern of freeing and entry's zpool allocation, > * freeing the entry itself, and decrementing the number of stored pages. > */ > -static void zswap_free_entry(struct zswap_entry *entry) > +static void zswap_entry_free(struct zswap_entry *entry) > { > if (!entry->length) > atomic_dec(&zswap_same_filled_pages); > @@ -555,7 +555,7 @@ static void zswap_entry_put(struct zswap_entry *entry) > WARN_ON_ONCE(refcount < 0); > if (refcount == 0) { > WARN_ON_ONCE(!RB_EMPTY_NODE(&entry->rbnode)); > - zswap_free_entry(entry); > + zswap_entry_free(entry); > } > } >