From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD366D1CA0E for ; Tue, 5 Nov 2024 01:56:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 228696B0098; Mon, 4 Nov 2024 20:56:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D85A6B0099; Mon, 4 Nov 2024 20:56:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A0316B009A; Mon, 4 Nov 2024 20:56:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DE8286B0098 for ; Mon, 4 Nov 2024 20:56:10 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8EA911A0CE7 for ; Tue, 5 Nov 2024 01:56:10 +0000 (UTC) X-FDA: 82750375764.28.D25EEF0 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf11.hostedemail.com (Postfix) with ESMTP id 87A1C40019 for ; Tue, 5 Nov 2024 01:55:28 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="uD/fBj5W"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730771601; a=rsa-sha256; cv=none; b=NJl5RnrJHWo1y7iV5gUzWof0znL9uJV4//42YkevD/HnmhcleLnlNZ9pMH4borOf2DrvXM ut36lFIGBMTeErwo1CkG2WO6u6Cfp6a7DpHOmJkKuFlgs/1MMRRdYzmMTmzTkAKxDzoFH2 a6aTEUPd3r1hNxby675ClZC2i9t7z5k= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="uD/fBj5W"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730771601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+ynilCnkI72Wptbd9knjb2x8bDuE0N5pLnbO7dKEnNA=; b=GMLk1qsognavxSm8nF8sGxu+Bo43CmI1pmvERX2Uqi+8q/F7m5MhGWG/E/br57EaPg1AqR /mIsahI7YfulChvljFJr4viUSVEo4NBFXy0yFhOvLTE2FKnBfdPKJNZDxCp9VIaM9aCdex eL2cv9q5CoIU8u5rGrVA4gAN2JKGwmg= Date: Mon, 4 Nov 2024 17:55:59 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730771765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+ynilCnkI72Wptbd9knjb2x8bDuE0N5pLnbO7dKEnNA=; b=uD/fBj5WpHLwCIORWAlFJqD4BYOVPqHX8O1mZS2HBi7QunzKb1kwkXaCMildUG8CQNPesZ tN/BZhfx1oQqOh00/xslKKq+QkAhObG6GRGhO9GOpN2BmMU/FwybhXCMa77I0OjBxlcHEP aA+UjNYZJfrQyZRh1qDM3Oqhy/vUc4g= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Keren Sun Cc: akpm@linux-foundation.org, roman.gushchin@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] mm: fix quoted strings spliting across lines Message-ID: References: <20241104222737.298130-1-kerensun@google.com> <20241104222737.298130-2-kerensun@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241104222737.298130-2-kerensun@google.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: haz9hayig63sx4ygmrhy4yo7sjnijueh X-Rspamd-Queue-Id: 87A1C40019 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1730771728-6252 X-HE-Meta: U2FsdGVkX1/NJmq4buzjjyeQT4JFaHiOtnLmyhxUV9uC3SiFCNEoVxNGum0yhoC8ujdwdPbNl7GE+GexH9iw/0yirzSBy8vfr+gSLqrhaXknf2Gk6HJtmCqOmz5kgjKwMQid30ZccANf3xKcq1nSpkTjH5/gJlKV2xaanHvp1543ad+wGEhf1Iw8NcrR6zCzORxDO0yzgYjp3jk3W5x2H9C5fBrMXnySRPYX3XJRNofo/e01XFS3vOTfWsmF+qSXMpGPp4Y1Mhzr72o8JJeY5fs8fZXnYuwQ2c36A34zXZs2/d9QlI9fxWq6ZJZeEGtQxMR6b9srS+YcNTQYPkahWwDaOVisLD9/Qbz7/S2qMI80uUMgH+e78mrOTAOVrCvX2V7vGGboy12LkytryBzVXZqKn9MuplIQE+U1BddCmXST/e543Wv5WVAHMK9BzfiPbgeCe6tRMxYwk2BehcapRFAd+lMdj2EKoqFBGdxpL+/P7s+JOLqNAZioVFOHeGwL1Ch7dxDBEnF/gv0gvM7o27W3o6qiD5vsRrN1nNIfA4lmBaATi9B4xe7uHFquFQ3Zmng+ruAfav4YwP+lRcxEoeTOTCjynxlHljxc25zAouwmTROlyJ1n3/TAxtLPF9TYT0wY0uXSVFlV9+C+mX1dLPODcAMUxWaZ0KDd1kTmuS7d1t2h4XnxsreQGnZIAo2MuTJq8E6D7iLX+QRnSIeFk3pURlc8lhz+wR11oHbtvx+jB6MNE3+wXrdVp6uYs8fD1PUAIInWUZIKrpgqFLiAQxwG+x29zInNbWmsbN54tya6AhBVqCfIgne6JbpVQ/New8xfpvmT81gXpO8Vj5BQVLq+ytKDXQyfCIGLxzn5WO+EkPKdq6w9VLkrv5akhh9myGXxq9aEF/9pHk1sgk7LJIWIhtXLQWA1Bw+B89xLjDQNq+XKqPyP3+oZ1xpn8MNx3aPYips6uyS1pUpoOj+ 6lkwfYMl P9qfhBWnOzP6+1Wls3ltIFdumqUA9K6K0TKzKIlGzcPvrzDWMZ1Ahjf5IDQfGkkbsS+T9heOs7Y9V+meEyQVzTfxIyJlUYVmpdhuUbuaPawuCLXZsaBYuuqufhH/eKDXS6rpe7rVG4RUm+d9jXVZzbAAt1hLlnnzJpiO9yOGXd0BxNRw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 04, 2024 at 02:27:34PM -0800, Keren Sun wrote: > This patch fixes quoted strings splitting across lines in > pr_warn_once() by putting them into one line. > > Signed-off-by: Keren Sun Other patches seems fine but personally I don't like this patch. I would prefer a multi line string over a very long single line of string.