From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C3B1C07E8E for ; Wed, 24 Apr 2024 03:49:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10C9F6B01F6; Tue, 23 Apr 2024 23:49:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BDA26B01F8; Tue, 23 Apr 2024 23:49:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC7B06B01F9; Tue, 23 Apr 2024 23:49:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CD7106B01F6 for ; Tue, 23 Apr 2024 23:49:16 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4AD9C401F9 for ; Wed, 24 Apr 2024 03:49:16 +0000 (UTC) X-FDA: 82043045112.26.3F56EC3 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by imf19.hostedemail.com (Postfix) with ESMTP id 2D4531A0005 for ; Wed, 24 Apr 2024 03:49:13 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ALyi8zv6; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713930554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZvxFBpP6Srhkt4fBNm1R3664oVz/K43/BSO9nAVF7Rw=; b=Y4ZHLozA61znraXRqIdUnszr5PfRFIvyp4kGeW6MzCD8+zLcYJSAZNeSnrfHPpJ1/t6PR7 vJBaD8JvB0cMx+1AeQWaPIvsTNoQ2DwhBhLr9xY6B15AKaklHGGRGf92B43Hz7pPApk4z/ JvWlYg25VoWyZMwBYNU4vTexXe95/wQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ALyi8zv6; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713930554; a=rsa-sha256; cv=none; b=CR35vMap8hZ1Vt2JtTTSDtOevoX+Nq8KbuamwNDliswCcyPrZVYgPo8biTWAbCqw4w5M7E Znrmtv1a2KViA/JRlGmMs9/CVrgN1bsO1M3VUlbo+zZ9u5SB07zx7wLOd15jcuEwQ55oib re3Gf9y7bWcSRB5zXl6EbaGh4RnJsJU= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1713930551; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=ZvxFBpP6Srhkt4fBNm1R3664oVz/K43/BSO9nAVF7Rw=; b=ALyi8zv6WGpL6MiZ04cRVHjzMGNBFWOOJe+BO6EgRHWPan0PkPGD3TaXgNAjA9eVI3ttrf7puZGu9WlX1ifRtdCIw9cY8gewlz0NdyskaMhh7g/hcmkzGB/nWV0rVFqzmyWFkdfDvVhj9JYy7V8X/bEZi5TjiVrltZr8GNyBaMI= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033022160150;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0W5AlpPx_1713930506; Received: from 30.97.56.58(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W5AlpPx_1713930506) by smtp.aliyun-inc.com; Wed, 24 Apr 2024 11:49:09 +0800 Message-ID: Date: Wed, 24 Apr 2024 11:49:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 5/5] mm: shmem: add anonymous share mTHP counters To: Lance Yang Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, david@redhat.com, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, shy828301@gmail.com, wangkefeng.wang@huawei.com, willy@infradead.org, ying.huang@intel.com, ziy@nvidia.com References: <20240423094502.4080-1-ioworker0@gmail.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 2D4531A0005 X-Stat-Signature: fbg7hcnq9np9uysgxn1mrkebhz3ec4gg X-HE-Tag: 1713930553-869622 X-HE-Meta: U2FsdGVkX1+zJy38Po4+0GRN4FdEUGYnUCtm7xVaPUOQeaDYeSG8ZO/4w8ul2YdEjSCYjlenRdTuB9StiFT/pWB0v3rUuXBW3f33xdgryeujbW2gDiEsRhI7OJuZBiqxH6hAsZIouf0DhJoE/6e7ogjnOGl1wbeKVjGA/LzDK9jUG2wd2ab7CSIFnjnCDG29DigtdrtBRByxAoUcC7dM0y1B+D2Jv5Iw88e6I9qAJ59FReTuhA9piwna9B+TZ3ZTiNZXug0sJnNuCv6Nlk725xV6vgJq3ubLZbc4YuQWsb3480gO6O1sZs6eqtBRhS69EVBQkSShw6/AlvwQnK4+HFGkVJFjYAK22NRZ9qBIBPwlH3p03gURXPuYgXzRv2l9NJz+l2E/WnZEvMKZ+Z3Flbyo+aySHTYmeB5b/Se2sBsC0bt1Szhnrd6YsdEDCiv0622wcUks3v1ktR/WEIzG7lscMq2ch0Gue4t821oAfok+hJDL0BhG+8PlYO5DKQv7b+ghVnr4C6zlSx/lFZAoEET+/mMMpf+jOMUnJs2Q/Q3/gwe/pecH7dc7PCgxJHMtIeikBHx1rsAH7eGrocQc2lhxx//YIpKQ1NzMsA7u+/p+09eOigulOxR2zMtJrokYgLvP/C1aTVGkvT+OvNHXwUgHkGF3nTOa3O2B3cj64J4m47jMlQ4MAe7AL6gVtJ+YxAofSgcc15wdWBFe/PERXqIrMNyXG2muqIqfZCOOpM8xq5b6uA4D5k1gCXIfYRLlWk6wTTaFkkxBNCLxa8PboFWtRN9GhHAv/fOBOC83yEIIg1yXKk77AlZE/8fnZmKHDUe6kHQCU6KtBlTSNRGEjpzTSC9UL7E/h9xJBwBZVAajVYdd50Pu3vgebcZNL1HGtYuTcgCPMus6rtKIcoh6I2b0DcQTIQ+Jz/uGzxgjJJfqq2AuihB0R5ZtGSQ8rnqboSFs+ztlF2PcljjDt1S VJBj/Q/K OkyYgutVLLHhhsyaOMW/FITcJr9cUvkq2NUqQ4gPV9KMeaKzz7QWXuUWjrcjhZrsi7bscuawo5id+xFJdwNnUi6f+V5H2LZokUJ3+QH0Z5liaBgH0DA/451JPNIZ0I2LjA8FLZMSrYhx8sTv45fiZS+qeILOksCWceTVEmwKZWQvJIvv23VxTnr+DouECalC0mUsMLlKdfQLCx57x4ejfNhN5aXa9wwc/UuR8PaJmRp70LwFHDh8gJ8rqoY2cxL83DCqlDAOIjnkE/M+PbDJRDGxUnAdcZotvyiImtjIxZ8SbxOi4N4yvjvg6mbXwD1DXDgFpGaAraObYijvmUoCa6ig9fdV0J1S/4Cyx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/23 19:22, Lance Yang wrote: > On Tue, Apr 23, 2024 at 5:46 PM Lance Yang wrote: >> >> On 2024/4/23 09:17, Barry Song wrote: >> [...] >>>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >>>> index 26b6fa98d8ac..67b9c1acad31 100644 >>>> --- a/include/linux/huge_mm.h >>>> +++ b/include/linux/huge_mm.h >>>> @@ -270,6 +270,8 @@ enum mthp_stat_item { >>>> MTHP_STAT_ANON_SWPOUT, >>>> MTHP_STAT_ANON_SWPOUT_FALLBACK, >>>> MTHP_STAT_ANON_SWPIN_REFAULT, >>>> + MTHP_STAT_SHMEM_ANON_ALLOC, >>>> + MTHP_STAT_SHMEM_ANON_ALLOC_FALLBACK, > > Seems like you forgot to add the FILE_FALLBACK_CHARGE counter > in this patch :) > > IIUC, you've excluded the THP_FILE_FALLBACK_CHARGE counter > for PTE-mapped mTHP that size < PMD in patch3. Yes, will add in next version.