From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 807FFC5AE59 for ; Thu, 5 Jun 2025 20:26:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1779E6B00C2; Thu, 5 Jun 2025 16:26:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 129816B00C3; Thu, 5 Jun 2025 16:26:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F321A6B00D5; Thu, 5 Jun 2025 16:26:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D5B5D6B00C2 for ; Thu, 5 Jun 2025 16:26:22 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6EE8A14090D for ; Thu, 5 Jun 2025 20:26:22 +0000 (UTC) X-FDA: 83522479404.29.E9FCF1A Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf26.hostedemail.com (Postfix) with ESMTP id 5DB8414000C for ; Thu, 5 Jun 2025 20:26:20 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IDJ9o7wN; spf=pass (imf26.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749155180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ziYA5HNk/3b+C572WPNtkL1FIpx+25jD8CPAOz0v7y8=; b=a1LLk/wXi2I86XhMEJB0ssLjWq5HEDOC+tZAkSOXr6eK1a0RtIprB5zrUBCGgtz6rNVQiL I99M3eyakR96Ubcdt7jbZ93AeTzqOEbpzJB29rIFKJYVKQpfhARAjOE+8zukl41F79tArH PpaXuUf8+PhjsuscoMscUS7sHefOuvE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IDJ9o7wN; spf=pass (imf26.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749155180; a=rsa-sha256; cv=none; b=0ZFAi+8uHnXQaQpRd1dauBPw2CUXTJeSgV3X4ZDBaS+M2g5nAZT5tS4ve8FVohYaz+xAhn d+IMLdjU5+0j/OT3smrB/UEj5dSA4/m6bHBc4EI1qCfX3JCJnlPVdi9CFrpUj8EMLsek77 jeKNi89GW+YgUhs8fDjz0QYlCns2ovs= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-442e9c00bf4so11592545e9.3 for ; Thu, 05 Jun 2025 13:26:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749155179; x=1749759979; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ziYA5HNk/3b+C572WPNtkL1FIpx+25jD8CPAOz0v7y8=; b=IDJ9o7wN0X5IhfKKDsSUgGACsylEOyIBa+BWHRjbWLUSVtd4oWYDyQAWhJ0coLiJsH OmlqTne2ExMj9av5FVOJ/wBoZPvCIiAVFEP7qJNd4vNCu/yI+6AKdzfXR/+YC02TdqW9 qJ6MPsp4w39iUvpi4yg4HH1MVBJQTxCpCiFoQ+lif4RLbejhk/x8f302djmoqYwwe9eZ Tj+k5qR/6WQ2B0/fsOnLBycY0uKSjBaw2w9Ns1znokSE/IMV4M+uwPeL0S8/n9gqsoTx LvQXPGy1JTQSFsy53HtxeOilHjH/O+ztdE3q3JH8yhzDrOKRrH1Fv2di5GqWWUAAS0Oe ez2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749155179; x=1749759979; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ziYA5HNk/3b+C572WPNtkL1FIpx+25jD8CPAOz0v7y8=; b=lYBniM6UTMsvtg3fsWYkzbpPoc2eSaKAu2c+R4o6nJZL6HSEcMIwxIrIe1DBzStLdS 5PR5lfGWoDYhidcHOwW19PDL5ceirmqHk8t3moisTKgdXYXtZneWAudDX1B8+rgM49ve yMdZ4TVApvqOGN66XDuHZ2jwa81G22M/7NXkDTnauuzPH4EskV7YUqzAfSH8lTSSYxBJ yMLGCJpZWwZgbJ7Sa1mJw6GvmVZ8sM9/mxtY5sOt87nBJ8NepvRFCktgDtNT1t/6TF4y fiwCGOrDN5hRMAjC512E4v/c5FZmuIMBcMiokHGjulqYUAAQ3eRK9oTjZCicpfBkNedA G/5Q== X-Forwarded-Encrypted: i=1; AJvYcCV7HDZVoSqVTmYyCVkgEcLtqdHgYnEoMB0WNeMvVZu+boGWyQW1EuC0ZDYRc2Xqxv9ep7L+KQJWUQ==@kvack.org X-Gm-Message-State: AOJu0Yyb9lF5s6jsjEVfuEMZqzuy9vE3pu06GD40zbEGigt+dKFj6/7u qfn5zihzybnDr94cCsxOisrmbMhJgDKPfvnwuvp6Gm6NZqNAL6jgJ4Ih X-Gm-Gg: ASbGnctE1D7984MvDDWf/ceI2ntSzTjpOhExIqASL/V58xK6pKzQogncDNyw+HSu9at x4FG8leEklkEsEDl/UwEU/YzwZVG5LfGYgklVdNUU2PMCe7fdmf44Z+wYlEJNbeiwtRG5/1VbjI 5SfPqLvWqg8frYBb/qQHxVpDwFcGEvuVgcg+sgKLsIz1TZ7yQTBGtX7W7/QsVXqJbeAWgMC4pt9 N4MuKgt2lSuKgj3bh6V7iQ9VSZZrxbXkX2IL7mtnxPFYbNB+mqD7Tj6chcP25qHg1Y5W9d20HSk r7YvpY4u9jlZ6g85OoBZUkP7N9KN6ADRsTWZcnGGRU8Pp0GbzFWv6lojNFFnig== X-Google-Smtp-Source: AGHT+IEQKdgJ+yBlCmq313HWyJi8MKwe0ZhZefu46HwpijquuDpy56UFySftqQ0mr5S2uC/fiW9I5g== X-Received: by 2002:a05:600c:6749:b0:450:cc3d:6a03 with SMTP id 5b1f17b1804b1-452013fd6c0mr8637935e9.7.1749155178354; Thu, 05 Jun 2025 13:26:18 -0700 (PDT) Received: from [192.168.8.100] ([148.252.145.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a532464e7fsm133755f8f.96.2025.06.05.13.26.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 13:26:17 -0700 (PDT) Message-ID: Date: Thu, 5 Jun 2025 21:27:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v4 03/18] page_pool: use netmem alloc/put APIs in __page_pool_alloc_page_order() To: Mina Almasry Cc: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250604025246.61616-1-byungchul@sk.com> <20250604025246.61616-4-byungchul@sk.com> <29f2c375-65e3-4d22-8274-552653222f8d@gmail.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5DB8414000C X-Stat-Signature: sfgei7fzpfj681qnkcsaj4uep41pcf5g X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1749155180-356783 X-HE-Meta: U2FsdGVkX19pAfxr/MJ+hm7OmNxIEgEavktb8YtaVqc0tO9zSwzEEUiJnv3Iuwv/PrrU/6Lc+nDjslfgiK67cwDAOJ0PFZg1avIbgEP/9bD34SPK8CRXCqK5zY75cHh3CXBw5V+7AAA5lvDN0BlUiQKaJnuy7JpdZHw7XtGFNM3L9yq/Kp9OH9c/wnKQK5ImHLlQAeZdKta7otanri3TdKAgq6acJFq9RMptGL7+blmdTO2LfisfH1pLbUzwbLO8CVFRk8JyOcMBuLt9ZhF/OS8jHeacDPrnLeFW/h4ULSI6HI7tsw4Bpqtc8YSlIh5uaf2icOkoNdWFJyOGxOsV9F8GWgZSw9zw90FH9PH+x4PW+1kT2WDbMJtYuWtl4RRtDzsiQfZ/S/0H7jUxyMSfoDOYtotE5YQAM8UUIXEIj+zgqVEdtkXEXFPZRiHP9XaAW+EA9ZdiWG3yHj9v0qxGvZLM/88l0mLbMUTgrnJpccXzR+0rbBFFLYszIcYFDNP8u7di0/qcPBQmelSA60bQUHYeUyM3BS/X0cEQ0ivAatBKhuO3ZwjaqecH+6l4l/+5WstxfHMWfeBK7ESUgIxCiFZ+JPlcLIUrRu208VUGcgvfh5BI9H0tM9sS9Y7yTNFcq5uiixUfRE9dwrPy9cJ8tviMuTbcMg9/qMJB1sLmgoU9kEOMgrf2RGAwLjacG2saanTQkGR7KrGbJDXu3hA++6WtVt3WhWF+2lJWVuKuWXOAlVc2XRPDUZB4XJJVmGPPurMKa0cceDCkoFpIRB2cumz0vshrnSgNJpc30dxiZrVxmWgvrU7tsr6BD7xAm3GQOL5Q/2J3BEYtL+ZCv6QWMCv3OnMpJqzo/PJxy6fwWJ7GNYlwRIP9ZBJgDSEUKZyM1uleO2eXkdr2PPfPTukPzH1clBGf/3a40H/UX9yTjMTKAsDd4Bz8q/p0InKF2kpW2DjFEsIWMY5lhpV5LT4 iAhYVQiM MfJ148HP9rrLVYZnlZDeBK/E5kTxm1aW2STBB2QTqoOd2Y2X19j3U0hv1RYO0cm6taUWjhnxe/tFyw29OzkRllR5hU4npOB7+x2o06XU/6ijwtMCyL5df0PFY4FwAeD+SVjwEZJZR8KkU/tj85e19tfprweEbNFWGYfyRo4EF10zH1tlOcqGMsZRVY7mkLrc8ZsK+BjtMsBBayJvFohw2CSPgxk50bVvhkjl8K+djzXhAyq5J2n4Xj6k8D+AWWfGYod8j/F2KqCCJfnaLqT6q2HrL6sqHhCTl8hXxMEC6KZuajk8fiU1YCpED7WcIYP385qJIE6jKVnExcPfLxcgq7gFSCurPjsd7j1GkNtR4DJ8kEOUnyhyteqHrDvfi+hh6LJaBthflX6gnPWXDALRg9WgaQUpnTGGDO9TrdeAGXxQZmOnCg9DrqQ9diq54qOFgky6xSkKsw25Db+oa2LxcbWHnu39NAXuX/T2E2xF+RhYS+yK+xJOxNL3Bhs7KuWMiP0sW7U0HI1tX8cRlEevKngqFT7kyMMdaLEpiGy8inXVMOBiwRx/cGv4+WDCd0AXN5MvpscnSOZHxtZWo5U6jMrSnGOgKxMwxukUo/+3b8QxuiFHhW4V6GmZPr3lnH6QfDvSoIp3/dpLqq3D47DSsI9aC7UzL+oua+0HSOVlWm7jpzCtBR2YjttM5Bg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/5/25 20:39, Mina Almasry wrote: > On Thu, Jun 5, 2025 at 3:25 AM Pavel Begunkov wrote: >> >> On 6/4/25 03:52, Byungchul Park wrote: >>> Use netmem alloc/put APIs instead of page alloc/put APIs and make it >>> return netmem_ref instead of struct page * in >>> __page_pool_alloc_page_order(). >>> >>> Signed-off-by: Byungchul Park >>> Reviewed-by: Mina Almasry >>> --- >>> net/core/page_pool.c | 26 +++++++++++++------------- >>> 1 file changed, 13 insertions(+), 13 deletions(-) >>> >>> diff --git a/net/core/page_pool.c b/net/core/page_pool.c >>> index 4011eb305cee..523354f2db1c 100644 >>> --- a/net/core/page_pool.c >>> +++ b/net/core/page_pool.c >>> @@ -518,29 +518,29 @@ static bool page_pool_dma_map(struct page_pool *pool, netmem_ref netmem, gfp_t g >>> return false; >>> } >>> >>> -static struct page *__page_pool_alloc_page_order(struct page_pool *pool, >>> - gfp_t gfp) >>> +static netmem_ref __page_pool_alloc_page_order(struct page_pool *pool, >>> + gfp_t gfp) >>> { >>> - struct page *page; >>> + netmem_ref netmem; >>> >>> gfp |= __GFP_COMP; >>> - page = alloc_pages_node(pool->p.nid, gfp, pool->p.order); >>> - if (unlikely(!page)) >>> - return NULL; >>> + netmem = alloc_netmems_node(pool->p.nid, gfp, pool->p.order); >>> + if (unlikely(!netmem)) >>> + return 0; >>> >>> - if (pool->dma_map && unlikely(!page_pool_dma_map(pool, page_to_netmem(page), gfp))) { >>> - put_page(page); >>> - return NULL; >>> + if (pool->dma_map && unlikely(!page_pool_dma_map(pool, netmem, gfp))) { >>> + put_netmem(netmem); >> >> It's a bad idea to have {put,get}_netmem in page pool's code, it has a >> different semantics from what page pool expects for net_iov. I.e. >> instead of releasing the netmem and allowing it to be reallocated by >> page pool, put_netmem(niov) will drop a memory provider reference and >> leak the net_iov. Depending on implementation it might even underflow >> mp refs if a net_iov is ever passed here. >> > > Hmm, put_netmem (I hope) is designed and implemented to do the right > thing no matter what netmem you pass it (and it needs to, because we > can't predict what netmem will be passed to it): > > - For non-pp pages, it drops a page ref. > - For pp pages, it drops a pp ref. > - For non-pp net_iovs (devmem TX), it drops a net_iov ref (which for > devmem net_iovs is a binding ref) > - For pp net_iovs, it drops a niov->pp ref (the same for both iouring > and devmem). void put_netmem(netmem_ref netmem) { struct net_iov *niov; if (netmem_is_net_iov(netmem)) { niov = netmem_to_net_iov(netmem); if (net_is_devmem_iov(niov)) net_devmem_put_net_iov(netmem_to_net_iov(netmem)); return; } put_page(netmem_to_page(netmem)); } EXPORT_SYMBOL(put_netmem); void net_devmem_put_net_iov(struct net_iov *niov) { net_devmem_dmabuf_binding_put(net_devmem_iov_binding(niov)); } Am I looking at an outdated version? for devmem net_iov it always puts the binding and not niov refs, and it's always does put_page for pages. And it'd also silently ignore io_uring. And we're also patching early alloc/init failures in this series, so gauging if it's pp or non-pp originated struct page might be dangerous and depend on init order. We don't even need to think about all that if we continue to use put_page, which is why I think it's a much better option. > In my estimation using it should be safe to use put_netmem here, but > I'm not opposed to reverting to put_page here, since we're sure it's a > page in this call path anyway. > -- Pavel Begunkov