From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9647AEB64D8 for ; Wed, 14 Jun 2023 15:57:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B7F56B0078; Wed, 14 Jun 2023 11:57:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 168226B007B; Wed, 14 Jun 2023 11:57:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0301D6B007E; Wed, 14 Jun 2023 11:57:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E81496B0078 for ; Wed, 14 Jun 2023 11:57:48 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C0A621A070A for ; Wed, 14 Jun 2023 15:57:48 +0000 (UTC) X-FDA: 80901809016.07.BF88D13 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 7FD19C0020 for ; Wed, 14 Jun 2023 15:57:46 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XbOKL7zc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686758266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VBEkKn5fELdXle4Y33cuC2dwRJcYuUrgCYNnAHpQ2ZE=; b=wIavcOXWmBnWSqCuYQXP3K1y+WoFphh9AXN30v7HxjxDmxzVJjT2hRR+IrKN7p4hNzZWE6 u+j961P1OtmowMOyPUJpi/OZptSdd/o6+thrcr2s7RBWCpWgn0BVgxQwWPWa2gHP8eBKyk hfa3kvN+8rlcDXIE19BIu1UNQYakS4c= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XbOKL7zc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686758266; a=rsa-sha256; cv=none; b=OhUl9X0/xWNxv4avYgMK6v8/I6IDhyJIT5GBbnVYzeVrksUjQTXZIxKei6cKfxrfde1Qzq OAc0DwoLSlWAvsOd3NxiSDY8FnRjltdF8gvlwoUfiizhKxY8txzAQr9TEwTrHEjs/U/h+y Khxw53rsJdYr+BVYgZrSiT2xTDsIJHg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686758265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VBEkKn5fELdXle4Y33cuC2dwRJcYuUrgCYNnAHpQ2ZE=; b=XbOKL7zcbkfalkzer9zRZi9k+WNxneahITJa2u5vz1WcYOoRh4/EVYWDM19Gux8LCE37yv zb4zb30F4KXJSiUnrMmcheQNONQUeXooLLs0k2iORpmHMaxuhXNcL31O3oGdgFA06x67Hy CTZvf/NN0fPCJ4jPXGex/t6iFb6Tpfk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-K8zGBoN5NTO3JOmKsAdmMg-1; Wed, 14 Jun 2023 11:57:44 -0400 X-MC-Unique: K8zGBoN5NTO3JOmKsAdmMg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f73283f6c7so4048915e9.1 for ; Wed, 14 Jun 2023 08:57:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686758263; x=1689350263; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VBEkKn5fELdXle4Y33cuC2dwRJcYuUrgCYNnAHpQ2ZE=; b=haAo11EKNcObNziGCbIHM7lmj4h63KbhtgltkyVhQnw72t1s4BmaTj2JeSqwP1Wa3T dM0sscKYMdVrkb9Lunj2HwWojolMXFSI3lZlG4hZvSL8xWkXY2ouK/miX/18Igriulav e06Bjq7EOFI/lpfUj6676cFDtJzFfy2NyPOREzRSE4AROLJ0UfmMh8VVqRdKAAFYskSO WI5sLBO0fuTFmLRNXQx5xkS5x6JjCW32Ryme43LAbJc/n7XRsDXPL29fQQM0azhmViJy Ykf3MlvCXvkr+4M6RJ25LQxdVl8PldpIEo2PWz/F949Yub4iq224zsE7I7KX1mwVfQDZ /SyA== X-Gm-Message-State: AC+VfDz5jxLvFE/cxzvBIXffZvCEYkxD9PFh0u/e4zX9RXS+eQrbCg0g sNDk5Yb047UraHMZKZ2drpWPR/ItdBfdXpAX8UPPwT7jAxf8EswEKeQZHWVSepQMY+V/g6jEimn SWGXCeFvJvvg= X-Received: by 2002:a05:600c:4f96:b0:3f7:f302:161 with SMTP id n22-20020a05600c4f9600b003f7f3020161mr1999676wmq.8.1686758263555; Wed, 14 Jun 2023 08:57:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ53Um/PvnitZJvGvInqSSXPNb7PBP0CKxlPpICpz1jpz3DwV4ttJBoSmVIIf0i8BB9A0MPD2Q== X-Received: by 2002:a05:600c:4f96:b0:3f7:f302:161 with SMTP id n22-20020a05600c4f9600b003f7f3020161mr1999658wmq.8.1686758263212; Wed, 14 Jun 2023 08:57:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:b200:7d03:23db:ad5:2d21? (p200300cbc704b2007d0323db0ad52d21.dip0.t-ipconnect.de. [2003:cb:c704:b200:7d03:23db:ad5:2d21]) by smtp.gmail.com with ESMTPSA id y10-20020a1c4b0a000000b003f5ffba9ae1sm17926102wma.24.2023.06.14.08.57.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 08:57:42 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2023 17:57:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/7] mm/hugetlb: Fix hugetlb_follow_page_mask() on permission checks To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Andrea Arcangeli , John Hubbard , Mike Rapoport , Vlastimil Babka , "Kirill A . Shutemov" , Andrew Morton , Mike Kravetz , James Houghton , Hugh Dickins References: <20230613215346.1022773-1-peterx@redhat.com> <20230613215346.1022773-3-peterx@redhat.com> <24bc512a-b5c2-b7ea-fa83-5752cec7455b@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7FD19C0020 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: myntngn6s89p1khoxcx4yiux8cxsfif5 X-HE-Tag: 1686758266-321639 X-HE-Meta: U2FsdGVkX1+v6vft8qlX4gP+7cRbfJKJ5gFnl0wkFlkXE+YFSmgkgjhmApxIEuTLcF6Xem7C9x956n4f7MFOusqsV+aEVlJ5fTBdVggOeLupFnX2h5MuWIDkQuUF+yR8KfpQplxG60sPMikRNf8QMNOf67aV6CBuUr83mVNyQ/9/P7n3dDXwWIED81+BYCkhZLzebz9Sjchc48AOan5zavhrORUhKzW+xXrywCtqKJ6I/KJjhNCvxx2YVBgTNTTNiIaCusSBVPOE4vKvgNSQrf+++9AQXIbPeN/xAZHlFtt+22oz3Tj/1kb/SAsDj6osrrhxs8VT/5xL5dWOfnWTxZKLlZsiU0XD8dgWb4hAiRaaWqnaPBfqzYJHW2BzSEn2VkzQjEhYVdFZmX3CeuGg6UhikeECf9ApBIFaT+9DAaYoJheOOKn1msEq+2HIiVvAluauCnXXqxUjUdAIC8CO4I6LYcR57oaQlV7yglTaHe9y58ZRWYbltjfqQUxwSq7aLomTT7sNlmi/7MLZOXaG8+MV8NMUIt2u8Q0SRiimDRtmb8hIidRcKumCWPOsig3q0BQUo5DISOAXAFFUIGRw5tmw6GQyvrmBozzIkzmtB+90I3a3nBudi1AGHjTfkLoTjI61ozLSzEeIa2EVQWHi6yN1XMMU2Zo3b3iJbHEnPseeDMwKSj0p8JJM9fz9l/IxWH9z96rz0wwne1rmSW6x0PvJcPGGhL7bcIQu3bGGlwU277j9TJBZp58bnEr6vo8Q4RxnF0z6yEt4G8L5E1/3Ib2wsIiScJFyTe0YTZJwGIBrTIKshBL+0EiSd67kHdbUCfhmaftk5H6686UQrGUBeUbN2VVAva14Xo7dPZnH5qNcIl1Zs8hCvspaS7UVmM76Erykorod6SAd49K6AfTZcV01Ujg3oaWpgM4pMMQ2i+zZTfIGx9glW9fSvuvDnQWGfOMbCa6w6uRDdQNOhoy LxS9TxKZ QzPem1DIVE8CVTKO56Z/xxm6Q0j24R1imIKk04LbeNsayvzW0jBYZiLzeMei3IWn8KdydYJUxERr7vzj9kIa8XK18YrtmIec5GpVCGkm43J4zWHXeZkxygtkHlZN2SY/rXb+9R1dHDLKQdqULFhlf9wn2g1ZE4ckLlXyIALv4Buqo9/3xGNTlUbACWLS6eg+TEO8P+fJ3gq9UTyF+eD1NhowVCjfvyQUBDlH65fRjNh3HRKM/7XLmSXxEbzKp5pKYkCsK5X4ydzPB/q8H2kWdKvRMOq2E0d/2+LVXPcGDA+iWc6dzXGz0kMBkAHsBJ23Xn4InTCWuIHY7xFMARHGfoIiGgwcaFHeW6En+FsrZotEpSm1kXLmapIfT9o+N7ZiHgdXPTgMajdOWsVIS0wwUz7bpX8ibtjDtxXTpTGqtNxRxVmA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.06.23 17:46, Peter Xu wrote: > On Wed, Jun 14, 2023 at 05:31:36PM +0200, David Hildenbrand wrote: >> On 13.06.23 23:53, Peter Xu wrote: >>> It seems hugetlb_follow_page_mask() was missing permission checks. For >>> example, one follow_page() can get the hugetlb page with FOLL_WRITE even if >>> the page is read-only. >> >> I'm curious if there even is a follow_page() user that operates on hugetlb >> ... >> >> s390x secure storage does not apply to hugetlb IIRC. > > You're the expert, so I'll rely on you. :) > Hehe, there is a comment in gmap_destroy_page(), above one of the follow_page() users: /* * Huge pages should not be able to become secure */ if (is_vm_hugetlb_page(vma)) goto out; -- Cheers, David / dhildenb