From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 018CAC761A6 for ; Wed, 29 Mar 2023 23:30:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FA806B0075; Wed, 29 Mar 2023 19:30:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 682F26B0078; Wed, 29 Mar 2023 19:30:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FD616B007B; Wed, 29 Mar 2023 19:30:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 387FE6B0075 for ; Wed, 29 Mar 2023 19:30:05 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0449F40F3A for ; Wed, 29 Mar 2023 23:30:04 +0000 (UTC) X-FDA: 80623531170.12.BA04DE3 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by imf07.hostedemail.com (Postfix) with ESMTP id 76FB840006 for ; Wed, 29 Mar 2023 23:30:02 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b="bR/elBEa"; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=attI7Cb1; spf=pass (imf07.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.144 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680132602; a=rsa-sha256; cv=none; b=zQTNCbT0MULeUq9mQ1gCfYGCrq7r7iSysNWgl9yK0Jp4vSKVWrJqULApc8QhlR/TVfCwNk Aaj1mRGj0kR5ckXXpA0cd/1vynQcNGmxVm6BLncbd2ZUQghQctf3z4MVX2v6o2H0bHHTk7 /cMNQdwDj0AXUmNpx93QF7l7H3w+KOQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b="bR/elBEa"; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=attI7Cb1; spf=pass (imf07.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.144 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680132602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Dmy00NSi1jBvY5axs+SWSHXNt2uzOUpyhLS1r8T8Ig=; b=c2wJVQ+Z+e3RyOudKJyxYo+KN9ECjrbG8AE1nxKUu+cKi54OIMWnqz0u3Y60XNNOU35wtp k9k5SEpclC3cHPaAUBVe9v1H+AACH1mpJiUCxtTaxHU/9Rz2cXcGN4WVEfz6CRq5wmvbcE pqwIofBu3tifsTcbN2UKZl5MLcQwKzQ= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132602; x=1711668602; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=/Y/8nFwSzVjprTaZ9/Wyk96kEMW0qhqMfVVhpdupNbM=; b=bR/elBEad6DlD8fi7OhUbTlBngKOHSzHYtkuUDr+jeSUshLOSSZ3gRk4 vrmDjv5xjwjOw8mcKihv3pRtAGW880KWq1f1YgKAXAyDY/5QVRVTBHVMz Zg+vIPx5faL5NFYk3wu+2nIZZVBPrhy9C5sgPv8CwpgsI8Byf1mBhMOUW 7N0FHev2nHAcPJ/Il3p5yAWQjTYjFQnl23o95tt7qYBVfeb3McfMC0Egr HmJDKCgaGq/Noe/+1r9HZfXs2WLQAXBNCyGeIHNAm9oqxNbAGl1deDEVC Qaimr98roy9QMyXvtiu8Jl1KxtfPOEcM1wUgSXkMTAbsdHigRhgdGcZhU w==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="226647976" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:30:01 +0800 IronPort-SDR: GrfzjH1tkTyh5312a4EufWfyYT6gt9kGEoqFfNUuB/3Hf64YmQJsUqbJ4UmfxVTqlY0rNcfzbQ yr3fR/nM20tz1t+MKbwM795Ja+sBtQQH9+bSc5mCyqqOBuiDeqsobwHCSyaPSAWwRGBGcLSgBa A8GPWBHxMwDSneP+7XLokvs8JFdQNk08W5f7fIgye/XjJu3GRDC4xVo/SfhU9aNMd6zFY5b7C7 e8vUvLBxINwPtDJKf3m6oFNgFg740+Pxvunje5ITUDVoc+RL0XWeH0jgaW/l7tfoSK3JXyS5Yg Sy0= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:46:09 -0700 IronPort-SDR: 5OS7het9K4ZSgF/xtOqsY7bUDowm7UCQw3QAOg7X81GIAeDiDNO/SQ/GySHWPKbzRqasmagGAz 0puCXGixqUn2RI5alzj+H3M/r180SvOxFqhGdFM1XWdc7qmnoLncpG/WKu7aHPyx4QKKMefkEC daRYTZhAAMvS2zpYPOLdvpf+fWOKo08VNPzkgzi9icn7i/cQw0JPZVPnAfKq+3hP0F21H8bxFe CgpdCVo2h2FaeIZKzLXKthSCdiofsAFGvtr5VHlNLxtFOYeVMgGbCQl5gKYOFBa8SIPeIsxnMH 0F8= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:30:01 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2pJ3Xmrz1RtVv for ; Wed, 29 Mar 2023 16:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132599; x=1682724600; bh=/Y/8nFwSzVjprTaZ9/Wyk96kEMW0qhqMfVV hpdupNbM=; b=attI7Cb1FiJUfGooWKuUBF69nVtx8C0v6ZnYPU/aallwnH131e8 koFS+onmiGvEVL5Rsy8MD8W84BqTFny7oW+UX3Q0EgmJyd7MjsjVGq5Fag+o00/p kBXyOu8rVI1MppDWnwv1nSsJjZgW3+f/JtpOKGfbDSqhjxMshlz8soCSdqYWdxyR mZbB9MxATuHT290hQKyTcBQsnd1Zs0bx71V0NrVJwmHkHSmV/TllIeaQKFtE+uS6 +2zu64x2THYHjMlElnTspmwc+eMYbDW16URD8fpUN8smUWhlgc3H2/33t07voR+F ONOgbvSndu0231MHqn3BP6ebhDrfi+c2eNQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id xNV8FmUyijLS for ; Wed, 29 Mar 2023 16:29:59 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2pD1Xt9z1RtVm; Wed, 29 Mar 2023 16:29:56 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 08:29:55 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 02/19] drbd: use __bio_add_page to add page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <87d0bf7d65cb7c64a0010524e5b39466f2b79870.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <87d0bf7d65cb7c64a0010524e5b39466f2b79870.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 76FB840006 X-Rspamd-Server: rspam01 X-Stat-Signature: gr9a4d1jg7nj9shkpedeimbj6jy4eu9t X-HE-Tag: 1680132602-912115 X-HE-Meta: U2FsdGVkX18rnMXb3lOwMXjSKoEJ540JvogguzCrj0Mppri9x0seC2HCvjtOUG0oxYYCZPkjEx8P1hcI6X8PrwgII5LjTmUfJ8fH+g60aNvNJZ3Bph7UcQdE+5VOH4AAlXEkkSEzw3/OHo2X0+SJLkNaHLlyHcjNisD7vCPAsz7SRHFMdSP8xl+PP3nmHkcmz9dso3k21BURdMBtkFNt7D0CMzNZQllQTry9SlYzLD2YApwzvjVg4G6WTrZMSODSWvYEeCJZKDD+9CydkGunzGVFKURnPgZiAMfd1lvmu923ZxhCdB+LAcAdpugH7D0kbUQ1J4R5QKe2mpLSqPUWc1Zk0p2Nd2MD5QBTbB17ageRbZTyDO3bglmt7i+P+0DYgafXY3xeix3IPRhpgjs9Zs/64TLt+nIJXuSkeamkfFg6z2siy58wxkIxjXLSTG416v3gJ/SsnLY3mQ/DESE8zDMdtGr3e4rgSVdmYzTvNcy3FzAvmtaXx3fu301M8eC79v2cuy9MuPzPVVImyn1OVFkiLMbDpOfCMtmbLLqXcNAS3gvD0Cwi+Om4BDUqRKVAqXpk76ICPagVvzVGtO4+ocsShWIgwmKf3HYnvgFXoJsAPJ/Gwkoqa8vkUw3yRzoBx6yOeZKcrP0Ecv0SIivSJ0CVGcRsMi9Z5TPm3j+x5tnOKi4XHujbBkw2pD4HgUbb/Lh6LG6cLYvVcU3M6WxFNaObbUehIagNcTLAmb0B3O2dhKQHwJ4g9aGUiAt9+dN/XJWisEzFuAac5z+G8+oPitxUyr8nmcreWFa5oFXJmwPybNHxv5T8QvQx33k3um0DJWSIna/Qn1D1dL7f/YIOECdfyiQPHt600PM0c2fb7pYi3kCSmWaIupHA6R8mPDl4VEjFyAZ1lnPX6blWVn1vakY4ev6ZhvbHTQuzb47qplNJAnfWEAuVmUIbp0qTvQ5JUhIjiUdAHGhyrugn3x+ ZfwVdGUj hK9Tcb8moNLTYUKqhkC6OVwYgZ4yjtl3w8SL8MdCl1zcP82NKGnHbt3TKgk3ofdw4yFVZ14WMLZrEFzDTikjCJFEb2/HP9IXxudh2F+2CvpwAI6qMIBd8YDWUnJCjVKqrWrMHGsBZsBfrdl0Hl9ZkPPWCBhYGw74lZ1+bbPXX9bWWVS0huSa/eyGA1zrZLCbe8XJ3lxkv2kbMQ7MOohsOCyxf/QIiVvOkh6k5e5F0QO56L0EbbXeMWUALdnnZlDeg0zOUAvoSEy8SSQwIAUTjDI7vJKK+jibBoaqovIQ0dK8GbQyeKECgcattKPAsEmdM2QTkRPw6XOp+RuSgqbo9BdqgGNPtYdDcRKqWhLIskxKwjaIJweXzEPEo80+inS4tM19otyEJ43mjIMKwLP0E/By9a8IAHO/54Re7qy2n99o5yGBbeJH+RipghTglaf6+QvzBxRiGlbKqoigrqmv/GAu5Pf47mAqOZavsU9Vxz9QmQCncvNgptYWGNdYoBsTJLe13MDxlTAdTq8NeBwhogIvi/sjWml3h3oH9/+goPtTK6B8ykjjAGlGA0xvyzUK7sYCNF/ltC538sYZ31R7ubWvuyJHnrftGivRG959pYMAm01fWLiaAdAnkWLM6jtY0bxHA4NSmG8ZrmOluRBnbLIr7YeY2aYmksycTn86yRShF0D3d0K3BarYAGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:05, Johannes Thumshirn wrote: > The drbd code only adds a single page to a newly created bio. So use > __bio_add_page() to add the page which is guaranteed to succeed in this > case. > > This brings us closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn With Matthew comment addressed, Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research