From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 634B6C48BF8 for ; Thu, 22 Feb 2024 12:15:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8FF46B0071; Thu, 22 Feb 2024 07:15:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E405E6B0083; Thu, 22 Feb 2024 07:15:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBA686B008A; Thu, 22 Feb 2024 07:15:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BC6276B0071 for ; Thu, 22 Feb 2024 07:15:08 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6A864160D84 for ; Thu, 22 Feb 2024 12:15:08 +0000 (UTC) X-FDA: 81819334296.04.AF92981 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id C00BC1A0024 for ; Thu, 22 Feb 2024 12:15:04 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C1uN+SDh; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708604104; a=rsa-sha256; cv=none; b=iO7yw5/5mV2/3y4ISxkwKQIhLjJK/ljlh5FkSvpuni+uaOo22mqvwHjB1whHBc7UcEL2uU mZIE6YujnBiy8+VIg2ri/nRaMPCcg/UbmBmhG6An002zQYhwk8qW8hnK6afd/xxCoKqY6R 9IsffScpiDVvbmCvNKh4lvudEeo6Ofw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C1uN+SDh; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708604104; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ms6xEIb2jDGpCHrso8jLzDaD7R/RPnC3mdi3yCtznwA=; b=Y6PQobHH3j7ibnr+6f33cC089q5qkBODZYu2ghXFauW4u6n67mwhVBE6qkh8Np/Hm0PJC5 OeKTkSCXaS4lpi8q6lQZvi6/GlZxWPdWFc2jM751ULB5iQwW8EeXA62qnatzJDbozJlKk+ Xz3zBf9/b1WvEmsQR5PzWRFN1/pyn10= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708604104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ms6xEIb2jDGpCHrso8jLzDaD7R/RPnC3mdi3yCtznwA=; b=C1uN+SDhnLWKjuJyOnPIshEeuvMDSmHy4wRjwDpRMSJI/PYzNxfO0h+0xhGXVoSX4i7Vfp 6n1oYZl83+zw+qLcnf0IbexSS5WpZQ/55qGwym9xqnAualy9+1qzUIrreonskCwXG/XOxI XVMLhE4ubuokvNmyTEVrMDIhwqZRHjs= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-580-WM_gsp3FOyilfidHacmb7g-1; Thu, 22 Feb 2024 07:15:01 -0500 X-MC-Unique: WM_gsp3FOyilfidHacmb7g-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d2549572e7so14301171fa.3 for ; Thu, 22 Feb 2024 04:15:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708604100; x=1709208900; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ms6xEIb2jDGpCHrso8jLzDaD7R/RPnC3mdi3yCtznwA=; b=BvDvCWmNvvetiQPj6SEWsT7+PIHPFqezq5PUVjjwDiE055D6MYHZjnQvdPjOYf1Lm7 92iDWqnq8ZJ2fOKWPiNInVx53g/a3Z8hnZHvX4VqoxfqOua23eKv9OepgOuHnUCKb4bn bwBEJ0La1KRo5l4//cJ+vNBsGDtnuHPsO2bFAC0m2qDq5B6HeLrroEBurrzQsW9MERqR sacp7P+copW4OY1GctPnV4wZSC9n/ut/AeBsWc7JkYkN71ps7MPNxX7NkGloRgks1mxV 3alH5REvlvJDPJYoywAC2x769x96oi1tlUnkHP4E+PZhYlRVBlC7d+ELtb2tUWhYhTZP AbdQ== X-Gm-Message-State: AOJu0Yx8yepSkLCrrGmbJ1vrhPder9EDJdgaKjhKDFxHLsDk7HPzB08A jXph8hp4+oXO/NF7Q8PGMSga4aRh4+04tB5Ro7szTZTb7/gcOpPOzPiFfgI/DYz27i1baQndL/3 483jKg3j4A4mDoVmgXlaZZ+u6cJwrpZU6XP8JTfVlE+GORheXacU23Pu1 X-Received: by 2002:a2e:8290:0:b0:2d2:1fed:8029 with SMTP id y16-20020a2e8290000000b002d21fed8029mr10988821ljg.28.1708604100098; Thu, 22 Feb 2024 04:15:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IF9ni3MK5l8fE7rGvAsklL/mmBAZXmPn/QkRgvTr8hO5nhtZpmXSjAbfeYC1+0RruyRPPWx1A== X-Received: by 2002:a2e:8290:0:b0:2d2:1fed:8029 with SMTP id y16-20020a2e8290000000b002d21fed8029mr10988802ljg.28.1708604099694; Thu, 22 Feb 2024 04:14:59 -0800 (PST) Received: from ?IPV6:2003:cb:c70f:8b00:ed48:6d18:2152:1cda? (p200300cbc70f8b00ed486d1821521cda.dip0.t-ipconnect.de. [2003:cb:c70f:8b00:ed48:6d18:2152:1cda]) by smtp.gmail.com with ESMTPSA id z23-20020a05600c221700b004128815c374sm1663051wml.5.2024.02.22.04.14.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Feb 2024 04:14:59 -0800 (PST) Message-ID: Date: Thu, 22 Feb 2024 13:14:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm, thp: display [never] for defrag when THP is set to never To: Yuanhe Shu , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, liusong@linux.alibaba.com References: <20240222115323.4925-1-xiangzao@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240222115323.4925-1-xiangzao@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C00BC1A0024 X-Stat-Signature: g8fhm5u4mtygqhajy7si7jy6przmsuqi X-Rspam-User: X-HE-Tag: 1708604104-866786 X-HE-Meta: U2FsdGVkX1/j8SnE9M0doGt8JHvS1Ac+0hEpngvIQ/jwZXTl8bgQrUVu6R4mWi3E+pqOn0NfdWPfDa7CHkIPNXoTVSO+s7T9WYGZnuF8C6NFIC0FjfK33/D0G9rxf5Rp6pMIJCg7GUEwK22nPbZmqS0q0C4PNHIVvh6gkcrlT5TgS4jgPPl1v0BecniYd8Qac7Zq9vR149lirNlBhnnK+GYfwjXqWaVlxU0UuBjYA0UCcCnmWQdBwsLMQGl9Bcdf5n9JT2adOKkDnZ8KdTlykykEyH+6n9NME8r3uZHTQ9lCfMoQgaLSgrNGcR+/GFCKXcdwoSbbkA58Cc6jjp4VB5VcBZSJu+r5K3YFLK8y8nGtiI7UpuHZehxJYmLDhssZX5fpY/2eIAE/rn6Rl1NbOfII0jqakYsy8WnFrQoFxH9mS30vHFBZSed6p0014OWRuTGrz4MJpqXjsVuRm5FiFmIGG8Oukcw7I1fUno/Xt0e8RRy32V4mVHvvKbXd999jNsu+XKNMwBkiNYJj55t3gmseEIsrCq4v9yyCAXPRDHGzH9Ch/iELpcUja+BEJkBhUyUPuG9J8cJck6Ai0Wi6G7o3pTKkLjfTA9N5p6He1xP9TMVrdRhY2tniBjJ0RKKzuCft8fvTQa02uJXz2a0X5J8jnYSpnAhFzBYPPvTLg8oSyIKF9g+SUKC1xMq1K5LFB3F6OFY7q7J14DTsC8jr0WxhFsL/+aIaSnfBKMX/WZe47Za3DR9gSujo1BHJL1xyxGv6UVMIoPoU2qyo9wv5wrrwbrvyYRSYc1YGUDWHmIHxwkBH66I2VMvDNMnoXrL+6VoUFDhrepvFWK64SCCfp0Npd8u+VcZwnW5YiU1oGd17DMndVXVPyzxqP9Zkw20YWVPkFnuAisO9Fbu7gVOTbI8MKgmN7xhttCjQEiQL0WbkIQ/CEfxZIOW5ktmHKB7pZd7sqO7RIuF8DjGaRcq 2EEOneIv BhLXUa2BpBqhu5TJOwLkfnSfaCGWbP/29JIaDh7yOxQDrvpFk5nlzFtrHdsaP/fbTJgTgunD/9dOHYlnenE7fHaQVACDjc5i7rsLmSxx+m1f9bpIlHCE96pFugcZN89yQjlEi6VXCPqHqKa9LP05mDtZXaar3vHqKo/T3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000600, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.02.24 12:53, Yuanhe Shu wrote: > When transparent_hugepage is set to never by cmdline or echo, defrag > still show what it used to be and can be modified which makes user > confusing whether defrag would take effect. > > Actually if transparent_hugepage is set to never, defrag will not take > effect. Just Display never and remain unchangeable to for defrag when > transparent_hugepage is set to never. > > Suggested-by: Liu Song > Signed-off-by: Yuanhe Shu > --- No, I don't think we want such a dependency between both options. You might just end up breaking existing scripts (enable defrag before enabling THP) for no good reason. -- Cheers, David / dhildenb