From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C2AC47DDB for ; Tue, 30 Jan 2024 15:21:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A447F6B007E; Tue, 30 Jan 2024 10:21:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F5296B0080; Tue, 30 Jan 2024 10:21:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BCD36B0081; Tue, 30 Jan 2024 10:21:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7CB7C6B007E for ; Tue, 30 Jan 2024 10:21:10 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E6F28140BB5 for ; Tue, 30 Jan 2024 15:21:09 +0000 (UTC) X-FDA: 81736340658.23.1E8D4BF Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf21.hostedemail.com (Postfix) with ESMTP id D0F631C001A for ; Tue, 30 Jan 2024 15:21:07 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b="hp+idUU/"; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf21.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706628067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6KPrj6X9HrS9UfyjVBDlSMFCc/HbkMpym0Zay68Ch4U=; b=zIwl1YRRQYwIKReqEiBPFucevfHOFP6HQWTEQTJDMuttnS83kYEEEZydEYGoAwlHd2FcF3 cfxLVf9/mNE/wzaWGkS5cDCEsfOQO2LpfDqmZBM7UxZvE8dn/+e1wHTMGSn6KshxvY+7jq cAweawf0W9YOSIVvaF5HNQYwiExaV8o= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b="hp+idUU/"; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf21.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706628067; a=rsa-sha256; cv=none; b=Eh0/8zs7h13GnEKhisLXM15SX2fktSEAX0q+cbZTRLXyT3SxEKouj7qjfIF6U6Ezplmci2 A1eWVlCfQrRRyrV2Wvcd0XvnOjeTLDCXz/6h5iVN16d3+wSGXCaM9B3YEcgdzciUnUKNr3 z+5H21HZQpzbzLe11wnLrSbTY3IuXzk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1706628067; bh=jPyAa9WfdA8ROQgMJjeMeeC8xbDVD5scgsQuDyPrR/E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hp+idUU/OYb8BUfLwfi8e2vK6zsG2zyiPmbiWXGtiQ6yT7Xli/fB5x+A4aoacjxBX AmOncQTD2Y1gQ4BUbfoikaPeKi1giCFmK9ayt/RSiDEfMcs2V5R9HFTcJ7EsqhrbD5 V4YXlfUxRNxqJRnmW3dcclwuwvmnlYYBpXrpVqfyJGKcN+LlAQdYmXgRXfC6g3kldo yIJvyVfJ7XukuyD8Yf90+0fA9xWOjcRN2T3S8xZJsBgiAdL2ByWohNXlPa0baN1qlT KA4N4kTrimhzvyJZd4HLzpTFFvQyLGnAPKcuGg9rmdsL62J0gCVlLNn+E6+1REUU+m f1xyZbTxlMbfQ== Received: from [172.16.0.134] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TPTQV5ylyzVj2; Tue, 30 Jan 2024 10:21:06 -0500 (EST) Message-ID: Date: Tue, 30 Jan 2024 10:21:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 4/7] ext2: Use dax_is_supported() Content-Language: en-US To: Jan Kara Cc: Dan Williams , Vishal Verma , Dave Jiang , linux-kernel@vger.kernel.org, Jan Kara , linux-ext4@vger.kernel.org, Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arch@vger.kernel.org, Matthew Wilcox , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org References: <20240129210631.193493-1-mathieu.desnoyers@efficios.com> <20240129210631.193493-5-mathieu.desnoyers@efficios.com> <20240130113337.frem6a3y5n2iibnh@quack3> From: Mathieu Desnoyers In-Reply-To: <20240130113337.frem6a3y5n2iibnh@quack3> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D0F631C001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: y669oh966bhmybmt775pp5ofcg7dir6r X-HE-Tag: 1706628067-828175 X-HE-Meta: U2FsdGVkX1/RW3xp10svmdp7CH7UbugQJW2HZCI8kIBVDfKHcfI4VjrnPPURnE1ITkMtPpV6ctdLoKlfZ87Tj3qtGm67DmZsNDMNA+NkFJz5FLT32HEqSX8cwxlOex/v3YJdPxws5hj+LCm3KrNrG9fLToOyiBPgnKLl95i2D8RtCOxqbRNlOuhsyyzb2vCTJclE5QCPlcVIpApPSiriTxOQKrRRUkXbWrfX0fSCVZMgW/hyIreXfepMhHWehxiJ5fvqAVTPHu5YOlXycmM0lnI+YHx97hl2COUEtdj7Wd8V53e4F6MtrRfRtXD2gAffZJobgon3R22OQUMIJ60Foh4+zwBVW8hGnu1zLnvId7219u4asIshC6V6lcEPc2K6KlevD7lqRBGmDqcKsvf4xa7kmzQoFN5fxOuO0EPs7zkm6MoHfaQuZMMEjS8D5Mfps3HkptTpenV2aJeaj23ZANx34WTNkC0zmB/xD9TH6t+cGB0kZzDclCqB8+j5zC0wFYoLGTqgVtDMC46JGNjZ/Dp3WExtu0k6w86vQMNV7X7733UooBbb26/7Z3lCmkG4X/nUU83LT6mhy59oDW45dn3l4ebF4LzNxbwNf4DYJKk5ayTWmlObQHzURGujnwX9erGNnrJacBEpmWr6xOHC1eqVj99ThXabSR0rsR6SsdOok9pEttemud0Pl4ljoLiGDF2cbbxW0IGF/zFW9WJmONZQXr0abS4BW1HB2MEbGVEO//hG5zAkNT95G0+Z9SJdtriMdHEal5wTwu0H4F3uU9cPzUKDgFKFK6dJ67fx4sFwqfs3DWKDYciE602N0kEHqE8n4V6fsREZRuGY0fPv5jSLYjvC2GMMGh0E1fXDel18J2PdfLfB8fUxTgOClPJdSx9nbtyMT3mzsWEmPH8+5XxwOt/jjvDTFhtjvz4HrmfDGgAUK8fEMCikEgOmSa1kWCNAU50nIdYTGpGOuz7 NZxQocT9 VtkZXU4ozKfkhQywqvZkTmnp2lsJCTH0ROUdqIOG6ngF9TfnA7TXoW5sqseGzJ7vgVFss+x8VfcuRKb7cJkI1lwsTc9Jyqm+EoJS5S15hLA1IDd4Od/R8A6oceJzx4ouixNtyqIEqwqRr7oUnynU3vXZmPp3GCI2lOfx35YIHHLn65fMfTXZT9AmIEfooATEzu4t7MwM8f8vLFcaLsxmTyAauSW3RNQjDDDdSSenNGDFD5ueZBKGwRhv0axWpZxJRszseOQ2ziBg/YbXoqSDDAOSMcMp2YQ0xVFkKBPomP4SaY+yD6fNIduh3n9BfJE8cJslMUMSkXIKkBGjZO73H3M56iMRLiY0irWL4dojxBi5WQ0/JLOZpIdKOVS9zuEXyJVmBbUYZxEVu4WmlB4MLjZTbOzRfVFCl2eD8bRD2rP6fUb6fgoSN0RhRgAMzYHi/1jsAvMwjmC7R8QYOCeKHfYwfV8G8l7f7EsQtwXD5Ymp/8K8N2PudjVFoVfEuZcWE54U3l7YNVuWY3e0c8Sl9uF6ULAd8jcJZQ7QWuqWXVCSH+R00OC8rNIR0xnK6G8PGEDGlMxKaOk9gMdzL9a2xgLoZ4o+wEa+GgCEyQNj0pivNbjashO34u3GU6BwStErmCKg7DWqEd1pjPleG/DXNYsqE6SRu8+CjHP49 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-01-30 06:33, Jan Kara wrote: > On Mon 29-01-24 16:06:28, Mathieu Desnoyers wrote: >> Use dax_is_supported() to validate whether the architecture has >> virtually aliased caches at mount time. >> >> This is relevant for architectures which require a dynamic check >> to validate whether they have virtually aliased data caches >> (ARCH_HAS_CACHE_ALIASING_DYNAMIC=y). >> >> Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") >> Signed-off-by: Mathieu Desnoyers >> Cc: Jan Kara >> Cc: linux-ext4@vger.kernel.org >> Cc: Andrew Morton >> Cc: Linus Torvalds >> Cc: linux-mm@kvack.org >> Cc: linux-arch@vger.kernel.org >> Cc: Dan Williams >> Cc: Vishal Verma >> Cc: Dave Jiang >> Cc: Matthew Wilcox >> Cc: nvdimm@lists.linux.dev >> Cc: linux-cxl@vger.kernel.org > > Looks good to me (although I share Dave's opinion it would be nice to CC > the whole series to fsdevel - luckily we have lore these days so it is not > that tedious to find the whole series :)). Feel free to add: > > Acked-by: Jan Kara Hi Jan, Thanks for looking at it! I will do significant changes for v2, so I will hold on before integrating your acked-by if it's OK with you. Thanks! Mathieu > > Honza > >> --- >> fs/ext2/super.c | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/fs/ext2/super.c b/fs/ext2/super.c >> index 01f9addc8b1f..0398e7a90eb6 100644 >> --- a/fs/ext2/super.c >> +++ b/fs/ext2/super.c >> @@ -585,13 +585,13 @@ static int parse_options(char *options, struct super_block *sb, >> set_opt(opts->s_mount_opt, XIP); >> fallthrough; >> case Opt_dax: >> -#ifdef CONFIG_FS_DAX >> - ext2_msg(sb, KERN_WARNING, >> - "DAX enabled. Warning: EXPERIMENTAL, use at your own risk"); >> - set_opt(opts->s_mount_opt, DAX); >> -#else >> - ext2_msg(sb, KERN_INFO, "dax option not supported"); >> -#endif >> + if (dax_is_supported()) { >> + ext2_msg(sb, KERN_WARNING, >> + "DAX enabled. Warning: EXPERIMENTAL, use at your own risk"); >> + set_opt(opts->s_mount_opt, DAX); >> + } else { >> + ext2_msg(sb, KERN_INFO, "dax option not supported"); >> + } >> break; >> >> #if defined(CONFIG_QUOTA) >> -- >> 2.39.2 >> -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com