From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E8FCD611D for ; Mon, 9 Oct 2023 18:21:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47AF86B0252; Mon, 9 Oct 2023 14:21:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4027280027; Mon, 9 Oct 2023 14:21:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A3C76B0255; Mon, 9 Oct 2023 14:21:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 13B346B0252 for ; Mon, 9 Oct 2023 14:21:08 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DD0A01CA9AF for ; Mon, 9 Oct 2023 18:21:07 +0000 (UTC) X-FDA: 81326739774.15.1DA76FD Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf23.hostedemail.com (Postfix) with ESMTP id 0094514001F for ; Mon, 9 Oct 2023 18:21:05 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=I82MmtyN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696875666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TfP0qTBUd4xX1/BfpaGnOAmCxHeUgPJ3aawAUXPsDFY=; b=HjaYFwPlvUx5YZ1YPcvzTdY5ycmyTz9JbpFcFZimP603DnXX+ts7xODWrdstUX73cLep4z 7eJAmL+yVjC2ZhzZcZvMNrKpR8pMLKXMOrdnRECQyvH7QkUeEM4vQnQDGAAsK9GP4+wj6y ZILtjtLE87TWE1OuROGc7H6cz/ATXGA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=I82MmtyN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696875666; a=rsa-sha256; cv=none; b=DmaTgB6NqkkHSvoFFWbXLBJ74b3KUBCTpQsEP7vWTcjxc2Z5YdVniABsoIeMsUwbUBRHWW RwyrJZCeMcI3nenN0+pP5omcpejsy1A3u7zLi1FDU3/1TP8jfdAguDiTw+vHyy3gL1ZIfC rMSa3oGtgY9iDgZdJ8IFPwngNhOlQKc= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-40684f53bfcso45104675e9.0 for ; Mon, 09 Oct 2023 11:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696875664; x=1697480464; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TfP0qTBUd4xX1/BfpaGnOAmCxHeUgPJ3aawAUXPsDFY=; b=I82MmtyN4SUeG/AVzP4+MkKmRA53nb55MiPunmsD5UjKHEc0SGNP1+j/3G730GgF2K SgmNGNjwz1wCBGlfgftYglI64o+kaV/iqGwiG75g1TOB2KSYzdMGO6Fzq5kZ2RiW64my /bCAEjM4BO0DPlWmbIZE3808fbGEy4dBl4v9K8tROqwtDQfzTuoJ9wiSc+zPp4MLQKs4 d1yzqGMkXVao+mI/JJoIp51xFCXOFEjqet8bCPtQgdbQIuWmsNg2ZMV7EpyX/5W1HqDN RiQQybTOsCS3kfStscpLQoao9PtaCpZ+GcfHMsmPLubmNSz0S4dNC6Oz61p5vBxUPh73 HMfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696875664; x=1697480464; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TfP0qTBUd4xX1/BfpaGnOAmCxHeUgPJ3aawAUXPsDFY=; b=m1lt1KmyDJL4F5fjpxVBGb9pMPKPPXIBG1+nOlmeXf5fg+j4uJJ90kVi2tL4urQuDX Eu5dqHCH4drJYrrh5lbkR+YhwUcCiKKnYmRQMRB+Ru0R1dbZiOdMwWrQk4V+oSZJKmOR mOQODU2zMc1nrU2rQ5E1A8X1FsTEq5yTchj41q01/cB3PWO2JHZ5+EU+KPF9hqb7afVJ ffFjBbD7ugKJs7MCsSjxQ6SuKyGRvJGOMmJ37FK3ErT52yzHoAwwv7KtkDE2uucc5zhP RKCLIvmeAHP9XKVOlo1WUIZVfkEnNB+XoClppMQj2KAjvJPT+a4mfAgkKxrj4ucZs2/B CDKw== X-Gm-Message-State: AOJu0YxcVblk4SzasxEHedJJTaNCZA3T4wCpTkAR8OhnLuEzI5yhTP9T 1k93T29P1JnZbl/q+NagKih5mKYIPiQ= X-Google-Smtp-Source: AGHT+IH+zjGLzFR7Y7bhfkh7TWduH/jUD5oAtocqjWrnmntfmwCseppIEAA2/7Ynq8jdvcUJYfZmuA== X-Received: by 2002:a7b:cc07:0:b0:401:73b2:f039 with SMTP id f7-20020a7bcc07000000b0040173b2f039mr14792796wmh.7.1696875664611; Mon, 09 Oct 2023 11:21:04 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id v2-20020a1cf702000000b00405d9a950a2sm14151670wmh.28.2023.10.09.11.21.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 11:21:03 -0700 (PDT) Date: Mon, 9 Oct 2023 19:21:03 +0100 From: Lorenzo Stoakes To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Alexander Viro , Christian Brauner , "=Liam R . Howlett" , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 3/4] mm: abstract merge for new VMAs into vma_merge_new_vma() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0094514001F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 6u1x88ycqnicp7ereuj5ufp5439qujo4 X-HE-Tag: 1696875665-491904 X-HE-Meta: U2FsdGVkX1+opkKsOrpVpVPgJfSHxxkYUvUONcsTGZwlpA7sAr0AWAigLWnc0dRuOrgOK2vsuaiCHfewtDiki9kxKVVgxLEPjLjBCvoQdatyw1mmkdl77XVCT4lcLVHz/PIYWy+MTs9QclcxN3WQrAJhYF4K9NDnv1iAx9FuBa8PV4lyNSzH2AdE//fUnknNo30iSNuDOxIAX/r03wsAXUqOPwxDIo7ZytIf7ON+PZQZgYC4HxlQ+uJgF4PUvWUY3vbDblbE4IP78oyuOsLbgcnz8c1MTGmAKphgSneXExf3q5qzKpjf124GWmyTuj0sn/reCb38HObmIlng7MmRf8TfaJADbiE3NiGY4hMOBfVbzyBkoddlhNv9uwyYZ8xCjGjGtW0JZKjwVz6sl2BuhLyaG5Mi9bVjHrg5CDnEaxkHGwZ+XiMgPKs92g6D1WWCyrnl3jjiL49wgSZsUVA1Rx4o+Si9sfakLOrInGGr/oILHtcN1KDha29g099IFd6KSQ7O5FKLcXRd9Ac2Y46UJPwvwyAkWNVgHrNJprHhNvYi4HltEn2G91g3eamoE7wcvUDpWzgketmW/Th8FgFeMtXyt5qsvXp+vXzR2HO1a3kOUB8+u4/oaoahPeL2ldn9wEtBdwUdy+TRCb9lnIyOnJl4BG7tTxZPg266Js/tlBtUzu51IdSVW+kjuGCpm04yIO4Cuf5idcwzWCBE+Ofs4XLtLc5xgkxxYkaCbCzfIHmhKVtdmXGg8C6nak5wMHuNfyp7f0eU+79X5McfnZc6yx4PUgDksMJssRmHLDKL6pZhikmPaeAtpwTCec7em3hAGzoNs1mevCBCDD+HK4pJCFTVzfZYtAg/cxDr5sgOl3lP12GyIb4pTrtHD8CCpiwNW4S957fUJ9e3pjcB5rYeQgTMuOzshbusW6qDncFIfEb0sFfubgGHqhhYc7SrJ3yvx71MKtRuNtr4nPIDwRv ooJXxu4o r/6JfLInwzkNBBR4atlTV2HKOLYFhuWySBSiPVALt8qu4uFdkz7RXgB+bljDKo7xztVWHV8iJPqpxBbE9JMp2KqCjrfKvkljlkfgm5N2VjmImBsqb/oQdnUS+q2lwPHFuVPC2ZvjAzDO4p3/GUzKj7u0ghSzsqGTJfd05rf51wGQ3rC/jlfHzyD+tYWVS9Vzizqyu5fcdCTd5tTf9EceWBBDndRdH8JQY3sGooyskIo6D5Isok5CMK/R1uC44HmivCKIMgwwFd0c3DRoGdaMqbXVMV1wzZmRdBpW/RXlFD7mA0fJ3qpd8aWiJjXcfhcimF1O5scnqX2RBxanvgSP4lCqpg5b+A8E+lNUvepD/qXo7045CYaGgkzTETlk/xStImEho7C+jljGxX0V+zxUK6MiU6jCIGGmI46hHqbsOdhH0Oxsyt3nwolaIGfoWKDHMyIKVjlcL2elrlZg+KsH8aO3gbg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 09, 2023 at 06:04:47PM +0200, Vlastimil Babka wrote: > On 10/8/23 22:23, Lorenzo Stoakes wrote: > > Only in mmap_region() and copy_vma() do we add VMAs which occupy entirely > > new regions of virtual memory. > > > > We can share the logic between these invocations and make it absolutely > > explici to reduce confusion around the rather inscrutible parameters > > explicit ... inscrutable > Ack will fix up in v2. > > possessed by vma_merge(). > > > > This also paves the way for a simplification of the core vma_merge() > > implementation, as we seek to make the function entirely an implementation > > detail. > > > > Note that on mmap_region(), vma fields are initialised to zero, so we can > > simply reference these rather than explicitly specifying NULL. > > Right, if they were different from NULL, the code would be broken already. > > > Signed-off-by: Lorenzo Stoakes > > Reviewed-by: Vlastimil Babka > Thanks!