From: Lorenzo Stoakes <lstoakes@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
"=Liam R . Howlett" <Liam.Howlett@oracle.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/4] mm: abstract merge for new VMAs into vma_merge_new_vma()
Date: Mon, 9 Oct 2023 19:21:03 +0100 [thread overview]
Message-ID: <ec520a80-4b4f-4eef-ab17-1ee3ebc2982e@lucifer.local> (raw)
In-Reply-To: <e0300e5a-394d-0cdf-4044-a9a67a24c9b3@suse.cz>
On Mon, Oct 09, 2023 at 06:04:47PM +0200, Vlastimil Babka wrote:
> On 10/8/23 22:23, Lorenzo Stoakes wrote:
> > Only in mmap_region() and copy_vma() do we add VMAs which occupy entirely
> > new regions of virtual memory.
> >
> > We can share the logic between these invocations and make it absolutely
> > explici to reduce confusion around the rather inscrutible parameters
>
> explicit ... inscrutable
>
Ack will fix up in v2.
> > possessed by vma_merge().
> >
> > This also paves the way for a simplification of the core vma_merge()
> > implementation, as we seek to make the function entirely an implementation
> > detail.
> >
> > Note that on mmap_region(), vma fields are initialised to zero, so we can
> > simply reference these rather than explicitly specifying NULL.
>
> Right, if they were different from NULL, the code would be broken already.
>
> > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
>
> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
>
Thanks!
next prev parent reply other threads:[~2023-10-09 18:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 20:23 [PATCH 0/4] Abstract vma_merge() and split_vma() Lorenzo Stoakes
2023-10-08 20:23 ` [PATCH 1/4] mm: abstract the vma_merge()/split_vma() pattern for mprotect() et al Lorenzo Stoakes
2023-10-09 15:22 ` Vlastimil Babka
2023-10-09 18:19 ` Lorenzo Stoakes
2023-10-08 20:23 ` [PATCH 2/4] mm: make vma_merge() and split_vma() internal Lorenzo Stoakes
2023-10-09 15:45 ` Vlastimil Babka
2023-10-09 18:20 ` Lorenzo Stoakes
2023-10-08 20:23 ` [PATCH 3/4] mm: abstract merge for new VMAs into vma_merge_new_vma() Lorenzo Stoakes
2023-10-09 16:04 ` Vlastimil Babka
2023-10-09 18:21 ` Lorenzo Stoakes [this message]
2023-10-08 20:23 ` [PATCH 4/4] mm: abstract VMA extension and merge into vma_merge_extend() helper Lorenzo Stoakes
2023-10-09 16:30 ` Vlastimil Babka
2023-10-09 18:22 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec520a80-4b4f-4eef-ab17-1ee3ebc2982e@lucifer.local \
--to=lstoakes@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox