From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CA36C5AD4C for ; Thu, 16 Nov 2023 23:08:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B18E280012; Thu, 16 Nov 2023 18:08:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 461C3280011; Thu, 16 Nov 2023 18:08:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DBD8280012; Thu, 16 Nov 2023 18:08:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1E3AE280011 for ; Thu, 16 Nov 2023 18:08:41 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F186EA0CD8 for ; Thu, 16 Nov 2023 23:08:40 +0000 (UTC) X-FDA: 81465358800.05.B432B15 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id A4D944000E for ; Thu, 16 Nov 2023 23:08:38 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gjTqWTGC; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700176118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rk1XvrBGytixpa3Vi9kkQQNLQDVV+cUQfUIaz33yvuw=; b=ZCaXT8VUW0dAfKIrJwPfdEaS1+YAOjsxggK3y8sBaMI3qW1FNSlpDVhiYxWIAKMRL7mxdO tz0zetXXOHgLbuv8vDm1KQHN+buZlxnqM07iHnxIWSxAKDqzXyENuxUQ4ypJbbctirei1E byp1610o0lj6c0IUjFKYeCk578zg8kU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700176118; a=rsa-sha256; cv=none; b=7OtRx77wkxGEqCrfdFzuX3ampNiaRz3m/h1VDEXMyq7hZSB8OcMUFM7UMCuSPk+yK/jFJM 5Wic0g/raqd0TcKgkliYB+RVuIve0lXOIAHtDxgyZpeVUs1/UzVpou3mIs5BGjTkj4Zkna pIf76v3Z2DXsCDrE6ruICKlVafKBgls= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gjTqWTGC; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700176117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Rk1XvrBGytixpa3Vi9kkQQNLQDVV+cUQfUIaz33yvuw=; b=gjTqWTGCYtSc19nC+phCRV3zLIxtQqFZGJzfobyzBTbVR5WMtgBjwr+gi8aS0rmYVkcnNn k7glUA8tsxPGeXFp+ESOyYu6jOkT5h6cUE7WN+F5IDS+IZqWsWSHD2ZLD8BIrYWYl3dwOt LpF6W8DaF75NLnLqeXKtYGyRjPxHA7U= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-hFPofjhkMVWDC5btBVfJDw-1; Thu, 16 Nov 2023 18:08:34 -0500 X-MC-Unique: hFPofjhkMVWDC5btBVfJDw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4090fa518bbso7798315e9.2 for ; Thu, 16 Nov 2023 15:08:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700176113; x=1700780913; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rk1XvrBGytixpa3Vi9kkQQNLQDVV+cUQfUIaz33yvuw=; b=lps+Mm58eb53SSG7o9pqZkH7DLv6LoTtnjziHEYap3x/k1dPKyNrSMD5SM5raUHhRc j3TqfAibRMrEL8h6lZSg+sbFemRNQNwrPhMZNiCYexXv+LPyMEtIsfDmQMcvRiraDzdJ TjDPqcs4Ywg/e6fptt4GavXi7Jm98/XsjryPO2x+58nnnDM7xITqm212S0YvDOscFckF Z7dp8NXqdIq0kqTMqoAeLvLbDcGMlSLs8fWye4yd8Nrn42qBN1Or4BbUeGXocbgCnsMy JpNl8ObhHfUeqqTXDIRz7fzbClzMh5aiAaGmzLoQziPFBpqUZ1N+bKlc/Q9TWUFlKxNG 7TKA== X-Gm-Message-State: AOJu0YwBYXJgdIzVDom7YDsUW9G6EhsO/nqfXVeqZaa5mQxMpgn7eBdy m/KL+WEcZr8jGECBH0Ipw6rthYac44bBsjoZdQCiKJ3Dl6OpK1xkELAK+NfGmQfPmT6+Jvkyg3w MnB7Ox96uUnE= X-Received: by 2002:a05:600c:1d9b:b0:409:67bc:e1cc with SMTP id p27-20020a05600c1d9b00b0040967bce1ccmr14009691wms.36.1700176113393; Thu, 16 Nov 2023 15:08:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGf7gqOC1iCqOj8ZxAPTIce917kdXd/Zg/xN294Ih2xkHUPKqJsBcfgmPqReLICglBlTde2Lw== X-Received: by 2002:a05:600c:1d9b:b0:409:67bc:e1cc with SMTP id p27-20020a05600c1d9b00b0040967bce1ccmr14009670wms.36.1700176112992; Thu, 16 Nov 2023 15:08:32 -0800 (PST) Received: from ?IPV6:2003:cb:c714:e000:d929:2324:97c7:112c? (p200300cbc714e000d929232497c7112c.dip0.t-ipconnect.de. [2003:cb:c714:e000:d929:2324:97c7:112c]) by smtp.gmail.com with ESMTPSA id r14-20020a05600c35ce00b004094d4292aesm676638wmq.18.2023.11.16.15.08.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Nov 2023 15:08:32 -0800 (PST) Message-ID: Date: Fri, 17 Nov 2023 00:08:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] implement "memmap on memory" feature on s390 To: Sumanth Korikkar , linux-mm , Andrew Morton Cc: Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML References: <20231114180238.1522782-1-sumanthk@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231114180238.1522782-1-sumanthk@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A4D944000E X-Rspam-User: X-Stat-Signature: jes53jychsx14gz954p58xr8ijobmff1 X-Rspamd-Server: rspam03 X-HE-Tag: 1700176118-299003 X-HE-Meta: U2FsdGVkX1+P7T2UWLqSCxbJkpSRXoU9UGtZvpW8G0T6xO4BVf3PT+uj5CWcSKFWMeFDyN0RoqVGBa4KtBwn32l3f/h6Q83gLkpd8MceH6wG3QQ1e0lb1Wek+ZqvRJkoeMZsHWFC04O6wQpOqjoHeHpdBFeOg9EJJvzIb9EQPHqpEd/EWylvXL8cIM3Cz8k8MobD+BMgdOhKvxE6B9RrXSWT4UKHUhVoS7/Mhat9hy7ybKkk0ytBZQY0FhTj/VuKKgGfr/akDfaMWdIRN9pzf8NMXzTwexOqyeQIpOl2P1cCrhMoiDMXfnWshPYa32X2ZFuZ9b9GOrTCfc0ANXYkk7MJgo1bSxTFEnDCsQ9A6rfX4z1zuRNFpIINSJkdC/DIZtc7MEdkgd3QAcSrOUq45VZ6d+Dl3W1V58ofFgTi8zQ14bZNW8uGoYCm6ZnQQjBXrCfhXvhvP3y441Y1EOE7OE4vtv1O2A4yHXimCBmVeTzTahKkfhlWMt/C0ewADgBMxUnA9tnWi0+R2CqfoPFMjMJHanbyE+KE5BJ8+Zh9YhGQlpu15fgRFRjN57nw7bmvrGbh3cC2mMHe1ezW0Oo32RfvI3BrCm8TujJWLG2yhZUDN0H3FpIxpWuAJO4umNz6RjcVHCO8AY730v43e0fGeLWNLKoGJypF9MVKUjXo2PrgpqKiiP216CnuxTMuycOCicx7aYlNgoNJFXjTAFKWBk2iKHYR0P+8jZwMcF21L4bGltImpoKYccEbQIEBeZmvI85hxihRMIlhWksgS8wNkk/fCRlYfYBrzn5ZqJjCIrMs1wNpBsjPmiPoB3LX/QPER21T+MTpuq/8rHVTby8cmjfk5IlGJfZoU6l4cPXuEIyy8K4e+NC8IypWJe/CzWYg7fFysXETqRAaLkPHFZ+dpSDzkRem18fQ2QspQEkMUFiUzEYkmcGcJpIX+7w97I80cYiwgLloEatLC6QfTP6 BX8isAyl gRA8YxEqwAj3OonLzvolraFHNDXNokY0uyl44dCGgL8hxJA7Xh9F9QIMW3AIsDuaiZFkh9FTj7q3qoqlAuJbFN3Gbes+spi3AN0FNLb/6xeL5YR9axKSC7os4FkvAndUVYCyzPozt+1BV5TOSqKdowbIrwlP2oRYp90qrL4+sUeqt9rgPunhamX+bTIm0hp78d9miMHeN7VTLiFK4J3lpugZZpSydd72oTMOlaW3WVzxHggQ22C7JpAfY7yViOW5oA3IwrmKeYsoDSAF8YeOQm5Iiu0E+KK2EwxF8Nn7G6tKB4W2i8/4P9howDOo7eUBrfPhj1JnNrYIFSScr4zvhLeHSGsQ3PnVTGHgle3QYjxuKngXMfLlth98gks2BphArPPPVt+IfT4sbWjUbCETage2L8BlP6nvK3ivG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.11.23 19:02, Sumanth Korikkar wrote: > Hi All, > > The patch series implements "memmap on memory" feature on s390 and > provides the necessary fixes for it. Thinking about this, one thing that makes s390x different from all the other architectures in this series is the altmap handling. I'm curious, why is that even required? A memmep that is not marked as online in the section should not be touched by anybody (except memory onlining code :) ). And if we do, it's usually a BUG because that memmap might contain garbage/be poisoned or completely stale, so we might want to track that down and fix it in any case. So what speaks against just leaving add_memory() populate the memmap from the altmap? Then, also the page tables for the memmap are already in place when onlining memory. Then, adding two new notifier calls on start of memory_block_online() called something like MEM_PREPARE_ONLINE and end the end of memory_block_offline() called something like MEM_FINISH_OFFLINE is still suboptimal, but that's where standby memory could be activated/deactivated, without messing with the altmap. That way, the only s390x specific thing is that the memmap that should not be touched by anybody is actually inaccessible, and you'd activate/deactivate simply from the new notifier calls just the way we used to do. It's still all worse than just adding/removing memory properly, using a proper interface -- where you could alloc/free an actual memmap when the altmap is not desired. But I know that people don't want to spend time just doing it cleanly from scratch. -- Cheers, David / dhildenb