From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9510BEB64D9 for ; Mon, 19 Jun 2023 06:40:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1B998D0002; Mon, 19 Jun 2023 02:40:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCB418D0001; Mon, 19 Jun 2023 02:40:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB9828D0002; Mon, 19 Jun 2023 02:40:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BFF728D0001 for ; Mon, 19 Jun 2023 02:40:45 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 823E71C7C13 for ; Mon, 19 Jun 2023 06:40:45 +0000 (UTC) X-FDA: 80918549250.28.BC44515 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 614BA40007 for ; Mon, 19 Jun 2023 06:40:41 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf07.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687156843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TicZn0SCoWfv1pOo33zAJyllEu6sfpVy4yQtUZQ+QH0=; b=1qkrXW36wTA12BuTHkLiwNeT2eyIWPSHNpIp646pQYlns4yNB5KkpPfaclpT+IjL21cUP1 iFiDnqrUmXGkxUR98k6kh+CgRDScDieL/zA00dCt1NpAI2gxsLUVVJYdV0rFRYvbV5yG0s lhWS3YGPI+HKC0q57uOYOBDeUaBysc8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf07.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687156843; a=rsa-sha256; cv=none; b=4LJR90hnqfIImYrS0RKbSM3mqxxRQG6kYdD21da5xK8cYMYLmXOkWOdc1LXbwu+kKWX9jp OUrCsQxyoq0zoysLTPnqzl74S+b6RYNeR7yYLY5Ca3b3R0DGGRWfC3FWuFWY9QA+Y1HUoM bXa0MTB0Kd9MPTGBTWGfFB2i93pWfoY= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0VlQ13kY_1687156836; Received: from 30.97.48.59(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VlQ13kY_1687156836) by smtp.aliyun-inc.com; Mon, 19 Jun 2023 14:40:37 +0800 Message-ID: Date: Mon, 19 Jun 2023 14:40:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] mm: Fix shmem THP counters on migration To: Jan Glauber , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230619055735.141740-1-jglauber@digitalocean.com> From: Baolin Wang In-Reply-To: <20230619055735.141740-1-jglauber@digitalocean.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 614BA40007 X-Stat-Signature: 9bs9fazxkc17osqnzye6onmiq79oacuc X-Rspam-User: X-HE-Tag: 1687156841-50248 X-HE-Meta: U2FsdGVkX1+t6JR4Yvi0o69Jd1H9amt+JYXp99e+QG6NM8fA25BLh9KKt6I0W+xYitgAdLa9DqfpMS6vU5NhnjIzf7vmNDAccYDrDdFGsk2PWSrmkImJxp1auctmZ40hj1jjtbWGipHeiX3Y7gBvw2bhOPY/bPmNpdq9/IkJqF63Egj8pLs5OmrE+NkPU2BXV+GDCwbBRwq+XgdZupfH72CA6n/zpDo1D9ymHP9uk4uRLLAfq0M4AhocSXy3oKUSodGq1z5vR3BmcabufzvUBShQ+/Ma9fpvxHfIyIQvy63dN1D6+pp8a8qUM/h/ux4vgiX/0H+OusLlRxVPLVdvNugYBj+uHdR2ItPOzUQKImEgENozjtiq9AL3ciNkT+s/W0M4gQxGyF7qw17qshEa7cfrt8g+JIEAtYWs2uA40bb9rGp37+mOiTJ3sM9FVy6eXiaz/bX9j7QqoGn3d2UIY7VH55gv100/yN221q422FJzMS1q4GZ/yzlB6p385/86RnRus+xqJ9gZ/KxUex6OAcJFmIpQhaQzxFwIRMX0z/UqRWUM7dDHTmx62Exo4h/H98i32VB24o5vAdxDW6ON2IOtdS1RtI5/JQ9CKFJ8gDK5qsFJpywthtyorQB7imjw9wGp6nUkeJyPo4qNj1F75MI2dhR+aB8fTEcFTcUOMiP7bfUO0p1kh+IeHaLCK0RYLTFFxDfVg6lGU0o4oy+vSCW2oIdkTTt/0WxVAONglYwyxeYNqAvPERE+1VDG1R7+aK48sZdFJzBH588jFOFNA2XUVg1DKFo/rzDoTFwMhHtKI+uHnk6CJrksDBf8Neuh3GyxL0Z1nJn4R7W7CLk4xW2XSoHR2uhBSXgRzy38x0X2UyT1FrnvEYUgnGDNeauvw4je4mOcrnFFJafgD2YoeTMDjiU939W1Jzz3TgCSCHNQwGEwOKMyOUKWNjXQwo38Xz7nkTiapZHg55H0G0k kBO+T+fe 1ARgFcGYcv8PVhc96OYDVqSyXJJA/KI9NKIK222cdEirJ1K5AXplgLFQy2fdATEq3VB6PEfxxQzMD2y6oNkJVVNBRR9wKYtPuCXP738kZXa1upBI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/19/2023 1:57 PM, Jan Glauber wrote: > The per node numa_stat values for shmem don't change on > page migration for THP: > > grep shmem /sys/fs/cgroup/machine.slice/.../memory.numa_stat: > > shmem N0=1092616192 N1=10485760 > shmem_thp N0=1092616192 N1=10485760 > > migratepages 9181 0 1: > > shmem N0=0 N1=1103101952 > shmem_thp N0=1092616192 N1=10485760 > > Fix that by updating shmem_thp counters likewise to shmem counters > on page migration. > > Signed-off-by: Jan Glauber > --- > mm/migrate.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 01cac26a3127..d2ba786ea105 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -492,6 +492,11 @@ int folio_migrate_mapping(struct address_space *mapping, > if (folio_test_swapbacked(folio) && !folio_test_swapcache(folio)) { > __mod_lruvec_state(old_lruvec, NR_SHMEM, -nr); > __mod_lruvec_state(new_lruvec, NR_SHMEM, nr); > + > + if (folio_test_transhuge(folio)) { > + __mod_lruvec_state(old_lruvec, NR_SHMEM_THP, -nr); > + __mod_lruvec_state(new_lruvec, NR_SHMEM_THP, nr); Should be NR_SHMEM_THPS.