From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B61CE7719A for ; Sat, 11 Jan 2025 21:26:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC94E6B0085; Sat, 11 Jan 2025 16:26:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E530D6B0089; Sat, 11 Jan 2025 16:26:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCB8B6B008C; Sat, 11 Jan 2025 16:26:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AAD146B0085 for ; Sat, 11 Jan 2025 16:26:56 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0D7B91C8418 for ; Sat, 11 Jan 2025 21:26:56 +0000 (UTC) X-FDA: 82996456032.04.21DF7D6 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by imf15.hostedemail.com (Postfix) with ESMTP id BF83CA0005 for ; Sat, 11 Jan 2025 21:26:53 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=fu-berlin.de header.s=fub01 header.b=S5bV6qWK; spf=pass (imf15.hostedemail.com: domain of glaubitz@zedat.fu-berlin.de designates 130.133.4.66 as permitted sender) smtp.mailfrom=glaubitz@zedat.fu-berlin.de; dmarc=pass (policy=none) header.from=fu-berlin.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736630814; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Za3lNvTGyrdHzd0kbc6Emf7PfenPferYFam0p+9TJkk=; b=ANMPFKx51bjMfV2F3fo/yPrKS/njgtDD6885fCZMWTx/bhVt4D9xuKk69UU1l/5sJL/ky1 6t3TqiG8TiWGvi7A+15Vj9jUzDLuiHItlpoefckFZ52CEOFp5wC0J2choidbLYDzFsoJHo IJXVFwfPrbon/cu7qSEL4js7pX4MM4E= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=fu-berlin.de header.s=fub01 header.b=S5bV6qWK; spf=pass (imf15.hostedemail.com: domain of glaubitz@zedat.fu-berlin.de designates 130.133.4.66 as permitted sender) smtp.mailfrom=glaubitz@zedat.fu-berlin.de; dmarc=pass (policy=none) header.from=fu-berlin.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736630814; a=rsa-sha256; cv=none; b=tJeYexzybHRcKIzU61+/mHL2VbBHJTcKWaJQbBj62zF4NKTyj48eAKPIwWaOVwIcGaMIhV YNho8FfBnKVLMcKm79gFVJbXfGekysbLsZ+HJSaQBtcUGCfcIYWIDw4nGf/tJXgpdJ3fHT fxx97v7SOv9LuS+Pcgg1apD2JXnEq+c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fu-berlin.de; s=fub01; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Za3lNvTGyrdHzd0kbc6Emf7PfenPferYFam0p+9TJkk=; t=1736630813; x=1737235613; b=S5bV6qWKBVszcnvORQF4EuSiRIDuu5SjuE5h1TXDNIn5P9aVrk5H5QhBnjyUEWGk/wypTmlmbiN jz3+LxcnNv7ENxCvc+cyjKV/vlXw3HISMRM4NqXjAIN81vc6uiJlfDANgZ4Qzco5a0lqu3TUBCpi/ dpcO0vgNgRUoPkn7GNgjbDvDaptplKxCqwA0yOm4qelFmKaldDf+2tbVrZAQ+x50uLOhti5qWidnu AtFY9fPXEcrX7840BXw0abXjpuZC6UVjea9Octg7fX9jVWn9MPyvI8Djj4t9JDPVirTJ2HYggcSDd gRqOGF/DMZsKnG173+DOm7KVV5fbsJ4eg4Vw==; Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.98) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1tWj0H-00000003Tg8-2wmF; Sat, 11 Jan 2025 22:26:45 +0100 Received: from p57bd9274.dip0.t-ipconnect.de ([87.189.146.116] helo=[192.168.178.61]) by inpost2.zedat.fu-berlin.de (Exim 4.98) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1tWj0H-00000003tVX-1oT0; Sat, 11 Jan 2025 22:26:45 +0100 Message-ID: Subject: Re: [PATCH] alpha/elf: Fix misc/setarch test of util-linux by removing 32bit support From: John Paul Adrian Glaubitz To: "Eric W. Biederman" Cc: Arnd Bergmann , Richard Henderson , Matt Turner , Kees Cook , "Paul E. McKenney" , linux-alpha@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michael Cree , Sam James , "Maciej W. Rozycki" , Geert Uytterhoeven , Michael Karcher , Chris Hofstaedtler , util-linux@vger.kernel.org, linux-mips@vger.kernel.org, loongarch@lists.linux.dev Date: Sat, 11 Jan 2025 22:26:44 +0100 In-Reply-To: <87jzb2tdb7.fsf_-_@email.froward.int.ebiederm.org> References: <20250103140148.370368-1-glaubitz@physik.fu-berlin.de> <24f03227-1b55-4e50-b6e9-7ac74fda2602@app.fastmail.com> <678ee681-12c3-4e79-a04b-495daf343846@app.fastmail.com> <82d33a2d-dffe-4268-a175-4536b3f9c07f@app.fastmail.com> <87jzb2tdb7.fsf_-_@email.froward.int.ebiederm.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.2 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.189.146.116 X-ZEDAT-Hint: PO X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BF83CA0005 X-Rspam-User: X-Stat-Signature: 4ia3xqkr467r6x4f5bjap33t5xyck7dm X-HE-Tag: 1736630813-536467 X-HE-Meta: U2FsdGVkX1/yDLzO9A+VmO1ZMGNjaiuaEJJ2Eo5rABBWF5LN4Fdlt8ImsyM59n/mmkSAPAjFLkclu80jw68M1QMUTYRxbgy3B1UmNXuQtviY8DRrM+ArWzCPxd4kBivRQL9c7w2FMKzfQzveNqu0AZiEs2d41oUQdJWcYnfugy8A/udzWfCXeeNlGLKTeHLv0wZxhqiCLHQxeU99Ko5NvC7HXOS/9E6byM4oe/TNzbwBjXvBrqQ3+wJ06r3N8lIa3UvX2PzBgDl5a/lmbNmg/r511bSMiPeYoKldOaRpahTHENd0AZdzzCLw05Y1AzGvCnnyuB+n7M5dyAa3a0umiLmDnSYq0ifSaXWxk2SDq1/BmYCdcw+8jE4HUkG387MTPhxG5ysqmyjawgsrX8xgz/DLcB7Y8qNgg5tcDjgf4vY8WwExtIOj0IHKAcBiZkZjeHOwhMcaClIlBQwSVPkh2XCCJZ4j3fHfAxDARmdc3PhfhOfTwQdwcnHXTLioQq8zmtfQ+HLef3s+5N+LRNc5NRyqqWvQdGxMm+UmyacWFu+wBXpXRiYBvTThQlZQWZ6NFy148aCEfUP+YLSxxitnkmVEaNa8W57cvn9FUyT6x0zIrShAeoyWTFffI3PI3NqWza6unUbZ5io1qj48c5VlttWCOhlAUb1y+dOnH3u2DkFV6IME+qsF3CSbITu+mKMw614k37C7UOYrcapDhcD+z3Lk5aqA/Qr12P4RWqn1oWFoUtTuJrd0jL73JKRZmbVH8NoDcqFJZ+AUzGG+fbhIMqFgMVdGpjYUDdrxZ91YIdbSsYORqCPlp8g5ONRTsDGH0H6qhI1piKMKkYSwFnvMZIvP9CoANqN0YYFO6OtOLEeh2/w5oAVxzRkJAqY8VbC8VZuXiBxrJjsvTnQSuFLgTzjC/GamZ6lpD3ZX8+F+5n3seEKFpDhRkAIE6x4nLAXigLRQ10mR0UpPKe8YsBY h2SJBOYj 0FT4eS8lnhgI5hcUcuAZSp3LBWbJqyqPYUwVkFwOEZd41Hl7hqD4YkSLw7v2bbI2LsisyjsRt0C1dIVrELNoCqQVTX3eNCiExA1ln5J1i6QXyIFOoGqKhK+QSmkHWck9HgMyXHwQJbUP8/oS+o0EM8wLT4h6zyH9wy6rAzGHX/QGBIzs+UX71ka+F+1uqPYS/mk2S1tPebd10dAAHPyZPFXpch4XflSHN8K8dBpQMGaHQ1mNlfqhXEK6PI9FhAPOCkmw7MdrCK8QJJZb/B1yJGku3WkjJh2+QFuym9OAPizFGPxkmatt6pIsUP3sUxXwtwNBDFWyTbvqlsciM6UhRsqcsz4+CrCn5gwpYUmdX+pTtAWZMIqMQ7BKqpiSrzui4r4WGD8NufTsoh+dYIkqFYflz0N3k6qRBydui9quSlPXnRbR50ToFtv+YT7ZhYc2hrvYsOI3CVTF1z895Z6CyikTdJ0HPaHeOOjKJsbebwBx7nS1cWul4qkCMtSMcQieFeL3Pcy2bf83vewSBkHI+8LsC28nwbA9pDk7EneOPacO4xp7Y5o/kSnPnkiKiUGlyocXXfCqjDuzB2LnKpMjRQMT5oASeqDEnx04HCs+2inQWao8gHqaO5FyhKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Eric, On Fri, 2025-01-10 at 18:16 -0600, Eric W. Biederman wrote: > Richard Henderson writes[1]: >=20 > > There was a Spec benchmark (I forget which) which was memory bound and = ran > > twice as fast with 32-bit pointers. > >=20 > > I copied the idea from DEC to the ELF abi, but never did all the other = work > > to allow the toolchain to take advantage. > >=20 > > Amusingly, a later Spec changed the benchmark data sets to not fit into= a > > 32-bit address space, specifically because of this. > >=20 > > I expect one could delete the ELF bit and personality and no one would > > notice. Not even the 10 remaining Alpha users. >=20 > In [2] it was pointed out that parts of setarch weren't working > properly on alpha because it has it's own SET_PERSONALITY > implementation. In the discussion that followed Richard Henderson > pointed out that the 32bit pointer support for alpha was never > completed. >=20 > Fix this by removing alpha's 32bit pointer support. >=20 > As a bit of paranoia refuse to execute any alpha binaries that hafe > the EF_ALPHA_32BIT flag set. Just to fail explicitly in case someone > somewhere has binaries that trying to use alpha's 32bit pointer > support. >=20 > [1] https://lkml.kernel.org/r/CAFXwXrkgu=3D4Qn-v1PjnOR4SG0oUb9LSa0g6QXpBq= 4ttm52pJOQ@mail.gmail.com > [2] https://lkml.kernel.org/r/20250103140148.370368-1-glaubitz@physik.fu-= berlin.de > Signed-off-by: "Eric W. Biederman" > --- > arch/alpha/include/asm/elf.h | 6 +----- > arch/alpha/include/asm/pgtable.h | 2 +- > arch/alpha/include/asm/processor.h | 8 ++------ > arch/alpha/kernel/osf_sys.c | 11 ++--------- > 4 files changed, 6 insertions(+), 21 deletions(-) >=20 > diff --git a/arch/alpha/include/asm/elf.h b/arch/alpha/include/asm/elf.h > index 4d7c46f50382..50c82187e60e 100644 > --- a/arch/alpha/include/asm/elf.h > +++ b/arch/alpha/include/asm/elf.h > @@ -74,7 +74,7 @@ typedef elf_fpreg_t elf_fpregset_t[ELF_NFPREG]; > /* > * This is used to ensure we don't load something for the wrong architec= ture. > */ > -#define elf_check_arch(x) ((x)->e_machine =3D=3D EM_ALPHA) > +#define elf_check_arch(x) (((x)->e_machine =3D=3D EM_ALPHA) && !((x)->e_= flags & EF_ALPHA_32BIT)) > =20 > /* > * These are used to set parameters in the core dumps. > @@ -137,10 +137,6 @@ extern int dump_elf_task(elf_greg_t *dest, struct ta= sk_struct *task); > : amask (AMASK_CIX) ? "ev6" : "ev67"); \ > }) > =20 > -#define SET_PERSONALITY(EX) \ > - set_personality(((EX).e_flags & EF_ALPHA_32BIT) \ > - ? PER_LINUX_32BIT : PER_LINUX) > - > extern int alpha_l1i_cacheshape; > extern int alpha_l1d_cacheshape; > extern int alpha_l2_cacheshape; > diff --git a/arch/alpha/include/asm/pgtable.h b/arch/alpha/include/asm/pg= table.h > index 635f0a5f5bbd..02e8817a8921 100644 > --- a/arch/alpha/include/asm/pgtable.h > +++ b/arch/alpha/include/asm/pgtable.h > @@ -360,7 +360,7 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte= ) > =20 > extern void paging_init(void); > =20 > -/* We have our own get_unmapped_area to cope with ADDR_LIMIT_32BIT. */ > +/* We have our own get_unmapped_area */ > #define HAVE_ARCH_UNMAPPED_AREA > =20 > #endif /* _ALPHA_PGTABLE_H */ > diff --git a/arch/alpha/include/asm/processor.h b/arch/alpha/include/asm/= processor.h > index 55bb1c09fd39..5dce5518a211 100644 > --- a/arch/alpha/include/asm/processor.h > +++ b/arch/alpha/include/asm/processor.h > @@ -8,23 +8,19 @@ > #ifndef __ASM_ALPHA_PROCESSOR_H > #define __ASM_ALPHA_PROCESSOR_H > =20 > -#include /* for ADDR_LIMIT_32BIT */ > - > /* > * We have a 42-bit user address space: 4TB user VM... > */ > #define TASK_SIZE (0x40000000000UL) > =20 > -#define STACK_TOP \ > - (current->personality & ADDR_LIMIT_32BIT ? 0x80000000 : 0x00120000000U= L) > +#define STACK_TOP (0x00120000000UL) > =20 > #define STACK_TOP_MAX 0x00120000000UL > =20 > /* This decides where the kernel will search for a free chunk of vm > * space during mmap's. > */ > -#define TASK_UNMAPPED_BASE \ > - ((current->personality & ADDR_LIMIT_32BIT) ? 0x40000000 : TASK_SIZE / = 2) > +#define TASK_UNMAPPED_BASE (TASK_SIZE / 2) > =20 > /* This is dead. Everything has been moved to thread_info. */ > struct thread_struct { }; > diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c > index 86185021f75a..a08e8edef1a4 100644 > --- a/arch/alpha/kernel/osf_sys.c > +++ b/arch/alpha/kernel/osf_sys.c > @@ -1210,8 +1210,7 @@ SYSCALL_DEFINE1(old_adjtimex, struct timex32 __user= *, txc_p) > return ret; > } > =20 > -/* Get an address range which is currently unmapped. Similar to the > - generic version except that we know how to honor ADDR_LIMIT_32BIT. *= / > +/* Get an address range which is currently unmapped. */ > =20 > static unsigned long > arch_get_unmapped_area_1(unsigned long addr, unsigned long len, > @@ -1230,13 +1229,7 @@ arch_get_unmapped_area(struct file *filp, unsigned= long addr, > unsigned long len, unsigned long pgoff, > unsigned long flags, vm_flags_t vm_flags) > { > - unsigned long limit; > - > - /* "32 bit" actually means 31 bit, since pointers sign extend. */ > - if (current->personality & ADDR_LIMIT_32BIT) > - limit =3D 0x80000000; > - else > - limit =3D TASK_SIZE; > + unsigned long limit =3D TASK_SIZE; > =20 > if (len > limit) > return -ENOMEM; Compile- and boot-tested on QEMU alpha, works as expected: glaubitz@debian-alpha:~/util-linux$ ./tests/ts/misc/setarch=20 misc: setarch ... : options ...[ 110.194279] pid=3D558, = couldn't seal address 0, ret=3D-12. OK : uname26 ... OK : uname26-version ... OK : show ... OK ... OK (all 4 sub-tests PASSED) glaubitz@debian-alpha:~/util-linux$ Tested-by: John Paul Adrian Glaubitz Adrian --=20 .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913