From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F249C7618A for ; Mon, 20 Mar 2023 08:30:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 135F86B0072; Mon, 20 Mar 2023 04:30:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E3876B0074; Mon, 20 Mar 2023 04:30:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EED5E6B0075; Mon, 20 Mar 2023 04:30:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DF5576B0072 for ; Mon, 20 Mar 2023 04:30:08 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9591E40B27 for ; Mon, 20 Mar 2023 08:30:08 +0000 (UTC) X-FDA: 80588604096.24.246CB2D Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf24.hostedemail.com (Postfix) with ESMTP id A75B4180008 for ; Mon, 20 Mar 2023 08:30:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qqzTKoX6; spf=pass (imf24.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679301006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IOF4ZXLbqCUFP0rJHH2mzd0wteSSnr5LaAAXjkDeZsI=; b=2hpwBRXo0Mky1/6Z28SfHS6syliOmgHZCo1WZCLUexNcqBAx2POjRSUyXlQckNfXT0iXx4 +i3xLcQUbuyTUjo1Mn8yPY/ZFwMwvMr6oVRX77aTz/oas86A9sgMZQ31RSqBHQdjUqcdsy lFLjjINcdcb5LsIMzjPKHgzqLDh5+GY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qqzTKoX6; spf=pass (imf24.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679301006; a=rsa-sha256; cv=none; b=iWaZuakOWlsCglrwJtz0GbbCd5x10d55O142JbcYE+moMpzXnff0VgAGw9ICoAegnSBy97 Y0Trv9Ce3SiQ4kOVUJ9DOV0NXGxNSSvcg38Aje98clP5YNHibNQ5wfmqr299vvu3B+Xcww BGN+PZdC/+uvtFNhachlyZ0VTCxHKPg= Received: by mail-wr1-f46.google.com with SMTP id v25so6004814wra.12 for ; Mon, 20 Mar 2023 01:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679301005; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IOF4ZXLbqCUFP0rJHH2mzd0wteSSnr5LaAAXjkDeZsI=; b=qqzTKoX6mjNXfOi1lncIPMjRKAtzBqwnFFPw+i/pc7L0cD+zJMKHzmGTmCxGt8um0g UE2yiBmZopbmFLyVnd+83qZClYw2gI3s4zVheaCIJUYZvYERTdE5qYrZvhwYWgR6LZzX 6eP81zC/vO3yVa8wi2ppKow1ZeOGaDrRtyRu8o0MSRPrwnbOuCtpv2fpgEoe7mxKT/6Z 2MIxQTHZeLWK9yd+tC70pZW+jzB4RxdNxVtqQtTDd3tisB5oez4PMxU/y1OC+JBb+W3Q 6nd0EtcbtEuKE/eu+y6I1aBhfYDJU4B3MxrS13E3nSY+vdEiUmwyyPGHemR+y0Bu+6Bt drXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679301005; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IOF4ZXLbqCUFP0rJHH2mzd0wteSSnr5LaAAXjkDeZsI=; b=Mpx4A7NX/Jko2yXo4SC1ig2YV7Rv1Wy4n+gVFqSBSZCGlvL/i7UYRAQIB+we8pcF1u cdvaqmKvUKX8Sz/cyZh39m5Nz8Wj3b9uXjVWAGk3xgI4LacqZWvFnscXPs83OJbrBngw p5Mg7OF3DWcZP9oEM5tFI4tcMkwgYFHcHhmJvhrP4QpSNu5hAkM0Id/kVP/IPx4IKMFl bwHlNmYy9vTA5jOZLk5Qg9+TNqnN7uqoVytWsEIXB1g4l7NqTwWUL400DtEZ0E4J4qCJ nbYWrroDDevS16KvAYx6kEAPab20J09htTKaj3TKFkaiMKCEKPRmwCCFrYeq1Z47+Yoq no4Q== X-Gm-Message-State: AO0yUKXRil8tSCIjQwdPqpZuRoD7XcjgHRqJGGlODEkGw9DuC/ySZiWM X223XR6cX5mfSMJT2KOIodg= X-Google-Smtp-Source: AK7set9V17xN1GV2zmXnzgZRsia56c9Egzq/+s2UUqUAebggUDpwcq2uZ0zAI5tFk9trI2loLG5L+g== X-Received: by 2002:a5d:56c8:0:b0:2c8:c440:cb05 with SMTP id m8-20020a5d56c8000000b002c8c440cb05mr12763870wrw.55.1679301005101; Mon, 20 Mar 2023 01:30:05 -0700 (PDT) Received: from localhost (host86-146-209-214.range86-146.btcentralplus.com. [86.146.209.214]) by smtp.gmail.com with ESMTPSA id p5-20020a5d4e05000000b002d75909c76esm1396888wrt.73.2023.03.20.01.30.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 01:30:04 -0700 (PDT) Date: Mon, 20 Mar 2023 08:30:03 +0000 From: Lorenzo Stoakes To: David Laight Cc: 'Matthew Wilcox' , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Andrew Morton , Baoquan He , Uladzislau Rezki , David Hildenbrand , Liu Shixin , Jiri Olsa Subject: Re: [PATCH 4/4] mm: vmalloc: convert vread() to vread_iter() Message-ID: References: <119871ea9507eac7be5d91db38acdb03981e049e.1679183626.git.lstoakes@gmail.com> <63c98c518c1e4bfbb36c5295ba7c959d@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63c98c518c1e4bfbb36c5295ba7c959d@AcuMS.aculab.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A75B4180008 X-Stat-Signature: fhie58ia6aqspap1jqwsw9z981udgdoa X-Rspam-User: X-HE-Tag: 1679301006-414704 X-HE-Meta: U2FsdGVkX193eKWlMVedFRJz706Z+OJNkbBj8kbHxMF8C1oQFB6pvZrE4OQJ6aLbNfguzYf27biPyfhmVlaD7lP9zC9fwv379H3uNHGlBAjoQ9SgtLVzlBJzGZweXaHufReA/DnnUJF+cl295TxLm2TrkVQno3r2hvf7czTwHYs9jYk7W5goBPQRCo7v7hC17XksBUlPSjFrk7+1JZ8OVmFjzc6iT7+eAqa83fXAYTsMyTs21nx3vHhqEeiHiNFioRTivaRvk7RyiXFN8Kdil1f1ppp0PzgLgXY5/uZRt9mK3p64AQxbfCXjuTElSH9EmANAIIBq1WIjjREcS3hDo9VLpjoU+HZodzgWdmFznsFohIjJQAJ8xAfjYF3GBoktjQ1iLTt7aLEhfDbJsm6uyCr25rzBwiLzSS8raF+ooXOhrcoPtIlFzwK9XwbB/7KDarN5rg8nWgCuo6EWBSwYLeC4bK60dhbK50wo0t8/7nGPBpqANaPA4UabKyOvs1w7mhaw98OUq8sLn7Po4ZHnjlLvVjDLc1+4JLbnYQy107SUT7OxJ2DUvzHQCrRpJWnzVxk9fBASbd6Wn7AV09c7Hhi+Gogao1muqVG5GBr4xAvRAHdNF1PNkEs/y40/CAbiGPP8rnCisCDgqHFePYe7oiY6gTJo+l7OCpmYi+ZlOP5uOriqMCrFJVmBxTDh931QAF0kmU/VSNppZO5mbduop4u59I9zNv+X2QNMJSs8driKN9Budjghu7hkRJjABJdWHWVeMbfYWysiE9q6yMMbSrqmKOq1c6HkrMm9iUA2lL6i6xQaOrHHHsFgr2NgqQB+dugaYVHYZrJSCc4teuf9mnykp5vRlkG9TmCpTmcfrrCkwtJPKPnWZ4DRKBVURPadAPn2Isgz9/AjHGqMNCILbcN5O6TaVZ+ZkBGsKDoWVVUrxItjJ0G+bQY64uwKuGwywUBbVOA2dsQoiMAO2Ex vkzvKR8S K8/QfGC/hgl/KpMys8xW1+NCykW7Gh1cYTj4c+itH8Emf7gBE15skSsUSoG+trrAZuKalnxjnB/fM7idbOEczi0ca9xIQXPdA0T86vvbpz6tDm1rDXhV+pqWdqqtlwXOU6vIv2iNmG83uCwYvzRndCjPovV5yqxprpKvQ12ygdUw85kGw8eTREg7C9WukFn4/1nTNlsea3q/lGyQt/ctXRfwbFwXHiIAsxJO2JBaL9yjuMzNub22Yec3hNddV93QHckxt+AP490L4NQbLlAe+kKhXyaJMuG76rypaMCBi1OVKRXDXUeWsyMeKVrkTrTYNkKHLBo7s0UmRzJ220rSj1wGmiZ3JWuv0YsT3AeTrl2tChxPeQXNXgdpUJzMEV/nO0s6+nzrFAgiBwS0e3mMV5Tn0rinCiuylia9vXF9spXRNI0bu10Bd4ft+stNuBQoVRksdYW+g3MiIGRl6FSM2fq9K7IX4GicyKoh335ycKGWwKkao120BbX08ww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 19, 2023 at 10:28:12PM +0000, David Laight wrote: > From: Matthew Wilcox > > Sent: 19 March 2023 02:51 > > > > On Sun, Mar 19, 2023 at 12:20:12AM +0000, Lorenzo Stoakes wrote: > > > /* for /proc/kcore */ > > > -extern long vread(char *buf, char *addr, unsigned long count); > > > +extern long vread_iter(char *addr, size_t count, struct iov_iter *iter); > > > > I don't love the order of the arguments here. Usually we follow > > memcpy() and have (dst, src, len). This sometimes gets a bit more > > complex when either src or dst need two arguments, but that's not the > > case here. > > And, if 'addr' is the source (which Matthew's comment implies) > it ought to be 'const char *' (or probably even 'const void *'). > Ack, I'll update on the next respin. > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) >