From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH hotfix 6.12 0/8] fix error handling in mmap_region() and refactor
Date: Wed, 23 Oct 2024 11:26:00 +0100 [thread overview]
Message-ID: <ec22d5b7-14e9-4df8-9e78-ca0af1b09930@lucifer.local> (raw)
In-Reply-To: <20241023032236.c7a4f842b7a71c0e492bf322@linux-foundation.org>
On Wed, Oct 23, 2024 at 03:22:36AM -0700, Andrew Morton wrote:
> On Tue, 22 Oct 2024 21:40:51 +0100 Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:
>
> > After this we go further, refactoring the code, placing it in mm/vma.c in
> > order to make it eventually userland testable, and significantly
> > simplifying the logic to avoid this issue arising in future.
>
> I'm not sure that patches 4-8 are strictly 6.12 material. What's the
> thinking here?
>
Patch 4 is absolutely critical and without which 1-3 don't really matter
all that much. It also needs to be backported (I will be doing some manual
backports for that once landed).
Patches 5-8 could be held back to 6.13 if preferred as, while nice to have
as they do further work to eliminate this class of bugs, are not as
important.
prev parent reply other threads:[~2024-10-23 10:26 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 20:40 Lorenzo Stoakes
2024-10-22 20:40 ` [PATCH hotfix 6.12 1/8] mm: avoid unsafe VMA hook invocation when error arises on mmap hook Lorenzo Stoakes
2024-10-22 21:14 ` Jann Horn
2024-10-23 16:56 ` Lorenzo Stoakes
2024-10-23 9:11 ` Vlastimil Babka
2024-10-23 14:22 ` Liam R. Howlett
2024-10-22 20:40 ` [PATCH hotfix 6.12 2/8] mm: unconditionally close VMAs on error Lorenzo Stoakes
2024-10-22 21:15 ` Jann Horn
2024-10-23 17:00 ` Lorenzo Stoakes
2024-10-23 9:24 ` Vlastimil Babka
2024-10-23 16:58 ` Lorenzo Stoakes
2024-10-23 14:26 ` Liam R. Howlett
2024-10-23 14:41 ` Liam R. Howlett
2024-10-22 20:40 ` [PATCH hotfix 6.12 3/8] mm: refactor map_deny_write_exec() Lorenzo Stoakes
2024-10-22 21:15 ` Jann Horn
2024-10-23 16:35 ` Lorenzo Stoakes
2024-10-23 9:57 ` Vlastimil Babka
2024-10-23 14:30 ` Liam R. Howlett
2024-10-23 16:25 ` Linus Torvalds
2024-10-23 16:37 ` Lorenzo Stoakes
2024-10-22 20:40 ` [PATCH hotfix 6.12 4/8] mm: resolve faulty mmap_region() error path behaviour Lorenzo Stoakes
2024-10-23 12:58 ` Vlastimil Babka
2024-10-23 14:20 ` Liam R. Howlett
2024-10-23 17:11 ` Lorenzo Stoakes
2024-10-23 15:02 ` Liam R. Howlett
2024-10-22 20:40 ` [PATCH hotfix 6.12 5/8] tools: testing: add additional vma_internal.h stubs Lorenzo Stoakes
2024-10-22 20:40 ` [PATCH hotfix 6.12 6/8] mm: insolate mmap internal logic to mm/vma.c Lorenzo Stoakes
2024-10-22 20:40 ` [PATCH hotfix 6.12 7/8] mm: refactor __mmap_region() Lorenzo Stoakes
2024-10-23 14:38 ` Vlastimil Babka
2024-10-23 15:21 ` Liam R. Howlett
2024-10-23 17:39 ` Lorenzo Stoakes
2024-10-23 18:12 ` Liam R. Howlett
2024-10-23 17:30 ` Lorenzo Stoakes
2024-10-23 17:19 ` Liam R. Howlett
2024-10-23 17:52 ` Lorenzo Stoakes
2024-10-22 20:40 ` [PATCH hotfix 6.12 8/8] mm: do not attempt second merge for file-backed VMAs Lorenzo Stoakes
2024-10-23 15:01 ` Vlastimil Babka
2024-10-23 15:16 ` Lorenzo Stoakes
2024-10-23 18:16 ` Liam R. Howlett
2024-10-23 18:20 ` Lorenzo Stoakes
2024-10-22 20:58 ` [PATCH hotfix 6.12 0/8] fix error handling in mmap_region() and refactor Lorenzo Stoakes
2024-10-23 8:37 ` Vlastimil Babka
2024-10-23 8:45 ` Lorenzo Stoakes
2024-10-23 10:22 ` Andrew Morton
2024-10-23 10:25 ` Andrew Morton
2024-10-23 10:26 ` Lorenzo Stoakes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec22d5b7-14e9-4df8-9e78-ca0af1b09930@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox