From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D68B1C369D5 for ; Sun, 27 Apr 2025 06:05:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6F3F6B0007; Sun, 27 Apr 2025 02:05:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1E476B0008; Sun, 27 Apr 2025 02:05:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C97ED6B000C; Sun, 27 Apr 2025 02:05:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9098A6B0007 for ; Sun, 27 Apr 2025 02:05:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 84BB95AFAA for ; Sun, 27 Apr 2025 06:05:43 +0000 (UTC) X-FDA: 83378787366.16.6F1D91C Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf02.hostedemail.com (Postfix) with ESMTP id 26E1580007 for ; Sun, 27 Apr 2025 06:05:39 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=HRH2qzVH; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf02.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745733942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OAjq9LNbHWJusiKPmnwrKHajD1aAkosJ1OT3e2o8rvg=; b=Y7hQX4hSfNeesTOrZAXLZoLrpDsIyH5HJwg5pK7Yu6BOHWp33eyD30t+rmG661h22jUmyY 4Bvev4a+1l51G6VqR2gcnJ5GoGTREiUe3T9WirgeSqREVTMNX/RNRwkkIEPEeKRs0kz4aL wvejvYbX8cXXMcAcoKa0nwY2oIy46i0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745733942; a=rsa-sha256; cv=none; b=egj21LmWkNWQZVh8sjxA/pYS5rB4MkfXIQMTkd5Sk9bwd15Hnyy85njsh44vTeceaLCC3w KAF9fZ5w8mAMlMpqDUueswlaIUZkGhKVbEBb0XbgrAySRm3kQj7kI50+N+SqaPOTn7/F3N NuEEubA6iX72KpUw2rKTLJcScdGGbyY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=HRH2qzVH; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf02.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1745733937; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=OAjq9LNbHWJusiKPmnwrKHajD1aAkosJ1OT3e2o8rvg=; b=HRH2qzVHA7NBxO+QRQB2AGiVqX3kqQ2yWUfw7v2SMkqhbPsWwYpFHefGUaRXAp35YfS/8zO7tHllc2434dPylfkBhZBOP/m/r9u87KEoN1jK4xZWwBk+b5BYcqs+JL4Faug8Vs+nRPj5S2kzlpQWA8U8Q3dltO4SX7vl0/jlhtc= Received: from 30.74.144.120(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WY7rxZ4_1745733935 cluster:ay36) by smtp.aliyun-inc.com; Sun, 27 Apr 2025 14:05:35 +0800 Message-ID: Date: Sun, 27 Apr 2025 14:05:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm/huge_memory: Adjust try_to_migrate_one() and split_huge_pmd_locked() To: Gavin Guo , linux-mm@kvack.org, akpm@linux-foundation.org Cc: gshan@redhat.com, david@redhat.com, willy@infradead.org, ziy@nvidia.com, linmiaohe@huawei.com, hughd@google.com, revest@google.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org References: <20250425103859.825879-1-gavinguo@igalia.com> <20250425103859.825879-2-gavinguo@igalia.com> From: Baolin Wang In-Reply-To: <20250425103859.825879-2-gavinguo@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 26E1580007 X-Rspam-User: X-Stat-Signature: rr3gxwmoyw9epb7xw1yn6f1os5yybwp5 X-HE-Tag: 1745733939-959431 X-HE-Meta: U2FsdGVkX18YXeoPTYJx4Iccp7JSdwI0vX8EXTE2qkOOewQhlyspowWWJuDIBwM6S2RosKHdSbrnAtP8m6T5C07ZcbulmDkEIfI5FVSx93akIzHALZr9XwC7hKJOPIu5sH1pXIEqEpE0vU9cjWENPIcdlLlwTBsVLlwHBeyhGgCCOyai4tdBNBmxRh2wPMeXIYovZq+bR7K9Wa7c+sygFsYwINgRwH9dhBgoxsi3kHJ28HKeB2mjXihVv3XAWwU7X4IZwVDx35oh60MhAJdIU9c9X9PBIQMJt0KxZTmVE3ov0VmjB70SW5vTZV78LioZ4KCpmb7jPLbzHzrv/0u8+zCRkpS8l+ryIubkJYsJfnutGlC6Cb0SnvCbz53oIJKRK0G9HahZzXsRoGAGcdsa59+tpNksFxbV0VZWKG7srl0djqSJEKiGo9jDYHViG4EPQcx8H4FZqCPxPKe7PNdzwetxTZ5u2xwv5AmvrmX4ciDPf252m+ouv5cpMQIf9p87w7FRkIjWJT/09wlSnX+xx+PklFc6hZN5DSUbnKFSjW2WTkVUDrzWYo1fkD5KwyaC8A1BgzZ7w/BfG3R+3phY6+9N7SoP4wFA419SkcFm9IarjQ2m8Y7mRPjo1Rj5Fv7jaYC21hcP4mTri3N9HjjcytaGBhxdYNJyY02LRQ24MTEGOOnFC5XzuSXr+r4O7oG613/UfTb2Z3tOkO6tvnvIqPXKJzSHxPq+2GgkI/YSXmofaZLaTKLadJ/98cm7MNosjtQPerQoTJBGwNmcOa1hJGb59hWXZQSvDLeJjOI8x8TKvtLJAIIWce0LA2w7/wvLR9zG+pqmLwCX2z0dIS1MxsKpl8S4kKio1wu/0buD7pBodDQA7HssQXluavpnoe5Bs5B3+/RQoyEOHq9lkYloZ2mXNY5055WlwCcId5LFZvkPGFN7SDHSv4uaPpaVsWsa9wElKpoxTWWaVkh9wSR hvdzOHmv Tqf4B4Uh0EdV0afaxWcFE9XDYr53Dbl0DKvvCH9inSXOsVoz0stprwj47QiPugEPrT9DVyt8rvgmoM4FU/jAu8Gs8U9HPU7CsYyc7bTJawWIDQ67IbMDek3Rzizin6AQ1IH8lqpeGZNQMdqleolUz8NE0PcXTzbcXbo5qKZCugojsqVnM+Z2WmGrQvZhMfJRyeW3bOncYd3kN5RLSQztcdcjI0JIIgayf8L2TPKnhDMf7nl5uSLzMdWhI6/uWAvtxKUrxQFvaKye5D5a0dleaNWoujoGqOo0eylCH8wexE/dYCr4umKLWOukhRit86lt5yW44USP4rVuPhqCz9NUWsACIc5RMLU2P7kfh4SiPddc4r0BB6Mfu2O/hRdyF80aWGmA53Jpa5HFg5wDXJ/kLIdro69NZ6LbgQaFNyj6+O0EG7Xw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/4/25 18:38, Gavin Guo wrote: > The split_huge_pmd_locked function currently performs redundant checks > for migration entries and folio validation that are already handled by > the page_vma_mapped_walk mechanism in try_to_migrate_one. > > Specifically, page_vma_mapped_walk already ensures that: > - The folio is properly mapped in the given VMA area > - pmd_trans_huge, pmd_devmap, and migration entry validation are > performed > > To leverage page_vma_mapped_walk's work, moving TTU_SPLIT_HUGE_PMD > handling to the while loop checking and removing these duplicate checks > from split_huge_pmd_locked. > > Suggested-by: David Hildenbrand > Link: https://lore.kernel.org/all/98d1d195-7821-4627-b518-83103ade56c0@redhat.com/ > Link: https://lore.kernel.org/all/91599a3c-e69e-4d79-bac5-5013c96203d7@redhat.com/ > Signed-off-by: Gavin Guo > Acked-by: David Hildenbrand LGTM. Reviewed-by: Baolin Wang