From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Gavin Guo <gavinguo@igalia.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: gshan@redhat.com, david@redhat.com, willy@infradead.org,
ziy@nvidia.com, linmiaohe@huawei.com, hughd@google.com,
revest@google.com, kernel-dev@igalia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mm/huge_memory: Adjust try_to_migrate_one() and split_huge_pmd_locked()
Date: Sun, 27 Apr 2025 14:05:35 +0800 [thread overview]
Message-ID: <ec1eca29-4ac7-4b5c-a962-b81ee4b77d75@linux.alibaba.com> (raw)
In-Reply-To: <20250425103859.825879-2-gavinguo@igalia.com>
On 2025/4/25 18:38, Gavin Guo wrote:
> The split_huge_pmd_locked function currently performs redundant checks
> for migration entries and folio validation that are already handled by
> the page_vma_mapped_walk mechanism in try_to_migrate_one.
>
> Specifically, page_vma_mapped_walk already ensures that:
> - The folio is properly mapped in the given VMA area
> - pmd_trans_huge, pmd_devmap, and migration entry validation are
> performed
>
> To leverage page_vma_mapped_walk's work, moving TTU_SPLIT_HUGE_PMD
> handling to the while loop checking and removing these duplicate checks
> from split_huge_pmd_locked.
>
> Suggested-by: David Hildenbrand <david@redhat.com>
> Link: https://lore.kernel.org/all/98d1d195-7821-4627-b518-83103ade56c0@redhat.com/
> Link: https://lore.kernel.org/all/91599a3c-e69e-4d79-bac5-5013c96203d7@redhat.com/
> Signed-off-by: Gavin Guo <gavinguo@igalia.com>
> Acked-by: David Hildenbrand <david@redhat.com>
LGTM.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
next prev parent reply other threads:[~2025-04-27 6:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 10:38 [PATCH v2 0/2] Clean up split_huge_pmd_locked() and remove unnecessary folio pointers Gavin Guo
2025-04-25 10:38 ` [PATCH v2 1/2] mm/huge_memory: Adjust try_to_migrate_one() and split_huge_pmd_locked() Gavin Guo
2025-04-25 11:10 ` Zi Yan
2025-04-25 11:23 ` David Hildenbrand
2025-04-25 11:39 ` Zi Yan
2025-04-27 6:05 ` Baolin Wang [this message]
2025-04-25 10:38 ` [PATCH v2 2/2] mm/huge_memory: Remove useless folio pointers passing Gavin Guo
2025-04-25 11:40 ` Zi Yan
2025-04-27 6:06 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec1eca29-4ac7-4b5c-a962-b81ee4b77d75@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gavinguo@igalia.com \
--cc=gshan@redhat.com \
--cc=hughd@google.com \
--cc=kernel-dev@igalia.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=revest@google.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox