From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB6C2EB64DD for ; Wed, 14 Jun 2023 11:10:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 381F36B0074; Wed, 14 Jun 2023 07:10:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 332726B0075; Wed, 14 Jun 2023 07:10:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 184698E0002; Wed, 14 Jun 2023 07:10:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 088B66B0074 for ; Wed, 14 Jun 2023 07:10:42 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C5D26C06DB for ; Wed, 14 Jun 2023 11:10:41 +0000 (UTC) X-FDA: 80901085482.12.53E6255 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf28.hostedemail.com (Postfix) with ESMTP id 5CB9CC001E for ; Wed, 14 Jun 2023 11:10:38 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=rx8X9ZRL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of perlyzhang@gmail.com designates 209.85.210.66 as permitted sender) smtp.mailfrom=perlyzhang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686741038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f4Efw5DfR6kHUKoVdNGUy3CfmJsg9ulDb0gdQoCc7P0=; b=mR9T6rXXzpH1CeoOuQjToVQmKGyHuCqYq3fNkr/dS8d/XOKjLsxGK6tdMQaERh9p+BuNKH 8e9EgfZUYHJ1xF2J3ysXSsouFinnxfL8Pniyz120CTUdoB/o8ktXzE34s5rQSISsVU4lvv /wT8waghfOoEmV4dRX4PI+LCY96YIbY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=rx8X9ZRL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of perlyzhang@gmail.com designates 209.85.210.66 as permitted sender) smtp.mailfrom=perlyzhang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686741038; a=rsa-sha256; cv=none; b=5DptIncJl/9NjLw3lYwGG3wFtAUTmr3YGk9f/lwCS6Lm3ZUH1HUrCmjWfIsDhZPMEBMv7/ rbC7Nvq+y2oTEYN1pC4tWiPtJGr27QlEYz+5Ebi5ZUI3sj4lCxhqcQ6Wis5FXJYk9ktk73 arCFwfPIX8OmSBDq504o2t8r0tRJIQQ= Received: by mail-ot1-f66.google.com with SMTP id 46e09a7af769-6b28fc7a6dcso4764630a34.0 for ; Wed, 14 Jun 2023 04:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686741037; x=1689333037; h=content-transfer-encoding:in-reply-to:from:cc:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=f4Efw5DfR6kHUKoVdNGUy3CfmJsg9ulDb0gdQoCc7P0=; b=rx8X9ZRLJijZ79bDCxtwMEkWFu3yVawiFcCxfbgyzqkxCI6pLB3p7dQyTFlz5whya6 oB2DARQUr0yFRrraKgjcckXbC3PuTIVo//mJUap1qUaoHSoI5UeuYxF4PEL+Htfq+bhd 9Yy9+u5aLwuELLRUKywwH97zqDD1YdRYZNzADo7jvcvsEV9ayk+sGiU/idzK9do+j8DU fiSNoJU5IuNFdEMo9sRLY+3Hi4WFbOxxHZVyg29sJz+dLWhtBCgcYBRossWQnvYUL0Un LGJ6/dq+eF86f5cszITdZyPSK+5sI2PwFjOZ7F88EhoGBNaPkzlhZoPVH8At231NjsWb 0whg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686741037; x=1689333037; h=content-transfer-encoding:in-reply-to:from:cc:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=f4Efw5DfR6kHUKoVdNGUy3CfmJsg9ulDb0gdQoCc7P0=; b=Gg4sHN6dtw+02Xa9Piq3tQGf7N18NIylJa0FWlmViFy5g8KnXjRhFeydkcLn+uB84K MEE6v986oJSTVNuAOzvzFi0+O84dX9ATtUYVXf0zuIjnjL9dQ5PI0eLLzBU38IoJ1mjg /DmNq3OHZ1ONuf9U1zV93VyFUWgSAGQ4YxoUTKjeID0esMgQf+NcB6xWTC7DAMfkUYkQ CvVDxim97YMwgIgXijvLjabXVMa0sfQ1p5QvSOGyV/WLtH36lF6b34/ClhhjNgXgCW/g voYhcnyoolz15/ez9C2Lf5vDlp+/RfcLFXMSBTNQ2BC/3GREkYkEQ6VeE1uQxIxzEmnr NnwA== X-Gm-Message-State: AC+VfDynoKiIiCLHOFva9xHe/ruBgNFOAZ8gV2g7v/Km2mrKTgu7AvYM gtJpE25cevrL0HlDD/2JclI= X-Google-Smtp-Source: ACHHUZ4C1mnG/aBQjZIam0AFKfCICLTOt3dN0R8wjrlWCEmsZoSXw3aCovYyUIg+wXiftNnZQ/mJBA== X-Received: by 2002:a05:6359:c20:b0:129:d027:3a62 with SMTP id gn32-20020a0563590c2000b00129d0273a62mr10143801rwb.16.1686741037153; Wed, 14 Jun 2023 04:10:37 -0700 (PDT) Received: from [10.200.9.101] ([139.177.225.249]) by smtp.gmail.com with ESMTPSA id g12-20020a62e30c000000b0065438394fa4sm10465810pfh.90.2023.06.14.04.10.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 04:10:36 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2023 19:10:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v2 0/3] Optimize the fast path of mas_store() To: "Liam R. Howlett" References: <20230609120347.63936-1-zhangpeng.00@bytedance.com> <20230613172352.u4oj5ydoloztvdqk@revolver> Cc: Peng Zhang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org From: Peng Zhang In-Reply-To: <20230613172352.u4oj5ydoloztvdqk@revolver> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5CB9CC001E X-Stat-Signature: 7brr4ioks8bfdfzcs5wyu34gg3qiw8ak X-HE-Tag: 1686741038-470462 X-HE-Meta: U2FsdGVkX18dg3arkxTYpASXy2icw0fJiAcHaUNlzSzh0CFClX2AxZTalxtJpd7jQ6EDtqIBmi2gIbnvoyl6uIpncYfPPM/S0QUEAIkQtSL7x4UUVFxT1SoVKkcFz1CmtY9fEUb/lcOvTVQaYZep/RmWLt4PKHIPg2khlGc/GsL+sRn0xTWe6CcfiyTFMtu0eCUtNv41FfEjIYhaVdSzqjkLInsPRghodKA6T4aPM8qSRmk9g4ad+bR619Ls6taNbct9l95WvU4AWF13su1zw6cvf5fKGGsUZgFoz69Y4Vr4MugZ2Oq0FEWgcoRUg7dC+d+7m5vHNHaGy1Mfq1hDV3fPkkjCadLlLgGXKWoHyIYtITvuLsw9jSOuCgSPJqtsiv01eHw1DygpzxogrkIH6IckYxef8a3Gxpj/BleAOUkFIbpU6FopHLWqsnuZ6Ri/hUxsqVygiwunRFSh211KnvitRyf1/JCGGQICr0YsV3a7KcKs31odoYM+llvj5nPfa2+yfd0NEwQ60wVVbqdf8FGNrEXh3V8kYlibVkhCoakR6AHyarrXDaBvnxNe6qle5vDfZg72ITB9w2pOvOmbYbKHQXBuH5HeEIQiaPMv/KWk9kP8IunnAJRnHaSmktOHN5kYRpa0AIzW1VzjwJ4U/Kq0LyxBSVeVnPuAUu8mEnnCh4CC/DXfpkLUvblHeNAR8YNHsrvegJag0kulmvWRhVn9Cgxsiljzsqkicx3ICmAe2pqymdS0RBZvPQzDrRTkN5K6H6ZyIPCZgxU1SXDYo3Eo5ixDGddwXVJIn42UZ/RMYoXK3quJJoHHjFn6xKZkOFy+5RfqggVAOO8SkbFqvMysSbdXucP+wRtniml9/l6L+IVs1toZM3uu9nsItvAm8y0qeEVDMT80J+JzogqdfvK02YS7FSLCxeOzPbCyx9+8Tj6a9qBH5v/SJZfF6TFUWI75Fy40DfMdE2AQogq HYuz127Q NxKdN6okoqA1yFiGuqmgyOPLXyObv38UrCauk0Ev0w7iGVevK8xVdoU8K3QQeRmJGHoP7fCrUhD+AD2TRFcyEH4VxYmhgK7CN2s0SSO9bRFo/VOfInV/IBJEuShPlS1+p7mzDpYisAnllciFaac37eWQqhrONkt5w7QhmI/Gcr8+xU4Sx/Y9IMHXwquaZl6W5j/aZXCN76tuME1y65cTui1SaU+TjXzxrT/FOXMYS+X7Ot6Hudopzip5FkJWtx80/EVGQzPntJoAaRpjYujqU50m8lqswWaK9kFdRZKJiWDaoEktd70LamPj+hM06kqRrwwOBrfXP4zmTPkHIuwCJMgDR3DkKtkocLb82iQ/FOK5oQ6O6Aj67zZxxvWwaN/ZKE2QXrBU98S+Z2U3aMFHMKFD9aOwmrqv7u7axZz2YOcw6Jvy6C0HeaGYRqRNWf/8NAHWGMeslKa3WxNugLhKcXKGQ4YcBMnsyeKE/b+4+f+mxZGRJneXcDZaqT1cuhusS1bL1GvbGPVYBy7ItWTCnmGPRrJERqFkXqgNNalVK4m5O0KgDy85tS3WHpg7BpXLuP8OitV+vN1p5tkrjclNm4GijXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/6/14 01:23, Liam R. Howlett 写道: > * Peng Zhang [230609 08:04]: >> Add fast paths for mas_wr_append() and mas_wr_slot_store() respectively. >> The newly added fast path of mas_wr_append() is used in fork() and how >> much it benefits fork() depends on how many VMAs are duplicated. >> >> Changes since v1: >> - Revise comment and commit log. [3/3] >> - Add test for mas_wr_modify() fast path. [1/3] > > Thanks for adding the tests. I'm just trying to figure out how to best > address testing this in RCU mode. And by testing it I mean add tests in > RCU that does this and detect the failure by modifying your code, then > change it back and have it pass the test by falling back to node store. > This would need to change tools/testing/radix-tree/maple.c to update the > testing there. I see what you mean now, I will try to make a test in RCU mode. > >> >> v1: https://lore.kernel.org/lkml/20230602075353.5917-1-zhangpeng.00@bytedance.com/ >> >> Peng Zhang (3): >> maple_tree: add test for mas_wr_modify() fast path >> maple_tree: optimize mas_wr_append(), also improve duplicating VMAs >> maple_tree: add a fast path case in mas_wr_slot_store() >> >> lib/maple_tree.c | 69 ++++++++++++++++++++++++++++--------------- >> lib/test_maple_tree.c | 65 ++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 111 insertions(+), 23 deletions(-) >> >> -- >> 2.20.1 >> >