From: Bixuan Cui <cuibixuan@huawei.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <linux-next@vger.kernel.org>,
<john.wanghui@huawei.com>, Roman Gushchin <guro@fb.com>
Subject: Re: [PATCH] mm/percpu: mark pcpu_chunk_type() as __maybe_unused
Date: Tue, 14 Jul 2020 21:33:29 +0800 [thread overview]
Message-ID: <ec030764-e2e9-726b-8d7d-13c929eddc51@huawei.com> (raw)
In-Reply-To: <20200714225311.7aeffffd@canb.auug.org.au>
On 2020/7/14 20:53, Stephen Rothwell wrote:
> Hi Bixuan,
>
> On Tue, 14 Jul 2020 13:41:01 +0000 Bixuan Cui <cuibixuan@huawei.com> wrote:
>> Gcc report the following warning without CONFIG_MEMCG_KMEM:
>>
>> mm/percpu-internal.h:145:29: warning: ‘pcpu_chunk_type’ defined
>> but not used [-Wunused-function]
>> static enum pcpu_chunk_type pcpu_chunk_type(struct pcpu_chunk *chunk)
>> ^~~~~~~~~~~~~~~
>>
>> Mark pcpu_chunk_type() as __maybe_unused to make it clear.
> Given that it is in a header file, it should probably just be "static
> inline" (which will also suppress the warning). As should
> pcpu_is_memcg_chunk() and pcpu_chunk_list(). Also, without them being
> inline, there will be a new copy for each file that
> mm/percpu-internal.h is included in.
>
> And that should be considered a fix for "mm: memcg/percpu: account
> percpu memory to memory cgroups".
Thinks，i will fix it.
next prev parent reply other threads:[~2020-07-14 13:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 13:41 Bixuan Cui
2020-07-14 12:53 ` Stephen Rothwell
2020-07-14 13:33 ` Bixuan Cui [this message]
2020-07-14 13:34 ` [PATCH v2] mm/percpu: fix 'defined but not used' warning Bixuan Cui
2020-07-14 13:45 ` Bixuan Cui
2020-07-14 13:46 ` Bixuan Cui
2020-07-14 18:41 ` Roman Gushchin
2020-07-15 0:24 ` Bixuan Cui
2020-07-14 20:22 ` Stephen Rothwell
2020-07-15 0:25 ` [PATCH v3] " Bixuan Cui
2020-07-15 1:50 ` Stephen Rothwell
2020-07-15 2:18 ` Bixuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec030764-e2e9-726b-8d7d-13c929eddc51@huawei.com \
--to=cuibixuan@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=john.wanghui@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox