From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02661EE49A6 for ; Mon, 21 Aug 2023 12:52:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 788738D000A; Mon, 21 Aug 2023 08:52:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 737E28D0002; Mon, 21 Aug 2023 08:52:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6004F8D000A; Mon, 21 Aug 2023 08:52:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4D2A78D0002 for ; Mon, 21 Aug 2023 08:52:37 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0E7CBB21DF for ; Mon, 21 Aug 2023 12:52:37 +0000 (UTC) X-FDA: 81148100754.17.5A64CAF Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf29.hostedemail.com (Postfix) with ESMTP id 84ECD12001D for ; Mon, 21 Aug 2023 12:52:34 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692622355; a=rsa-sha256; cv=none; b=pDxJ8whzDgtdDDMPvhGrfrq/NZXphbQINAVLKLuxfwqFKbzJhn4J5SML/ljn5Nyb9uy+YU r4hs1YYdnAwEy2OQiSmT6MfHvdBSA8wECBsTv4xvybmfVqmh/EEx/zGEv2Q62HaeZemgF8 TdojirAIF1bNqctLaQbOs/c2XolvdII= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692622355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=biW3/yDX5XG+0QeD3YljktHh5dVBSWRbjkHARH2Q4B4=; b=UwQwSbL84V6ykHVNaCz3qdXGtZNMPsctMEUiMGrN+/B2lcDqVIznU3PCCNFI5VivTJzl0J vLpeuX8d6042JCyqxA6gf7aYM5NeQ1NB8vhwgDXGybexLgT/2sTAKsRfZ1JH6NvnN7qYXm YpXxLUPiZxz3QpxXdSeyXGYOUqctTVk= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RTskF0FJmzLp1Z; Mon, 21 Aug 2023 20:49:25 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 21 Aug 2023 20:52:27 +0800 Message-ID: Date: Mon, 21 Aug 2023 20:52:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] mm: migrate: remove PageTransHuge check in numamigrate_isolate_page() Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , , , , , Zi Yan , Mike Kravetz , References: <20230821115624.158759-1-wangkefeng.wang@huawei.com> <20230821115624.158759-2-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 84ECD12001D X-Stat-Signature: qjdjprtopbt6k1313spfdtrx1r9rumtn X-HE-Tag: 1692622354-638705 X-HE-Meta: U2FsdGVkX1/gZvZfNRE5tvKX3WYrUnSFFmmKMv+iQTUXf/HqH3kWZjgb9gkPg0wi5PsS3efUjDoW2w5YJWOkaD5kUWm0WbFM6LB3Ecoe9M+FHx09prMdw1k2KFmZGNS5kckmIPvzBeMsRG6Q2alf9szUatZK5ytIOMV5gaiDhvmxcgJesadd4+m4Uo02oK5VmvrE3CjSRnrE9mi9GhC3U5rMa3gwjyr/E3i7aG9alpuF/gFakuPP2apgvdWaCxlJkrqm2cQBCHaUShwcZPF0DhGUefeT0UeznwXvpmGfMTr4C8r2eV1350FFBWXwxnaSPbr0Y6NRtanxABGQ4lcDF4wSiy57SlbDDWHknoVpvhX8CW7AFj3i3btwc6wUNDtAyd9Vn0t4jq1pxUn3zDJZhMJTEgp6L/t2rQqZO5yEdNnzWkDRFvhBWi2U0dpY6Kl4fgaI9e76ufI21GwEoRH4Wzlgxi/3egR6u1F/A850FL5JpbV1br63AhoSkV21XvPVVYa+WbJTGytcG6e1zbb+O87a5Dxmf+p3rZsJ6wmVXBPcrqcizgkYj7obW6JN7AMyAezLExKNoU81y0ItI4yh3We/ril6o9IAFdTQbdsmZSefbnrO+NwxYaqFRX9jIt1ewDmbGAyJCG1AbdHNBe6GgvMd9o5Wi1OLLnewHVpcDxJlX5lQrgA5Lj5F2uBp5xTWXVSBdrmVgr3JXAUqYkcKXw6E2BOE8PRyGXGv0AfdEJ0oUOvnoB5DwrlJlZQud6hG4T9un1S2nzPKf1FmYQc1Ymq9JSS3rC0BgBwm9XqmfzL8V5O5QZgMzQ00qbw8EvEywAyHniY/3a0cAAj+M11UWFZBHJwwTQz/aO9vMetmuv43Wpf19Pu9ty8dJUGrHleDs4ZnefxVuyptp9MpBvTMbbleV8Vi/sUgi9WSa+BoexUEvqt/egGameoR5uTTLXGeQKSrCbvp43bYqq/pGIG 4HHZnC3u z9z1Wuf9rB0hH3Yc+c7mL1a7NqdQA0D/K9aZO5+llHM0ZQJ1NvId8nyuFBKCo1nO+JkEhbz33GDGAbuBsXVzN5DLcFqPLfjlaS4/NcLfUJwtZH9sGiomi4O09nQVmBv9AfzRfdNKoia3yUsBBnwmTWReQSHEP3l8IQWwAjK0w3u0nFzxNxCNAOtZDyZlrhGwzo0qCsAY6/s1fHUG8931RFqhapZoJK+HoLjstrbPxkyKfayEOTAkykH5qDuwhCWa6svhnU7qjZSCSDbvReWe9XPpwcGCKa2ddB4rP03PcII9yoLY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/21 20:38, Matthew Wilcox wrote: > On Mon, Aug 21, 2023 at 07:56:17PM +0800, Kefeng Wang wrote: >> Since we begin to convert the numa migration code to use folio, which >> could let us to handle arbitrary sizes of folio, so drop assert that >> we only support PageTransHuge page(PMD size) when order > 0. > > Have you looked at the implementation of PageTransHuge()? Your > description doesn't match what the code does. oops, not only PMD size... > >> Suggested-by: Matthew Wilcox (Oracle) >> Signed-off-by: Kefeng Wang >> --- >> mm/migrate.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/mm/migrate.c b/mm/migrate.c >> index b7fa020003f3..646d8ee7f102 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -2483,8 +2483,6 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) >> int nr_pages = thp_nr_pages(page); >> int order = compound_order(page); >> >> - VM_BUG_ON_PAGE(order && !PageTransHuge(page), page); >> - >> /* Do not migrate THP mapped by multiple processes */ >> if (PageTransHuge(page) && total_mapcount(page) > 1) >> return 0; >> -- >> 2.41.0 >> >> >