From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F10E7716A for ; Tue, 17 Dec 2024 05:52:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35F1C6B00A3; Tue, 17 Dec 2024 00:52:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 30E9A6B00A9; Tue, 17 Dec 2024 00:52:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D6226B00AA; Tue, 17 Dec 2024 00:52:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F1DA46B00A3 for ; Tue, 17 Dec 2024 00:52:48 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 930B81A0486 for ; Tue, 17 Dec 2024 05:52:48 +0000 (UTC) X-FDA: 82903381428.11.FBFC449 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf16.hostedemail.com (Postfix) with ESMTP id EE5E0180006 for ; Tue, 17 Dec 2024 05:52:15 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf16.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734414753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pLkYsWwdKvlM/jJ6J11NcUw+6AUgE5QkEqgmF9J3/8Y=; b=SLdySoMCPrv6xBSThn57er0F58en/hab+jq4S3GzMSuXlh75Ibkpl8POqfNn4Wi+yzFnSC qPO+szM0S6md9NjEz0WiGAVWkqLAW9y1x/8L2AHoGtv2VahkJRJVKDPVTSg8QKLy49akCV hfT0lAewqiRGrfsrle2IKZISRtIlSos= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734414753; a=rsa-sha256; cv=none; b=UDp+204judokETrL81jph8IPKCgzZHXmGQ4SO4ArDxTCX6/Frqc75OjkYWcdkIMubPkmJL GVNpwSR/O9FswCuxQYrFitUjAZtSM0d8d7jh9Hicv2tNbUZDUr4J8ssFn6SGqRpTz57oRS KLfcA1D6+VCcOjmYPZNj/QC8Hc2/DtU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf16.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CFBD11007; Mon, 16 Dec 2024 21:53:13 -0800 (PST) Received: from [10.162.40.67] (K4MQJ0H1H2.blr.arm.com [10.162.40.67]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3ECAE3F528; Mon, 16 Dec 2024 21:52:35 -0800 (PST) Message-ID: Date: Tue, 17 Dec 2024 11:22:32 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 01/12] khugepaged: Rename hpage_collapse_scan_pmd() -> ptes() To: Matthew Wilcox Cc: akpm@linux-foundation.org, david@redhat.com, kirill.shutemov@linux.intel.com, ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241216165105.56185-1-dev.jain@arm.com> <20241216165105.56185-2-dev.jain@arm.com> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: jnoouukzfxcjn9fquanfthgwg81ngxjw X-Rspamd-Queue-Id: EE5E0180006 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1734414735-881510 X-HE-Meta: U2FsdGVkX1/JX4z5Pl3YWtzL1BLjGdZZkywDFMCW3pk7rbhnD9iE6Sux8eI8nTLBG5lVY9sAUUc8uXoJ1+R4ufJgXB7pIq+1aC9FMYgEHg8L3hqlBC0Np7OK5YfTknsmWHRm3rcm944eZLuqVy4VMrbbxkhSSaxbf4AA/p5kpQgILP14EkxsvyFM8d5riJGdUdoaIyf+rTvfQjTlA3WQZaoYztMJYVFgIijq6g3QdW6qzu8bJszgs6RJJFV1JacBDRHG0e6w+SR/20ZvqbwGeS2wKtTmG72gqdH6q14AnOMrP7/BbQzIHWxwu3Hu2Ss1tvA9P8nWa69xHuwAEFzzi0VuoVBOhdkNKZtgpVmGOIsfAQi47LJq5ifLG/DzvFxzNAPr3vZB8sc2GAgk3eIanwKvJTU7kQcqf32HGw0YsMpSDuJihC2wuDuxebciznWL87P9NSmz7YRsOXUl+m5xqJjMmE6zzR2JVPtytdMfKaqwbXv3kXoYp0V+JpXStiwDyAkwWlp4MNM6YWvdomkKhReh/qye6ZU7r0EKtFwOWy7CPu6oQj2bOgIYGgflRSaqBUUUlz8EGRlPOm78MRCZ8ErbAP78GafXvJada3ph7Wq+hp1ab6g6yQkUBMLDJBSpmcrm60BnAGyXsKxYtqkhq+kF6hM6pX/UNJsRIaWS89iuQS6nGdjfbLC+U70Hk1p13nwYcwJfUUUT/xzlT+qX22tSMVEi86LKxLMMbiuS+HM3nk64YcoO5bIdsly+HdSc8S5x9Z35/4FQvgHu0ghilft4EUiB7DLqGpNRejv8/ctUc5Nfw3Fy1nIAEhLz4lJm4rQ2JzieMzui2+eO+4I3zNlSV2Di/VHbnTxhKQEo3FZlug+z6CbLJ0njRRc+sYU6Cbcvg7aqULgOBHVGHHUMGMGYBvdvBdNDXTo7tCyE8bUpLBDreYKHAII4BWEvgYslVm65wofwuLZKEm8pN+2 JROlDtpi IyZLNNjuAazg1zXHpl3ormAafZBWAnbj7XZ2WcC7q253h2I0ZixbdkxJBIzKq0TBlNCd0rTfa5qQBCQcTlVvGfszdemZS3rWHL1sd91SYzH4900gZTSd7JIartzEUwX5GVYwopFJAzgkwiXgH67AnO6YodEGuWtZb5uAX7HLhFRZFNplArIqe4GGSTV9StD9RM1kr22CqB01zq2oX3SDRrCWvE2F1oq119xAkCy2FEz5vJuGcW3CW2T6UHjlr0J0kkzQR7Xw1tyoksGNUSDO/qZome6nRIw7d/WVC9qMjCF1vSfyOmMplfrL7KFv2JY8oN6H0BULWNEdv+L0cUHICCEClWH/y1awV9vougPxZWpztb8xUxvwdUty5Tw6wUHcAjKL5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17/12/24 9:48 am, Matthew Wilcox wrote: > On Mon, Dec 16, 2024 at 10:20:54PM +0530, Dev Jain wrote: >> -static int hpage_collapse_scan_pmd(struct mm_struct *mm, >> +static int hpage_collapse_scan_ptes(struct mm_struct *mm, > i don't think this is necessary at all. you're scanning a pmd. > you might not be scanning in order to collapse to a pmd, but pmd > is the level you're scanning at. I did that if at all in the review process we note that we need to even drop down the starting scan order, so that we do not skip smaller VMAs. I kinda agree with you so till that time I have no problem reverting. >