From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1014C4332F for ; Tue, 12 Dec 2023 13:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DB6E6B02E4; Tue, 12 Dec 2023 08:45:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78A8A6B02E5; Tue, 12 Dec 2023 08:45:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62B5A6B02E6; Tue, 12 Dec 2023 08:45:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 512B86B02E4 for ; Tue, 12 Dec 2023 08:45:33 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 21D50A09B7 for ; Tue, 12 Dec 2023 13:45:33 +0000 (UTC) X-FDA: 81558288546.02.B8DE46F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id D76C040025 for ; Tue, 12 Dec 2023 13:45:30 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bZMelrk+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702388730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iGm9KLE/pE130EnHFNjjiHoY0waSGBlkZUatIGs4SP0=; b=G8KvEe3FcGQT+RSPjxl413BGqMbwLdrK8EmPo1nvhQeuObKuW2aIfSu8BfuHEl+StpAc+Q XfdD6RZmeMjJgDKo1PK/5MtSKcTWBytCBGHcnwHafAWJwuB8ShBqaNWv4P1V1HZmFS+4/n GFhjkhWpkQN6VVaLSkx7xlXfQlF4aeM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bZMelrk+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702388730; a=rsa-sha256; cv=none; b=b8HGB5lgh012RVlCHPHvjB5stVhzf4F8p44LPcECsiuT4lZehNVLdOGzY2RQq61CQ0MsyP 54i0upyGLc6ZCB6jL5Rqn/CRiuiPTkBtIVDY1un+O5l6W4jL+E4k+WjFNSoBcT0ob5Ftp1 i0vTeDPJH3IIYAVg/DmI3IPGCybS7Tc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702388730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iGm9KLE/pE130EnHFNjjiHoY0waSGBlkZUatIGs4SP0=; b=bZMelrk+Lb7rQHWWa6lGG3MCN1u1OCKK9vOR3cBtXjtDessgfqAIXqkqfKZbusqLvdPaLg Dd0YkG6xWzGokzJw9RemKzbqcdhzF629gGwXbPEeBZnfLMQW6iuwiflHjFEKc1FBp9yWSQ BwsJSifL/sIXSP98f/4Mdz7p6/KVmhc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-x5XQ0gf4OLC8gbF6GBYmKQ-1; Tue, 12 Dec 2023 08:45:28 -0500 X-MC-Unique: x5XQ0gf4OLC8gbF6GBYmKQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40b3d4d6417so37291965e9.0 for ; Tue, 12 Dec 2023 05:45:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702388727; x=1702993527; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iGm9KLE/pE130EnHFNjjiHoY0waSGBlkZUatIGs4SP0=; b=pni3eqSZnzvCZqxMgQD8MqiK8e2l7XfSEWHu1KVK+F5SusjkJ83oOPMHHowDVErMu0 +HdppP0S4VaNeDMNtvC5NOKkEjjG0Bs943W5yRBZc52Xhcu8dy15PGTsFu+554bDS1mi N2mpe6YdIBy9W7ymMeRMYBEeQ5CklbZPHBH0MvMHOgcTjZlYsdPVrpKrlruNDoS83NF9 hFwCwx8Opcazw3CQaRbs/IZJ8xxUHZi4Um8SKU3WcTyI9bYRvBJDwDuR3UEIucp4JhVO CnbKuN4CcnxYlhaDV/M+5029ID7CQCuPdyZOK9yQOKClMqw4rFikC1QS6U4D7oLFrEGo E2TQ== X-Gm-Message-State: AOJu0YzjHuMyyA+YOQ1R9IocycqNa54XHCxz4Y1hOX25vUz3hPvNfZBG wIAl/TImo2eNm7K9f9cYex1nwY1pBS4cmib9tXLqRn3XvYuoMInd3jaiuNTMxK/1+WqfQ4XCDxB tMpQuVTuRE3M= X-Received: by 2002:a05:600c:3793:b0:40b:4007:11f1 with SMTP id o19-20020a05600c379300b0040b400711f1mr1636971wmr.11.1702388727671; Tue, 12 Dec 2023 05:45:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IHVDpB21ik6TcsZDgEF4G512B0k2ImaLvUYMPDbqxF5km1WNr5D1D02+a1eKpq9FVsQdwad5A== X-Received: by 2002:a05:600c:3793:b0:40b:4007:11f1 with SMTP id o19-20020a05600c379300b0040b400711f1mr1636962wmr.11.1702388727254; Tue, 12 Dec 2023 05:45:27 -0800 (PST) Received: from ?IPV6:2003:cb:c74b:ca00:4ca2:ff2c:9092:f070? (p200300cbc74bca004ca2ff2c9092f070.dip0.t-ipconnect.de. [2003:cb:c74b:ca00:4ca2:ff2c:9092:f070]) by smtp.gmail.com with ESMTPSA id e10-20020adffd0a000000b003334675634bsm10885476wrr.29.2023.12.12.05.45.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 05:45:26 -0800 (PST) Message-ID: Date: Tue, 12 Dec 2023 14:45:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] mm/ksm: add sysfs knobs for advisor To: Stefan Roesch , kernel-team@fb.com Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20231204234906.1237478-1-shr@devkernel.io> <20231204234906.1237478-3-shr@devkernel.io> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231204234906.1237478-3-shr@devkernel.io> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D76C040025 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: g399oca9qksha9sw8wxtbxc3rume6q3y X-HE-Tag: 1702388730-597620 X-HE-Meta: U2FsdGVkX19yH+7e/b51AbycObxdzdk7ZOvoufw99t1cdLkF8Ab1e0c6h0hV88KS8wv7nG+SAarnc1X16S6nH6jsIuu3Wc9vDucD+nTjtGakigk7LJZBajA2CC2kNjlRJj080YIM4r2igS4iL6vTGPI5cf0jqPwYF6yXgbO1Gmvow7YJYPOtG/vIXxBd+1XQaI9a96AKvGVwaX0CJnD7ByyZUbhg68OwrQw5m5VM/B03CFiFbI1TRLshhFamUNTypYFuxNjxvj1WxDpG/uO+U2ANjNH6mpVJsecn4qzLsVJSkgq20yHAFRIOaueS07ju0h1iK9E5wg5DAz9jrexpa/RbI7I/Ncd5m1lrOuqBfBD/4/BMndvI1TmN+RQ76ySxYKudhj8xYuQR2c9YU4P83iLMw/Ln1AKHmTRlFbgF5DcWWbHkZ173BaBlqronve+ff9tzRJGOgdktnZIXsh8ADb9Vjx9jGL24yckTjYbSyHdXNgc1T+M1Pko2F6CT2WS4j16WiMLGrnMAsUee9+GMUBSz7DUe9ZOzibQk1oGrlU1vrbFQnaDk99vt/c/bmDKuPc1dZlGYObjiGs608o+6DbeZT/NVCIOId84deLe+HE4QYHLHpAJsEppOT01cXQWV1xo61IaFHihl/oNrH7JKbElSu/tHKH1GRj6NUe7C4vP6v8azoc4caKG4FS82oChlUS2jTk1gCcqziywQYWyQEpyIOloUoVIAEsXdnVRVvoAsMfrX9DVd0WefbcA5F7aXYAH4kYlXq6cycbuHOunFqSqt/PavK6QjKA3yX8Grp/u761rAO4U41gVWLviXcFsRzUVgUPOu5ZLUktP0sm0x3AnEBG5BKPO5aDyaQ+oEpBiAt5FgLxQmqX3+IvYCdDok7f0gmk08Dp+vY4vAi+lYJHtY1OtNy1xGkqsCHcJEIW+FW4EIN4ELN4GjXZmhjW5lZto9dAo/FVtKKHXoHol fQpN/zfy SeCC3MdyQpVHpXdKn7WtSbifsI53c+glF5QclpvWmWLeS6qETy87XRJuZVX6rnaMxShV6lBSBnprznT/oA1MN8v4rZNogmaMROgROQv939hl8Lje0UKJSM9bblS2b10GpqwKNVnKo//BXvcGvZaZHB1TQztzf+PUeFKB4dJwEyeokN0e6Mo8rZg4zLcqCMBOElRBJRBQCrdZSWrXpL9a3OljK6darKo7y6h9gHokKWPBY5SdXdN/uTDHaF6Uy6dQh66sXklv4IbkRmpw45ucolFAI2fv9jbf50c0seJe8+Xow1gqwRTyxZxsGWkhMG2qp/7OubGcMVP3BXJYOfxZ9Q8CYLA5tLBug7OnMfbounSCT712hSPm4IigdwpKboimkWtaHV7c91r4YjemG46WwziCPRN9FlQmt/XlI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.12.23 00:49, Stefan Roesch wrote: > This adds four new knobs for the KSM advisor to influence its behaviour. > > The knobs are: > - advisor_mode: > none: no advisor (default) > scan-time: scan time advisor > - advisor_max_cpu: 70 (default, cpu usage percent) > - advisor_min_pages: 500 (default) > - advisor_max_pages: 30000 (default) > - advisor_target_scan_time: 200 (default in seconds) > > The new values will take effect on the next scan round. > > Signed-off-by: Stefan Roesch > --- > mm/ksm.c | 127 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 127 insertions(+) > > diff --git a/mm/ksm.c b/mm/ksm.c > index b27010fa2e946..18b7185bbc65b 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -3735,6 +3735,128 @@ static ssize_t smart_scan_store(struct kobject *kobj, > } > KSM_ATTR(smart_scan); > > +static ssize_t advisor_mode_show(struct kobject *kobj, > + struct kobj_attribute *attr, char *buf) > +{ > + const char *output; > + > + if (ksm_advisor == KSM_ADVISOR_NONE) > + output = "[none] scan-time"; > + else if (ksm_advisor == KSM_ADVISOR_SCAN_TIME) > + output = "none [scan-time]"; > + > + return sysfs_emit(buf, "%s\n", output); > +} > + > +static ssize_t advisor_mode_store(struct kobject *kobj, > + struct kobj_attribute *attr, const char *buf, > + size_t count) > +{ > + if (sysfs_streq("scan-time", buf)) > + ksm_advisor = KSM_ADVISOR_SCAN_TIME; > + else if (sysfs_streq("none", buf)) > + ksm_advisor = KSM_ADVISOR_NONE; > + else > + return -EINVAL; > + > + /* Set advisor default values */ > + init_advisor(); Is the "init_advisor()" really required? > + set_advisor_defaults(); That function should go to this patch. -- Cheers, David / dhildenb