From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6006ED3C92A for ; Sun, 20 Oct 2024 16:44:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B49E6B007B; Sun, 20 Oct 2024 12:44:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6655E6B0082; Sun, 20 Oct 2024 12:44:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B7386B0083; Sun, 20 Oct 2024 12:44:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 29A596B007B for ; Sun, 20 Oct 2024 12:44:53 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6D1168030C for ; Sun, 20 Oct 2024 16:44:40 +0000 (UTC) X-FDA: 82694554446.10.5A53D07 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf20.hostedemail.com (Postfix) with ESMTP id CC02D1C001E for ; Sun, 20 Oct 2024 16:44:32 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="ag/1y6kt"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=GeiNg0s8; spf=pass (imf20.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729442613; a=rsa-sha256; cv=pass; b=Lhmxard7w8REh+bGCrycXJtbysXY+vWAZTLU+gE3Rq4fiN1Ld52z7gwTi+n3aTkJO7hI2m YpkFSpe0QJ44yHJjs/GuEabMNY46h+RDijYtTxTp72SxBQ9u/t62p1m2+nSL+gBoVH/MN/ g7Sad+ZUf1GHyrhaHtXpOoysF8xNjqQ= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="ag/1y6kt"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=GeiNg0s8; spf=pass (imf20.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729442613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VvccvPelQoYa+dEfm4s/lnmtwtbehOD0umxkL5YIzas=; b=L5r95JFzLt//I4QVR6Mj9dXkUkSmjFAugZ/TzaOlFjchtLhmm3FyWOkXVkG9rTb18HMCkE 1CXyDXi3VDxS5ZJkoqLLuRxAgaV15osO0ZRjG17H4VZbr7lGgeliWZ3Qijr/HDzUP5FjNp GH4e1c3hh9OIkqBNVMgU/4aS1hjmLc4= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49KDBjkP028098; Sun, 20 Oct 2024 16:44:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=VvccvPelQoYa+dEfm4 s/lnmtwtbehOD0umxkL5YIzas=; b=ag/1y6ktA1uLUpPkFVv5IE6FGHjsdMrZv5 kGk/CQacDLiLBH8qfCyutAD0Eh/1IydZXzq4lx2xjhsCPWsE4g9Qi8SjjLzDFirs aGBZ2iELYDXTOONa+RUHwb9GkZrMh0tlu2DKtRMdM0ebVQAxtRcsO1vZHiNPklMq eUB4d2lnGJc85vW2PpP7zhFNsi87E5z2PstJ8iZCSuUVNXoJnMjj2+hDhmAp61r9 VVzoPtBNcwYqLQ0BkubuPNjU+L5bs/dGGNSXD7V+djGqwoeo+RnbTT7jAPDFLv1e EbD4IOlQwzZKqcGff6TIwttIupvfHO9vVZijOd7KUSxkJzdKpAxw== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42cqv38xre-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 20 Oct 2024 16:44:44 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49KDoqZe007594; Sun, 20 Oct 2024 16:44:43 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2042.outbound.protection.outlook.com [104.47.55.42]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42c375h2fe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 20 Oct 2024 16:44:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UJBvhW6bmjd6AM5J/ZVFEGvOmmxpjwNpZNE2sO7kA3gy0yU2y6S96s99m4zt+LbIOHxD9OWyV90/XJPzfmH2izFnZCrW7YZuvrLZNAdOWcLCDbcwC3KEGmryaexz5juENHY0mPLadvnV5iCxK7bEg0L6QwqhJxAdxjdHm3Qywd/01VtK/5no6hLzzBiOluXo6r8oHZNfyGbQsjoiDy+DOMuOfvk4GKzT/nP1LAKmm73kX/gnh/1uaQ0+Nh6sU9XpcEUo5N5zX5C4PagALRCSRG33VOIYk42MbjflD+4tX+SaVYR0x4/nsrL73Hz1amVr5dnYNH1PNUTPhqgjrYy+7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VvccvPelQoYa+dEfm4s/lnmtwtbehOD0umxkL5YIzas=; b=XZNDONKdL89hGQbNt234pd7Qz/sF4CvOX9Smey7ErlaEejizX3deU095Jzb0ttOytzpgAZfRlVq0+zodtAqboFkqD9DUrxpPx44389cZpe2cw8JhJFlYq+REkkc5atosJo0yrZEv9QE70Pvdtpqmhll9vAJI5fnQpcMKtGEEmAh9tdVUkXbJ/De/o9swnnfx7gvusuMvJZvqcAJUQdZtlJqqXRH5hHRKo2mpar6mgqGQX0ku4W5Cv22R51kCtDAW49mNTpt8uNEHxv2KxDekiu1LKaO+dVCuX1ahfMulGBMwUqZjSkFRDtzveV241NdlSbJLRIw1cyOnevqNH5Kvog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VvccvPelQoYa+dEfm4s/lnmtwtbehOD0umxkL5YIzas=; b=GeiNg0s8HgpwiaOwCx16sS2eKv8Qy/o/njeigKESuHQZed1kc8LWgVIJEQ7Qr50XZoXnAWdgJTBAKB8bbz+NVxKF+ZWnH05OD5HVU/GKbcnabGg6AmcdCBcaWov7Ia1IILUyJ7pD1bnLtHdWZEqMR4lpQXctWgHXmihcSun7jro= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by CH0PR10MB4827.namprd10.prod.outlook.com (2603:10b6:610:df::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28; Sun, 20 Oct 2024 16:44:40 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8069.024; Sun, 20 Oct 2024 16:44:40 +0000 Date: Sun, 20 Oct 2024 17:44:37 +0100 From: Lorenzo Stoakes To: Kent Overstreet Cc: linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Andrew Morton , Linus Torvalds , Uladzislau Rezki , Christoph Hellwig Subject: Re: [PATCH] mm: Drop INT_MAX limit from kvmalloc() Message-ID: References: <20241019210037.146825-1-kent.overstreet@linux.dev> <90bc0794-4cab-415f-a442-4af85a32eed8@lucifer.local> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P265CA0210.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33a::13) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|CH0PR10MB4827:EE_ X-MS-Office365-Filtering-Correlation-Id: 24d8147b-bcea-41c1-2d81-08dcf1267dd6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ajsCP3a3EBrIO0pVvQzAI9wQ68JeSWX6n8uHlG+iy8MXfKW+h4p9uLkP4RjG?= =?us-ascii?Q?wGwUHDfQnjGncjcYWRbYyI0bKtzW/N1oAbzqgDkS04SeNL7N41ZgmIhJfBIA?= =?us-ascii?Q?CIBQs/m8QP3akYHdBYmnnn3mXAGuCQcIfqN9QRTzP4FA6qatquSzJsQGM4km?= =?us-ascii?Q?kbsfPnwjvUqSh6vofyABU4T1Y2EBPVD/+0bYhFLpFbG2mpcmEZtF/vhVCoWT?= =?us-ascii?Q?J4pyG3RYaROcfClysUigNha/3Ia3ajZXYGlTndaMviBrCS+QWtnN3/RV8u3P?= =?us-ascii?Q?ycSdeFeKXFN4Vz20RJcVzSatHjT7nHnFKMaDE8INQn3p9c2YZ0YPQxkmW2VY?= =?us-ascii?Q?2T+iKQF1r+W2zzI4kp8FkJe5pLuzhai7RUsVQ3RS4sLtkM2LT5ZkhHjr0s5m?= =?us-ascii?Q?EDaKPCONZ/XB+mU2yCM+OxOWcSNFUtsdG2CQc7RXszkbPbPXLpp1uvK885za?= =?us-ascii?Q?IrQKf3gdkq77JV8UAN9hfGYjrQZulU1cwd1pIUyBL24tb3gVYdlGcReBVQ0K?= =?us-ascii?Q?dGaTRBeMUIRdZt1jwVsVfoN6tJmoJr99NaH2StupgpaURnxw2hi0dCcYGXlP?= =?us-ascii?Q?3ZA/SXHsptQm3MglUn1xzPP3POCU1xh9BPa5GqeLbGJ2bBI24yEpr+yacbZ/?= =?us-ascii?Q?5xV3sr2fnRI5evtEmd314vQBocibsK2id4wFIUez+Qkd4U84ACDZ55etHMFc?= =?us-ascii?Q?MPuIK6AO90lWMw92aIDtpRqB5I1ZLFbO5YzhSg56mqAf5EmHkY0boqFwN2km?= =?us-ascii?Q?pLrkopDclwUbzDMEYoCsrOaiJMjeN9x4TqJxxauO4NV2tUbfh/hb9POQ4FRp?= =?us-ascii?Q?ymMZ9GmNeRXsiN+SXVD2fCp3QeGhL4B3HA10l45BE7kG0E8chOQtWPZqlDht?= =?us-ascii?Q?5hdkMWd/cfO8zrFqOB3lv5LAaTlQ5EZxgm6FZgGT4/W8bo4jxFoKL5T6rxxM?= =?us-ascii?Q?CwsW+DxUUudzfClTUy54j4IVPglKhw7e9LMMJEh4mg4k/zESWDe/5j+V9jXy?= =?us-ascii?Q?7IgKtpHA+DNIEyga4QhaSdh6kORNMwMVbK0K6gQMNKUZWqRTIrD1ewzoAhuS?= =?us-ascii?Q?W9RKGhhgzr8uCJubGQGzDikWeTIvBmP51YyK8Exn/8COAMQFHgKxnNhbgNxB?= =?us-ascii?Q?+TxWnj6faqlwSv8CyY4YXX5JeaJTzywhERQyhIfqT8kk/6vLA+mugUnhm0IC?= =?us-ascii?Q?TXPTJol6J5dtca09leZqGs/ne1mOfjQwW2tlGTpd6+XgtfPdXe1RECfbVp2U?= =?us-ascii?Q?cPrPHQaTheBEQ7ahJOJ62p4QnnF5bFYoTJvYOiKU2nf9jDc73aIr3Tlr7+12?= =?us-ascii?Q?vMB/dBObKckx53dAFHu8J+PI?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6B9YQUF1PH/8NSUL5OcryEOKXHsrZjoaaArfeEbMN9GbybrKu6V8DtYjgxWp?= =?us-ascii?Q?jyscBxkVa2pZs1ahSELyXjOSI0y7qYUuq7JVEtXfyXKPod1cHgUauzWUFaiM?= =?us-ascii?Q?RR5YzPh+Wz/ZkEh9xtgL32k63gMAnjhEwPrOEeaInXcv6CIyTLbx1CopX8os?= =?us-ascii?Q?vq/8N+vq18fcz7VxG/w6jMHfcXVeyzq8qkclkNZ/BB99rjf4+jaC73hCF15N?= =?us-ascii?Q?q9CIny3Gg2fRvMsS2yxVwazzuLcueLvBH+3S1lDFj8oW5lxXABgTAulBzFMc?= =?us-ascii?Q?lM35M1Je1qdC3+d8rGCrkZZcj4SOeoL8Sbu/GNjA5pJ5Khp53EFeqvjZ19Tl?= =?us-ascii?Q?Vaaoggq8HB5H43fcLtD2ay59esjxbDq9XnpXC9ipwgeyClQSdkTDAEjFkib6?= =?us-ascii?Q?i5QhSjnqstTXooDKRsYmtY5sDyeUtn3vq7TouL1sjo1Cuh6fSSbIh8Rh4Cu8?= =?us-ascii?Q?4R69xTBwqw7hpWuiyzt66hS0z/Ie8g/EMuBAWGMgG8GutmOB1BLQGemnQYgw?= =?us-ascii?Q?wQVyYuyepAapUAifiw5zEUi8AKFNcipycUoNpnb1VPYhFKGat4mw12igH0HA?= =?us-ascii?Q?YVnVCdDTU6yNN0E3FpYjnp04SV/8HCpyw3T0Ln3BvMpDVonk4v9ubIFh1Pa1?= =?us-ascii?Q?pD1syYBNiEhizFD81Ut/qBvwTfo2aGIGZVoj3oBIR7U7Axf4Pk60B+vwxeNy?= =?us-ascii?Q?QEZOs5FS9RFD0rceKDIqdsgHmCRqLsfx8PoGj/V8qTMYXG6Mni1RM5k31YY9?= =?us-ascii?Q?cdL9mN0jNkMhUPXeT6ttftgkqwAkgumKxxoYBKiPZQ+8BeUOhGrH+jpI4CJB?= =?us-ascii?Q?XLHY0kYyRbub92Xmg1alDRU1aPVgZDjFA90XzwBPI6RpYPJFvB+7SEhoxoVV?= =?us-ascii?Q?MylhFtTYZNBOBABpCsFlvRaWadZizRhs3VWQrqEcRBW8Y8Iu/WYU/WeLRPXY?= =?us-ascii?Q?ZrVszaYpUxt26ar4RDh3nmuCTFlpQ81itEVuna/hRKGD4TFKTR6sPV/TSq15?= =?us-ascii?Q?I9H/iCgu1Fz9d4blcpbi2CQAGSqWDbc0GKs3/rLzuUHoey8BlgOMCNCjPI7V?= =?us-ascii?Q?EptFTgemHkZoN6WoXce6mjPwP/kH2SIi6gaaq8X3VtOrYJ4xuc6QTySNnrZY?= =?us-ascii?Q?9LqCTQjafbEZh6/2YFhKKEuo1+A+mNx0sAPTbocSchis3CNjjiAeTA+dPXY9?= =?us-ascii?Q?EPXExm+GxUvWb7HU6LdaNrP9jrBaNGoSKcxkyRMY/viXJkhgq6QXlZ+7NdZE?= =?us-ascii?Q?Pa2c4glZVcZ+cCzLOXSBXiDHPQFyRMUDi3bSxePPV/UxEVbwRQs0JALIy7Ya?= =?us-ascii?Q?O+Bqp79SOUYBd8f8MYEFab/Abw4Q57Vuz/U8h5R97o3TX4Al/DuOLWeD0k7U?= =?us-ascii?Q?lXPUcPa0pk8YX+n7m4ujQ1NQSxzwov8tKbPBUJuHTyjb++f4wQ+Ui2xjn12b?= =?us-ascii?Q?DsaBYlP7zBYOpI2qwuUWw0AmhFJyFuuaijQ1c8pNUuyPQG2a+iTPFYXpCwpZ?= =?us-ascii?Q?Utdn4SfmE1Y2mMYymf9HFrGRnFBwFm1a1R3OygMkNLw1CozXEA1qHRotZ1Vg?= =?us-ascii?Q?vakVzkTZqbt3PDebAHB3Z5ocZ5Atd2nJieExTUPA6F7cLszqPMu/csSo06de?= =?us-ascii?Q?Vw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hoJDbNXNwi4eqfQ61o8VWTspJyQoBo0COJn3G8U04nIW9e4Due3zaPTGkxNwCfpOlwbryw5wT0rtdKkGe2eIlkqXGxLud0LST3FVS0AQVfUbrca0nJZpwU6rk2O3vZ6m7viyaOT8Bksb4HaEhtYBZZ6YyM0yUipFZqRs5JXBZJNDV0DhRYCh17L2Tq0L/9WaL7TpGQSRs5ESb5YI1tEhWNMZ1rwqOZ19bU77ApDzV/SqP+VHh1F5aL8R4zXOg5qMOF47i4zwFT4HpyYiPyI0r1LOT+IuakrYfogHQP0T+QRIHTv70x/7KIgI3d8aTodw1c19IYNHYcXsSWXPM1/CFQy+z9TSDsZfEK2mfpxsEuZ+2rKb9DBIGRDhfZ3U0yYlc4w3/mKlDCjxEr6/auMUSt3/JoDebzubB2dLhRNsogzW0DrZGY40459W7jJY7dRO2IuA+ea5H0WkN4TVc49VWe712422O8UIHnpO4JEz30CQ3WapOOy93t3YZQaurWrzUwpbRgFxcDvpj0dHF+9VjnR/dtZCRYUDl6GsARFFH0SdF+7X6bpafh0BmEF8UNS3NcfjujtoxT9XU5d0L/4Q8uXH4ns9wD65p0b23OdAX78= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24d8147b-bcea-41c1-2d81-08dcf1267dd6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2024 16:44:40.4455 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1CGD0Tkvpi70FGGiehWzpSeRQ9COO1oFxWgaoN5BXWnIpdPZv2Mly3avjKd74lyvPtEdKPPChAE8HzJrXLIpAxwbasU8O56N8LPhSpPfRtE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4827 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-20_14,2024-10-17_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410200117 X-Proofpoint-ORIG-GUID: uRFiiLiUKPqoPE2TJnEVGc3bjV7skgiS X-Proofpoint-GUID: uRFiiLiUKPqoPE2TJnEVGc3bjV7skgiS X-Stat-Signature: ihz3rwynzpwih3d8wia1u1nwira441uu X-Rspamd-Queue-Id: CC02D1C001E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729442672-989972 X-HE-Meta: U2FsdGVkX19D0BKLYEXyB6NnFrjIGLVRnwMGe1RW3kAsP7wI4Jt1cJ0FLRe6q1RgQmjMV8Ap1djNhsj5tpbyl/BxP8a2Mst/yeHT0W2N0mFTWYnaEa4WX0BhMQZ/g3bG7yx5pgn3H039aCoaMhdhUqLc/6eHp5tWwWwKKU9hhNSFZvpYXDLvFV53Z7gplncSUJ6LQNs1Rs0MzeTiKoM1Yxtnac6SX6KhGOCJxisKIALY+mp3adMLZ+ouGOLHw4pz5DV7mnFaWlLLrFzscoE1uZw8LBbG/I1nrBlB0vchWlhCL7XOod3J1HXV3cgWFAUit+OejFjEplLFIRpXbp+xgcXDkvlvqj0jUM3B+4AVY1KT8H6c9yIdAuNG1xIHPVZHK1uNoPVRWEAaOQy9whXWMA0yoKWf2lLeftDcMYIMRkNB1tPC0xdwylc4xN1SIkpd+Q+kTIU3w8q6NgeiiAIzi19pA/agu+zocfKVB1XYpwwY4L4tYROVi49CygoEicFQG+Gdpf4WP6gJtWAWg5An2eKKoXTNaR5S9+RdF75iK+75Gs0+iIC5l4JI6p1MOd8hq8agqmV7t5+2Incv/23PdYxxCPyZBBQgOEHWjZYklo2zkGLUtp9LOra1xoIj92e5B9+ULFFRJz/EKWsHD9qw396g/TbbKS2qaX8pcE8n9dyNw6dEJFN22UkOBWFMWxXzlpeoFRooKyd35ssT2K0691JVTKhrHFX5vJhghkt4s8BqHg25qteORAIPkNrPj7/45pV6rC5u8kEcNflKSWGhwvtlScUpnVOl/RVDlzaw2LszYJajXJunV4OvaloiZebeqLV1MeEv9DZv9LLUdbEHn0Mu5fwVMQPPDlMb3IAXlD6V/YWpGK34B+dLZmnwDZq35/jc9W9N1NPh5+nnMF9ghMzQDSro9qMPzbgAzS0LTzNon9+QHubwJFlimjltW4hSUcfDO6JN60QSvAC8mBW ejChYQGm 5D66/7S3P5HoAL497deRLb/d5bKroTXrVtYxypLhJOfRfuYRj2Fp6EYvmjmvQyXYgiOJ4AUO5Fl73MqLKMgLT9pYNjgZg2LUnmR9PApom2b6wVjLn8lUaZ5qMaCgYheX3cYw1gS8KI5xInv5xAqleTNuEDyFkunK/8FdzAfTTd78mk/KL9wZvSpFV0IRoQ4jIA8xcF+brHINPxbD+29MQZjU4vK/xTiwHw44cbQxMijLk1fAXaU4gYfqlElrb2ejlqlKmH/VHZtFa8apYUejvfTUczUOcNI0Gf1M2FTvw0X05Rsa21j5BDhVjRPfoK+ovmDZtR9rt+12OTCoLkcTUn7nTXMm86JYy1g7m18W/hetsinWb+Nz1ZX5P4ofmAkHmKq4MO3WAOzjnCH6n4tOfsj7K+btmHouRRMNd2RAVqZlEh2Ro/WB5R4/SY2mbNKBSIA35jcYtwaicaUL4V52gzwDfFdG3VLYJmS7m2d2ldmlHCqOq/4ZlQbuy0/nkGucJ/Nzku3yT8QS8U2q+ssE9EnG9tdRcv5IfulskSBz7zoKGh0jkSNX2yXWQsTxF2v2lPY/a744v6EuWbXmOMI3ic7GtVrIPzH6AjpgCMNat3Cu8dmfeKgxJFLKxDw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: +cc Linus, vmalloc reviewers On Sun, Oct 20, 2024 at 09:00:07AM -0400, Kent Overstreet wrote: > On Sun, Oct 20, 2024 at 12:45:33PM +0100, Lorenzo Stoakes wrote: > > On Sat, Oct 19, 2024 at 05:00:37PM -0400, Kent Overstreet wrote: > > > A user with a 75 TB filesystem reported the following journal replay > > > error: > > > https://github.com/koverstreet/bcachefs/issues/769 > > > > > > In journal replay we have to sort and dedup all the keys from the > > > journal, which means we need a large contiguous allocation. Given that > > > the user has 128GB of ram, the 2GB limit on allocation size has become > > > far too small. > > > > > > Cc: Vlastimil Babka > > > Cc: Andrew Morton > > > Signed-off-by: Kent Overstreet > > > --- > > > mm/util.c | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > > > diff --git a/mm/util.c b/mm/util.c > > > index 4f1275023eb7..c60df7723096 100644 > > > --- a/mm/util.c > > > +++ b/mm/util.c > > > @@ -665,12 +665,6 @@ void *__kvmalloc_node_noprof(DECL_BUCKET_PARAMS(size, b), gfp_t flags, int node) > > > if (!gfpflags_allow_blocking(flags)) > > > return NULL; > > > > > > - /* Don't even allow crazy sizes */ > > > - if (unlikely(size > INT_MAX)) { > > > - WARN_ON_ONCE(!(flags & __GFP_NOWARN)); > > > - return NULL; > > > - } > > > - > > > > Err, and not replace it with _any_ limit? That seems very unwise. > > large allocations will go to either the page allocator or vmalloc, and > they have their own limits. Ah actually I misread it here, I see the allocation gets immediately sent off to __kmalloc_node_noprof() and thus that'll apply its own limits before doing this check prior to the vmalloc call. We actually do have a basic check in __vmalloc_node_range_noprof() that prevents _totally_ insane requests, checking that size >> PAGE_SHIFT <= totalram_pages(), so we shouldn't get anything too stupid here (I am thinking especially of ptr + size overflow type situations). But Linus explicitly introduced this INT_MAX check in commit 7661809d493b ("mm: don't allow oversized kvmalloc() calls"), presumably for a reason, so have cc'd him here in case he has an objection to this which amounts to a revert of that patch. Assuming Linus doesn't object, I don't see how this is really doing anything different than just invoking __vmalloc_node_range_noprof() direct which we do in quite a few places anyway? I guess let's wait and see what he says or if Vlastimil/the vmalloc reviewers have any thoughts on this. But looks sane to me otherwise. > > although I should have a look at that, and make sure we're not > triggering the > MAX_ORDER warning in the page allocator unnecessarily w > hen we could just call vmalloc(). OK I guess tha would be a check prior to invoking __kmalloc_node_noprof() -> ... -> __alloc_pages_noprof() and WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp) ? Sounds sensible.